# HG changeset patch # User weijun # Date 1466168851 -28800 # Node ID e8da0515445a2335565a6404f5aab46a4d2f529d # Parent 668c400a8dd17d9c05a14a946a827e6f25d3a392 8158633: BASE64 encoded cert not correctly parsed with UTF-16 Reviewed-by: mullan diff -r 668c400a8dd1 -r e8da0515445a jdk/src/java.base/share/classes/sun/security/util/Pem.java --- a/jdk/src/java.base/share/classes/sun/security/util/Pem.java Fri Jun 17 21:42:38 2016 +0900 +++ b/jdk/src/java.base/share/classes/sun/security/util/Pem.java Fri Jun 17 21:07:31 2016 +0800 @@ -26,6 +26,7 @@ package sun.security.util; import java.io.IOException; +import java.nio.charset.StandardCharsets; import java.util.Base64; /** @@ -42,7 +43,8 @@ * @throws java.io.IOException if input is invalid */ public static byte[] decode(String input) throws IOException { - byte[] src = input.replaceAll("\\s+", "").getBytes(); + byte[] src = input.replaceAll("\\s+", "") + .getBytes(StandardCharsets.ISO_8859_1); try { return Base64.getDecoder().decode(src); } catch (IllegalArgumentException e) { diff -r 668c400a8dd1 -r e8da0515445a jdk/test/sun/security/util/Pem/PemEncoding.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/jdk/test/sun/security/util/Pem/PemEncoding.java Fri Jun 17 21:07:31 2016 +0800 @@ -0,0 +1,34 @@ +/* + * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +import java.io.FileInputStream; +import java.security.cert.CertificateFactory; + +public class PemEncoding { + public static void main(String[] args) throws Exception { + try (FileInputStream fis = new FileInputStream(args[0])) { + CertificateFactory cf = CertificateFactory.getInstance("X.509"); + System.out.println(cf.generateCertificate(fis)); + } + } +} diff -r 668c400a8dd1 -r e8da0515445a jdk/test/sun/security/util/Pem/encoding.sh --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/jdk/test/sun/security/util/Pem/encoding.sh Fri Jun 17 21:07:31 2016 +0800 @@ -0,0 +1,35 @@ +# +# Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. +# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. +# +# This code is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License version 2 only, as +# published by the Free Software Foundation. +# +# This code is distributed in the hope that it will be useful, but WITHOUT +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License +# version 2 for more details (a copy is included in the LICENSE file that +# accompanied this code). +# +# You should have received a copy of the GNU General Public License version +# 2 along with this work; if not, write to the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. +# +# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA +# or visit www.oracle.com if you need additional information or have any +# questions. +# + +# @test +# @bug 8158633 +# @summary BASE64 encoded cert not correctly parsed with UTF-16 +# @build PemEncoding +# @run shell encoding.sh + +# jtreg does not like -Dfile.encoding=UTF-16 inside a @run main line, +# therefore a shell test is written. + +$TESTJAVA/bin/java $TESTVMOPTS -cp $TESTCLASSES \ + -Dfile.encoding=UTF-16 \ + PemEncoding $TESTSRC/../HostnameMatcher/cert5.crt