# HG changeset patch # User jdv # Date 1516254748 -19800 # Node ID e4b03365ddbf0d242a838f0dd3306dc7a14f5850 # Parent 36a1966132aa8b3fe6435ddb80bf3c17f4c20574 8176795: Wrong color drawn when painting translucent colors on volatile images using XRender. Reviewed-by: prr, ceisserer, pnarayanan diff -r 36a1966132aa -r e4b03365ddbf src/java.desktop/unix/classes/sun/java2d/xr/XRSolidSrcPict.java --- a/src/java.desktop/unix/classes/sun/java2d/xr/XRSolidSrcPict.java Wed Jan 17 09:08:44 2018 -0800 +++ b/src/java.desktop/unix/classes/sun/java2d/xr/XRSolidSrcPict.java Thu Jan 18 11:22:28 2018 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2013, 2014, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2013, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -47,7 +47,7 @@ public XRSurfaceData prepareSrcPict(int pixelVal) { if(pixelVal != curPixVal) { - xrCol.setColorValues(pixelVal, false); + xrCol.setColorValues(pixelVal, true); con.renderRectangle(srcPict.picture, XRUtils.PictOpSrc, xrCol, 0, 0, 1, 1); this.curPixVal = pixelVal; } diff -r 36a1966132aa -r e4b03365ddbf test/jdk/java/awt/Color/XRenderTranslucentColorDrawTest.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/jdk/java/awt/Color/XRenderTranslucentColorDrawTest.java Thu Jan 18 11:22:28 2018 +0530 @@ -0,0 +1,80 @@ +/* + * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8176795 + * @summary Test verifies that we get proper color when we draw translucent + * color over an opaque color using X Render extension in Linux. + * @requires (os.family == "linux") + * @run main XRenderTranslucentColorDrawTest -Dsun.java2d.xrender=true + */ + +import java.awt.Color; +import java.awt.Graphics2D; +import java.awt.GraphicsConfiguration; +import java.awt.GraphicsDevice; +import java.awt.GraphicsEnvironment; +import java.awt.image.BufferedImage; +import java.awt.image.VolatileImage; + +public class XRenderTranslucentColorDrawTest { + + public static void main(String[] args) throws Exception { + GraphicsEnvironment env = GraphicsEnvironment. + getLocalGraphicsEnvironment(); + GraphicsConfiguration translucentGC = null; + SCREENS: for (GraphicsDevice screen : env.getScreenDevices()) { + for (GraphicsConfiguration gc : screen.getConfigurations()) { + if (gc.isTranslucencyCapable()) { + translucentGC = gc; + break SCREENS; + } + } + } + if (translucentGC == null) { + throw new RuntimeException("No suitable gc found."); + } + int width = 10; + int height = 10; + VolatileImage image = translucentGC. + createCompatibleVolatileImage(width, height); + Graphics2D g = image.createGraphics(); + // draw opaque black color + g.setColor(new Color(0xff000000, true)); + g.fillRect(0, 0, width, height); + // draw translucent white color over opaque black color + g.setColor(new Color(0x80ffffff, true)); + g.fillRect(0, 0, width, height); + g.dispose(); + // Get snapshot of VolatileImage to pick color and verify the same + BufferedImage snapshot = image.getSnapshot(); + int argb = snapshot.getRGB(width / 2, height / 2); + // we expect the resultant rgb hex value to be ff808080 + if (!(Integer.toHexString(argb).equals("ff808080"))) { + throw new RuntimeException("Using X Render extension for drawing" + + " translucent color is not giving expected results."); + } + } +} +