# HG changeset patch # User joehw # Date 1508358349 25200 # Node ID e1a6c01687414db52dee498a7d66c28acf634350 # Parent d07d5f7cab35a2e7ed6199fd0eeb02b8a0a3b896 8181150: Fix lint warnings in JAXP repo: rawtypes and unchecked Reviewed-by: lancea, rriggs, mullan diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHere.java --- a/src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHere.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHere.java Wed Oct 18 13:25:49 2017 -0700 @@ -27,12 +27,14 @@ import com.sun.org.apache.xml.internal.dtm.DTM; import com.sun.org.apache.xml.internal.security.utils.I18n; import com.sun.org.apache.xml.internal.security.utils.XMLUtils; +import com.sun.org.apache.xml.internal.utils.QName; import com.sun.org.apache.xpath.internal.NodeSetDTM; import com.sun.org.apache.xpath.internal.XPathContext; import com.sun.org.apache.xpath.internal.functions.Function; import com.sun.org.apache.xpath.internal.objects.XNodeSet; import com.sun.org.apache.xpath.internal.objects.XObject; import com.sun.org.apache.xpath.internal.res.XPATHErrorResources; +import java.util.List; import org.w3c.dom.Document; import org.w3c.dom.Node; @@ -145,8 +147,7 @@ * @param vars * @param globalsSize */ - @SuppressWarnings("rawtypes") - public void fixupVariables(java.util.Vector vars, int globalsSize) { + public void fixupVariables(List vars, int globalsSize) { // do nothing } } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/java_cup/internal/runtime/lr_parser.java --- a/src/java.xml/share/classes/com/sun/java_cup/internal/runtime/lr_parser.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/java_cup/internal/runtime/lr_parser.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2005, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2017, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -272,7 +272,7 @@ /*. . . . . . . . . . . . . . . . . . . . . . . . . . . . . .*/ /** The parse stack itself. */ - protected Stack stack = new Stack(); + protected Stack stack = new Stack<>(); /*. . . . . . . . . . . . . . . . . . . . . . . . . . . . . .*/ @@ -322,7 +322,7 @@ public abstract Symbol do_action( int act_num, lr_parser parser, - Stack stack, + Stack stack, int top) throws java.lang.Exception; @@ -571,7 +571,7 @@ /* current state is always on the top of the stack */ /* look up action out of the current state with the current input */ - act = get_action(((Symbol)stack.peek()).parse_state, cur_token.sym); + act = get_action((stack.peek()).parse_state, cur_token.sym); /* decode the action -- > 0 encodes shift */ if (act > 0) @@ -603,7 +603,7 @@ } /* look up the state to go to from the one popped back to */ - act = get_reduce(((Symbol)stack.peek()).parse_state, lhs_sym_num); + act = get_reduce((stack.peek()).parse_state, lhs_sym_num); /* shift to that state */ lhs_sym.parse_state = act; @@ -626,7 +626,7 @@ /* just in case that wasn't fatal enough, end parse */ done_parsing(); } else { - lhs_sym = (Symbol)stack.peek(); + lhs_sym = stack.peek(); } } } @@ -661,8 +661,8 @@ /* dump the stack */ for (int i=0; i"); if ((i%3)==2 || (i==(stack.size()-1))) { debug_message(sb.toString()); - sb = new StringBuffer(" "); + sb = new StringBuilder(" "); } } } @@ -762,7 +762,7 @@ //debug_stack(); /* look up action out of the current state with the current input */ - act = get_action(((Symbol)stack.peek()).parse_state, cur_token.sym); + act = get_action((stack.peek()).parse_state, cur_token.sym); /* decode the action -- > 0 encodes shift */ if (act > 0) @@ -798,9 +798,9 @@ } /* look up the state to go to from the one popped back to */ - act = get_reduce(((Symbol)stack.peek()).parse_state, lhs_sym_num); + act = get_reduce((stack.peek()).parse_state, lhs_sym_num); debug_message("# Reduce rule: top state " + - ((Symbol)stack.peek()).parse_state + + (stack.peek()).parse_state + ", lhs sym " + lhs_sym_num + " -> state " + act); /* shift to that state */ @@ -826,7 +826,7 @@ /* just in case that wasn't fatal enough, end parse */ done_parsing(); } else { - lhs_sym = (Symbol)stack.peek(); + lhs_sym = stack.peek(); } } } @@ -916,7 +916,7 @@ protected boolean shift_under_error() { /* is there a shift under error Symbol */ - return get_action(((Symbol)stack.peek()).parse_state, error_sym()) > 0; + return get_action((stack.peek()).parse_state, error_sym()) > 0; } /*. . . . . . . . . . . . . . . . . . . . . . . . . . . . . .*/ @@ -936,8 +936,8 @@ if (debug) debug_message("# Finding recovery state on stack"); /* Remember the right-position of the top symbol on the stack */ - int right_pos = ((Symbol)stack.peek()).right; - int left_pos = ((Symbol)stack.peek()).left; + int right_pos = (stack.peek()).right; + int left_pos = (stack.peek()).left; /* pop down until we can shift under error Symbol */ while (!shift_under_error()) @@ -945,7 +945,7 @@ /* pop the stack */ if (debug) debug_message("# Pop stack by one, state was # " + - ((Symbol)stack.peek()).parse_state); + (stack.peek()).parse_state); left_pos = ((Symbol)stack.pop()).left; tos--; @@ -958,11 +958,11 @@ } /* state on top of the stack can shift under error, find the shift */ - act = get_action(((Symbol)stack.peek()).parse_state, error_sym()); + act = get_action((stack.peek()).parse_state, error_sym()); if (debug) { debug_message("# Recover state found (#" + - ((Symbol)stack.peek()).parse_state + ")"); + (stack.peek()).parse_state + ")"); debug_message("# Shifting on error to state #" + (act-1)); } @@ -1145,7 +1145,7 @@ debug_message("# Reparsing saved input with actions"); debug_message("# Current Symbol is #" + cur_err_token().sym); debug_message("# Current state is #" + - ((Symbol)stack.peek()).parse_state); + (stack.peek()).parse_state); } /* continue until we accept or have read all lookahead input */ @@ -1155,7 +1155,7 @@ /* look up action out of the current state with the current input */ act = - get_action(((Symbol)stack.peek()).parse_state, cur_err_token().sym); + get_action((stack.peek()).parse_state, cur_err_token().sym); /* decode the action -- > 0 encodes shift */ if (act > 0) @@ -1205,7 +1205,7 @@ } /* look up the state to go to from the one popped back to */ - act = get_reduce(((Symbol)stack.peek()).parse_state, lhs_sym_num); + act = get_reduce((stack.peek()).parse_state, lhs_sym_num); /* shift to that state */ lhs_sym.parse_state = act; @@ -1234,7 +1234,7 @@ protected static short[][] unpackFromStrings(String[] sa) { // Concatanate initialization strings. - StringBuffer sb = new StringBuffer(sa[0]); + StringBuilder sb = new StringBuilder(sa[0]); for (int i=1; i shadowing_stack) throws java.lang.Exception { /* sanity check */ if (shadowing_stack == null) @@ -58,7 +58,7 @@ /* set up our internals */ real_stack = shadowing_stack; - vstack = new Stack(); + vstack = new Stack<>(); real_next = 0; /* get one element onto the virtual portion of the stack */ @@ -73,7 +73,7 @@ * the bottom of the virtual portion of the stack, but is always left * unmodified. */ - protected Stack real_stack; + protected Stack real_stack; /*. . . . . . . . . . . . . . . . . . . . . . . . . . . . . .*/ @@ -91,7 +91,7 @@ * on the virtual stack). When this portion of the stack becomes empty we * transfer elements from the underlying stack onto this stack. */ - protected Stack vstack; + protected Stack vstack; /*-----------------------------------------------------------*/ /*--- General Methods ---------------------------------------*/ @@ -108,7 +108,7 @@ if (real_next >= real_stack.size()) return; /* get a copy of the first Symbol we have not transfered */ - stack_sym = (Symbol)real_stack.elementAt(real_stack.size()-1-real_next); + stack_sym = real_stack.get(real_stack.size()-1-real_next); /* record the transfer */ real_next++; @@ -136,7 +136,7 @@ throw new Exception( "Internal parser error: top() called on empty virtual stack"); - return ((Integer)vstack.peek()).intValue(); + return (vstack.peek()); } /*. . . . . . . . . . . . . . . . . . . . . . . . . . . . . .*/ diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java --- a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -73,8 +73,8 @@ private static final Class[] EXCS_FIELD_AND_METHOD_RESOLUTION = { NO_SUCH_FIELD_ERROR, ILLEGAL_ACCESS_ERROR, NO_SUCH_METHOD_ERROR }; // Chapter 5.2 - private static final Class[] EXCS_INTERFACE_METHOD_RESOLUTION = new Class[0]; // Chapter 5.3 (as below) - private static final Class[] EXCS_STRING_RESOLUTION = new Class[0]; + private static final Class[] EXCS_INTERFACE_METHOD_RESOLUTION = new Class[0]; // Chapter 5.3 (as below) + private static final Class[] EXCS_STRING_RESOLUTION = new Class[0]; // Chapter 5.4 (no errors but the ones that _always_ could happen! How stupid.) private static final Class[] EXCS_ARRAY_EXCEPTION = { NULL_POINTER_EXCEPTION, ARRAY_INDEX_OUT_OF_BOUNDS_EXCEPTION diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/ARRAYLENGTH.java --- a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/ARRAYLENGTH.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/ARRAYLENGTH.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -43,7 +43,7 @@ */ @Override public Class[] getExceptions() { - return new Class[] { + return new Class[] { ExceptionConst.NULL_POINTER_EXCEPTION }; } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/ATHROW.java --- a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/ATHROW.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/ATHROW.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -43,7 +43,7 @@ */ @Override public Class[] getExceptions() { - return new Class[] { + return new Class[] { ExceptionConst.THROWABLE }; } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/IDIV.java --- a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/IDIV.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/IDIV.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -42,7 +42,7 @@ */ @Override public Class[] getExceptions() { - return new Class[] { + return new Class[] { ExceptionConst.ARITHMETIC_EXCEPTION }; } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/IREM.java --- a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/IREM.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/IREM.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -42,7 +42,7 @@ */ @Override public Class[] getExceptions() { - return new Class[] { + return new Class[] { ExceptionConst.ARITHMETIC_EXCEPTION }; } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDIV.java --- a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDIV.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDIV.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -39,7 +39,7 @@ @Override public Class[] getExceptions() { - return new Class[] { + return new Class[] { ExceptionConst.ARITHMETIC_EXCEPTION }; } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LREM.java --- a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LREM.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LREM.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -38,7 +38,7 @@ @Override public Class[] getExceptions() { - return new Class[] { + return new Class[] { ExceptionConst.ARITHMETIC_EXCEPTION }; } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/MONITORENTER.java --- a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/MONITORENTER.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/MONITORENTER.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -38,7 +38,7 @@ @Override public Class[] getExceptions() { - return new Class[] { + return new Class[] { ExceptionConst.NULL_POINTER_EXCEPTION }; } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/MONITOREXIT.java --- a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/MONITOREXIT.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/MONITOREXIT.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -38,7 +38,7 @@ @Override public Class[] getExceptions() { - return new Class[] { + return new Class[] { ExceptionConst.NULL_POINTER_EXCEPTION }; } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/MethodGen.java --- a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/MethodGen.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/MethodGen.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,5 +1,6 @@ /* * Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -1165,7 +1166,7 @@ if (attribute instanceof ParameterAnnotations) { // Initialize param_annotations if (!hasParameterAnnotations) { - @SuppressWarnings("unchecked") // OK + @SuppressWarnings({"rawtypes", "unchecked"}) final List[] parmList = new List[arg_types.length]; param_annotations = parmList; for (int j = 0; j < arg_types.length; j++) { @@ -1213,7 +1214,7 @@ final AnnotationEntryGen annotation) { ensureExistingParameterAnnotationsUnpacked(); if (!hasParameterAnnotations) { - @SuppressWarnings("unchecked") // OK + @SuppressWarnings({"rawtypes", "unchecked"}) final List[] parmList = new List[arg_types.length]; param_annotations = parmList; hasParameterAnnotations = true; diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/NEWARRAY.java --- a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/NEWARRAY.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/NEWARRAY.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,12 +21,11 @@ package com.sun.org.apache.bcel.internal.generic; +import com.sun.org.apache.bcel.internal.ExceptionConst; +import com.sun.org.apache.bcel.internal.util.ByteSequence; import java.io.DataOutputStream; import java.io.IOException; -import com.sun.org.apache.bcel.internal.ExceptionConst; -import com.sun.org.apache.bcel.internal.util.ByteSequence; - /** * NEWARRAY - Create new array of basic type (int, short, ...) *
Stack: ..., count -> ..., arrayref
@@ -107,7 +106,7 @@ @Override public Class[] getExceptions() { - return new Class[] { + return new Class[] { ExceptionConst.NEGATIVE_ARRAY_SIZE_EXCEPTION }; } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/ReturnInstruction.java --- a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/ReturnInstruction.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/ReturnInstruction.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -71,7 +71,7 @@ @Override public Class[] getExceptions() { - return new Class[] { + return new Class[] { ExceptionConst.ILLEGAL_MONITOR_STATE }; } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/bcel/internal/util/InstructionFinder.java --- a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/util/InstructionFinder.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/util/InstructionFinder.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,9 +1,30 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + package com.sun.org.apache.bcel.internal.util; +import com.sun.org.apache.bcel.internal.Const; +import com.sun.org.apache.bcel.internal.generic.ClassGenException; +import com.sun.org.apache.bcel.internal.generic.InstructionHandle; +import com.sun.org.apache.bcel.internal.generic.InstructionList; import java.util.ArrayList; import java.util.HashMap; import java.util.Iterator; @@ -13,11 +34,6 @@ import java.util.regex.Matcher; import java.util.regex.Pattern; -import com.sun.org.apache.bcel.internal.Const; -import com.sun.org.apache.bcel.internal.generic.ClassGenException; -import com.sun.org.apache.bcel.internal.generic.InstructionHandle; -import com.sun.org.apache.bcel.internal.generic.InstructionList; - /** * InstructionFinder is a tool to search for given instructions patterns, i.e., * match sequences of instructions in an instruction list via regular diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/utils/FeaturePropertyBase.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/utils/FeaturePropertyBase.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/utils/FeaturePropertyBase.java Wed Oct 18 13:25:49 2017 -0700 @@ -62,7 +62,7 @@ * @param state the state of the property * @param value the value of the property */ - public void setValue(Enum property, State state, String value) { + public void setValue(Enum property, State state, String value) { //only update if it shall override if (state.compareTo(states[property.ordinal()]) >= 0) { values[property.ordinal()] = value; @@ -128,7 +128,7 @@ * @param property the property * @return the value of the property */ - public String getValue(Enum property) { + public String getValue(Enum property) { return values[property.ordinal()]; } @@ -195,7 +195,7 @@ * @param property the property * @param systemProperty the name of the system property */ - void getSystemProperty(Enum property, String systemProperty) { + void getSystemProperty(Enum property, String systemProperty) { try { String value = SecuritySupport.getSystemProperty(systemProperty); if (value != null) { diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/utils/ObjectFactory.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/utils/ObjectFactory.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/utils/ObjectFactory.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. - * @LastModified: Sep 2017 + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -124,7 +124,7 @@ { ClassLoader cl = System.getSecurityManager()!=null ? null : findClassLoader(); try{ - Class providerClass = findProviderClass(className, cl, doFallback); + Class providerClass = findProviderClass(className, cl, doFallback); Object instance = providerClass.getConstructor().newInstance(); debugPrintln(()->"created new instance of " + providerClass + " using ClassLoader: " + cl); diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/Translet.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/Translet.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/Translet.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -43,8 +43,8 @@ public void buildKeys(DOM document, DTMAxisIterator iterator, SerializationHandler handler, int root) throws TransletException; - public void addAuxiliaryClass(Class auxClass); - public Class getAuxiliaryClass(String className); + public void addAuxiliaryClass(Class auxClass); + public Class getAuxiliaryClass(String className); public String[] getNamesArray(); public String[] getUrisArray(); public int[] getTypesArray(); diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ApplyTemplates.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ApplyTemplates.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ApplyTemplates.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,5 +1,6 @@ /* - * Copyright (c) 2015, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -20,9 +21,6 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Enumeration; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; import com.sun.org.apache.bcel.internal.generic.INVOKEINTERFACE; import com.sun.org.apache.bcel.internal.generic.INVOKEVIRTUAL; @@ -38,7 +36,8 @@ import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Util; import com.sun.org.apache.xml.internal.utils.XML11Char; -import java.util.Iterator; +import java.util.ArrayList; +import java.util.List; /** * @author Jacek Ambroziak @@ -119,10 +118,10 @@ final int current = methodGen.getLocalIndex("current"); // check if sorting nodes is required - final Vector sortObjects = new Vector<>(); + final List sortObjects = new ArrayList<>(); for (final SyntaxTreeNode child : getContents()) { if (child instanceof Sort) { - sortObjects.addElement((Sort)child); + sortObjects.add((Sort)child); } } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AttributeSet.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AttributeSet.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AttributeSet.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,5 +1,6 @@ /* - * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -34,10 +35,8 @@ import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Util; import com.sun.org.apache.xml.internal.utils.XML11Char; -import java.util.Enumeration; import java.util.Iterator; import java.util.List; -import java.util.Vector; /** diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AttributeValueTemplate.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AttributeValueTemplate.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AttributeValueTemplate.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,5 +1,6 @@ /* - * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -23,11 +24,6 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Enumeration; -import java.util.Vector; -import java.util.StringTokenizer; -import java.util.NoSuchElementException; - import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; import com.sun.org.apache.bcel.internal.generic.INVOKESPECIAL; import com.sun.org.apache.bcel.internal.generic.INVOKEVIRTUAL; @@ -41,6 +37,8 @@ import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; import java.util.Iterator; import java.util.List; +import java.util.NoSuchElementException; +import java.util.StringTokenizer; /** * @author Jacek Ambroziak @@ -86,7 +84,7 @@ */ String t = null; String lookahead = null; - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); int state = OUT_EXPR; while (tokenizer.hasMoreTokens()) { @@ -220,7 +218,7 @@ } public String toString() { - final StringBuffer buffer = new StringBuffer("AVT:["); + final StringBuilder buffer = new StringBuilder("AVT:["); final int count = elementCount(); for (int i = 0; i < count; i++) { buffer.append(elementAt(i).toString()); @@ -252,7 +250,7 @@ il.append(new NEW(cpg.addClass(STRING_BUFFER_CLASS))); il.append(DUP); il.append(new INVOKESPECIAL(initBuffer)); - // StringBuffer is on the stack + // StringBuilder is on the stack final Iterator elements = elements(); while (elements.hasNext()) { final Expression exp = (Expression)elements.next(); diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/BinOpExpr.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/BinOpExpr.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/BinOpExpr.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -83,11 +83,11 @@ new MethodType(Type.Void, tleft, tright)); if (ptype != null) { - final Type arg1 = (Type) ptype.argsType().elementAt(0); + final Type arg1 = (Type) ptype.argsType().get(0); if (!arg1.identicalTo(tleft)) { _left = new CastExpr(_left, arg1); } - final Type arg2 = (Type) ptype.argsType().elementAt(1); + final Type arg2 = (Type) ptype.argsType().get(1); if (!arg2.identicalTo(tright)) { _right = new CastExpr(_right, arg1); } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/BooleanCall.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/BooleanCall.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/BooleanCall.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,12 +21,11 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Vector; - import com.sun.org.apache.xalan.internal.xsltc.compiler.util.ClassGenerator; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.MethodGenerator; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Type; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; +import java.util.List; /** * @author Jacek Ambroziak @@ -36,7 +35,7 @@ private Expression _arg = null; - public BooleanCall(QName fname, Vector arguments) { + public BooleanCall(QName fname, List arguments) { super(fname, arguments); _arg = argument(0); } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CallTemplate.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CallTemplate.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CallTemplate.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,5 +1,6 @@ /* - * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2016, 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -30,8 +31,7 @@ import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Util; import com.sun.org.apache.xml.internal.utils.XML11Char; - -import java.util.Vector; +import java.util.List; /** * @author Jacek Ambroziak @@ -205,11 +205,11 @@ private void buildParameterList() { // Put the parameters from the called template into the array first. // This is to ensure the order of the parameters. - Vector defaultParams = _calleeTemplate.getParameters(); + List defaultParams = _calleeTemplate.getParameters(); int numParams = defaultParams.size(); _parameters = new SyntaxTreeNode[numParams]; for (int i = 0; i < numParams; i++) { - _parameters[i] = defaultParams.elementAt(i); + _parameters[i] = defaultParams.get(i); } // Replace a Param with a WithParam if they have the same name. diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CastCall.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CastCall.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CastCall.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,17 +21,16 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Vector; - +import com.sun.org.apache.bcel.internal.generic.CHECKCAST; import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; -import com.sun.org.apache.bcel.internal.generic.CHECKCAST; import com.sun.org.apache.bcel.internal.generic.InstructionList; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.ClassGenerator; +import com.sun.org.apache.xalan.internal.xsltc.compiler.util.ErrorMsg; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.MethodGenerator; -import com.sun.org.apache.xalan.internal.xsltc.compiler.util.ErrorMsg; +import com.sun.org.apache.xalan.internal.xsltc.compiler.util.ObjectType; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Type; -import com.sun.org.apache.xalan.internal.xsltc.compiler.util.ObjectType; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; +import java.util.List; /** * @author Santiago Pericas-Geertsen @@ -52,7 +51,7 @@ /** * Constructor. */ - public CastCall(QName fname, Vector arguments) { + public CastCall(QName fname, List arguments) { super(fname, arguments); } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CeilingCall.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CeilingCall.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CeilingCall.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,20 +21,19 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; import com.sun.org.apache.bcel.internal.generic.INVOKESTATIC; import com.sun.org.apache.bcel.internal.generic.InstructionList; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.ClassGenerator; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.MethodGenerator; +import java.util.List; /** * @author Jacek Ambroziak * @author Santiago Pericas-Geertsen */ final class CeilingCall extends FunctionCall { - public CeilingCall(QName fname, Vector arguments) { + public CeilingCall(QName fname, List arguments) { super(fname, arguments); } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Choose.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Choose.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Choose.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,5 +1,6 @@ /* - * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -23,9 +24,6 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Enumeration; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.BranchHandle; import com.sun.org.apache.bcel.internal.generic.GOTO; import com.sun.org.apache.bcel.internal.generic.IFEQ; @@ -37,7 +35,11 @@ import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Type; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Util; +import java.util.ArrayList; +import java.util.Collections; +import java.util.Enumeration; import java.util.Iterator; +import java.util.List; /** * @author Jacek Ambroziak @@ -61,7 +63,7 @@ * elements and default to the if present. */ public void translate(ClassGenerator classGen, MethodGenerator methodGen) { - final Vector whenElements = new Vector(); + final List whenElements = new ArrayList<>(); Otherwise otherwise = null; Iterator elements = elements(); @@ -74,7 +76,7 @@ SyntaxTreeNode element = elements.next(); // Add a When child element if (element instanceof When) { - whenElements.addElement(element); + whenElements.add(element); } // Add an Otherwise child element else if (element instanceof Otherwise) { @@ -108,10 +110,10 @@ // next element will hold a handle to the beginning of next // When/Otherwise if test on current When fails BranchHandle nextElement = null; - Vector exitHandles = new Vector(); + List exitHandles = new ArrayList<>(); InstructionHandle exit = null; - Enumeration whens = whenElements.elements(); + Enumeration whens = Collections.enumeration(whenElements); while (whens.hasMoreElements()) { final When when = (When)whens.nextElement(); final Expression test = when.getTest(); @@ -142,7 +144,7 @@ if (!when.ignore()) when.translateContents(classGen, methodGen); // goto exit after executing the body of when - exitHandles.addElement(il.append(new GOTO(null))); + exitHandles.add(il.append(new GOTO(null))); if (whens.hasMoreElements() || otherwise != null) { nextElement = il.append(new GOTO(null)); test.backPatchFalseList(nextElement); @@ -160,7 +162,7 @@ } // now that end is known set targets of exit gotos - Enumeration exitGotos = exitHandles.elements(); + Enumeration exitGotos = Collections.enumeration(exitHandles); while (exitGotos.hasMoreElements()) { BranchHandle gotoExit = (BranchHandle)exitGotos.nextElement(); gotoExit.setTarget(exit); diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ConcatCall.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ConcatCall.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ConcatCall.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,8 +21,6 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; import com.sun.org.apache.bcel.internal.generic.INVOKESPECIAL; import com.sun.org.apache.bcel.internal.generic.INVOKEVIRTUAL; @@ -34,13 +32,14 @@ import com.sun.org.apache.xalan.internal.xsltc.compiler.util.MethodGenerator; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Type; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; +import java.util.List; /** * @author Jacek Ambroziak * @author Santiago Pericas-Geertsen */ final class ConcatCall extends FunctionCall { - public ConcatCall(QName fname, Vector arguments) { + public ConcatCall(QName fname, List arguments) { super(fname, arguments); } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ContainsCall.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ContainsCall.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ContainsCall.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,8 +21,6 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; import com.sun.org.apache.bcel.internal.generic.IFLT; import com.sun.org.apache.bcel.internal.generic.INVOKEVIRTUAL; @@ -32,6 +30,7 @@ import com.sun.org.apache.xalan.internal.xsltc.compiler.util.MethodGenerator; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Type; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; +import java.util.List; /** * @author Jacek Ambroziak @@ -46,7 +45,7 @@ /** * Create a contains() call - two arguments, both strings */ - public ContainsCall(QName fname, Vector arguments) { + public ContainsCall(QName fname, List arguments) { super(fname, arguments); } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/DocumentCall.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/DocumentCall.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/DocumentCall.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,11 +21,8 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; import com.sun.org.apache.bcel.internal.generic.GETFIELD; -import com.sun.org.apache.bcel.internal.generic.INVOKEINTERFACE; import com.sun.org.apache.bcel.internal.generic.INVOKESTATIC; import com.sun.org.apache.bcel.internal.generic.InstructionList; import com.sun.org.apache.bcel.internal.generic.PUSH; @@ -34,6 +31,7 @@ import com.sun.org.apache.xalan.internal.xsltc.compiler.util.MethodGenerator; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Type; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; +import java.util.List; /** * @author Jacek Ambroziak @@ -48,7 +46,7 @@ /** * Default function call constructor */ - public DocumentCall(QName fname, Vector arguments) { + public DocumentCall(QName fname, List arguments) { super(fname, arguments); } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ElementAvailableCall.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ElementAvailableCall.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ElementAvailableCall.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,8 +21,6 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; import com.sun.org.apache.bcel.internal.generic.PUSH; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.ClassGenerator; @@ -30,6 +28,7 @@ import com.sun.org.apache.xalan.internal.xsltc.compiler.util.MethodGenerator; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Type; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; +import java.util.List; /** * @author Jacek Ambroziak @@ -37,7 +36,7 @@ */ final class ElementAvailableCall extends FunctionCall { - public ElementAvailableCall(QName fname, Vector arguments) { + public ElementAvailableCall(QName fname, List arguments) { super(fname, arguments); } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Expression.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Expression.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Expression.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,8 +21,6 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.BranchHandle; import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; import com.sun.org.apache.bcel.internal.generic.GOTO_W; @@ -37,6 +35,7 @@ import com.sun.org.apache.xalan.internal.xsltc.compiler.util.NodeSetType; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Type; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; +import java.util.List; /** * @author Jacek Ambroziak @@ -193,12 +192,12 @@ public MethodType lookupPrimop(SymbolTable stable, String op, MethodType ctype) { MethodType result = null; - final Vector primop = stable.lookupPrimop(op); + final List primop = stable.lookupPrimop(op); if (primop != null) { final int n = primop.size(); int minDistance = Integer.MAX_VALUE; for (int i = 0; i < n; i++) { - final MethodType ptype = (MethodType) primop.elementAt(i); + final MethodType ptype = primop.get(i); // Skip if different arity if (ptype.argsCount() != ctype.argsCount()) { continue; diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FilterExpr.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FilterExpr.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FilterExpr.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,17 +21,13 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.ALOAD; import com.sun.org.apache.bcel.internal.generic.ASTORE; import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; import com.sun.org.apache.bcel.internal.generic.ILOAD; -import com.sun.org.apache.bcel.internal.generic.INVOKEINTERFACE; import com.sun.org.apache.bcel.internal.generic.INVOKESPECIAL; -import com.sun.org.apache.bcel.internal.generic.INVOKESTATIC; +import com.sun.org.apache.bcel.internal.generic.ISTORE; import com.sun.org.apache.bcel.internal.generic.InstructionList; -import com.sun.org.apache.bcel.internal.generic.ISTORE; import com.sun.org.apache.bcel.internal.generic.LocalVariableGen; import com.sun.org.apache.bcel.internal.generic.NEW; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.ClassGenerator; @@ -41,6 +37,7 @@ import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Type; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Util; +import java.util.List; /** * @author Jacek Ambroziak @@ -57,9 +54,9 @@ /** * Array of predicates in '(e)[p1]...[pn]'. */ - private final Vector _predicates; + private final List _predicates; - public FilterExpr(Expression primary, Vector predicates) { + public FilterExpr(Expression primary, List predicates) { _primary = primary; _predicates = predicates; primary.setParent(this); @@ -78,7 +75,7 @@ if (_predicates != null) { final int n = _predicates.size(); for (int i = 0; i < n; i++) { - final Expression exp = (Expression)_predicates.elementAt(i); + final Expression exp = (Expression)_predicates.get(i); exp.setParser(parser); exp.setParent(this); } @@ -112,7 +109,7 @@ // Type check predicates and turn all optimizations off if appropriate int n = _predicates.size(); for (int i = 0; i < n; i++) { - Predicate pred = (Predicate) _predicates.elementAt(i); + Predicate pred = (Predicate) _predicates.get(i); if (!canOptimize) { pred.dontOptimize(); diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FloorCall.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FloorCall.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FloorCall.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,18 +21,17 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.INVOKESTATIC; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.ClassGenerator; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.MethodGenerator; +import java.util.List; /** * @author Jacek Ambroziak * @author Santiago Pericas-Geertsen */ final class FloorCall extends FunctionCall { - public FloorCall(QName fname, Vector arguments) { + public FloorCall(QName fname, List arguments) { super(fname, arguments); } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FlowList.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FlowList.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FlowList.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,27 +21,27 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Iterator; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.BranchHandle; import com.sun.org.apache.bcel.internal.generic.InstructionHandle; import com.sun.org.apache.bcel.internal.generic.InstructionList; +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; /** * @author Jacek Ambroziak * @author Santiago Pericas-Geertsen */ public final class FlowList { - private Vector _elements; + private List _elements; public FlowList() { _elements = null; } public FlowList(InstructionHandle bh) { - _elements = new Vector(); - _elements.addElement(bh); + _elements = new ArrayList<>(); + _elements.add(bh); } public FlowList(FlowList list) { @@ -50,9 +50,9 @@ public FlowList add(InstructionHandle bh) { if (_elements == null) { - _elements = new Vector(); + _elements = new ArrayList<>(); } - _elements.addElement(bh); + _elements.add(bh); return this; } @@ -61,11 +61,11 @@ _elements = right._elements; } else { - final Vector temp = right._elements; + final List temp = right._elements; if (temp != null) { final int n = temp.size(); for (int i = 0; i < n; i++) { - _elements.addElement(temp.elementAt(i)); + _elements.add(temp.get(i)); } } } @@ -79,7 +79,7 @@ if (_elements != null) { final int n = _elements.size(); for (int i = 0; i < n; i++) { - BranchHandle bh = (BranchHandle)_elements.elementAt(i); + BranchHandle bh = (BranchHandle)_elements.get(i); bh.setTarget(target); } _elements.clear(); // avoid backpatching more than once @@ -99,15 +99,15 @@ } final int n = _elements.size(); - final Iterator oldIter = oldList.iterator(); - final Iterator newIter = newList.iterator(); + final Iterator oldIter = oldList.iterator(); + final Iterator newIter = newList.iterator(); while (oldIter.hasNext()) { - final InstructionHandle oldIh = (InstructionHandle) oldIter.next(); - final InstructionHandle newIh = (InstructionHandle) newIter.next(); + final InstructionHandle oldIh = oldIter.next(); + final InstructionHandle newIh = newIter.next(); for (int i = 0; i < n; i++) { - if (_elements.elementAt(i) == oldIh) { + if (_elements.get(i) == oldIh) { result.add(newIh); } } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ForEach.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ForEach.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ForEach.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,5 +1,6 @@ /* - * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -23,9 +24,6 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Enumeration; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.BranchHandle; import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; import com.sun.org.apache.bcel.internal.generic.GOTO; @@ -42,7 +40,9 @@ import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Type; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Util; +import java.util.ArrayList; import java.util.Iterator; +import java.util.List; /** * @author Jacek Ambroziak @@ -97,12 +97,12 @@ il.append(methodGen.loadIterator()); // Collect sort objects associated with this instruction - final Vector sortObjects = new Vector(); + final List sortObjects = new ArrayList<>(); Iterator children = elements(); while (children.hasNext()) { - final Object child = children.next(); + final SyntaxTreeNode child = children.next(); if (child instanceof Sort) { - sortObjects.addElement(child); + sortObjects.add((Sort)child); } } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FormatNumberCall.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FormatNumberCall.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FormatNumberCall.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,8 +21,6 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; import com.sun.org.apache.bcel.internal.generic.INVOKESTATIC; import com.sun.org.apache.bcel.internal.generic.INVOKEVIRTUAL; @@ -34,6 +32,7 @@ import com.sun.org.apache.xalan.internal.xsltc.compiler.util.StringType; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Type; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; +import java.util.List; /** * @author Jacek Ambroziak @@ -46,7 +45,7 @@ private Expression _name; private QName _resolvedQName = null; - public FormatNumberCall(QName fname, Vector arguments) { + public FormatNumberCall(QName fname, List arguments) { super(fname, arguments); _value = argument(0); _format = argument(1); diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionAvailableCall.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionAvailableCall.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionAvailableCall.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,19 +21,18 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.lang.reflect.Method; -import java.lang.reflect.Modifier; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; import com.sun.org.apache.bcel.internal.generic.PUSH; +import com.sun.org.apache.xalan.internal.utils.ObjectFactory; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.ClassGenerator; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.ErrorMsg; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.MethodGenerator; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Type; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Util; -import com.sun.org.apache.xalan.internal.utils.ObjectFactory; +import java.lang.reflect.Method; +import java.lang.reflect.Modifier; +import java.util.List; /** * @author G. Todd Miller @@ -52,9 +51,9 @@ * a list of arguments where the arguments must be instances of * LiteralExpression. */ - public FunctionAvailableCall(QName fname, Vector arguments) { + public FunctionAvailableCall(QName fname, List arguments) { super(fname, arguments); - _arg = (Expression)arguments.elementAt(0); + _arg = (Expression)arguments.get(0); _type = null; if (_arg instanceof LiteralExpr) { @@ -131,7 +130,7 @@ methodName = replaceDash(methodName); try { - final Class clazz = ObjectFactory.findProviderClass(className, true); + final Class clazz = ObjectFactory.findProviderClass(className, true); if (clazz == null) { return false; diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionCall.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionCall.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionCall.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,5 +1,6 @@ /* * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -48,12 +49,12 @@ import java.lang.reflect.Constructor; import java.lang.reflect.Method; import java.lang.reflect.Modifier; +import java.util.ArrayList; import java.util.Collections; -import java.util.Enumeration; import java.util.HashMap; +import java.util.List; import java.util.Map; import java.util.Objects; -import java.util.Vector; import jdk.xml.internal.JdkXmlFeatures; /** @@ -68,9 +69,9 @@ // Name of this function call private QName _fname; // Arguments to this function call (might not be any) - private final Vector _arguments; + private final List _arguments; // Empty argument list, used for certain functions - private final static Vector EMPTY_ARG_LIST = new Vector(0); + private final static List EMPTY_ARG_LIST = new ArrayList<>(0); // Valid namespaces for Java function-call extension protected final static String EXT_XSLTC = @@ -122,9 +123,9 @@ // External Java function's class/method/signature private String _className; - private Class _clazz; + private Class _clazz; private Method _chosenMethod; - private Constructor _chosenConstructor; + private Constructor _chosenConstructor; private MethodType _chosenMethodType; // Encapsulates all unsupported external function calls @@ -156,7 +157,7 @@ public Class type; public int distance; - public JavaType(Class type, int distance){ + public JavaType(Class type, int distance){ this.type = type; this.distance = distance; } @@ -294,7 +295,7 @@ } - public FunctionCall(QName fname, Vector arguments) { + public FunctionCall(QName fname, List arguments) { _fname = fname; _arguments = arguments; _type = null; @@ -314,7 +315,7 @@ if (_arguments != null) { final int n = _arguments.size(); for (int i = 0; i < n; i++) { - final Expression exp = (Expression)_arguments.elementAt(i); + final Expression exp = _arguments.get(i); exp.setParser(parser); exp.setParent(this); } @@ -435,18 +436,18 @@ _fname.clearNamespace(); // HACK!!! final int n = _arguments.size(); - final Vector argsType = typeCheckArgs(stable); + final List argsType = typeCheckArgs(stable); final MethodType args = new MethodType(Type.Void, argsType); final MethodType ptype = lookupPrimop(stable, _fname.getLocalPart(), args); if (ptype != null) { for (int i = 0; i < n; i++) { - final Type argType = (Type) ptype.argsType().elementAt(i); - final Expression exp = (Expression)_arguments.elementAt(i); + final Type argType = (Type) ptype.argsType().get(i); + final Expression exp = _arguments.get(i); if (!argType.identicalTo(exp.getType())) { try { - _arguments.setElementAt(new CastExpr(exp, argType), i); + _arguments.set(i, new CastExpr(exp, argType)); } catch (TypeCheckError e) { throw new TypeCheckError(this); // invalid conversion @@ -462,7 +463,7 @@ public Type typeCheckConstructor(SymbolTable stable) throws TypeCheckError{ - final Vector constructors = findConstructors(); + final List> constructors = findConstructors(); if (constructors == null) { // Constructor not found in this class throw new TypeCheckError(ErrorMsg.CONSTRUCTOR_NOT_FOUND, @@ -472,23 +473,22 @@ final int nConstructors = constructors.size(); final int nArgs = _arguments.size(); - final Vector argsType = typeCheckArgs(stable); + final List argsType = typeCheckArgs(stable); // Try all constructors int bestConstrDistance = Integer.MAX_VALUE; _type = null; // reset for (int j, i = 0; i < nConstructors; i++) { // Check if all parameters to this constructor can be converted - final Constructor constructor = - (Constructor)constructors.elementAt(i); - final Class[] paramTypes = constructor.getParameterTypes(); + final Constructor constructor = constructors.get(i); + final Class[] paramTypes = constructor.getParameterTypes(); Class extType; int currConstrDistance = 0; for (j = 0; j < nArgs; j++) { // Convert from internal (translet) type to external (Java) type extType = paramTypes[j]; - final Type intType = (Type)argsType.elementAt(j); + final Type intType = argsType.get(j); JavaType match = _internal2Java.maps(intType, new JavaType(extType, 0)); if (match != null) { currConstrDistance += match.distance; @@ -556,7 +556,7 @@ || _namespace_format == NAMESPACE_FORMAT_PACKAGE) hasThisArgument = true; - Expression firstArg = (Expression)_arguments.elementAt(0); + Expression firstArg = _arguments.get(0); Type firstArgType = (Type)firstArg.typeCheck(stable); if (_namespace_format == NAMESPACE_FORMAT_CLASS @@ -566,7 +566,7 @@ hasThisArgument = true; if (hasThisArgument) { - _thisArgument = (Expression) _arguments.elementAt(0); + _thisArgument = _arguments.get(0); _arguments.remove(0); nArgs--; if (firstArgType instanceof ObjectType) { _className = ((ObjectType) firstArgType).getJavaClassName(); @@ -592,30 +592,30 @@ } } - final Vector methods = findMethods(); + final List methods = findMethods(); if (methods == null) { // Method not found in this class throw new TypeCheckError(ErrorMsg.METHOD_NOT_FOUND_ERR, _className + "." + name); } - Class extType = null; + Class extType = null; final int nMethods = methods.size(); - final Vector argsType = typeCheckArgs(stable); + final List argsType = typeCheckArgs(stable); // Try all methods to identify the best fit int bestMethodDistance = Integer.MAX_VALUE; _type = null; // reset internal type for (int j, i = 0; i < nMethods; i++) { // Check if all paramteters to this method can be converted - final Method method = (Method)methods.elementAt(i); - final Class[] paramTypes = method.getParameterTypes(); + final Method method = (Method)methods.get(i); + final Class[] paramTypes = method.getParameterTypes(); int currMethodDistance = 0; for (j = 0; j < nArgs; j++) { // Convert from internal (translet) type to external (Java) type extType = paramTypes[j]; - final Type intType = (Type)argsType.elementAt(j); + final Type intType = argsType.get(j); JavaType match = _internal2Java.maps(intType, new JavaType(extType, 0)); if (match != null) { currMethodDistance += match.distance; @@ -683,18 +683,16 @@ /** * Type check the actual arguments of this function call. */ - public Vector typeCheckArgs(SymbolTable stable) throws TypeCheckError { - final Vector result = new Vector(); - final Enumeration e = _arguments.elements(); - while (e.hasMoreElements()) { - final Expression exp = (Expression)e.nextElement(); - result.addElement(exp.typeCheck(stable)); + public List typeCheckArgs(SymbolTable stable) throws TypeCheckError { + final List result = new ArrayList<>(); + for (Expression exp : _arguments) { + result.add(exp.typeCheck(stable)); } return result; } protected final Expression argument(int i) { - return (Expression)_arguments.elementAt(i); + return _arguments.get(i); } protected final Expression argument() { @@ -706,7 +704,7 @@ } protected final void setArgument(int i, Expression exp) { - _arguments.setElementAt(exp, i); + _arguments.set(i, exp); } /** @@ -795,7 +793,7 @@ // .class.getModule().addReads( generateAddReads(classGen, methodGen, clazz); - Class[] paramTypes = _chosenConstructor.getParameterTypes(); + Class[] paramTypes = _chosenConstructor.getParameterTypes(); LocalVariableGen[] paramTemp = new LocalVariableGen[n]; // Backwards branches are prohibited if an uninitialized object is @@ -856,7 +854,7 @@ translateUnallowedExtension(cpg, il); final String clazz = _chosenMethod.getDeclaringClass().getName(); - Class[] paramTypes = _chosenMethod.getParameterTypes(); + Class[] paramTypes = _chosenMethod.getParameterTypes(); // Generate call to Module.addReads: @@ -960,9 +958,9 @@ * after stripping its namespace or null * if no such methods exist. */ - private Vector findMethods() { + private List findMethods() { - Vector result = null; + List result = null; final String namespace = _fname.getNamespace(); if (_className != null && _className.length() > 0) { @@ -1003,9 +1001,9 @@ && methods[i].getParameterTypes().length == nArgs) { if (result == null) { - result = new Vector(); + result = new ArrayList<>(); } - result.addElement(methods[i]); + result.add(methods[i]); } } } @@ -1022,9 +1020,8 @@ * after stripping its namespace or null * if no such methods exist. */ - private Vector findConstructors() { - Vector result = null; - final String namespace = _fname.getNamespace(); + private List> findConstructors() { + List> result = null; final int nArgs = _arguments.size(); try { @@ -1037,20 +1034,17 @@ } } - final Constructor[] constructors = _clazz.getConstructors(); + final Constructor[] constructors = _clazz.getConstructors(); - for (int i = 0; i < constructors.length; i++) { - final int mods = constructors[i].getModifiers(); - // Is it public, static and same number of args ? - if (Modifier.isPublic(mods) && - constructors[i].getParameterTypes().length == nArgs) - { - if (result == null) { - result = new Vector(); + for (Constructor constructor : constructors) { + final int mods = constructor.getModifiers(); + // Is it public, static and same number of args ? + if (Modifier.isPublic(mods) && constructor.getParameterTypes().length == nArgs) { + if (result == null) { + result = new ArrayList<>(); + } result.add(constructor); } - result.addElement(constructors[i]); - } - } + } } catch (ClassNotFoundException e) { final ErrorMsg msg = new ErrorMsg(ErrorMsg.CLASS_NOT_FOUND_ERR, _className); @@ -1064,10 +1058,10 @@ /** * Compute the JVM signature for the class. */ - static final String getSignature(Class clazz) { + static final String getSignature(Class clazz) { if (clazz.isArray()) { final StringBuffer sb = new StringBuffer(); - Class cl = clazz; + Class cl = clazz; while (cl.isArray()) { sb.append("["); cl = cl.getComponentType(); @@ -1120,7 +1114,7 @@ static final String getSignature(Method meth) { final StringBuffer sb = new StringBuffer(); sb.append('('); - final Class[] params = meth.getParameterTypes(); // avoid clone + final Class[] params = meth.getParameterTypes(); // avoid clone for (int j = 0; j < params.length; j++) { sb.append(getSignature(params[j])); } @@ -1131,10 +1125,10 @@ /** * Compute the JVM constructor descriptor for the constructor. */ - static final String getSignature(Constructor cons) { + static final String getSignature(Constructor cons) { final StringBuffer sb = new StringBuffer(); sb.append('('); - final Class[] params = cons.getParameterTypes(); // avoid clone + final Class[] params = cons.getParameterTypes(); // avoid clone for (int j = 0; j < params.length; j++) { sb.append(getSignature(params[j])); } @@ -1144,13 +1138,13 @@ /** * Return the signature of the current method */ - private String getMethodSignature(Vector argsType) { + private String getMethodSignature(List argsType) { final StringBuffer buf = new StringBuffer(_className); buf.append('.').append(_fname.getLocalPart()).append('('); int nArgs = argsType.size(); for (int i = 0; i < nArgs; i++) { - final Type intType = (Type)argsType.elementAt(i); + final Type intType = argsType.get(i); buf.append(intType.toString()); if (i < nArgs - 1) buf.append(", "); } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/GenerateIdCall.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/GenerateIdCall.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/GenerateIdCall.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,20 +21,19 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; import com.sun.org.apache.bcel.internal.generic.INVOKESTATIC; import com.sun.org.apache.bcel.internal.generic.InstructionList; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.ClassGenerator; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.MethodGenerator; +import java.util.List; /** * @author Jacek Ambroziak * @author Santiago Pericas-Geertsen */ final class GenerateIdCall extends FunctionCall { - public GenerateIdCall(QName fname, Vector arguments) { + public GenerateIdCall(QName fname, List arguments) { super(fname, arguments); } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Key.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Key.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Key.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,5 +1,6 @@ /* - * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -23,8 +24,6 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.BranchHandle; import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; import com.sun.org.apache.bcel.internal.generic.GOTO; diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/KeyCall.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/KeyCall.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/KeyCall.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,28 +21,16 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Vector; - -import com.sun.org.apache.bcel.internal.generic.ALOAD; -import com.sun.org.apache.bcel.internal.generic.ASTORE; -import com.sun.org.apache.bcel.internal.generic.BranchHandle; import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; -import com.sun.org.apache.bcel.internal.generic.GOTO; -import com.sun.org.apache.bcel.internal.generic.IFGT; -import com.sun.org.apache.bcel.internal.generic.INVOKEINTERFACE; -import com.sun.org.apache.bcel.internal.generic.INVOKESPECIAL; import com.sun.org.apache.bcel.internal.generic.INVOKEVIRTUAL; -import com.sun.org.apache.bcel.internal.generic.InstructionHandle; import com.sun.org.apache.bcel.internal.generic.InstructionList; -import com.sun.org.apache.bcel.internal.generic.LocalVariableGen; -import com.sun.org.apache.bcel.internal.generic.NEW; import com.sun.org.apache.bcel.internal.generic.PUSH; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.ClassGenerator; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.MethodGenerator; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.StringType; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Type; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; -import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Util; +import java.util.List; /** * @author Morten Jorgensen @@ -82,7 +70,7 @@ * @param fname The function name (should be 'key' or 'id') * @param arguments A vector containing the arguments the the function */ - public KeyCall(QName fname, Vector arguments) { + public KeyCall(QName fname, List arguments) { super(fname, arguments); switch(argumentCount()) { case 1: diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LangCall.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LangCall.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LangCall.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,8 +21,6 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; import com.sun.org.apache.bcel.internal.generic.ILOAD; import com.sun.org.apache.bcel.internal.generic.INVOKESTATIC; @@ -33,6 +31,7 @@ import com.sun.org.apache.xalan.internal.xsltc.compiler.util.StringType; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Type; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.TypeCheckError; +import java.util.List; /** * @author Morten Jorgensen @@ -45,7 +44,7 @@ * Get the parameters passed to function: * lang(string) */ - public LangCall(QName fname, Vector arguments) { + public LangCall(QName fname, List arguments) { super(fname, arguments); _lang = argument(0); } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LiteralElement.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LiteralElement.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LiteralElement.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,5 +1,6 @@ /* - * Copyright (c) 2015, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -102,6 +103,7 @@ // Check if we have any declared namespaces if (_accessedPrefixes == null) { + // use Hashtable for behavior compatibility _accessedPrefixes = new Hashtable<>(); } else { diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LocalNameCall.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LocalNameCall.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LocalNameCall.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -21,14 +21,13 @@ package com.sun.org.apache.xalan.internal.xsltc.compiler; -import java.util.Vector; - import com.sun.org.apache.bcel.internal.generic.ConstantPoolGen; import com.sun.org.apache.bcel.internal.generic.INVOKEINTERFACE; import com.sun.org.apache.bcel.internal.generic.INVOKESTATIC; import com.sun.org.apache.bcel.internal.generic.InstructionList; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.ClassGenerator; import com.sun.org.apache.xalan.internal.xsltc.compiler.util.MethodGenerator; +import java.util.List; /** * @author Morten Jorgensen @@ -45,7 +44,7 @@ /** * Handles calls with one parameter (either node or node-set). */ - public LocalNameCall(QName fname, Vector arguments) { + public LocalNameCall(QName fname, List arguments) { super(fname, arguments); } diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LogicalExpr.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LogicalExpr.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LogicalExpr.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,6 +1,6 @@ /* - * reserved comment block - * DO NOT REMOVE OR ALTER! + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -137,11 +137,11 @@ // Yes, the operation is supported if (haveType != null) { // Check if left-hand side operand must be type casted - Type arg1 = (Type)haveType.argsType().elementAt(0); + Type arg1 = (Type)haveType.argsType().get(0); if (!arg1.identicalTo(tleft)) _left = new CastExpr(_left, arg1); // Check if right-hand side operand must be type casted - Type arg2 = (Type) haveType.argsType().elementAt(1); + Type arg2 = (Type) haveType.argsType().get(1); if (!arg2.identicalTo(tright)) _right = new CastExpr(_right, arg1); // Return the result type for the operator we will use diff -r d07d5f7cab35 -r e1a6c0168741 src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Mode.java --- a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Mode.java Tue Sep 05 13:40:14 2017 +0200 +++ b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Mode.java Wed Oct 18 13:25:49 2017 -0700 @@ -1,5 +1,6 @@ /* - * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. + * @LastModified: Oct 2017 */ /* * Licensed to the Apache Software Foundation (ASF) under one or more @@ -46,12 +47,12 @@ import com.sun.org.apache.xalan.internal.xsltc.compiler.util.Util; import com.sun.org.apache.xml.internal.dtm.Axis; import com.sun.org.apache.xml.internal.dtm.DTM; -import java.util.Enumeration; +import java.util.ArrayList; import java.util.HashMap; import java.util.Iterator; +import java.util.List; import java.util.Map; import java.util.Set; -import java.util.Vector; /** * Mode gathers all the templates belonging to a given mode; @@ -83,12 +84,12 @@ /** * A vector of all the templates in this mode. */ - private Vector _templates; + private List