# HG changeset patch # User littlee # Date 1338798635 -28800 # Node ID c404d4a709de7b675fe7d955a9bdb5124d221a55 # Parent 77e41e310650a4317447298e6981703202500559 7166055: Javadoc for WeakHashMap contains misleading advice Reviewed-by: dholmes, mduigou diff -r 77e41e310650 -r c404d4a709de jdk/src/share/classes/java/util/WeakHashMap.java --- a/jdk/src/share/classes/java/util/WeakHashMap.java Fri Jun 01 00:05:21 2012 -0700 +++ b/jdk/src/share/classes/java/util/WeakHashMap.java Mon Jun 04 16:30:35 2012 +0800 @@ -90,7 +90,8 @@ * from being discarded. Note that a value object may refer indirectly to its * key via the WeakHashMap itself; that is, a value object may * strongly refer to some other key object whose associated value object, in - * turn, strongly refers to the key of the first value object. One way + * turn, strongly refers to the key of the first value object. If the values + * in the map do not rely on the map holding strong references to them, one way * to deal with this is to wrap values themselves within * WeakReferences before * inserting, as in: m.put(key, new WeakReference(value)),