# HG changeset patch # User darcy # Date 1429840278 25200 # Node ID b9c86c17164a0f7481b8f749595a57a9d7938c45 # Parent e7dbbef69d12b6a74dfad331b7188e7f893e8d29 8078468: Update security libraries to use diamond with anonymous classes Reviewed-by: weijun diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/com/sun/crypto/provider/JceKeyStore.java --- a/jdk/src/java.base/share/classes/com/sun/crypto/provider/JceKeyStore.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/com/sun/crypto/provider/JceKeyStore.java Thu Apr 23 18:51:18 2015 -0700 @@ -711,7 +711,7 @@ cf = CertificateFactory.getInstance("X509"); } else { // version 2 - cfs = new Hashtable(3); + cfs = new Hashtable<>(3); } entries.clear(); diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/com/sun/crypto/provider/PBEKeyFactory.java --- a/jdk/src/java.base/share/classes/com/sun/crypto/provider/PBEKeyFactory.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/com/sun/crypto/provider/PBEKeyFactory.java Thu Apr 23 18:51:18 2015 -0700 @@ -56,7 +56,7 @@ } static { - validTypes = new HashSet(17); + validTypes = new HashSet<>(17); validTypes.add("PBEWithMD5AndDES".toUpperCase(Locale.ENGLISH)); validTypes.add("PBEWithSHA1AndDESede".toUpperCase(Locale.ENGLISH)); validTypes.add("PBEWithSHA1AndRC2_40".toUpperCase(Locale.ENGLISH)); diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java --- a/jdk/src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java Thu Apr 23 18:51:18 2015 -0700 @@ -115,7 +115,7 @@ final String BLOCK_PADS = "NOPADDING|PKCS5PADDING|ISO10126PADDING"; AccessController.doPrivileged( - new java.security.PrivilegedAction() { + new java.security.PrivilegedAction<>() { public Object run() { /* diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java --- a/jdk/src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java Thu Apr 23 18:51:18 2015 -0700 @@ -63,7 +63,7 @@ */ public final static String getDefaultAlgorithm() { String type; - type = AccessController.doPrivileged(new PrivilegedAction() { + type = AccessController.doPrivileged(new PrivilegedAction<>() { public String run() { return Security.getProperty("sun.ssl.keymanager.type"); } diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java --- a/jdk/src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java Thu Apr 23 18:51:18 2015 -0700 @@ -63,7 +63,7 @@ */ public final static String getDefaultAlgorithm() { String type; - type = AccessController.doPrivileged(new PrivilegedAction() { + type = AccessController.doPrivileged(new PrivilegedAction<>() { public String run() { return Security.getProperty("sun.ssl.trustmanager.type"); } diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/AccessControlContext.java --- a/jdk/src/java.base/share/classes/java/security/AccessControlContext.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/AccessControlContext.java Thu Apr 23 18:51:18 2015 -0700 @@ -458,7 +458,7 @@ Thread.dumpStack(); final ProtectionDomain pd = context[i]; final Debug db = debug; - AccessController.doPrivileged (new PrivilegedAction() { + AccessController.doPrivileged (new PrivilegedAction<>() { public Void run() { db.println("domain that failed "+pd); return null; diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/AccessController.java --- a/jdk/src/java.base/share/classes/java/security/AccessController.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/AccessController.java Thu Apr 23 18:51:18 2015 -0700 @@ -612,7 +612,7 @@ private static ProtectionDomain getCallerPD(final Class caller) { ProtectionDomain callerPd = doPrivileged - (new PrivilegedAction() { + (new PrivilegedAction<>() { public ProtectionDomain run() { return caller.getProtectionDomain(); } diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/AllPermission.java --- a/jdk/src/java.base/share/classes/java/security/AllPermission.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/AllPermission.java Thu Apr 23 18:51:18 2015 -0700 @@ -212,7 +212,7 @@ * @return an enumeration of all the AllPermission objects. */ public Enumeration elements() { - return new Enumeration() { + return new Enumeration<>() { private boolean hasMore = all_allowed; public boolean hasMoreElements() { diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/BasicPermission.java --- a/jdk/src/java.base/share/classes/java/security/BasicPermission.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/BasicPermission.java Thu Apr 23 18:51:18 2015 -0700 @@ -332,7 +332,7 @@ */ public BasicPermissionCollection(Class clazz) { - perms = new HashMap(11); + perms = new HashMap<>(11); all_allowed = false; permClass = clazz; } @@ -533,7 +533,7 @@ @SuppressWarnings("unchecked") Hashtable permissions = (Hashtable)gfields.get("permissions", null); - perms = new HashMap(permissions.size()*2); + perms = new HashMap<>(permissions.size()*2); perms.putAll(permissions); // Get all_allowed diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/CodeSource.java --- a/jdk/src/java.base/share/classes/java/security/CodeSource.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/CodeSource.java Thu Apr 23 18:51:18 2015 -0700 @@ -543,7 +543,7 @@ if (size > 0) { // we know of 3 different cert types: X.509, PGP, SDSI, which // could all be present in the stream at the same time - cfs = new Hashtable(3); + cfs = new Hashtable<>(3); this.certs = new java.security.cert.Certificate[size]; } diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/Identity.java --- a/jdk/src/java.base/share/classes/java/security/Identity.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/Identity.java Thu Apr 23 18:51:18 2015 -0700 @@ -185,7 +185,7 @@ check("setIdentityPublicKey"); this.publicKey = key; - certificates = new Vector(); + certificates = new Vector<>(); } /** @@ -248,7 +248,7 @@ check("addIdentityCertificate"); if (certificates == null) { - certificates = new Vector(); + certificates = new Vector<>(); } if (publicKey != null) { if (!keyEquals(publicKey, certificate.getPublicKey())) { diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/IdentityScope.java --- a/jdk/src/java.base/share/classes/java/security/IdentityScope.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/IdentityScope.java Thu Apr 23 18:51:18 2015 -0700 @@ -74,7 +74,7 @@ private static void initializeSystemScope() { String classname = AccessController.doPrivileged( - new PrivilegedAction() { + new PrivilegedAction<>() { public String run() { return Security.getProperty("system.scope"); } diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/KeyStore.java --- a/jdk/src/java.base/share/classes/java/security/KeyStore.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/KeyStore.java Thu Apr 23 18:51:18 2015 -0700 @@ -976,7 +976,7 @@ */ public final static String getDefaultType() { String kstype; - kstype = AccessController.doPrivileged(new PrivilegedAction() { + kstype = AccessController.doPrivileged(new PrivilegedAction<>() { public String run() { return Security.getProperty(KEYSTORE_TYPE); } diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/Permissions.java --- a/jdk/src/java.base/share/classes/java/security/Permissions.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/Permissions.java Thu Apr 23 18:51:18 2015 -0700 @@ -99,7 +99,7 @@ * Creates a new Permissions object containing no PermissionCollections. */ public Permissions() { - permsMap = new HashMap, PermissionCollection>(11); + permsMap = new HashMap<>(11); allPermission = null; } @@ -394,7 +394,7 @@ @SuppressWarnings("unchecked") Hashtable, PermissionCollection> perms = (Hashtable, PermissionCollection>)gfields.get("perms", null); - permsMap = new HashMap, PermissionCollection>(perms.size()*2); + permsMap = new HashMap<>(perms.size()*2); permsMap.putAll(perms); // Set hasUnresolved @@ -488,7 +488,7 @@ */ PermissionsHash() { - permsMap = new HashMap(11); + permsMap = new HashMap<>(11); } /** @@ -597,7 +597,7 @@ @SuppressWarnings("unchecked") Hashtable perms = (Hashtable)gfields.get("perms", null); - permsMap = new HashMap(perms.size()*2); + permsMap = new HashMap<>(perms.size()*2); permsMap.putAll(perms); } } diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/Policy.java --- a/jdk/src/java.base/share/classes/java/security/Policy.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/Policy.java Thu Apr 23 18:51:18 2015 -0700 @@ -170,7 +170,7 @@ PolicyInfo pinfo = policy.get(); if (pinfo.policy == null) { String policy_class = AccessController.doPrivileged( - new PrivilegedAction() { + new PrivilegedAction<>() { public String run() { return Security.getProperty("policy.provider"); } @@ -199,7 +199,7 @@ final String pc = policy_class; Policy pol = AccessController.doPrivileged( - new PrivilegedAction() { + new PrivilegedAction<>() { public Policy run() { try { ClassLoader cl = @@ -303,7 +303,7 @@ */ ProtectionDomain policyDomain = - AccessController.doPrivileged(new PrivilegedAction() { + AccessController.doPrivileged(new PrivilegedAction<>() { public ProtectionDomain run() { return p.getClass().getProtectionDomain(); } diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/ProtectionDomain.java --- a/jdk/src/java.base/share/classes/java/security/ProtectionDomain.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/ProtectionDomain.java Thu Apr 23 18:51:18 2015 -0700 @@ -367,7 +367,7 @@ PermissionCollection perms = java.security.AccessController.doPrivileged - (new java.security.PrivilegedAction() { + (new java.security.PrivilegedAction<>() { public PermissionCollection run() { Policy p = Policy.getPolicyNoCheck(); return p.getPermissions(ProtectionDomain.this); diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/Provider.java --- a/jdk/src/java.base/share/classes/java/security/Provider.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/Provider.java Thu Apr 23 18:51:18 2015 -0700 @@ -711,7 +711,7 @@ legacyChanged = true; if (legacyStrings == null) { - legacyStrings = new LinkedHashMap(); + legacyStrings = new LinkedHashMap<>(); } return true; } @@ -773,7 +773,7 @@ private void implReplaceAll(BiFunction function) { legacyChanged = true; if (legacyStrings == null) { - legacyStrings = new LinkedHashMap(); + legacyStrings = new LinkedHashMap<>(); } else { legacyStrings.replaceAll((BiFunction) function); } @@ -905,7 +905,7 @@ } serviceSet = null; if (legacyMap == null) { - legacyMap = new LinkedHashMap(); + legacyMap = new LinkedHashMap<>(); } else { legacyMap.clear(); } @@ -1133,7 +1133,7 @@ ("service.getProvider() must match this Provider object"); } if (serviceMap == null) { - serviceMap = new LinkedHashMap(); + serviceMap = new LinkedHashMap<>(); } servicesChanged = true; String type = s.getType(); @@ -1305,7 +1305,7 @@ } static { - knownEngines = new HashMap(); + knownEngines = new HashMap<>(); // JCA addEngine("AlgorithmParameterGenerator", false, null); addEngine("AlgorithmParameters", false, null); @@ -1431,14 +1431,14 @@ private void addAlias(String alias) { if (aliases.isEmpty()) { - aliases = new ArrayList(2); + aliases = new ArrayList<>(2); } aliases.add(alias); } void addAttribute(String type, String value) { if (attributes.isEmpty()) { - attributes = new HashMap(8); + attributes = new HashMap<>(8); } attributes.put(new UString(type), value); } @@ -1471,12 +1471,12 @@ if (aliases == null) { this.aliases = Collections.emptyList(); } else { - this.aliases = new ArrayList(aliases); + this.aliases = new ArrayList<>(aliases); } if (attributes == null) { this.attributes = Collections.emptyMap(); } else { - this.attributes = new HashMap(); + this.attributes = new HashMap<>(); for (Map.Entry entry : attributes.entrySet()) { this.attributes.put(new UString(entry.getKey()), entry.getValue()); } @@ -1644,7 +1644,7 @@ ("class configured for " + type + " (provider: " + provider.getName() + ") is not public."); } - classRef = new WeakReference>(clazz); + classRef = new WeakReference<>(clazz); } return clazz; } catch (ClassNotFoundException e) { diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/SecureRandom.java --- a/jdk/src/java.base/share/classes/java/security/SecureRandom.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/SecureRandom.java Thu Apr 23 18:51:18 2015 -0700 @@ -616,7 +616,7 @@ throws NoSuchAlgorithmException { String property = AccessController.doPrivileged( - new PrivilegedAction() { + new PrivilegedAction<>() { @Override public String run() { return Security.getProperty( diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/Security.java --- a/jdk/src/java.base/share/classes/java/security/Security.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/Security.java Thu Apr 23 18:51:18 2015 -0700 @@ -66,7 +66,7 @@ // things in initialize that might require privs. // (the FileInputStream call and the File.exists call, // the securityPropFile call, etc) - AccessController.doPrivileged(new PrivilegedAction() { + AccessController.doPrivileged(new PrivilegedAction<>() { public Void run() { initialize(); return null; @@ -810,7 +810,7 @@ final boolean pd = key.equals("package.definition"); if (pa || pd) { - AccessController.doPrivileged(new PrivilegedAction() { + AccessController.doPrivileged(new PrivilegedAction<>() { public Void run() { try { /* Get the class via the bootstrap class loader. */ diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/Signature.java --- a/jdk/src/java.base/share/classes/java/security/Signature.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/Signature.java Thu Apr 23 18:51:18 2015 -0700 @@ -265,7 +265,7 @@ private final static Map signatureInfo; static { - signatureInfo = new ConcurrentHashMap(); + signatureInfo = new ConcurrentHashMap<>(); Boolean TRUE = Boolean.TRUE; // pre-initialize with values for our SignatureSpi implementations signatureInfo.put("sun.security.provider.DSA$RawDSA", TRUE); diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/Signer.java --- a/jdk/src/java.base/share/classes/java/security/Signer.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/Signer.java Thu Apr 23 18:51:18 2015 -0700 @@ -140,7 +140,7 @@ } try { AccessController.doPrivileged( - new PrivilegedExceptionAction() { + new PrivilegedExceptionAction<>() { public Void run() throws KeyManagementException { setPublicKey(pub); return null; diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/UnresolvedPermission.java --- a/jdk/src/java.base/share/classes/java/security/UnresolvedPermission.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/UnresolvedPermission.java Thu Apr 23 18:51:18 2015 -0700 @@ -560,7 +560,7 @@ if (size > 0) { // we know of 3 different cert types: X.509, PGP, SDSI, which // could all be present in the stream at the same time - cfs = new Hashtable(3); + cfs = new Hashtable<>(3); this.certs = new java.security.cert.Certificate[size]; } diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/UnresolvedPermissionCollection.java --- a/jdk/src/java.base/share/classes/java/security/UnresolvedPermissionCollection.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/UnresolvedPermissionCollection.java Thu Apr 23 18:51:18 2015 -0700 @@ -61,7 +61,7 @@ * */ public UnresolvedPermissionCollection() { - perms = new HashMap>(11); + perms = new HashMap<>(11); } /** @@ -82,7 +82,7 @@ synchronized (this) { v = perms.get(up.getName()); if (v == null) { - v = new ArrayList(); + v = new ArrayList<>(); perms.put(up.getName(), v); } } @@ -203,7 +203,7 @@ Hashtable> permissions = (Hashtable>) gfields.get("permissions", null); - perms = new HashMap>(permissions.size()*2); + perms = new HashMap<>(permissions.size()*2); // Convert each entry (Vector) into a List Set>> set = permissions.entrySet(); diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/cert/CertPathBuilder.java --- a/jdk/src/java.base/share/classes/java/security/cert/CertPathBuilder.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/cert/CertPathBuilder.java Thu Apr 23 18:51:18 2015 -0700 @@ -301,7 +301,7 @@ */ public final static String getDefaultType() { String cpbtype = - AccessController.doPrivileged(new PrivilegedAction() { + AccessController.doPrivileged(new PrivilegedAction<>() { public String run() { return Security.getProperty(CPB_TYPE); } diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/cert/CertPathValidator.java --- a/jdk/src/java.base/share/classes/java/security/cert/CertPathValidator.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/cert/CertPathValidator.java Thu Apr 23 18:51:18 2015 -0700 @@ -313,7 +313,7 @@ */ public final static String getDefaultType() { String cpvtype = - AccessController.doPrivileged(new PrivilegedAction() { + AccessController.doPrivileged(new PrivilegedAction<>() { public String run() { return Security.getProperty(CPV_TYPE); } diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/cert/CertStore.java --- a/jdk/src/java.base/share/classes/java/security/cert/CertStore.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/cert/CertStore.java Thu Apr 23 18:51:18 2015 -0700 @@ -409,7 +409,7 @@ */ public final static String getDefaultType() { String cstype; - cstype = AccessController.doPrivileged(new PrivilegedAction() { + cstype = AccessController.doPrivileged(new PrivilegedAction<>() { public String run() { return Security.getProperty(CERTSTORE_TYPE); } diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/cert/CertificateRevokedException.java --- a/jdk/src/java.base/share/classes/java/security/cert/CertificateRevokedException.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/cert/CertificateRevokedException.java Thu Apr 23 18:51:18 2015 -0700 @@ -231,7 +231,7 @@ if (size == 0) { extensions = Collections.emptyMap(); } else { - extensions = new HashMap(size); + extensions = new HashMap<>(size); } // Read in the extensions and put the mappings in the extensions map diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/cert/PKIXParameters.java --- a/jdk/src/java.base/share/classes/java/security/cert/PKIXParameters.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/cert/PKIXParameters.java Thu Apr 23 18:51:18 2015 -0700 @@ -120,8 +120,8 @@ setTrustAnchors(trustAnchors); this.unmodInitialPolicies = Collections.emptySet(); - this.certPathCheckers = new ArrayList(); - this.certStores = new ArrayList(); + this.certPathCheckers = new ArrayList<>(); + this.certStores = new ArrayList<>(); } /** @@ -144,7 +144,7 @@ if (keystore == null) throw new NullPointerException("the keystore parameter must be " + "non-null"); - Set hashSet = new HashSet(); + Set hashSet = new HashSet<>(); Enumeration aliases = keystore.aliases(); while (aliases.hasMoreElements()) { String alias = aliases.nextElement(); @@ -156,8 +156,8 @@ } setTrustAnchors(hashSet); this.unmodInitialPolicies = Collections.emptySet(); - this.certPathCheckers = new ArrayList(); - this.certStores = new ArrayList(); + this.certPathCheckers = new ArrayList<>(); + this.certStores = new ArrayList<>(); } /** @@ -207,7 +207,7 @@ } } this.unmodTrustAnchors = Collections.unmodifiableSet - (new HashSet(trustAnchors)); + (new HashSet<>(trustAnchors)); } /** @@ -256,7 +256,7 @@ + "of type java.lang.String"); } this.unmodInitialPolicies = - Collections.unmodifiableSet(new HashSet(initialPolicies)); + Collections.unmodifiableSet(new HashSet<>(initialPolicies)); } else this.unmodInitialPolicies = Collections.emptySet(); } @@ -280,7 +280,7 @@ */ public void setCertStores(List stores) { if (stores == null) { - this.certStores = new ArrayList(); + this.certStores = new ArrayList<>(); } else { for (Iterator i = stores.iterator(); i.hasNext();) { if (!(i.next() instanceof CertStore)) { @@ -288,7 +288,7 @@ + "of type java.security.cert.CertStore"); } } - this.certStores = new ArrayList(stores); + this.certStores = new ArrayList<>(stores); } } @@ -316,7 +316,7 @@ */ public List getCertStores() { return Collections.unmodifiableList - (new ArrayList(this.certStores)); + (new ArrayList<>(this.certStores)); } /** @@ -544,14 +544,13 @@ */ public void setCertPathCheckers(List checkers) { if (checkers != null) { - List tmpList = - new ArrayList(); + List tmpList = new ArrayList<>(); for (PKIXCertPathChecker checker : checkers) { tmpList.add((PKIXCertPathChecker)checker.clone()); } this.certPathCheckers = tmpList; } else { - this.certPathCheckers = new ArrayList(); + this.certPathCheckers = new ArrayList<>(); } } @@ -567,7 +566,7 @@ * @see #setCertPathCheckers */ public List getCertPathCheckers() { - List tmpList = new ArrayList(); + List tmpList = new ArrayList<>(); for (PKIXCertPathChecker ck : certPathCheckers) { tmpList.add((PKIXCertPathChecker)ck.clone()); } @@ -667,11 +666,11 @@ // must clone these because addCertStore, et al. modify them if (certStores != null) { - copy.certStores = new ArrayList(certStores); + copy.certStores = new ArrayList<>(certStores); } if (certPathCheckers != null) { copy.certPathCheckers = - new ArrayList(certPathCheckers.size()); + new ArrayList<>(certPathCheckers.size()); for (PKIXCertPathChecker checker : certPathCheckers) { copy.certPathCheckers.add( (PKIXCertPathChecker)checker.clone()); diff -r e7dbbef69d12 -r b9c86c17164a jdk/src/java.base/share/classes/java/security/cert/PKIXRevocationChecker.java --- a/jdk/src/java.base/share/classes/java/security/cert/PKIXRevocationChecker.java Wed Jul 05 20:30:11 2017 +0200 +++ b/jdk/src/java.base/share/classes/java/security/cert/PKIXRevocationChecker.java Thu Apr 23 18:51:18 2015 -0700 @@ -170,7 +170,7 @@ { this.ocspExtensions = (extensions == null) ? Collections.emptyList() - : new ArrayList(extensions); + : new ArrayList<>(extensions); } /** @@ -232,7 +232,7 @@ public void setOptions(Set