# HG changeset patch # User darcy # Date 1308152231 25200 # Node ID b96a8c7fefef86b61f739fb5d4b6fd3af25e32a3 # Parent 1ce86f81cb71cf8a12de9ea92c4eca0ca4b87138 7041252: Use j.u.Objects.equals in security classes Reviewed-by: weijun diff -r 1ce86f81cb71 -r b96a8c7fefef jdk/src/share/classes/sun/security/tools/KeyTool.java --- a/jdk/src/share/classes/sun/security/tools/KeyTool.java Tue Jun 14 12:31:31 2011 -0700 +++ b/jdk/src/share/classes/sun/security/tools/KeyTool.java Wed Jun 15 08:37:11 2011 -0700 @@ -4193,15 +4193,11 @@ return "Pair[" + fst + "," + snd + "]"; } - private static boolean equals(Object x, Object y) { - return (x == null && y == null) || (x != null && x.equals(y)); - } - public boolean equals(Object other) { return other instanceof Pair && - equals(fst, ((Pair)other).fst) && - equals(snd, ((Pair)other).snd); + Objects.equals(fst, ((Pair)other).fst) && + Objects.equals(snd, ((Pair)other).snd); } public int hashCode() { diff -r 1ce86f81cb71 -r b96a8c7fefef jdk/src/share/classes/sun/security/x509/DistributionPoint.java --- a/jdk/src/share/classes/sun/security/x509/DistributionPoint.java Tue Jun 14 12:31:31 2011 -0700 +++ b/jdk/src/share/classes/sun/security/x509/DistributionPoint.java Wed Jun 15 08:37:11 2011 -0700 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2002, 2006, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2002, 2011, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -319,13 +319,6 @@ } /** - * Utility function for a.equals(b) where both a and b may be null. - */ - private static boolean equals(Object a, Object b) { - return (a == null) ? (b == null) : a.equals(b); - } - - /** * Compare an object to this DistributionPoint for equality. * * @param obj Object to be compared to this @@ -340,9 +333,9 @@ } DistributionPoint other = (DistributionPoint)obj; - boolean equal = equals(this.fullName, other.fullName) - && equals(this.relativeName, other.relativeName) - && equals(this.crlIssuer, other.crlIssuer) + boolean equal = Objects.equals(this.fullName, other.fullName) + && Objects.equals(this.relativeName, other.relativeName) + && Objects.equals(this.crlIssuer, other.crlIssuer) && Arrays.equals(this.reasonFlags, other.reasonFlags); return equal; } diff -r 1ce86f81cb71 -r b96a8c7fefef jdk/src/share/classes/sun/security/x509/DistributionPointName.java --- a/jdk/src/share/classes/sun/security/x509/DistributionPointName.java Tue Jun 14 12:31:31 2011 -0700 +++ b/jdk/src/share/classes/sun/security/x509/DistributionPointName.java Wed Jun 15 08:37:11 2011 -0700 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2005, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2005, 2011, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -201,8 +201,8 @@ } DistributionPointName other = (DistributionPointName)obj; - return equals(this.fullName, other.fullName) && - equals(this.relativeName, other.relativeName); + return Objects.equals(this.fullName, other.fullName) && + Objects.equals(this.relativeName, other.relativeName); } /** @@ -239,11 +239,4 @@ return sb.toString(); } - - /* - * Utility function for a.equals(b) where both a and b may be null. - */ - private static boolean equals(Object a, Object b) { - return (a == null) ? (b == null) : a.equals(b); - } }