# HG changeset patch # User kzhaldyb # Date 1474044543 -10800 # Node ID a276ca7d0c8cbae0acec036de60ba817027045c8 # Parent 9e686d23e6400759f63e22ac9d26f06b8f7bfd8c 8165613: Convert TestKlass_test to Gtest Reviewed-by: coleenp, rehn diff -r 9e686d23e640 -r a276ca7d0c8c hotspot/src/share/vm/oops/klass.cpp --- a/hotspot/src/share/vm/oops/klass.cpp Wed Sep 21 18:40:50 2016 +0000 +++ b/hotspot/src/share/vm/oops/klass.cpp Fri Sep 16 19:49:03 2016 +0300 @@ -734,27 +734,3 @@ } #endif - -/////////////// Unit tests /////////////// - -#ifndef PRODUCT - -class TestKlass { - public: - static void test_oop_is_instanceClassLoader() { - Klass* klass = SystemDictionary::ClassLoader_klass(); - guarantee(klass->is_instance_klass(), "assert"); - guarantee(InstanceKlass::cast(klass)->is_class_loader_instance_klass(), "test failed"); - - klass = SystemDictionary::String_klass(); - guarantee(!klass->is_instance_klass() || - !InstanceKlass::cast(klass)->is_class_loader_instance_klass(), - "test failed"); - } -}; - -void TestKlass_test() { - TestKlass::test_oop_is_instanceClassLoader(); -} - -#endif // PRODUCT diff -r 9e686d23e640 -r a276ca7d0c8c hotspot/src/share/vm/utilities/internalVMTests.cpp --- a/hotspot/src/share/vm/utilities/internalVMTests.cpp Wed Sep 21 18:40:50 2016 +0000 +++ b/hotspot/src/share/vm/utilities/internalVMTests.cpp Fri Sep 16 19:49:03 2016 +0300 @@ -57,7 +57,6 @@ run_unit_test(GuardedMemory_test); run_unit_test(TestNewSize_test); run_unit_test(TestOldSize_test); - run_unit_test(TestKlass_test); run_unit_test(TestBitMap_test); run_unit_test(TestResourcehash_test); run_unit_test(ObjectMonitor_test); diff -r 9e686d23e640 -r a276ca7d0c8c hotspot/test/native/oops/test_instanceKlass.cpp --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/hotspot/test/native/oops/test_instanceKlass.cpp Fri Sep 16 19:49:03 2016 +0300 @@ -0,0 +1,47 @@ +/* + * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +#include "precompiled.hpp" +#include "classfile/symbolTable.hpp" +#include "classfile/systemDictionary.hpp" +#include "memory/resourceArea.hpp" +#include "oops/instanceKlass.hpp" +#include "unittest.hpp" + +// Tests InstanceKlass::package_from_name() +TEST_VM(InstanceKlass, null_symbol) { + ResourceMark rm; + TempNewSymbol package_sym = InstanceKlass::package_from_name(NULL, NULL); + ASSERT_TRUE(package_sym == NULL) << "Wrong package for NULL symbol"; +} + +// Tests for InstanceKlass::is_class_loader_instance_klass() function +TEST_VM(InstanceKlass, class_loader_class) { + InstanceKlass* klass = SystemDictionary::ClassLoader_klass(); + ASSERT_TRUE(klass->is_class_loader_instance_klass()); +} + +TEST_VM(InstanceKlass, string_klass) { + InstanceKlass* klass = SystemDictionary::String_klass(); + ASSERT_TRUE(!klass->is_class_loader_instance_klass()); +} diff -r 9e686d23e640 -r a276ca7d0c8c hotspot/test/native/runtime/test_instanceKlass.cpp --- a/hotspot/test/native/runtime/test_instanceKlass.cpp Wed Sep 21 18:40:50 2016 +0000 +++ /dev/null Thu Jan 01 00:00:00 1970 +0000 @@ -1,36 +0,0 @@ -/* - * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - * - */ - -#include "precompiled.hpp" -#include "classfile/symbolTable.hpp" -#include "memory/resourceArea.hpp" -#include "oops/instanceKlass.hpp" -#include "unittest.hpp" - -// Tests InstanceKlass::package_from_name() -TEST_VM(instanceKlass, null_symbol) { - ResourceMark rm; - TempNewSymbol package_sym = InstanceKlass::package_from_name(NULL, NULL); - ASSERT_TRUE(package_sym == NULL) << "Wrong package for NULL symbol"; -}