# HG changeset patch # User mcimadamore # Date 1223564549 -3600 # Node ID 9c381121f3017b6297ff4796c94c08d31668c6de # Parent 19d266637353b001e30f19b20a2a701fe4dc46c6 6738538: javac crashes when using a type parameter as a covariant method return type Summary: Capture conversion should be applied when acccessing a member of an intersection type Reviewed-by: jjg diff -r 19d266637353 -r 9c381121f301 langtools/src/share/classes/com/sun/tools/javac/code/Types.java --- a/langtools/src/share/classes/com/sun/tools/javac/code/Types.java Thu Oct 09 15:56:20 2008 +0100 +++ b/langtools/src/share/classes/com/sun/tools/javac/code/Types.java Thu Oct 09 16:02:29 2008 +0100 @@ -1430,6 +1430,10 @@ long flags = sym.flags(); if (((flags & STATIC) == 0) && owner.type.isParameterized()) { Type base = asOuterSuper(t, owner); + //if t is an intersection type T = CT & I1 & I2 ... & In + //its supertypes CT, I1, ... In might contain wildcards + //so we need to go through capture conversion + base = t.isCompound() ? capture(base) : base; if (base != null) { List ownerParams = owner.type.allparams(); List baseParams = base.allparams(); diff -r 19d266637353 -r 9c381121f301 langtools/test/tools/javac/OverrideChecks/6738538/T6738538a.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/langtools/test/tools/javac/OverrideChecks/6738538/T6738538a.java Thu Oct 09 16:02:29 2008 +0100 @@ -0,0 +1,44 @@ +/* + * Copyright 2008 Sun Microsystems, Inc. All Rights Reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, + * CA 95054 USA or visit www.sun.com if you need additional information or + * have any questions. + */ + +/* + * @test + * @bug 6738538 6687444 + * @summary javac crashes when using a type parameter as a covariant method return type + * @author Maurizio Cimadamore + * + * @compile T6738538a.java + */ + +class T6738538a { + + class C { + public T m(){ + return null; + } + } + interface I{ + public T m(); + } + class Crash & I> {} +} \ No newline at end of file diff -r 19d266637353 -r 9c381121f301 langtools/test/tools/javac/OverrideChecks/6738538/T6738538b.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/langtools/test/tools/javac/OverrideChecks/6738538/T6738538b.java Thu Oct 09 16:02:29 2008 +0100 @@ -0,0 +1,47 @@ +/* + * Copyright 2008 Sun Microsystems, Inc. All Rights Reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, + * CA 95054 USA or visit www.sun.com if you need additional information or + * have any questions. + */ + +/* + * @test + * @bug 6738538 6687444 + * @summary javac crashes when using a type parameter as a covariant method return type + * @author Maurizio Cimadamore + * + * @compile T6738538b.java + */ + +class T6738538b { + interface I1 { + Object m(); + } + + interface I2 {} + + class C1 implements I1 { + public T m() { + return null; + } + } + + class C2 & I2> {} +} \ No newline at end of file