# HG changeset patch # User herrick # Date 1565784519 14400 # Node ID 8d6f0aff03fc48fc063cfc9fe4187d72c4c36c55 # Parent e3d4b9bc5093ab0f3bfb9911a20096be06244b89 8226534: combination of windows options cause exception in MsiBundler Submitted-by: almatvee Reviewed-by: herrick, asemenyuk diff -r e3d4b9bc5093 -r 8d6f0aff03fc src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java --- a/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java Wed Aug 14 07:50:54 2019 -0400 +++ b/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java Wed Aug 14 08:08:39 2019 -0400 @@ -188,7 +188,7 @@ } return null; } - + public static final StandardBundlerParam MENU_HINT = new WindowsBundlerParam<>( @@ -918,20 +918,44 @@ " "); } + // reset counters + compId = 0; + id = 0; + // We should get valid folder or subfolders String installDir = WINDOWS_INSTALL_DIR.fetchFrom(params); String [] installDirs = installDir.split(Pattern.quote("\\")); for (int i = 0; i < (installDirs.length - 1); i++) { out.println(" "); + if (!MSI_SYSTEM_WIDE.fetchFrom(params)) { + out.println(" "); + out.println(""); + // has to be under HKCU to make WiX happy + out.println(" " : " Action=\"createAndRemoveOnUninstall\">")); + out.println(" "); + out.println(" "); + out.println(" "); + out.println(""); + } } out.println(" "); // dynamic part - id = 0; - compId = 0; // reset counters walkFileTree(params, WIN_APP_IMAGE.fetchFrom(params), out, " "); // closing