# HG changeset patch # User darcy # Date 1466107234 25200 # Node ID 815e5274406899589036c550f39add3304279cf3 # Parent 52db877f18db725f0a36ae5069ab0bef82da795f 8071859: AnnotationInvocationHandler.equals(Object) return true when apply to annotation Reviewed-by: mchung, chegar diff -r 52db877f18db -r 815e52744068 jdk/src/java.base/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java --- a/jdk/src/java.base/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java Thu Jun 16 09:09:53 2016 -0300 +++ b/jdk/src/java.base/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java Thu Jun 16 13:00:34 2016 -0700 @@ -62,7 +62,7 @@ // Handle Object and Annotation methods if (member.equals("equals") && paramTypes.length == 1 && paramTypes[0] == Object.class) - return equalsImpl(args[0]); + return equalsImpl(proxy, args[0]); if (paramTypes.length != 0) throw new AssertionError("Too many parameters for an annotation method"); @@ -209,8 +209,8 @@ /** * Implementation of dynamicProxy.equals(Object o) */ - private Boolean equalsImpl(Object o) { - if (o == this) + private Boolean equalsImpl(Object proxy, Object o) { + if (o == proxy) return true; if (!type.isInstance(o)) diff -r 52db877f18db -r 815e52744068 jdk/test/java/lang/annotation/EqualityTest.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/jdk/test/java/lang/annotation/EqualityTest.java Thu Jun 16 13:00:34 2016 -0700 @@ -0,0 +1,55 @@ +/* + * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8071859 + * @summary Check annotation equality behavior against the invocation handler + */ + +import java.lang.annotation.*; +import java.lang.reflect.*; + +@TestAnnotation +public class EqualityTest { + public static void main(String... args) throws Exception { + TestAnnotation annotation = + EqualityTest.class.getAnnotation(TestAnnotation.class); + InvocationHandler handler = Proxy.getInvocationHandler(annotation); + + testEquality(annotation, handler, false); + testEquality(annotation, annotation, true); + testEquality(handler, handler, true); + } + + private static void testEquality(Object a, Object b, boolean expected) { + boolean result = a.equals(b); + if (result != b.equals(a) || result != expected) + throw new RuntimeException("Unexpected result"); + } +} + +@Retention(RetentionPolicy.RUNTIME) +@interface TestAnnotation { +} +