# HG changeset patch # User dfuchs # Date 1521649810 0 # Node ID 7f921a5a6e104432d223da3650ad9b0d68876240 # Parent 7e56c39fa1faab50f216ee44ff153b4def498168 http-client-branch: Early Review comments for JDK-8199938 Supplementary minor HTTP Client spec clarifications diff -r 7e56c39fa1fa -r 7f921a5a6e10 src/java.net.http/share/classes/java/net/http/HttpClient.java --- a/src/java.net.http/share/classes/java/net/http/HttpClient.java Wed Mar 21 15:12:11 2018 +0000 +++ b/src/java.net.http/share/classes/java/net/http/HttpClient.java Wed Mar 21 16:30:10 2018 +0000 @@ -458,7 +458,7 @@ * @implNote When automatic redirection occurs, the request method of the * redirected request may be modified depending on the specific {@code 30X} * status code, as specified in - * RFC 7231. In addition, the {@code 301} and {@code 302} status codes, + * RFC 7231. In addition, the {@code 301} and {@code 302} status codes * cause a {@code POST} request to be converted to a {@code GET} in the * redirected request. * @@ -494,7 +494,9 @@ * @return the response * @throws IOException if an I/O error occurs when sending or receiving * @throws InterruptedException if the operation is interrupted - * @throws IllegalArgumentException if the request method is not supported + * @throws IllegalArgumentException if the {@code request} argument is not + * a request that could have been validly built as specified by {@link + * HttpRequest.Builder HttpRequest.Builder}. * @throws SecurityException If a security manager has been installed * and it denies {@link java.net.URLPermission access} to the * URL in the given request, or proxy if one is configured. @@ -515,6 +517,9 @@ * @param request the request * @param responseBodyHandler the response body handler * @return a {@code CompletableFuture>} + * @throws IllegalArgumentException if the {@code request} argument is not + * a request that could have been validly built as specified by {@link + * HttpRequest.Builder HttpRequest.Builder}. */ public abstract CompletableFuture> sendAsync(HttpRequest request, @@ -547,7 +552,9 @@ * @param responseBodyHandler the response body handler * @param pushPromiseHandler push promise handler, may be null * @return a {@code CompletableFuture>} - * @throws IllegalArgumentException if the request method is not supported + * @throws IllegalArgumentException if the {@code request} argument is not + * a request that could have been validly built as specified by {@link + * HttpRequest.Builder HttpRequest.Builder}. */ public abstract CompletableFuture> sendAsync(HttpRequest request,