# HG changeset patch # User ihse # Date 1432022628 -7200 # Node ID 5e259b665bbf9fc1b93c1c80c2084fe40cfee660 # Parent 4915246064b2f89d5f00c96e758686b7fdad36a6 8080630: Stop doing sed manipulation of manifest files in SetupJavaCompilation Reviewed-by: erikj diff -r 4915246064b2 -r 5e259b665bbf make/JrtfsJar.gmk --- a/make/JrtfsJar.gmk Wed Jul 05 20:33:55 2017 +0200 +++ b/make/JrtfsJar.gmk Tue May 19 10:03:48 2015 +0200 @@ -1,5 +1,5 @@ # -# Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. +# Copyright (c) 2014, 2015, Oracle and/or its affiliates. All rights reserved. # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. # # This code is free software; you can redistribute it and/or modify it @@ -28,10 +28,20 @@ include $(SPEC) include MakeBase.gmk include JavaCompilation.gmk +include TextFileProcessing.gmk + +# This rule will be depended on due to the MANIFEST line +$(eval $(call SetupTextFileProcessing, BUILD_JAVA_MANIFEST, \ + SOURCE_FILES := $(JDK_TOPDIR)/make/data/mainmanifest/manifest.mf, \ + OUTPUT_FILE := $(SUPPORT_OUTPUTDIR)/java-main-manifest.mf, \ + REPLACEMENTS := \ + @@RELEASE@@ => $(RELEASE) ; \ + @@COMPANY_NAME@@ => $(COMPANY_NAME) , \ +)) $(eval $(call SetupArchive,JRTFS_JAR, , \ SRCS := $(BUILDTOOLS_OUTPUTDIR)/interim_jimage_classes, \ JAR := $(SUPPORT_OUTPUTDIR)/jrt-fs.jar, \ - MANIFEST := $(JDK_TOPDIR)/make/data/mainmanifest/manifest.mf)) + MANIFEST := $(SUPPORT_OUTPUTDIR)/java-main-manifest.mf)) all: $(JRTFS_JAR) diff -r 4915246064b2 -r 5e259b665bbf make/common/JavaCompilation.gmk --- a/make/common/JavaCompilation.gmk Wed Jul 05 20:33:55 2017 +0200 +++ b/make/common/JavaCompilation.gmk Tue May 19 10:03:48 2015 +0200 @@ -1,5 +1,5 @@ # -# Copyright (c) 2011, 2014, Oracle and/or its affiliates. All rights reserved. +# Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights reserved. # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. # # This code is free software; you can redistribute it and/or modify it @@ -265,7 +265,7 @@ endif # Include all variables of significance in the vardeps file - $1_VARDEPS := $(JAR) $$($1_JAR_CREATE_OPTIONS) $$($1_MANIFEST) $(RELEASE) $(COMPANY_NAME) \ + $1_VARDEPS := $(JAR) $$($1_JAR_CREATE_OPTIONS) $$($1_MANIFEST) \ $$($1_JARMAIN) $$($1_EXTRA_MANIFEST_ATTR) $1_VARDEPS_FILE := $$(call DependOnVariable, $1_VARDEPS, $$(dir $$($1_JAR))_the.$$($1_JARNAME).vardeps) @@ -280,8 +280,7 @@ # potential changes. $$(if $$(filter $$($1_VARDEPS_FILE) $$($1_MANIFEST), $$?), \ $$(if $$($1_MANIFEST), \ - $(SED) -e "s#@@RELEASE@@#$(RELEASE)#" \ - -e "s#@@COMPANY_NAME@@#$(COMPANY_NAME)#" $$($1_MANIFEST) > $$($1_MANIFEST_FILE) $$(NEWLINE) \ + $(CP) $$($1_MANIFEST) $$($1_MANIFEST_FILE) $$(NEWLINE) \ , \ $(RM) $$($1_MANIFEST_FILE) && $(TOUCH) $$($1_MANIFEST_FILE) $$(NEWLINE)) \ $$(if $$($1_JARMAIN), \