# HG changeset patch # User never # Date 1301630755 25200 # Node ID 458f0d0809b9459c2ec050fe068c2652e7013225 # Parent 1e9e60a225a6db1cb6cc5d8607e991266e77dc5b 6385687: UseFastEmptyMethods/UseFastAccessorMethods considered harmful Reviewed-by: kvn, jrose, phh diff -r 1e9e60a225a6 -r 458f0d0809b9 hotspot/src/share/vm/prims/jvmtiManageCapabilities.cpp --- a/hotspot/src/share/vm/prims/jvmtiManageCapabilities.cpp Thu Mar 31 16:54:27 2011 -0700 +++ b/hotspot/src/share/vm/prims/jvmtiManageCapabilities.cpp Thu Mar 31 21:05:55 2011 -0700 @@ -319,8 +319,11 @@ bool enter_all_methods = interp_events || avail.can_generate_breakpoint_events; - UseFastEmptyMethods = !enter_all_methods; - UseFastAccessorMethods = !enter_all_methods; + if (enter_all_methods) { + // Disable these when tracking the bytecodes + UseFastEmptyMethods = false; + UseFastAccessorMethods = false; + } if (avail.can_generate_breakpoint_events) { RewriteFrequentPairs = false; diff -r 1e9e60a225a6 -r 458f0d0809b9 hotspot/src/share/vm/runtime/globals.hpp --- a/hotspot/src/share/vm/runtime/globals.hpp Thu Mar 31 16:54:27 2011 -0700 +++ b/hotspot/src/share/vm/runtime/globals.hpp Thu Mar 31 21:05:55 2011 -0700 @@ -2726,10 +2726,10 @@ product(bool, UseLoopCounter, true, \ "Increment invocation counter on backward branch") \ \ - product(bool, UseFastEmptyMethods, true, \ + product(bool, UseFastEmptyMethods, false, \ "Use fast method entry code for empty methods") \ \ - product(bool, UseFastAccessorMethods, true, \ + product(bool, UseFastAccessorMethods, false, \ "Use fast method entry code for accessor methods") \ \ product_pd(bool, UseOnStackReplacement, \