# HG changeset patch # User rfield # Date 1461166544 25200 # Node ID 42e5136a367c9a879e19b6b95ba0941331807232 # Parent d4828c4d569c6725f0308e960eecc5036a95ca1d 8153551: jshell tool: no longer a mechanism to see current feedback modes Reviewed-by: jlahoda diff -r d4828c4d569c -r 42e5136a367c langtools/src/jdk.jshell/share/classes/jdk/internal/jshell/tool/Feedback.java --- a/langtools/src/jdk.jshell/share/classes/jdk/internal/jshell/tool/Feedback.java Wed Apr 20 08:30:30 2016 -0700 +++ b/langtools/src/jdk.jshell/share/classes/jdk/internal/jshell/tool/Feedback.java Wed Apr 20 08:35:44 2016 -0700 @@ -606,6 +606,7 @@ fluffmsg("jshell.msg.feedback.mode", mode.name); } else { fluffmsg("jshell.msg.see", "/help /set feedback"); + printFeedbackModes(); } return valid; } @@ -671,13 +672,17 @@ } else { errorat("jshell.err.feedback.ambiguous.mode", umode); } - fluffmsg("jshell.msg.feedback.mode.following"); - modeMap.keySet().stream() - .forEach(mk -> fluff(" %s", mk)); + printFeedbackModes(); return null; } } + void printFeedbackModes() { + fluffmsg("jshell.msg.feedback.mode.following"); + modeMap.keySet().stream() + .forEach(mk -> fluff(" %s", mk)); + } + // Test if the format string is correctly final String nextFormat() { String format = at.next(); diff -r d4828c4d569c -r 42e5136a367c langtools/test/jdk/jshell/ToolFormatTest.java --- a/langtools/test/jdk/jshell/ToolFormatTest.java Wed Apr 20 08:30:30 2016 -0700 +++ b/langtools/test/jdk/jshell/ToolFormatTest.java Wed Apr 20 08:35:44 2016 -0700 @@ -23,7 +23,7 @@ /* * @test - * @bug 8148316 8148317 8151755 8152246 + * @bug 8148316 8148317 8151755 8152246 8153551 * @summary Tests for output customization * @library /tools/lib * @modules jdk.compiler/com.sun.tools.javac.api @@ -155,6 +155,12 @@ } } + public void testShowFeedbackModes() { + test( + (a) -> assertCommandOutputContains(a, "/set feedback", "normal") + ); + } + public void testSetNewModeQuiet() { try { test(