# HG changeset patch # User sundar # Date 1344444447 -19800 # Node ID 41b5b4736385ddd8dfe34da98c33509617d09bb7 # Parent 964a25fb67e77e1b422bf77c95eb26198d85774d 7178324: Crash when compiling for(i : x) try(AutoCloseable x = ...) {} Reviewed-by: darcy, jjg diff -r 964a25fb67e7 -r 41b5b4736385 langtools/src/share/classes/com/sun/tools/javac/tree/TreeInfo.java --- a/langtools/src/share/classes/com/sun/tools/javac/tree/TreeInfo.java Tue Aug 07 20:24:18 2012 -0700 +++ b/langtools/src/share/classes/com/sun/tools/javac/tree/TreeInfo.java Wed Aug 08 22:17:27 2012 +0530 @@ -308,9 +308,8 @@ return endPos(((JCSynchronized) tree).body); else if (tree.hasTag(TRY)) { JCTry t = (JCTry) tree; - return endPos((t.finalizer != null) - ? t.finalizer - : t.catchers.last().body); + return endPos((t.finalizer != null) ? t.finalizer + : (t.catchers.nonEmpty() ? t.catchers.last().body : t.body)); } else return tree.pos; } diff -r 964a25fb67e7 -r 41b5b4736385 langtools/test/tools/javac/TryWithResources/T7178324.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/langtools/test/tools/javac/TryWithResources/T7178324.java Wed Aug 08 22:17:27 2012 +0530 @@ -0,0 +1,43 @@ +/* + * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 7178324 + * @summary Crash when compiling for(i : x) try(AutoCloseable x = ...) {} + * @compile T7178324.java + */ + +import java.io.File; +import java.io.FileInputStream; +import java.util.ArrayList; +import java.util.List; + +class T7178324 { + public static void main(String[] args) throws Exception { + List files = new ArrayList<>(); + for (File f : files) + try (FileInputStream is = new FileInputStream(f)) { + } + } +}