# HG changeset patch # User chegar # Date 1314855900 -3600 # Node ID 2ee16a0f6df5975844df8e45c75269e12479d6c2 # Parent 924705f0b73f46f160939f135fcebbd4e846030c 7014860: Socket.getInputStream().available() not clear for shutdown input Reviewed-by: alanb, michaelm diff -r 924705f0b73f -r 2ee16a0f6df5 jdk/src/share/classes/java/net/AbstractPlainSocketImpl.java --- a/jdk/src/share/classes/java/net/AbstractPlainSocketImpl.java Wed Aug 31 09:22:50 2011 +0800 +++ b/jdk/src/share/classes/java/net/AbstractPlainSocketImpl.java Thu Sep 01 06:45:00 2011 +0100 @@ -457,10 +457,10 @@ } /* - * If connection has been reset then return 0 to indicate - * there are no buffered bytes. + * If connection has been reset or shut down for input, then return 0 + * to indicate there are no buffered bytes. */ - if (isConnectionReset()) { + if (isConnectionReset() || shut_rd) { return 0; } diff -r 924705f0b73f -r 2ee16a0f6df5 jdk/src/share/classes/java/net/Socket.java --- a/jdk/src/share/classes/java/net/Socket.java Wed Aug 31 09:22:50 2011 +0800 +++ b/jdk/src/share/classes/java/net/Socket.java Thu Sep 01 06:45:00 2011 +0100 @@ -28,7 +28,6 @@ import java.io.InputStream; import java.io.OutputStream; import java.io.IOException; -import java.io.InterruptedIOException; import java.nio.channels.SocketChannel; import java.security.AccessController; import java.security.PrivilegedExceptionAction; @@ -1436,8 +1435,9 @@ * Any data sent to the input stream side of the socket is acknowledged * and then silently discarded. *

- * If you read from a socket input stream after invoking - * shutdownInput() on the socket, the stream will return EOF. + * If you read from a socket input stream after invoking this method on the + * socket, the stream's {@code available} method will return 0, and its + * {@code read} methods will return {@code -1} (end of stream). * * @exception IOException if an I/O error occurs when shutting down this * socket. diff -r 924705f0b73f -r 2ee16a0f6df5 jdk/src/share/classes/java/net/SocketImpl.java --- a/jdk/src/share/classes/java/net/SocketImpl.java Wed Aug 31 09:22:50 2011 +0800 +++ b/jdk/src/share/classes/java/net/SocketImpl.java Thu Sep 01 06:45:00 2011 +0100 @@ -181,8 +181,9 @@ * Any data sent to this socket is acknowledged and then * silently discarded. * - * If you read from a socket input stream after invoking - * shutdownInput() on the socket, the stream will return EOF. + * If you read from a socket input stream after invoking this method on the + * socket, the stream's {@code available} method will return 0, and its + * {@code read} methods will return {@code -1} (end of stream). * * @exception IOException if an I/O error occurs when shutting down this * socket. diff -r 924705f0b73f -r 2ee16a0f6df5 jdk/test/java/net/Socket/ShutdownInput.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/jdk/test/java/net/Socket/ShutdownInput.java Thu Sep 01 06:45:00 2011 +0100 @@ -0,0 +1,89 @@ +/* + * Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 7014860 + * @summary Socket.getInputStream().available() not clear for + * case that connection is shutdown for reading + */ + +import java.io.InputStream; +import java.io.OutputStream; +import java.net.InetAddress; +import java.net.InetSocketAddress; +import java.net.ServerSocket; +import java.net.Socket; +import java.nio.channels.ServerSocketChannel; +import java.nio.channels.SocketChannel; + +public class ShutdownInput { + static boolean failed = false; + + public static void main(String args[]) throws Exception { + InetAddress iaddr = InetAddress.getLocalHost(); + + try ( ServerSocket ss = new ServerSocket(0); + Socket s1 = new Socket(iaddr, ss.getLocalPort()); + Socket s2 = ss.accept() ) { + + test(s1, s2, "Testing NET"); + } + + // check the NIO socket adapter + try (ServerSocketChannel sc = ServerSocketChannel.open().bind(null); + SocketChannel s1 = SocketChannel.open( + new InetSocketAddress(iaddr, sc.socket().getLocalPort())); + SocketChannel s2 = sc.accept() ) { + + test(s1.socket(), s2.socket(), "Testing NIO"); + } + + if (failed) { + throw new RuntimeException("Failed: check output"); + } + } + + public static void test(Socket s1, Socket s2, String mesg) throws Exception { + OutputStream os = s1.getOutputStream(); + os.write("This is a message".getBytes("US-ASCII")); + + InputStream in = s2.getInputStream(); + s2.shutdownInput(); + + if (in.available() != 0) { + failed = true; + System.out.println(mesg + ":" + s2 + " in.available() should be 0, " + + "but returns "+ in.available()); + } + + byte[] ba = new byte[2]; + if (in.read() != -1 || + in.read(ba) != -1 || + in.read(ba, 0, ba.length) != -1) { + + failed = true; + System.out.append(mesg + ":" + s2 + " in.read() should be -1"); + } + } +}