# HG changeset patch # User erikj # Date 1517274492 28800 # Node ID 2e2551c38484ac877075001e9c85042d441e0e10 # Parent f944d1b7ab25bd24b1c237455d6de9cba7c6100f 8196365: Overriding configure variable from custom hook generates warning Reviewed-by: tbell diff -r f944d1b7ab25 -r 2e2551c38484 make/autoconf/basics.m4 --- a/make/autoconf/basics.m4 Thu Jan 25 15:18:13 2018 -0800 +++ b/make/autoconf/basics.m4 Mon Jan 29 17:08:12 2018 -0800 @@ -1187,9 +1187,6 @@ AC_DEFUN_ONCE([BASIC_TEST_USABILITY_ISSUES], [ - # Did user specify any unknown variables? - BASIC_CHECK_LEFTOVER_OVERRIDDEN - AC_MSG_CHECKING([if build directory is on local disk]) BASIC_CHECK_DIR_ON_LOCAL_DISK($OUTPUTDIR, [OUTPUT_DIR_IS_LOCAL="yes"], diff -r f944d1b7ab25 -r 2e2551c38484 make/autoconf/configure.ac --- a/make/autoconf/configure.ac Thu Jan 25 15:18:13 2018 -0800 +++ b/make/autoconf/configure.ac Mon Jan 29 17:08:12 2018 -0800 @@ -280,6 +280,9 @@ # This needs to be done after CUSTOM_LATE_HOOK since we can setup custom features. HOTSPOT_VALIDATE_JVM_FEATURES +# Did user specify any unknown variables? +BASIC_CHECK_LEFTOVER_OVERRIDDEN + # We're messing a bit with internal autoconf variables to put the config.status # in the output directory instead of the current directory. CONFIG_STATUS="$CONFIGURESUPPORT_OUTPUTDIR/config.status" diff -r f944d1b7ab25 -r 2e2551c38484 make/autoconf/generated-configure.sh --- a/make/autoconf/generated-configure.sh Thu Jan 25 15:18:13 2018 -0800 +++ b/make/autoconf/generated-configure.sh Mon Jan 29 17:08:12 2018 -0800 @@ -5215,7 +5215,7 @@ #CUSTOM_AUTOCONF_INCLUDE # Do not change or remove the following line, it is needed for consistency checks: -DATE_WHEN_GENERATED=1517244998 +DATE_WHEN_GENERATED=1517274450 ############################################################################### # @@ -69083,16 +69083,6 @@ fi - # Did user specify any unknown variables? - - if test "x$CONFIGURE_OVERRIDDEN_VARIABLES" != x; then - # Replace the separating ! with spaces before presenting for end user. - unknown_variables=${CONFIGURE_OVERRIDDEN_VARIABLES//!/ } - { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: The following variables might be unknown to configure: $unknown_variables" >&5 -$as_echo "$as_me: WARNING: The following variables might be unknown to configure: $unknown_variables" >&2;} - fi - - { $as_echo "$as_me:${as_lineno-$LINENO}: checking if build directory is on local disk" >&5 $as_echo_n "checking if build directory is on local disk... " >&6; } @@ -69174,6 +69164,16 @@ done +# Did user specify any unknown variables? + + if test "x$CONFIGURE_OVERRIDDEN_VARIABLES" != x; then + # Replace the separating ! with spaces before presenting for end user. + unknown_variables=${CONFIGURE_OVERRIDDEN_VARIABLES//!/ } + { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: The following variables might be unknown to configure: $unknown_variables" >&5 +$as_echo "$as_me: WARNING: The following variables might be unknown to configure: $unknown_variables" >&2;} + fi + + # We're messing a bit with internal autoconf variables to put the config.status # in the output directory instead of the current directory. CONFIG_STATUS="$CONFIGURESUPPORT_OUTPUTDIR/config.status"