# HG changeset patch # User xuelei # Date 1336524978 25200 # Node ID 2b25f3fc4f81d7f406e43135954ccca9f580f31c # Parent 3b7fae360d04b4c1b0c8a893e6e89bafc8666e51 7167092: Need to put the return clause in the synchronized block Summary: a regression fix for bug 7153184 Reviewed-by: wetmore diff -r 3b7fae360d04 -r 2b25f3fc4f81 jdk/src/share/classes/sun/security/ssl/SSLContextImpl.java --- a/jdk/src/share/classes/sun/security/ssl/SSLContextImpl.java Tue May 08 11:16:36 2012 -0700 +++ b/jdk/src/share/classes/sun/security/ssl/SSLContextImpl.java Tue May 08 17:56:18 2012 -0700 @@ -276,39 +276,33 @@ supportedCipherSuiteList = getApplicableCipherSuiteList( getSuportedProtocolList(), false); } + + return supportedCipherSuiteList; } - - return supportedCipherSuiteList; } // Get default CipherSuiteList. CipherSuiteList getDefaultCipherSuiteList(boolean roleIsServer) { - if (roleIsServer) { - // The maintenance of cipher suites needs to be synchronized. - synchronized (this) { - // Clear cache of available ciphersuites. - clearAvailableCache(); + // The maintenance of cipher suites needs to be synchronized. + synchronized (this) { + // Clear cache of available ciphersuites. + clearAvailableCache(); + if (roleIsServer) { if (defaultServerCipherSuiteList == null) { defaultServerCipherSuiteList = getApplicableCipherSuiteList( getDefaultProtocolList(true), true); } - } - return defaultServerCipherSuiteList; - } else { - // The maintenance of cipher suites needs to be synchronized - synchronized (this) { - // Clear cache of available ciphersuites. - clearAvailableCache(); - + return defaultServerCipherSuiteList; + } else { if (defaultClientCipherSuiteList == null) { defaultClientCipherSuiteList = getApplicableCipherSuiteList( getDefaultProtocolList(false), true); } + + return defaultClientCipherSuiteList; } - - return defaultClientCipherSuiteList; } }