# HG changeset patch # User aefimov # Date 1432891720 -10800 # Node ID 1f747213d6c9c711e44e178091f87508017bf560 # Parent 56166ce66037952fa21e9f680b31bf8eb47312c0 8081392: getNodeValue should return 'null' value for Element nodes Reviewed-by: joehw diff -r 56166ce66037 -r 1f747213d6c9 jaxp/src/java.xml/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeProxy.java --- a/jaxp/src/java.xml/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeProxy.java Wed Jul 05 20:36:16 2017 +0200 +++ b/jaxp/src/java.xml/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeProxy.java Fri May 29 12:28:40 2015 +0300 @@ -2116,7 +2116,7 @@ */ @Override public String getTextContent() throws DOMException { - return getNodeValue(); // overriden in some subclasses + return dtm.getStringValue(node).toString(); } /** diff -r 56166ce66037 -r 1f747213d6c9 jaxp/src/java.xml/share/classes/com/sun/org/apache/xml/internal/dtm/ref/sax2dtm/SAX2DTM2.java --- a/jaxp/src/java.xml/share/classes/com/sun/org/apache/xml/internal/dtm/ref/sax2dtm/SAX2DTM2.java Wed Jul 05 20:36:16 2017 +0200 +++ b/jaxp/src/java.xml/share/classes/com/sun/org/apache/xml/internal/dtm/ref/sax2dtm/SAX2DTM2.java Fri May 29 12:28:40 2015 +0300 @@ -3145,11 +3145,7 @@ m_data.elementAt(-dataIndex+1)); } } - else if (DTM.ELEMENT_NODE == type) - { - return getStringValueX(nodeHandle); - } - else if (DTM.DOCUMENT_FRAGMENT_NODE == type + else if (DTM.ELEMENT_NODE == type || DTM.DOCUMENT_FRAGMENT_NODE == type || DTM.DOCUMENT_NODE == type) { return null; diff -r 56166ce66037 -r 1f747213d6c9 jaxp/test/javax/xml/jaxp/unittest/javax/xml/transform/DocumentExtFunc.java --- a/jaxp/test/javax/xml/jaxp/unittest/javax/xml/transform/DocumentExtFunc.java Wed Jul 05 20:36:16 2017 +0200 +++ b/jaxp/test/javax/xml/jaxp/unittest/javax/xml/transform/DocumentExtFunc.java Fri May 29 12:28:40 2015 +0300 @@ -30,6 +30,6 @@ public static String test(NodeList list) { Node node = list.item(0); - return "["+node.getNodeName() + ":" + node.getNodeValue()+"]"; + return "["+node.getNodeName() + ":" + node.getTextContent()+"]"; } }