# HG changeset patch # User ihse # Date 1541674998 -3600 # Node ID 187d16766a63195de77140bba1be5b188ed4fed2 # Parent a1eb4f1b94c1e2abe79263e4cba38886550dd178 8213338: Reduce the number of generated make targets Reviewed-by: erikj diff -r a1eb4f1b94c1 -r 187d16766a63 make/Main.gmk --- a/make/Main.gmk Thu Nov 08 00:07:48 2018 -0800 +++ b/make/Main.gmk Thu Nov 08 12:03:18 2018 +0100 @@ -485,7 +485,10 @@ # ALL_NAMED_TESTS is defined in FindTests.gmk $(foreach t, $(ALL_NAMED_TESTS), $(eval $(call DeclareRunTestRecipe,$t))) ALL_TEST_TARGETS := $(addprefix test-, $(ALL_NAMED_TESTS)) -ALL_EXPLODED_TEST_TARGETS := $(addprefix exploded-test-, $(ALL_NAMED_TESTS)) + +# We only support the "exploded-test-gtest" shortcut +ALL_EXPLODED_TESTS := gtest +ALL_EXPLODED_TEST_TARGETS := $(addprefix exploded-test-, $(ALL_EXPLODED_TESTS)) ALL_TARGETS += $(ALL_TEST_TARGETS) $(ALL_EXPLODED_TEST_TARGETS) @@ -852,7 +855,7 @@ # Declare dependency for all generated test targets $(foreach t, $(filter-out test-make%, $(ALL_TEST_TARGETS)), $(eval $t: jdk-image test-image)) - $(foreach t, $(filter-out exploded-test-make%, $(ALL_EXPLODED_TEST_TARGETS)), $(eval $t: exploded-image test-image)) + $(foreach t, $(ALL_EXPLODED_TEST_TARGETS), $(eval $t: exploded-image test-image)) create-buildjdk-copy: jdk.jlink-java java.base-gendata \ $(addsuffix -java, $(INTERIM_IMAGE_MODULES)) @@ -1054,9 +1057,7 @@ # Let "run-test" be an alias for "test" $(foreach t, $(ALL_NAMED_TESTS), $(eval run-test-$t: test-$t)) -$(foreach t, $(ALL_NAMED_TESTS), $(eval exploded-run-test-$t: exploded-test-$t)) -RUN_TEST_TARGETS := $(addprefix run-test-, $(ALL_NAMED_TESTS)) \ - $(addprefix exploded-run-test-, $(ALL_NAMED_TESTS)) +RUN_TEST_TARGETS := $(addprefix run-test-, $(ALL_NAMED_TESTS)) run-test: test exploded-run-test: exploded-test