# HG changeset patch # User kzhaldyb # Date 1455625545 -10800 # Node ID 150bc828e27cbded5f0bfcf17c70fd9bf3aba48c # Parent 05f660b6deb36f7184cba467cc5cea928dc98cb1 8146287: typos in /test/failure_handler Reviewed-by: iignatyev, stsmirno diff -r 05f660b6deb3 -r 150bc828e27c test/failure_handler/Makefile --- a/test/failure_handler/Makefile Sat Mar 05 20:46:42 2016 -0800 +++ b/test/failure_handler/Makefile Tue Feb 16 15:25:45 2016 +0300 @@ -29,7 +29,7 @@ CLASSES_DIR := ${BUILD_DIR}/classes IMAGE_DIR := ${BUILD_DIR}/image RUN_DIR := $(shell pwd)/run - +CLASSPATH := ${JTREG_HOME}/lib/jtreg.jar:${JAVA_HOME}/lib/tools.jar SRC_DIR := src/share/classes/ SOURCES := ${SRC_DIR}/jdk/test/failurehandler/*.java \ ${SRC_DIR}/jdk/test/failurehandler/action/*.java \ @@ -47,9 +47,12 @@ ifeq ("${OS_NAME}", "Cygwin") BUILD_DIR := $(shell cygpath -m "${BUILD_DIR}") CLASSES_DIR := $(shell cygpath -m "${CLASSES_DIR}") -IMAGE_DIR := $(shell cygpath -m "${IMAGE_DIR}") RUN_DIR := $(shell cygpath -m "${RUN_DIR}") +IMAGE_DIR := $(shell cygpath -m "${IMAGE_DIR}") +RUN_DIR := $(shell cygpath -m "${RUN_DIR}") SRC_DIR := $(shell cygpath -m "${SRC_DIR}") +JAVA_HOME := $(shell cygpath -m "${JAVA_HOME}") JTREG_HOME := $(shell cygpath -m "${JTREG_HOME}") +CLASSPATH := $(shell cygpath -pm "${CLASSPATH}") CC := "cl.exe" endif @@ -57,33 +60,33 @@ native: require_env ifeq ("${OS_NAME}", "Cygwin") - "${CC}" src/windows/native/jdk/test/failurehandler/jtreg/*.c \ - -I"$(shell cygpath -w ${JAVA_HOME}/include)" \ - -I"$(shell cygpath -w ${JAVA_HOME}/include/win32)" \ - /link /MACHINE:X64 /DLL /OUT:timeoutHandler.dll + "${CC}" src/windows/native/jdk/test/failurehandler/jtreg/*.c \ + -I"$(shell cygpath -w "${JAVA_HOME}/include")" \ + -I"$(shell cygpath -w "${JAVA_HOME}/include/win32")" \ + /link /DLL /OUT:timeoutHandler.dll endif check_defined = $(foreach 1,$1,$(__check_defined)) __check_defined = $(if $(value $1),, $(error $1 is not set)) classes: require_env - mkdir -p ${IMAGE_DIR}/bin ${IMAGE_DIR}/lib ${CLASSES_DIR} - "${JAVA_HOME}"/bin/javac -target ${JAVA_RELEASE} -source ${JAVA_RELEASE} \ - -sourcepath $(shell pwd) \ - -classpath ${JTREG_HOME}/lib/jtreg.jar:${JAVA_HOME}/lib/tools.jar \ - -d ${CLASSES_DIR} \ + mkdir -p ${IMAGE_DIR}/bin ${IMAGE_DIR}/lib ${CLASSES_DIR} + "${JAVA_HOME}"/bin/javac -target ${JAVA_RELEASE} -source ${JAVA_RELEASE} \ + -sourcepath "$(shell pwd)" \ + -cp "${CLASSPATH}" \ + -d ${CLASSES_DIR} \ ${SOURCES} - "${JAVA_HOME}"/bin/jar cf ${TARGET_JAR} -C ${CLASSES_DIR} . - "${JAVA_HOME}"/bin/jar uf ${TARGET_JAR} -C ${CONF_DIR} . + "${JAVA_HOME}"/bin/jar cf "${TARGET_JAR}" -C "${CLASSES_DIR}" . + "${JAVA_HOME}"/bin/jar uf "${TARGET_JAR}" -C "${CONF_DIR}" . # # Use JTREG_TEST_OPTS for test VM options # Use JTREG_TESTS for jtreg tests parameter # test: require_env build - rm -rf ${RUN_DIR} - mkdir -p ${RUN_DIR} - "${JTREG_HOME}"/bin/jtreg \ + rm -rf "${RUN_DIR}" + mkdir -p "${RUN_DIR}" + "${JTREG_HOME}"/bin/jtreg \ -jdk:"${JAVA_HOME}" \ ${JTREG_TEST_OPTS} \ -timeout:0.1 -va -retain:all \ @@ -93,7 +96,8 @@ -th:jdk.test.failurehandler.jtreg.GatherProcessInfoTimeoutHandler \ -od:"${TARGET_JAR}" \ -o:jdk.test.failurehandler.jtreg.GatherDiagnosticInfoObserver \ - -w:${RUN_DIR}/JTwork -r:${RUN_DIR}/JTreport \ + -w:"${RUN_DIR}/JTwork" \ + -r:"${RUN_DIR}/JTreport" \ $(if ${JTREG_TESTS}, ${JTREG_TESTS}, test) \ && false || true @@ -101,11 +105,11 @@ debug: test require_env: - $(call check_defined, JAVA_HOME) - $(call check_defined, JTREG_HOME) + $(call check_defined, JAVA_HOME) + $(call check_defined, JTREG_HOME) clean: - rm -rf "${BUILD_DIR}" "${RUN_DIR}" + rm -rf "${BUILD_DIR}" "${RUN_DIR}" build: classes native diff -r 05f660b6deb3 -r 150bc828e27c test/failure_handler/test/sanity/Suicide.java --- a/test/failure_handler/test/sanity/Suicide.java Sat Mar 05 20:46:42 2016 -0800 +++ b/test/failure_handler/test/sanity/Suicide.java Tue Feb 16 15:25:45 2016 +0300 @@ -28,7 +28,7 @@ /* * @test * @summary Suicide test - * @run main/othervm Crash + * @run main/othervm Suicide */ public class Suicide { public static void main(String[] args) {