# HG changeset patch # User tbell # Date 1238538460 25200 # Node ID 0a3821d472a3a652475a4e415e909d7a37f0350a # Parent 103e268e2d164af0e43522036bec1aca8522c028 6819847: build is broken for OpenJDK with plugs Reviewed-by: jjg, robilad, ohair diff -r 103e268e2d16 -r 0a3821d472a3 jdk/make/Makefile --- a/jdk/make/Makefile Thu Mar 26 16:52:00 2009 -0700 +++ b/jdk/make/Makefile Tue Mar 31 15:27:40 2009 -0700 @@ -329,11 +329,6 @@ endif # -# Binary Plug rules and macros -# -include $(BUILDDIR)/common/internal/BinaryPlugs.gmk - -# # Get top level sccs_get rule # include $(BUILDDIR)/common/Rules-SCCS.gmk diff -r 103e268e2d16 -r 0a3821d472a3 jdk/make/common/Defs.gmk --- a/jdk/make/common/Defs.gmk Thu Mar 26 16:52:00 2009 -0700 +++ b/jdk/make/common/Defs.gmk Tue Mar 31 15:27:40 2009 -0700 @@ -145,6 +145,11 @@ # 2. ALT_BINARY_PLUGS_PATH overrides all locations of classes and libraries # 3. ALT_BUILD_BINARY_PLUGS_PATH is used to find a ALT_BINARY_PLUGS_PATH # 4. ALT_CLOSED_JDK_IMPORT_PATH is used to locate classes and libraries +# Note: If any of the ALT_ variables are modified here, it is assumed +# that the build should be done with IMPORT_BINARY_PLUGS=true as +# well. Otherwise the default will be IMPORT_BINARY_PLUGS=false. +# Lastly, setting IMPORT_BINARY_PLUGS=false on the command line +# will override this logic, and plugs will not be imported. # # Always needed, defines the name of the imported/exported jarfile @@ -155,9 +160,11 @@ CLOSED_JDK_IMPORT_PATH = $(ALT_CLOSED_JDK_IMPORT_PATH) BINARY_PLUGS_PATH = $(CLOSED_JDK_IMPORT_PATH) BINARY_PLUGS_JARFILE = $(CLOSED_JDK_IMPORT_PATH)/jre/lib/rt.jar + IMPORT_BINARY_PLUGS=true endif ifdef ALT_BUILD_BINARY_PLUGS_PATH BUILD_BINARY_PLUGS_PATH = $(ALT_BUILD_BINARY_PLUGS_PATH) + IMPORT_BINARY_PLUGS=true else BUILD_BINARY_PLUGS_PATH = $(SLASH_JAVA)/re/jdk/$(JDK_VERSION)/promoted/latest/openjdk/binaryplugs endif @@ -166,9 +173,11 @@ ifdef ALT_BINARY_PLUGS_PATH BINARY_PLUGS_PATH = $(ALT_BINARY_PLUGS_PATH) BINARY_PLUGS_JARFILE = $(BINARY_PLUGS_PATH)/jre/lib/$(BINARY_PLUGS_JARNAME) + IMPORT_BINARY_PLUGS=true endif ifdef ALT_BINARY_PLUGS_JARFILE BINARY_PLUGS_JARFILE = $(ALT_BINARY_PLUGS_JARFILE) + IMPORT_BINARY_PLUGS=true endif endif # OPENJDK diff -r 103e268e2d16 -r 0a3821d472a3 jdk/make/common/shared/Sanity-Settings.gmk --- a/jdk/make/common/shared/Sanity-Settings.gmk Thu Mar 26 16:52:00 2009 -0700 +++ b/jdk/make/common/shared/Sanity-Settings.gmk Tue Mar 31 15:27:40 2009 -0700 @@ -245,6 +245,7 @@ ALL_SETTINGS+=$(call addAltSetting,FREETYPE_HEADERS_PATH) ALL_SETTINGS+=$(call addAltSetting,FREETYPE_LIB_PATH) ALL_SETTINGS+=$(call addHeading,OPENJDK Import Binary Plug Settings) + ALL_SETTINGS+=$(call addOptionalSetting,IMPORT_BINARY_PLUGS) ALL_SETTINGS+=$(call addAltSetting,BINARY_PLUGS_JARFILE) ALL_SETTINGS+=$(call addAltSetting,BINARY_PLUGS_PATH) ALL_SETTINGS+=$(call addAltSetting,BUILD_BINARY_PLUGS_PATH) diff -r 103e268e2d16 -r 0a3821d472a3 jdk/make/java/redist/Makefile --- a/jdk/make/java/redist/Makefile Thu Mar 26 16:52:00 2009 -0700 +++ b/jdk/make/java/redist/Makefile Tue Mar 31 15:27:40 2009 -0700 @@ -251,9 +251,11 @@ # ifdef OPENJDK -include $(BUILDDIR)/common/internal/BinaryPlugs.gmk + ifeq ($(IMPORT_BINARY_PLUGS),true) + include $(BUILDDIR)/common/internal/BinaryPlugs.gmk -build: import-binary-plugs + build: import-binary-plugs + endif else # !OPENJDK