diff -r 449555c346d9 -r fa1f838b5486 src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java --- a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java Mon Oct 21 11:35:36 2019 -0700 +++ b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java Mon Oct 21 13:25:36 2019 -0700 @@ -332,36 +332,26 @@ } //------------------Start of Serializable Implementation---------------------// - private final static Map serializedForms = new HashMap<>(); + private final Map serializedForms = new HashMap<>(); - public SortedSet getSerializableFields(Utils utils, TypeElement klass) { - NewSerializedForm sf = serializedForms.get(klass); - if (sf == null) { - sf = new NewSerializedForm(utils, configuration.docEnv.getElementUtils(), klass); - serializedForms.put(klass, sf); - } - return sf.fields; + private NewSerializedForm getSerializedForm(TypeElement typeElem) { + return serializedForms.computeIfAbsent(typeElem, + te -> new NewSerializedForm(utils, configuration.docEnv.getElementUtils(), te)); } - public SortedSet getSerializationMethods(Utils utils, TypeElement klass) { - NewSerializedForm sf = serializedForms.get(klass); - if (sf == null) { - sf = new NewSerializedForm(utils, configuration.docEnv.getElementUtils(), klass); - serializedForms.put(klass, sf); - } - return sf.methods; + public SortedSet getSerializableFields(TypeElement typeElem) { + return getSerializedForm(typeElem).fields; } - public boolean definesSerializableFields(Utils utils, TypeElement klass) { - if (!utils.isSerializable(klass) || utils.isExternalizable(klass)) { + public SortedSet getSerializationMethods(TypeElement typeElem) { + return getSerializedForm(typeElem).methods; + } + + public boolean definesSerializableFields(TypeElement typeElem) { + if (!utils.isSerializable(typeElem) || utils.isExternalizable(typeElem)) { return false; } else { - NewSerializedForm sf = serializedForms.get(klass); - if (sf == null) { - sf = new NewSerializedForm(utils, configuration.docEnv.getElementUtils(), klass); - serializedForms.put(klass, sf); - } - return sf.definesSerializableFields; + return getSerializedForm(typeElem).definesSerializableFields; } }