8079841: Buffer underflow with empty zip entry names
Summary: check for zero-length entry name before accessing "last" byte
Reviewed-by: sherman, martin
/*
* Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* JDK-8023373: allow super invocation for adapters
*
* @test
* @run
*/
var CharArray = Java.type("char[]")
var jString = Java.type("java.lang.String")
var Character = Java.type("java.lang.Character")
function capitalize(s) {
if(s instanceof CharArray) {
return new jString(s).toUpperCase()
}
if(s instanceof jString) {
return s.toUpperCase()
}
return Character.toUpperCase(s) // must be int
}
var sw = new (Java.type("java.io.StringWriter"))
var FilterWriterAdapter = Java.extend(Java.type("java.io.FilterWriter"))
var cw = new FilterWriterAdapter(sw) {
write: function(s, off, len) {
s = capitalize(s)
// Must handle overloads by arity
if(off === undefined) {
cw.super$write(s, 0, s.length())
} else if (typeof s === "string") {
cw.super$write(s, off, len)
}
}
}
cw.write("abcd")
cw.write("e".charAt(0))
cw.write("fgh".toCharArray())
cw.write("**ijk**", 2, 3)
cw.write("***lmno**".toCharArray(), 3, 4)
cw.flush()
print(sw)
// Can invoke super for Object methods
print("cw has super hashCode(): " + (typeof cw.super$hashCode === "function"))
print("cw has super equals(): " + (typeof cw.super$equals === "function"))
// Can't invoke super for final methods
print("cw has no super getClass(): " + (typeof cw.super$getClass === "undefined"))
print("cw has no super wait(): " + (typeof cw.super$wait === "undefined"))
var r = new (Java.type("java.lang.Runnable"))(function() {})
// Can't invoke super for abstract methods
print("r has no super run(): " + (typeof r.super$run === "undefined"))
// Interfaces can also invoke super Object methods
print("r has super hashCode(): " + (typeof r.super$hashCode === "function"))
print("r has super equals(): " + (typeof r.super$equals === "function"))
// But still can't invoke final methods
print("r has no super getClass(): " + (typeof r.super$getClass === "undefined"))
print("r has no super wait(): " + (typeof r.super$wait === "undefined"))