test/jdk/sun/security/tools/jarsigner/DiffEnd.java
author weijun
Thu, 18 Jul 2019 08:53:06 +0800
changeset 57488 94691d8e746f
parent 54521 8de62c4af8c7
permissions -rw-r--r--
8217375: jarsigner breaks old signature with long lines in manifest Reviewed-by: jjiang, weijun Contributed-by: Philipp Kunz <philipp.kunz@paratix.ch>

/*
 * Copyright (c) 2010, 2019, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 only, as
 * published by the Free Software Foundation.
 *
 * This code is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
 * version 2 for more details (a copy is included in the LICENSE file that
 * accompanied this code).
 *
 * You should have received a copy of the GNU General Public License version
 * 2 along with this work; if not, write to the Free Software Foundation,
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
 *
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
 * or visit www.oracle.com if you need additional information or have any
 * questions.
 */

/*
 * @test
 * @bug 6948909 8217375
 * @summary Jarsigner removes MANIFEST.MF info for badly packages jar's
 * @library /test/lib
 */
/*
 * See also InsufficientSectionDelimiter.java for similar tests including cases
 * without or with different line breaks.
 */

import jdk.test.lib.Asserts;
import jdk.test.lib.SecurityTools;
import jdk.test.lib.process.OutputAnalyzer;

import java.io.FileOutputStream;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.jar.Attributes;
import java.util.jar.JarFile;
import java.util.zip.ZipEntry;
import java.util.zip.ZipOutputStream;

public class DiffEnd {

    static void check() throws Exception {
        String ksArgs = "-keystore " + Path.of(System.getProperty("test.src"))
                .resolve("JarSigning.keystore") + " -storepass bbbbbb";

        SecurityTools.jarsigner(ksArgs + " -digestalg SHA1 "
                + "-signedjar diffend.signed.jar diffend.jar c")
                .shouldHaveExitValue(0);
        SecurityTools.jarsigner(" -verify " + ksArgs + " -verbose "
                + "diffend.signed.jar c")
                .stdoutShouldMatch("^smk .* 1$").shouldHaveExitValue(0);

        try (JarFile jf = new JarFile("diffend.signed.jar")) {
            Asserts.assertTrue(jf.getManifest().getMainAttributes()
                    .containsKey(new Attributes.Name("Today")));
        }
    }

    public static void main(String[] args) throws Exception {
        // A MANIFEST.MF using \n as newlines and no double newlines at the end
        byte[] manifest = ("Manifest-Version: 1.0\n"
                        + "Created-By: 1.7.0-internal (Sun Microsystems Inc.)\n"
                        + "Today: Monday\n").getBytes(StandardCharsets.UTF_8);

        // Without the fake .RSA file, to trigger the if (wasSigned) else block
        try (FileOutputStream fos = new FileOutputStream("diffend.jar");
             ZipOutputStream zos = new ZipOutputStream(fos)) {
            zos.putNextEntry(new ZipEntry(JarFile.MANIFEST_NAME));
            zos.write(manifest);
            zos.putNextEntry(new ZipEntry("1"));
            zos.write(new byte[10]);
        }
        check();

        // With the fake .RSA file, to trigger the if (wasSigned) block
        try (FileOutputStream fos = new FileOutputStream("diffend.jar");
             ZipOutputStream zos = new ZipOutputStream(fos)) {
            zos.putNextEntry(new ZipEntry(JarFile.MANIFEST_NAME));
            zos.write(manifest);
            zos.putNextEntry(new ZipEntry("META-INF/x.RSA")); // fake .RSA
            zos.putNextEntry(new ZipEntry("1"));
            zos.write(new byte[10]);
        }
        check();
    }
}