--- a/src/hotspot/share/classfile/modules.cpp Tue Mar 06 08:36:44 2018 +0100
+++ b/src/hotspot/share/classfile/modules.cpp Tue Mar 06 17:15:16 2018 -0500
@@ -85,27 +85,27 @@
return java_lang_String::as_utf8_string(JNIHandles::resolve_non_null(version));
}
-static ModuleEntryTable* get_module_entry_table(Handle h_loader, TRAPS) {
+static ModuleEntryTable* get_module_entry_table(Handle h_loader) {
// This code can be called during start-up, before the classLoader's classLoader data got
// created. So, call register_loader() to make sure the classLoader data gets created.
- ClassLoaderData *loader_cld = SystemDictionary::register_loader(h_loader, CHECK_NULL);
+ ClassLoaderData *loader_cld = SystemDictionary::register_loader(h_loader);
return loader_cld->modules();
}
-static PackageEntryTable* get_package_entry_table(Handle h_loader, TRAPS) {
+static PackageEntryTable* get_package_entry_table(Handle h_loader) {
// This code can be called during start-up, before the classLoader's classLoader data got
// created. So, call register_loader() to make sure the classLoader data gets created.
- ClassLoaderData *loader_cld = SystemDictionary::register_loader(h_loader, CHECK_NULL);
+ ClassLoaderData *loader_cld = SystemDictionary::register_loader(h_loader);
return loader_cld->packages();
}
static ModuleEntry* get_module_entry(jobject module, TRAPS) {
- Handle module_h(THREAD, JNIHandles::resolve(module));
- if (!java_lang_Module::is_instance(module_h())) {
+ oop m = JNIHandles::resolve(module);
+ if (!java_lang_Module::is_instance(m)) {
THROW_MSG_NULL(vmSymbols::java_lang_IllegalArgumentException(),
"module is not an instance of type java.lang.Module");
}
- return java_lang_Module::module_entry(module_h(), CHECK_NULL);
+ return java_lang_Module::module_entry(m);
}
static PackageEntry* get_package_entry(ModuleEntry* module_entry, const char* package_name, TRAPS) {
@@ -124,7 +124,7 @@
ResourceMark rm(THREAD);
if (Modules::verify_package_name(package->as_C_string())) {
PackageEntryTable* const package_entry_table =
- get_package_entry_table(h_loader, CHECK_NULL);
+ get_package_entry_table(h_loader);
assert(package_entry_table != NULL, "Unexpected null package entry table");
return package_entry_table->lookup_only(package);
}
@@ -186,7 +186,7 @@
Handle h_loader(THREAD, loader);
// Ensure the boot loader's PackageEntryTable has been created
- PackageEntryTable* package_table = get_package_entry_table(h_loader, CHECK);
+ PackageEntryTable* package_table = get_package_entry_table(h_loader);
assert(pkg_list->length() == 0 || package_table != NULL, "Bad package_table");
// Ensure java.base's ModuleEntry has been created
@@ -346,7 +346,7 @@
pkg_list->append(pkg_symbol);
}
- ModuleEntryTable* module_table = get_module_entry_table(h_loader, CHECK);
+ ModuleEntryTable* module_table = get_module_entry_table(h_loader);
assert(module_table != NULL, "module entry table shouldn't be null");
// Create symbol* entry for module name.
@@ -382,7 +382,7 @@
MutexLocker ml(Module_lock, THREAD);
if (num_packages > 0) {
- package_table = get_package_entry_table(h_loader, CHECK);
+ package_table = get_package_entry_table(h_loader);
assert(package_table != NULL, "Missing package_table");
// Check that none of the packages exist in the class loader's package table.