--- a/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.inline.hpp Fri Sep 13 16:03:31 2019 -0700
+++ b/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.inline.hpp Sat Sep 14 14:40:09 2019 +0200
@@ -28,8 +28,11 @@
#include "classfile/classLoaderData.hpp"
#include "classfile/moduleEntry.hpp"
#include "classfile/packageEntry.hpp"
+#include "jfr/recorder/checkpoint/types/traceid/jfrTraceId.hpp"
+#include "jfr/recorder/checkpoint/types/traceid/jfrTraceIdBits.inline.hpp"
+#include "jfr/recorder/checkpoint/types/traceid/jfrTraceIdEpoch.hpp"
#include "jfr/recorder/checkpoint/types/traceid/jfrTraceIdMacros.hpp"
-#include "jfr/recorder/checkpoint/types/traceid/jfrTraceId.hpp"
+#include "jfr/support/jfrKlassExtension.hpp"
#include "oops/arrayKlass.hpp"
#include "oops/klass.hpp"
#include "oops/instanceKlass.hpp"
@@ -38,21 +41,11 @@
#include "utilities/debug.hpp"
template <typename T>
-inline traceid set_used_and_get(const T* type, bool leakp) {
+inline traceid set_used_and_get(const T* type) {
assert(type != NULL, "invariant");
- if (leakp) {
- SET_LEAKP_USED_THIS_EPOCH(type);
- assert(LEAKP_USED_THIS_EPOCH(type), "invariant");
- }
SET_USED_THIS_EPOCH(type);
assert(USED_THIS_EPOCH(type), "invariant");
- return TRACE_ID_MASKED_PTR(type);
-}
-
-template <typename T>
-inline traceid set_used_and_get_shifted(const T* type, bool leakp) {
- assert(type != NULL, "invariant");
- return set_used_and_get(type, leakp) >> TRACE_ID_SHIFT;
+ return TRACE_ID(type);
}
inline traceid JfrTraceId::get(const Klass* klass) {
@@ -65,38 +58,49 @@
return TRACE_ID_RAW(t->jfr_thread_local());
}
-inline traceid JfrTraceId::use(const Klass* klass, bool leakp /* false */) {
+inline traceid JfrTraceId::use(const Klass* klass) {
assert(klass != NULL, "invariant");
- return set_used_and_get_shifted(klass, leakp);
+ return set_used_and_get(klass);
}
-inline traceid JfrTraceId::use(const Method* method, bool leakp /* false */) {
+inline traceid JfrTraceId::use(const Method* method) {
+ assert(method != NULL, "invariant");
+ return use(method->method_holder(), method);
+}
+
+inline traceid JfrTraceId::use(const Klass* klass, const Method* method) {
+ assert(klass != NULL, "invariant");
assert(method != NULL, "invariant");
SET_METHOD_FLAG_USED_THIS_EPOCH(method);
- const Klass* const klass = method->method_holder();
- assert(klass != NULL, "invariant");
- if (leakp) {
- SET_LEAKP_USED_THIS_EPOCH(klass);
- assert(LEAKP_USED_THIS_EPOCH(klass), "invariant");
- }
+
SET_METHOD_AND_CLASS_USED_THIS_EPOCH(klass);
assert(METHOD_AND_CLASS_USED_THIS_EPOCH(klass), "invariant");
return (METHOD_ID(klass, method));
}
-inline traceid JfrTraceId::use(const ModuleEntry* module, bool leakp /* false */) {
+inline traceid JfrTraceId::use(const ModuleEntry* module) {
assert(module != NULL, "invariant");
- return set_used_and_get_shifted(module, leakp);
+ return set_used_and_get(module);
+}
+
+inline traceid JfrTraceId::use(const PackageEntry* package) {
+ assert(package != NULL, "invariant");
+ return set_used_and_get(package);
}
-inline traceid JfrTraceId::use(const PackageEntry* package, bool leakp /* false */) {
- assert(package != NULL, "invariant");
- return set_used_and_get_shifted(package, leakp);
+inline traceid JfrTraceId::use(const ClassLoaderData* cld) {
+ assert(cld != NULL, "invariant");
+ return cld->is_unsafe_anonymous() ? 0 : set_used_and_get(cld);
}
-inline traceid JfrTraceId::use(const ClassLoaderData* cld, bool leakp /* false */) {
- assert(cld != NULL, "invariant");
- return cld->is_unsafe_anonymous() ? 0 : set_used_and_get_shifted(cld, leakp);
+inline void JfrTraceId::set_leakp(const Method* method) {
+ assert(method != NULL, "invariant");
+ const Klass* const klass = method->method_holder();
+ assert(klass != NULL, "invariant");
+ assert(METHOD_AND_CLASS_USED_THIS_EPOCH(klass), "invariant");
+ assert(METHOD_FLAG_USED_THIS_EPOCH(method), "invariant");
+ SET_LEAKP(klass);
+ SET_METHOD_LEAKP(method);
}
inline bool JfrTraceId::in_visible_set(const Klass* klass) {
@@ -112,7 +116,7 @@
inline void JfrTraceId::tag_as_jdk_jfr_event(const Klass* klass) {
assert(klass != NULL, "invariant");
- SET_TAG(klass, JDK_JFR_EVENT_KLASS);
+ SET_JDK_JFR_EVENT_KLASS(klass);
assert(IS_JDK_JFR_EVENT_KLASS(klass), "invariant");
}
@@ -124,7 +128,7 @@
inline void JfrTraceId::tag_as_jdk_jfr_event_sub(const Klass* k) {
assert(k != NULL, "invariant");
if (IS_NOT_AN_EVENT_SUB_KLASS(k)) {
- SET_TAG(k, JDK_JFR_EVENT_SUBKLASS);
+ SET_JDK_JFR_EVENT_SUBKLASS(k);
}
assert(IS_JDK_JFR_EVENT_SUBKLASS(k), "invariant");
}
@@ -145,7 +149,7 @@
inline void JfrTraceId::tag_as_event_host(const Klass* k) {
assert(k != NULL, "invariant");
- SET_TAG(k, EVENT_HOST_KLASS);
+ SET_EVENT_HOST_KLASS(k);
assert(IS_EVENT_HOST_KLASS(k), "invariant");
}