--- a/src/hotspot/share/gc/g1/g1Analytics.cpp Fri Nov 29 11:28:39 2019 +0300
+++ b/src/hotspot/share/gc/g1/g1Analytics.cpp Fri Nov 29 10:20:14 2019 +0100
@@ -45,11 +45,11 @@
};
// all the same
-static double young_cards_per_entry_ratio_defaults[] = {
+static double young_card_merge_to_scan_ratio_defaults[] = {
1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0
};
-static double young_only_cost_per_remset_card_ms_defaults[] = {
+static double young_only_cost_per_card_scan_ms_defaults[] = {
0.015, 0.01, 0.01, 0.008, 0.008, 0.0055, 0.0055, 0.005
};
@@ -62,7 +62,6 @@
5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0
};
-
static double young_other_cost_per_region_ms_defaults[] = {
0.3, 0.2, 0.2, 0.15, 0.15, 0.12, 0.12, 0.1
};
@@ -81,13 +80,13 @@
_rs_length_diff_seq(new TruncatedSeq(TruncatedSeqLength)),
_concurrent_refine_rate_ms_seq(new TruncatedSeq(TruncatedSeqLength)),
_logged_cards_rate_ms_seq(new TruncatedSeq(TruncatedSeqLength)),
- _cost_per_logged_card_ms_seq(new TruncatedSeq(TruncatedSeqLength)),
- _cost_scan_hcc_seq(new TruncatedSeq(TruncatedSeqLength)),
- _young_cards_per_entry_ratio_seq(new TruncatedSeq(TruncatedSeqLength)),
- _mixed_cards_per_entry_ratio_seq(new TruncatedSeq(TruncatedSeqLength)),
- _young_only_cost_per_remset_card_ms_seq(new TruncatedSeq(TruncatedSeqLength)),
- _mixed_cost_per_remset_card_ms_seq(new TruncatedSeq(TruncatedSeqLength)),
- _cost_per_byte_ms_seq(new TruncatedSeq(TruncatedSeqLength)),
+ _young_card_merge_to_scan_ratio_seq(new TruncatedSeq(TruncatedSeqLength)),
+ _mixed_card_merge_to_scan_ratio_seq(new TruncatedSeq(TruncatedSeqLength)),
+ _young_cost_per_card_scan_ms_seq(new TruncatedSeq(TruncatedSeqLength)),
+ _mixed_cost_per_card_scan_ms_seq(new TruncatedSeq(TruncatedSeqLength)),
+ _young_cost_per_card_merge_ms_seq(new TruncatedSeq(TruncatedSeqLength)),
+ _mixed_cost_per_card_merge_ms_seq(new TruncatedSeq(TruncatedSeqLength)),
+ _copy_cost_per_byte_ms_seq(new TruncatedSeq(TruncatedSeqLength)),
_constant_other_time_ms_seq(new TruncatedSeq(TruncatedSeqLength)),
_young_other_cost_per_region_ms_seq(new TruncatedSeq(TruncatedSeqLength)),
_non_young_other_cost_per_region_ms_seq(new TruncatedSeq(TruncatedSeqLength)),
@@ -109,11 +108,10 @@
_concurrent_refine_rate_ms_seq->add(1/cost_per_logged_card_ms_defaults[0]);
// Some applications have very low rates for logging cards.
_logged_cards_rate_ms_seq->add(0.0);
- _cost_per_logged_card_ms_seq->add(cost_per_logged_card_ms_defaults[index]);
- _cost_scan_hcc_seq->add(0.0);
- _young_cards_per_entry_ratio_seq->add(young_cards_per_entry_ratio_defaults[index]);
- _young_only_cost_per_remset_card_ms_seq->add(young_only_cost_per_remset_card_ms_defaults[index]);
- _cost_per_byte_ms_seq->add(cost_per_byte_ms_defaults[index]);
+ _young_card_merge_to_scan_ratio_seq->add(young_card_merge_to_scan_ratio_defaults[index]);
+ _young_cost_per_card_scan_ms_seq->add(young_only_cost_per_card_scan_ms_defaults[index]);
+
+ _copy_cost_per_byte_ms_seq->add(cost_per_byte_ms_defaults[index]);
_constant_other_time_ms_seq->add(constant_other_time_ms_defaults[index]);
_young_other_cost_per_region_ms_seq->add(young_other_cost_per_region_ms_defaults[index]);
_non_young_other_cost_per_region_ms_seq->add(non_young_other_cost_per_region_ms_defaults[index]);
@@ -123,6 +121,10 @@
_concurrent_mark_cleanup_times_ms->add(0.20);
}
+bool G1Analytics::enough_samples_available(TruncatedSeq const* seq) const {
+ return seq->num() >= 3;
+}
+
double G1Analytics::get_new_prediction(TruncatedSeq const* seq) const {
return _predictor->get_new_prediction(seq);
}
@@ -166,27 +168,27 @@
_logged_cards_rate_ms_seq->add(cards_per_ms);
}
-void G1Analytics::report_cost_per_logged_card_ms(double cost_per_logged_card_ms) {
- _cost_per_logged_card_ms_seq->add(cost_per_logged_card_ms);
-}
-
-void G1Analytics::report_cost_scan_hcc(double cost_scan_hcc) {
- _cost_scan_hcc_seq->add(cost_scan_hcc);
-}
-
-void G1Analytics::report_cost_per_remset_card_ms(double cost_per_remset_card_ms, bool for_young_gc) {
+void G1Analytics::report_cost_per_card_scan_ms(double cost_per_card_ms, bool for_young_gc) {
if (for_young_gc) {
- _young_only_cost_per_remset_card_ms_seq->add(cost_per_remset_card_ms);
+ _young_cost_per_card_scan_ms_seq->add(cost_per_card_ms);
} else {
- _mixed_cost_per_remset_card_ms_seq->add(cost_per_remset_card_ms);
+ _mixed_cost_per_card_scan_ms_seq->add(cost_per_card_ms);
}
}
-void G1Analytics::report_cards_per_entry_ratio(double cards_per_entry_ratio, bool for_young_gc) {
+void G1Analytics::report_cost_per_card_merge_ms(double cost_per_card_ms, bool for_young_gc) {
if (for_young_gc) {
- _young_cards_per_entry_ratio_seq->add(cards_per_entry_ratio);
+ _young_cost_per_card_merge_ms_seq->add(cost_per_card_ms);
} else {
- _mixed_cards_per_entry_ratio_seq->add(cards_per_entry_ratio);
+ _mixed_cost_per_card_merge_ms_seq->add(cost_per_card_ms);
+ }
+}
+
+void G1Analytics::report_card_merge_to_scan_ratio(double merge_to_scan_ratio, bool for_young_gc) {
+ if (for_young_gc) {
+ _young_card_merge_to_scan_ratio_seq->add(merge_to_scan_ratio);
+ } else {
+ _mixed_card_merge_to_scan_ratio_seq->add(merge_to_scan_ratio);
}
}
@@ -198,7 +200,7 @@
if (mark_or_rebuild_in_progress) {
_cost_per_byte_ms_during_cm_seq->add(cost_per_byte_ms);
} else {
- _cost_per_byte_ms_seq->add(cost_per_byte_ms);
+ _copy_cost_per_byte_ms_seq->add(cost_per_byte_ms);
}
}
@@ -234,57 +236,37 @@
return get_new_prediction(_logged_cards_rate_ms_seq);
}
-double G1Analytics::predict_cost_per_logged_card_ms() const {
- return get_new_prediction(_cost_per_logged_card_ms_seq);
-}
-
-double G1Analytics::predict_scan_hcc_ms() const {
- return get_new_prediction(_cost_scan_hcc_seq);
+double G1Analytics::predict_young_card_merge_to_scan_ratio() const {
+ return get_new_prediction(_young_card_merge_to_scan_ratio_seq);
}
-double G1Analytics::predict_rs_update_time_ms(size_t pending_cards) const {
- return pending_cards * predict_cost_per_logged_card_ms() + predict_scan_hcc_ms();
-}
-
-double G1Analytics::predict_young_cards_per_entry_ratio() const {
- return get_new_prediction(_young_cards_per_entry_ratio_seq);
-}
-
-double G1Analytics::predict_mixed_cards_per_entry_ratio() const {
- if (_mixed_cards_per_entry_ratio_seq->num() < 2) {
- return predict_young_cards_per_entry_ratio();
+size_t G1Analytics::predict_scan_card_num(size_t rs_length, bool for_young_gc) const {
+ if (for_young_gc || !enough_samples_available(_mixed_card_merge_to_scan_ratio_seq)) {
+ return (size_t) (rs_length * predict_young_card_merge_to_scan_ratio());
} else {
- return get_new_prediction(_mixed_cards_per_entry_ratio_seq);
+ return (size_t) (rs_length * get_new_prediction(_mixed_card_merge_to_scan_ratio_seq));
}
}
-size_t G1Analytics::predict_card_num(size_t rs_length, bool for_young_gc) const {
- if (for_young_gc) {
- return (size_t) (rs_length * predict_young_cards_per_entry_ratio());
+double G1Analytics::predict_card_merge_time_ms(size_t card_num, bool for_young_gc) const {
+ if (for_young_gc || !enough_samples_available(_mixed_cost_per_card_merge_ms_seq)) {
+ return card_num * get_new_prediction(_young_cost_per_card_merge_ms_seq);
} else {
- return (size_t) (rs_length * predict_mixed_cards_per_entry_ratio());
+ return card_num * get_new_prediction(_mixed_cost_per_card_merge_ms_seq);
}
}
-double G1Analytics::predict_rs_scan_time_ms(size_t card_num, bool for_young_gc) const {
- if (for_young_gc) {
- return card_num * get_new_prediction(_young_only_cost_per_remset_card_ms_seq);
+double G1Analytics::predict_card_scan_time_ms(size_t card_num, bool for_young_gc) const {
+ if (for_young_gc || !enough_samples_available(_mixed_cost_per_card_scan_ms_seq)) {
+ return card_num * get_new_prediction(_young_cost_per_card_scan_ms_seq);
} else {
- return predict_mixed_rs_scan_time_ms(card_num);
- }
-}
-
-double G1Analytics::predict_mixed_rs_scan_time_ms(size_t card_num) const {
- if (_mixed_cost_per_remset_card_ms_seq->num() < 3) {
- return card_num * get_new_prediction(_young_only_cost_per_remset_card_ms_seq);
- } else {
- return card_num * get_new_prediction(_mixed_cost_per_remset_card_ms_seq);
+ return card_num * get_new_prediction(_mixed_cost_per_card_scan_ms_seq);
}
}
double G1Analytics::predict_object_copy_time_ms_during_cm(size_t bytes_to_copy) const {
- if (_cost_per_byte_ms_during_cm_seq->num() < 3) {
- return (1.1 * bytes_to_copy) * get_new_prediction(_cost_per_byte_ms_seq);
+ if (!enough_samples_available(_cost_per_byte_ms_during_cm_seq)) {
+ return (1.1 * bytes_to_copy) * get_new_prediction(_copy_cost_per_byte_ms_seq);
} else {
return bytes_to_copy * get_new_prediction(_cost_per_byte_ms_during_cm_seq);
}
@@ -294,14 +276,10 @@
if (during_concurrent_mark) {
return predict_object_copy_time_ms_during_cm(bytes_to_copy);
} else {
- return bytes_to_copy * get_new_prediction(_cost_per_byte_ms_seq);
+ return bytes_to_copy * get_new_prediction(_copy_cost_per_byte_ms_seq);
}
}
-double G1Analytics::predict_cost_per_byte_ms() const {
- return get_new_prediction(_cost_per_byte_ms_seq);
-}
-
double G1Analytics::predict_constant_other_time_ms() const {
return get_new_prediction(_constant_other_time_ms_seq);
}