--- a/test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java Thu Oct 17 20:27:44 2019 +0100
+++ b/test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java Thu Oct 17 20:53:35 2019 +0100
@@ -37,14 +37,13 @@
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
+import jdk.test.lib.Container;
import jdk.test.lib.Utils;
import jdk.test.lib.process.OutputAnalyzer;
-import jdk.test.lib.process.ProcessTools;
import jtreg.SkippedException;
public class DockerTestUtils {
- private static final String FS = File.separator;
private static boolean isDockerEngineAvailable = false;
private static boolean wasDockerEngineChecked = false;
@@ -54,11 +53,6 @@
// diagnostic information.
private static final int MAX_LINES_TO_COPY_FOR_CHILD_STDOUT = 100;
- // Use this property to specify docker location on your system.
- // E.g.: "/usr/local/bin/docker".
- private static final String DOCKER_COMMAND =
- System.getProperty("jdk.test.docker.command", "docker");
-
// Set this property to true to retain image after test. By default
// images are removed after test execution completes.
// Retaining the image can be useful for diagnostics and image inspection.
@@ -116,7 +110,7 @@
*/
private static boolean isDockerEngineAvailableCheck() throws Exception {
try {
- execute(DOCKER_COMMAND, "ps")
+ execute(Container.ENGINE_COMMAND, "ps")
.shouldHaveExitValue(0)
.shouldContain("CONTAINER")
.shouldContain("IMAGE");
@@ -179,9 +173,8 @@
DockerfileConfig.getBaseImageVersion());
try {
// Build the docker
- execute(DOCKER_COMMAND, "build", "--no-cache", "--tag", imageName, buildDir.toString())
- .shouldHaveExitValue(0)
- .shouldContain("Successfully built");
+ execute(Container.ENGINE_COMMAND, "build", "--no-cache", "--tag", imageName, buildDir.toString())
+ .shouldHaveExitValue(0);
} catch (Exception e) {
// If docker image building fails there is a good chance it happens due to environment and/or
// configuration other than product failure. Throw jtreg skipped exception in such case
@@ -194,7 +187,7 @@
/**
* Build the docker command to run java inside a container
*
- * @param DockerRunOptions optins for running docker
+ * @param DockerRunOptions options for running docker
*
* @return command
* @throws Exception
@@ -202,7 +195,7 @@
public static List<String> buildJavaCommand(DockerRunOptions opts) throws Exception {
List<String> cmd = new ArrayList<>();
- cmd.add(DOCKER_COMMAND);
+ cmd.add(Container.ENGINE_COMMAND);
cmd.add("run");
if (opts.tty)
cmd.add("--tty=true");
@@ -217,6 +210,7 @@
if (opts.appendTestJavaOptions) {
Collections.addAll(cmd, Utils.getTestJavaOpts());
}
+ cmd.addAll(opts.javaOptsAppended);
cmd.add(opts.classToRun);
cmd.addAll(opts.classParams);
@@ -227,7 +221,7 @@
/**
* Run Java inside the docker image with specified parameters and options.
*
- * @param DockerRunOptions optins for running docker
+ * @param DockerRunOptions options for running docker
*
* @return output of the run command
* @throws Exception
@@ -240,11 +234,11 @@
/**
* Remove docker image
*
- * @param DockerRunOptions optins for running docker
+ * @param DockerRunOptions options for running docker
* @throws Exception
*/
public static void removeDockerImage(String imageNameAndTag) throws Exception {
- execute(DOCKER_COMMAND, "rmi", "--force", imageNameAndTag);
+ execute(Container.ENGINE_COMMAND, "rmi", "--force", imageNameAndTag);
}