--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/test/langtools/tools/javac/modules/ServiceProvidedButNotExportedOrUsedTest.java Tue Sep 12 19:03:39 2017 +0200
@@ -0,0 +1,106 @@
+/*
+ * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/**
+ * @test
+ * @bug 8145013
+ * @summary Javac doesn't report warnings/errors if module provides unexported service and doesn't use it itself
+ * @library /tools/lib
+ * @modules
+ * jdk.compiler/com.sun.tools.javac.api
+ * jdk.compiler/com.sun.tools.javac.main
+ * @build toolbox.ToolBox toolbox.JavacTask ModuleTestBase
+ * @run main ServiceProvidedButNotExportedOrUsedTest
+ */
+
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Arrays;
+import java.util.List;
+
+import toolbox.JavacTask;
+import toolbox.Task;
+import toolbox.ToolBox;
+
+public class ServiceProvidedButNotExportedOrUsedTest extends ModuleTestBase {
+ public static void main(String... args) throws Exception {
+ ServiceProvidedButNotExportedOrUsedTest t = new ServiceProvidedButNotExportedOrUsedTest();
+ t.runTests();
+ }
+
+ @Test
+ public void testWarning(Path base) throws Exception {
+ Path src = base.resolve("src");
+ tb.writeJavaFiles(src,
+ "module m { provides p1.C1 with p2.C2; }",
+ "package p1; public class C1 { }",
+ "package p2; public class C2 extends p1.C1 { }");
+ Path classes = base.resolve("classes");
+ Files.createDirectories(classes);
+
+ List<String> output = new JavacTask(tb)
+ .outdir(classes)
+ .options("-Werror", "-XDrawDiagnostics")
+ .files(findJavaFiles(src))
+ .run(Task.Expect.FAIL)
+ .writeAll()
+ .getOutputLines(Task.OutputKind.DIRECT);
+ List<String> expected = Arrays.asList(
+ "module-info.java:1:12: compiler.warn.service.provided.but.not.exported.or.used: p1.C1",
+ "- compiler.err.warnings.and.werror",
+ "1 error",
+ "1 warning");
+ if (!output.containsAll(expected)) {
+ throw new Exception("Expected output not found");
+ }
+ }
+
+ @Test
+ public void testImplementationMustBeInSameModuleAsProvidesDirective(Path base) throws Exception {
+ Path src = base.resolve("src");
+ tb.writeJavaFiles(src.resolve("m1x"),
+ "module m1x { exports p1; }",
+ "package p1; public class C1 { }");
+ tb.writeJavaFiles(src.resolve("m2x"),
+ "module m2x { requires m1x; requires m3x; provides p1.C1 with p2.C2; }");
+ tb.writeJavaFiles(src.resolve("m3x"),
+ "module m3x { requires m1x; exports p2; }",
+ "package p2; public class C2 extends p1.C1 { }");
+ Path modules = base.resolve("modules");
+ Files.createDirectories(modules);
+
+ List<String> output = new JavacTask(tb)
+ .options("-XDrawDiagnostics", "--module-source-path", src.toString())
+ .outdir(modules)
+ .files(findJavaFiles(src))
+ .run(Task.Expect.FAIL)
+ .writeAll()
+ .getOutputLines(Task.OutputKind.DIRECT);
+ List<String> expected = Arrays.asList(
+ "module-info.java:1:42: compiler.err.service.implementation.not.in.right.module: m3x",
+ "1 error");
+ if (!output.containsAll(expected)) {
+ throw new Exception("Expected output not found");
+ }
+ }
+}