langtools/src/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java
--- a/langtools/src/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java Tue Dec 17 19:27:49 2013 -0500
+++ b/langtools/src/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java Wed Dec 18 10:29:25 2013 -0500
@@ -173,8 +173,7 @@
*/
private List<ProgramElementDoc> getInheritedPackagePrivateMethods(Configuration configuration) {
List<ProgramElementDoc> results = new ArrayList<ProgramElementDoc>();
- for (Iterator<ClassDoc> iter = visibleClasses.iterator(); iter.hasNext(); ) {
- ClassDoc currentClass = iter.next();
+ for (ClassDoc currentClass : visibleClasses) {
if (currentClass != classdoc &&
currentClass.isPackagePrivate() &&
!Util.isLinkable(currentClass, configuration)) {
@@ -221,11 +220,11 @@
private void sort(List<ClassDoc> list) {
List<ClassDoc> classes = new ArrayList<ClassDoc>();
List<ClassDoc> interfaces = new ArrayList<ClassDoc>();
- for (int i = 0; i < list.size(); i++) {
- ClassDoc cd = list.get(i);
+ for (ClassDoc cd : list) {
if (cd.isClass()) {
classes.add(cd);
- } else {
+ }
+ else {
interfaces.add(cd);
}
}
@@ -235,23 +234,23 @@
}
private void fillMemberLevelMap(List<ProgramElementDoc> list, String level) {
- for (int i = 0; i < list.size(); i++) {
- Object key = getMemberKey(list.get(i));
- Map<ProgramElementDoc,String> memberLevelMap = memberNameMap.get(key);
+ for (ProgramElementDoc element : list) {
+ Object key = getMemberKey(element);
+ Map<ProgramElementDoc, String> memberLevelMap = memberNameMap.get(key);
if (memberLevelMap == null) {
- memberLevelMap = new HashMap<ProgramElementDoc,String>();
+ memberLevelMap = new HashMap<ProgramElementDoc, String>();
memberNameMap.put(key, memberLevelMap);
}
- memberLevelMap.put(list.get(i), level);
+ memberLevelMap.put(element, level);
}
}
private void purgeMemberLevelMap(List<ProgramElementDoc> list, String level) {
- for (int i = 0; i < list.size(); i++) {
- Object key = getMemberKey(list.get(i));
+ for (ProgramElementDoc element : list) {
+ Object key = getMemberKey(element);
Map<ProgramElementDoc, String> memberLevelMap = memberNameMap.get(key);
- if (level.equals(memberLevelMap.get(list.get(i))))
- memberLevelMap.remove(list.get(i));
+ if (level.equals(memberLevelMap.get(element)))
+ memberLevelMap.remove(element);
}
}
@@ -273,11 +272,10 @@
}
public boolean isEqual(MethodDoc member) {
- for (Iterator<ProgramElementDoc> iter = members.iterator(); iter.hasNext(); ) {
- MethodDoc member2 = (MethodDoc) iter.next();
- if (Util.executableMembersEqual(member, member2)) {
+ for (ProgramElementDoc element : members) {
+ if (Util.executableMembersEqual(member, (MethodDoc) element)) {
members.add(member);
- return true;
+ return true;
}
}
return false;
@@ -345,9 +343,9 @@
private void mapClass() {
addMembers(mappingClass);
ClassDoc[] interfaces = mappingClass.interfaces();
- for (int i = 0; i < interfaces.length; i++) {
+ for (ClassDoc anInterface : interfaces) {
String locallevel = level + 1;
- ClassMembers cm = new ClassMembers(interfaces[i], locallevel);
+ ClassMembers cm = new ClassMembers(anInterface, locallevel);
cm.mapClass();
}
if (mappingClass.isClass()) {
@@ -371,13 +369,12 @@
private void addMembers(ClassDoc fromClass) {
List<ProgramElementDoc> cdmembers = getClassMembers(fromClass, true);
List<ProgramElementDoc> incllist = new ArrayList<ProgramElementDoc>();
- for (int i = 0; i < cdmembers.size(); i++) {
- ProgramElementDoc pgmelem = cdmembers.get(i);
+ for (ProgramElementDoc pgmelem : cdmembers) {
if (!found(members, pgmelem) &&
memberIsVisible(pgmelem) &&
!isOverridden(pgmelem, level) &&
!isTreatedAsPrivate(pgmelem)) {
- incllist.add(pgmelem);
+ incllist.add(pgmelem);
}
}
if (incllist.size() > 0) {
@@ -491,18 +488,17 @@
boolean required) {
AnnotationTypeElementDoc[] members = doc.elements();
List<AnnotationTypeElementDoc> targetMembers = new ArrayList<AnnotationTypeElementDoc>();
- for (int i = 0; i < members.length; i++) {
- if ((required && members[i].defaultValue() == null) ||
- ((!required) && members[i].defaultValue() != null)){
- targetMembers.add(members[i]);
+ for (AnnotationTypeElementDoc member : members) {
+ if ((required && member.defaultValue() == null) ||
+ ((!required) && member.defaultValue() != null)) {
+ targetMembers.add(member);
}
}
return targetMembers.toArray(new AnnotationTypeElementDoc[]{});
}
private boolean found(List<ProgramElementDoc> list, ProgramElementDoc elem) {
- for (int i = 0; i < list.size(); i++) {
- ProgramElementDoc pgmelem = list.get(i);
+ for (ProgramElementDoc pgmelem : list) {
if (Util.matches(pgmelem, elem)) {
return true;
}
@@ -520,10 +516,7 @@
Map<?,String> memberLevelMap = (Map<?,String>) memberNameMap.get(getMemberKey(pgmdoc));
if (memberLevelMap == null)
return false;
- String mappedlevel = null;
- Iterator<String> iterator = memberLevelMap.values().iterator();
- while (iterator.hasNext()) {
- mappedlevel = iterator.next();
+ for (String mappedlevel : memberLevelMap.values()) {
if (mappedlevel.equals(STARTLEVEL) ||
(level.startsWith(mappedlevel) &&
!level.equals(mappedlevel))) {
@@ -744,8 +737,7 @@
}
private ClassMember getClassMember(MethodDoc member) {
- for (Iterator<?> iter = memberNameMap.keySet().iterator(); iter.hasNext();) {
- Object key = iter.next();
+ for (Object key : memberNameMap.keySet()) {
if (key instanceof String) {
continue;
} else if (((ClassMember) key).isEqual(member)) {