--- a/hotspot/src/share/vm/memory/space.cpp Wed Aug 06 11:57:31 2008 -0400
+++ b/hotspot/src/share/vm/memory/space.cpp Thu Aug 21 23:36:31 2008 -0400
@@ -1,5 +1,5 @@
/*
- * Copyright 1997-2006 Sun Microsystems, Inc. All Rights Reserved.
+ * Copyright 1997-2008 Sun Microsystems, Inc. All Rights Reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -239,50 +239,45 @@
return new ContiguousSpaceDCTOC(this, cl, precision, boundary);
}
-void Space::set_bounds(MemRegion mr) {
+void Space::initialize(MemRegion mr,
+ bool clear_space,
+ bool mangle_space) {
HeapWord* bottom = mr.start();
HeapWord* end = mr.end();
assert(Universe::on_page_boundary(bottom) && Universe::on_page_boundary(end),
"invalid space boundaries");
set_bottom(bottom);
set_end(end);
+ if (clear_space) clear(mangle_space);
}
-void Space::initialize(MemRegion mr, bool clear_space) {
- set_bounds(mr);
- if (clear_space) clear();
-}
-
-void Space::clear() {
- if (ZapUnusedHeapArea) mangle_unused_area();
+void Space::clear(bool mangle_space) {
+ if (ZapUnusedHeapArea && mangle_space) {
+ mangle_unused_area();
+ }
}
-void CompactibleSpace::initialize(MemRegion mr, bool clear_space) {
- Space::initialize(mr, false); // We'll do the clearing if there's
- // clearing to be done.
- _compaction_top = bottom();
- _next_compaction_space = NULL;
- if (clear_space) clear();
+ContiguousSpace::ContiguousSpace(): CompactibleSpace(), _top(NULL),
+ _concurrent_iteration_safe_limit(NULL) {
+ _mangler = new GenSpaceMangler(this);
}
-void CompactibleSpace::clear() {
- _compaction_top = bottom();
- Space::clear();
+ContiguousSpace::~ContiguousSpace() {
+ delete _mangler;
}
-void ContiguousSpace::initialize(MemRegion mr, bool clear_space) {
- CompactibleSpace::initialize(mr, false); // We'll do the clearing if there's
- // clearing to be done.
- set_top(bottom());
- set_saved_mark();
- if (clear_space) clear();
+void ContiguousSpace::initialize(MemRegion mr,
+ bool clear_space,
+ bool mangle_space)
+{
+ CompactibleSpace::initialize(mr, clear_space, mangle_space);
set_concurrent_iteration_safe_limit(top());
}
-void ContiguousSpace::clear() {
+void ContiguousSpace::clear(bool mangle_space) {
set_top(bottom());
set_saved_mark();
- CompactibleSpace::clear();
+ CompactibleSpace::clear(mangle_space);
}
bool Space::is_in(const void* p) const {
@@ -298,17 +293,8 @@
return p >= _top;
}
-void OffsetTableContigSpace::initialize(MemRegion mr, bool clear_space) {
- // false ==> we'll do the clearing if there's clearing to be done.
- ContiguousSpace::initialize(mr, false);
- _offsets.zero_bottom_entry();
- _offsets.initialize_threshold();
- if (clear_space) clear();
-}
-
-void OffsetTableContigSpace::clear() {
- ContiguousSpace::clear();
- _offsets.zero_bottom_entry();
+void OffsetTableContigSpace::clear(bool mangle_space) {
+ ContiguousSpace::clear(mangle_space);
_offsets.initialize_threshold();
}
@@ -324,13 +310,53 @@
Space::set_end(new_end);
}
-void ContiguousSpace::mangle_unused_area() {
- // to-space is used for storing marks during mark-sweep
- mangle_region(MemRegion(top(), end()));
+#ifndef PRODUCT
+
+void ContiguousSpace::set_top_for_allocations(HeapWord* v) {
+ mangler()->set_top_for_allocations(v);
+}
+void ContiguousSpace::set_top_for_allocations() {
+ mangler()->set_top_for_allocations(top());
+}
+void ContiguousSpace::check_mangled_unused_area(HeapWord* limit) {
+ mangler()->check_mangled_unused_area(limit);
+}
+
+void ContiguousSpace::check_mangled_unused_area_complete() {
+ mangler()->check_mangled_unused_area_complete();
}
+// Mangled only the unused space that has not previously
+// been mangled and that has not been allocated since being
+// mangled.
+void ContiguousSpace::mangle_unused_area() {
+ mangler()->mangle_unused_area();
+}
+void ContiguousSpace::mangle_unused_area_complete() {
+ mangler()->mangle_unused_area_complete();
+}
void ContiguousSpace::mangle_region(MemRegion mr) {
- debug_only(Copy::fill_to_words(mr.start(), mr.word_size(), badHeapWord));
+ // Although this method uses SpaceMangler::mangle_region() which
+ // is not specific to a space, the when the ContiguousSpace version
+ // is called, it is always with regard to a space and this
+ // bounds checking is appropriate.
+ MemRegion space_mr(bottom(), end());
+ assert(space_mr.contains(mr), "Mangling outside space");
+ SpaceMangler::mangle_region(mr);
+}
+#endif // NOT_PRODUCT
+
+void CompactibleSpace::initialize(MemRegion mr,
+ bool clear_space,
+ bool mangle_space) {
+ Space::initialize(mr, clear_space, mangle_space);
+ set_compaction_top(bottom());
+ _next_compaction_space = NULL;
+}
+
+void CompactibleSpace::clear(bool mangle_space) {
+ Space::clear(mangle_space);
+ _compaction_top = bottom();
}
HeapWord* CompactibleSpace::forward(oop q, size_t size,
@@ -850,8 +876,8 @@
}
}
-void EdenSpace::clear() {
- ContiguousSpace::clear();
+void EdenSpace::clear(bool mangle_space) {
+ ContiguousSpace::clear(mangle_space);
set_soft_end(end());
}
@@ -908,7 +934,7 @@
_par_alloc_lock(Mutex::leaf, "OffsetTableContigSpace par alloc lock", true)
{
_offsets.set_contig_space(this);
- initialize(mr, true);
+ initialize(mr, SpaceDecorator::Clear, SpaceDecorator::Mangle);
}