--- a/src/java.base/share/classes/java/util/concurrent/Executors.java Sat Feb 10 09:17:53 2018 -0800
+++ b/src/java.base/share/classes/java/util/concurrent/Executors.java Sat Feb 10 09:23:41 2018 -0800
@@ -35,6 +35,7 @@
package java.util.concurrent;
+import static java.lang.ref.Reference.reachabilityFence;
import java.security.AccessControlContext;
import java.security.AccessControlException;
import java.security.AccessController;
@@ -185,9 +186,7 @@
* returned executor is guaranteed not to be reconfigurable to use
* additional threads.
*
- * @param threadFactory the factory to use when creating new
- * threads
- *
+ * @param threadFactory the factory to use when creating new threads
* @return the newly created single-threaded Executor
* @throws NullPointerException if threadFactory is null
*/
@@ -226,6 +225,7 @@
* will reuse previously constructed threads when they are
* available, and uses the provided
* ThreadFactory to create new threads when needed.
+ *
* @param threadFactory the factory to use when creating new threads
* @return the newly created thread pool
* @throws NullPointerException if threadFactory is null
@@ -248,6 +248,7 @@
* given time. Unlike the otherwise equivalent
* {@code newScheduledThreadPool(1)} the returned executor is
* guaranteed not to be reconfigurable to use additional threads.
+ *
* @return the newly created scheduled executor
*/
public static ScheduledExecutorService newSingleThreadScheduledExecutor() {
@@ -266,9 +267,9 @@
* equivalent {@code newScheduledThreadPool(1, threadFactory)}
* the returned executor is guaranteed not to be reconfigurable to
* use additional threads.
- * @param threadFactory the factory to use when creating new
- * threads
- * @return a newly created scheduled executor
+ *
+ * @param threadFactory the factory to use when creating new threads
+ * @return the newly created scheduled executor
* @throws NullPointerException if threadFactory is null
*/
public static ScheduledExecutorService newSingleThreadScheduledExecutor(ThreadFactory threadFactory) {
@@ -281,7 +282,7 @@
* given delay, or to execute periodically.
* @param corePoolSize the number of threads to keep in the pool,
* even if they are idle
- * @return a newly created scheduled thread pool
+ * @return the newly created scheduled thread pool
* @throws IllegalArgumentException if {@code corePoolSize < 0}
*/
public static ScheduledExecutorService newScheduledThreadPool(int corePoolSize) {
@@ -295,7 +296,7 @@
* even if they are idle
* @param threadFactory the factory to use when the executor
* creates a new thread
- * @return a newly created scheduled thread pool
+ * @return the newly created scheduled thread pool
* @throws IllegalArgumentException if {@code corePoolSize < 0}
* @throws NullPointerException if threadFactory is null
*/
@@ -678,44 +679,76 @@
* of an ExecutorService implementation.
*/
private static class DelegatedExecutorService
- extends AbstractExecutorService {
+ implements ExecutorService {
private final ExecutorService e;
DelegatedExecutorService(ExecutorService executor) { e = executor; }
- public void execute(Runnable command) { e.execute(command); }
+ public void execute(Runnable command) {
+ try {
+ e.execute(command);
+ } finally { reachabilityFence(this); }
+ }
public void shutdown() { e.shutdown(); }
- public List<Runnable> shutdownNow() { return e.shutdownNow(); }
- public boolean isShutdown() { return e.isShutdown(); }
- public boolean isTerminated() { return e.isTerminated(); }
+ public List<Runnable> shutdownNow() {
+ try {
+ return e.shutdownNow();
+ } finally { reachabilityFence(this); }
+ }
+ public boolean isShutdown() {
+ try {
+ return e.isShutdown();
+ } finally { reachabilityFence(this); }
+ }
+ public boolean isTerminated() {
+ try {
+ return e.isTerminated();
+ } finally { reachabilityFence(this); }
+ }
public boolean awaitTermination(long timeout, TimeUnit unit)
throws InterruptedException {
- return e.awaitTermination(timeout, unit);
+ try {
+ return e.awaitTermination(timeout, unit);
+ } finally { reachabilityFence(this); }
}
public Future<?> submit(Runnable task) {
- return e.submit(task);
+ try {
+ return e.submit(task);
+ } finally { reachabilityFence(this); }
}
public <T> Future<T> submit(Callable<T> task) {
- return e.submit(task);
+ try {
+ return e.submit(task);
+ } finally { reachabilityFence(this); }
}
public <T> Future<T> submit(Runnable task, T result) {
- return e.submit(task, result);
+ try {
+ return e.submit(task, result);
+ } finally { reachabilityFence(this); }
}
public <T> List<Future<T>> invokeAll(Collection<? extends Callable<T>> tasks)
throws InterruptedException {
- return e.invokeAll(tasks);
+ try {
+ return e.invokeAll(tasks);
+ } finally { reachabilityFence(this); }
}
public <T> List<Future<T>> invokeAll(Collection<? extends Callable<T>> tasks,
long timeout, TimeUnit unit)
throws InterruptedException {
- return e.invokeAll(tasks, timeout, unit);
+ try {
+ return e.invokeAll(tasks, timeout, unit);
+ } finally { reachabilityFence(this); }
}
public <T> T invokeAny(Collection<? extends Callable<T>> tasks)
throws InterruptedException, ExecutionException {
- return e.invokeAny(tasks);
+ try {
+ return e.invokeAny(tasks);
+ } finally { reachabilityFence(this); }
}
public <T> T invokeAny(Collection<? extends Callable<T>> tasks,
long timeout, TimeUnit unit)
throws InterruptedException, ExecutionException, TimeoutException {
- return e.invokeAny(tasks, timeout, unit);
+ try {
+ return e.invokeAny(tasks, timeout, unit);
+ } finally { reachabilityFence(this); }
}
}