--- a/hotspot/src/share/vm/runtime/arguments.cpp Tue Feb 23 23:14:34 2010 -0500
+++ b/hotspot/src/share/vm/runtime/arguments.cpp Wed Feb 24 07:00:33 2010 -0800
@@ -1203,6 +1203,11 @@
if (!FLAG_IS_DEFAULT(CMSParPromoteBlocksToClaim) || !FLAG_IS_DEFAULT(OldPLABWeight)) {
CFLS_LAB::modify_initialization(OldPLABSize, OldPLABWeight);
}
+ if (PrintGCDetails && Verbose) {
+ tty->print_cr("MarkStackSize: %uk MarkStackSizeMax: %uk",
+ MarkStackSize / K, MarkStackSizeMax / K);
+ tty->print_cr("ConcGCThreads: %u", ConcGCThreads);
+ }
}
#endif // KERNEL
@@ -1339,6 +1344,17 @@
if (FLAG_IS_DEFAULT(MaxGCPauseMillis)) {
FLAG_SET_DEFAULT(MaxGCPauseMillis, 200);
}
+
+ if (FLAG_IS_DEFAULT(MarkStackSize)) {
+ // Size as a multiple of TaskQueueSuper::N which is larger
+ // for 64-bit.
+ FLAG_SET_DEFAULT(MarkStackSize, 128 * TaskQueueSuper::total_size());
+ }
+ if (PrintGCDetails && Verbose) {
+ tty->print_cr("MarkStackSize: %uk MarkStackSizeMax: %uk",
+ MarkStackSize / K, MarkStackSizeMax / K);
+ tty->print_cr("ConcGCThreads: %u", ConcGCThreads);
+ }
}
void Arguments::set_heap_size() {
@@ -1800,6 +1816,29 @@
return false;
}
+bool Arguments::parse_uintx(const char* value,
+ uintx* uintx_arg,
+ uintx min_size) {
+
+ // Check the sign first since atomull() parses only unsigned values.
+ bool value_is_positive = !(*value == '-');
+
+ if (value_is_positive) {
+ julong n;
+ bool good_return = atomull(value, &n);
+ if (good_return) {
+ bool above_minimum = n >= min_size;
+ bool value_is_too_large = n > max_uintx;
+
+ if (above_minimum && !value_is_too_large) {
+ *uintx_arg = n;
+ return true;
+ }
+ }
+ }
+ return false;
+}
+
Arguments::ArgsRange Arguments::parse_memory_size(const char* s,
julong* long_arg,
julong min_size) {
@@ -2458,6 +2497,37 @@
jio_fprintf(defaultStream::error_stream(),
"Please use -XX:YoungPLABSize in place of "
"-XX:ParallelGCToSpaceAllocBufferSize in the future\n");
+ } else if (match_option(option, "-XX:CMSMarkStackSize=", &tail) ||
+ match_option(option, "-XX:G1MarkStackSize=", &tail)) {
+ julong stack_size = 0;
+ ArgsRange errcode = parse_memory_size(tail, &stack_size, 1);
+ if (errcode != arg_in_range) {
+ jio_fprintf(defaultStream::error_stream(),
+ "Invalid mark stack size: %s\n", option->optionString);
+ describe_range_error(errcode);
+ return JNI_EINVAL;
+ }
+ FLAG_SET_CMDLINE(uintx, MarkStackSize, stack_size);
+ } else if (match_option(option, "-XX:CMSMarkStackSizeMax=", &tail)) {
+ julong max_stack_size = 0;
+ ArgsRange errcode = parse_memory_size(tail, &max_stack_size, 1);
+ if (errcode != arg_in_range) {
+ jio_fprintf(defaultStream::error_stream(),
+ "Invalid maximum mark stack size: %s\n",
+ option->optionString);
+ describe_range_error(errcode);
+ return JNI_EINVAL;
+ }
+ FLAG_SET_CMDLINE(uintx, MarkStackSizeMax, max_stack_size);
+ } else if (match_option(option, "-XX:ParallelMarkingThreads=", &tail) ||
+ match_option(option, "-XX:ParallelCMSThreads=", &tail)) {
+ uintx conc_threads = 0;
+ if (!parse_uintx(tail, &conc_threads, 1)) {
+ jio_fprintf(defaultStream::error_stream(),
+ "Invalid concurrent threads: %s\n", option->optionString);
+ return JNI_EINVAL;
+ }
+ FLAG_SET_CMDLINE(uintx, ConcGCThreads, conc_threads);
} else if (match_option(option, "-XX:", &tail)) { // -XX:xxxx
// Skip -XX:Flags= since that case has already been handled
if (strncmp(tail, "Flags=", strlen("Flags=")) != 0) {