jdk-sandbox: comparison src/jdk.incubator.adba/share/classes/jdk/incubator/sql2/OperationGroup.java

equal deleted inserted replaced

-:6ba0dbf6a75f
+:62e92191354d
 * parallel, member {@link Operation}s may be executed in any order including
 * in parallel. If an {@link OperationGroup} is sequential, the default,
 * member {@link Operation}s are executed strictly in the order they are
 * submitted.
 *
-* Note: There is no covariant override of this method in {@link Connection}
+* Note: There is no covariant override of this method in {@link Session}
 * as there is only a small likelihood of needing it.
 *
 * @return this {@link OperationGroup}
 * @throws IllegalStateException if this {@link OperationGroup} has been
 * submitted, any member {@link Operation}s have been created, or this method
 * {@link SqlSkippedException} with the cause set to the original exception.
 *
 * The result of this {@link OperationGroup}'s execution is the result of collecting the
 * results of the member {@link Operation}s that complete normally.
 *
-* Note: There is no covariant override of this method in {@link Connection}
+* Note: There is no covariant override of this method in {@link Session}
 * as there is only a small likelihood of needing it.
 *
 * @return this {@link OperationGroup}
 * @throws IllegalStateException if this {@link OperationGroup} has been
 * submitted, any member {@link Operation}s have been created, or this method
 * executed. If {@link Boolean#FALSE} or if it is completed exceptionally the
 * member {@link Operation}s are not executed but are removed from the queue.
 * After all member {@link Operation}s have been removed from the queue this
 * {@link OperationGroup} is completed with {@code null}.
 *
-* Note: There is no covariant override of this method in Connection as there
+* Note: There is no covariant override of this method in Session as there
 * is only a small likelihood of needing it.
 *
 * ISSUE: Should the member Operations be skipped or otherwise completed
 * exceptionally?
 *
 *
 * If the {@link OperationGroup} is dependent and one of its member {@link Operation}s
 * completes exceptionally and its queue is empty the {@link OperationGroup}
 * is completed.
 *
-* Note: There is no covariant override of this method in Connection as there
+* Note: There is no covariant override of this method in Session as there
 * is only a small likelihood of needing it.
 *
 * ISSUE: Need a better name.
 *
 * @return a Submission for this OperationGroup
 * this method is called no additional member {@link Operation}s can be
 * submitted. Once all member {@link Operation}s have been removed from the
 * queue this {@link OperationGroup} will be completed and removed from the
 * queue.
 *
-* Note: There is no covariant override of this method in Connection as there
+* Note: There is no covariant override of this method in Session as there
 * is only a small likelihood of needing it.
 *
 * ISSUE: Need a better name.
 *
 * @return the same Submission that was returned by {@link OperationGroup#submitHoldingForMoreMembers}
 * Return a new {@link ArrayRowCountOperation}.
 * <p>
 * Usage Note: Frequently use of this method will require a type witness to
 * enable correct type inferencing.
 * <pre><code>
-*   conn.<b>&lt;List&lt;Integer&gt;&gt;</b>arrayCountOperation(sql)
+*   session.<b>&lt;List&lt;Integer&gt;&gt;</b>arrayCountOperation(sql)
 *     .set ...
 *     .collect ...
 *     .submit ...
 * </code></pre>
 *
 * convenience methods do so.</p>
 *
 * The type argument {@link S} of the containing {@link OperationGroup} must
 * be a supertype of {@link TransactionOutcome}.
 *
-* @param trans the Transaction that determines whether the Operation does a
+* @param trans the TransactionEnd that determines whether the Operation does a
 * database commit or a database rollback.
 * @return an {@link Operation} that will end the database transaction.
 * @throws IllegalStateException if this {@link OperationGroup} has been
 * submitted and is not held or is parallel.
 */
-public Operation<TransactionOutcome> endTransactionOperation(Transaction trans);
+public Operation<TransactionOutcome> endTransactionOperation(TransactionEnd trans);
 /**
 * Convenience method that creates and submits a endTransaction
 * {@link Operation} that commits by default but can be set to rollback by
-* calling {@link Transaction#setRollbackOnly}. The endTransaction Operation
+* calling {@link TransactionEnd#setRollbackOnly}. The endTransaction Operation
 * is never skipped.
 *
-* @param trans the Transaction that determines whether the {@link Operation} is a
+* @param trans the TransactionEnd that determines whether the {@link Operation} is a
 * database commit or a database rollback.
-* @return this {@link OperationGroup}
+* @return a {@link CompletionStage} that is completed with the outcome of the
+* transaction
 * @throws IllegalStateException if this {@link OperationGroup} has been
 * submitted and is not held or is parallel.
 */
-public default CompletionStage<TransactionOutcome> commitMaybeRollback(Transaction trans) {
+public default CompletionStage<TransactionOutcome> commitMaybeRollback(TransactionEnd trans) {
 catchErrors();
 return this.endTransactionOperation(trans).submit().getCompletionStage();
 }
 /**
 @Override
 public OperationGroup<S, T> timeout(Duration minTime);
 @Override
 public OperationGroup<S, T> onError(Consumer<Throwable> handler);
 }

branch	JDK-8188051-branch
changeset 56824	62e92191354d
parent 56797	fb523d4d9185
child 56828	64304e37e9b1