jdk-sandbox: comparison src/main/java/openjdk/http/tutorial/exercise1/Retrievals.java

equal deleted inserted replaced

-:fc030486080e
+:40e766eb611b
 /**
 * Exercise 1.
 *
 * Retrieve the response status code from a request to the given
-* URI. The returned response code will be a int.
+* URI. Return the response code, which is an integer.
 *
-* Hint: use the discard BodyHandler since the response body is not
+* Hint: use the {@link BodyHandler#discard(Object)BodyHandler} since
-* interesting.
+* the response body is not interesting.
 *
 * Hint: static imports reduce boilerplate when using BodyHandlers
 * and BodyProcessors, e.g. import static
 * jdk.incubator.http.HttpResponse.BodyHandler.discard
 */
 return response.statusCode();
 }
 /**
-* Exercise 1.
+* Exercise 2.
 *
 * Retrieve the response body from a given URI. Return the response
 * body as a String.
 *
-* Hint: use the asString BodyHandler to convert the HTTP response
+* Hint: use the {@link BodyHandler#asString()} BodyHandler to convert
-* body to a String.
+* the HTTP response body to a String.
 *
 * Hint: static imports reduce boilerplate when using BodyHandlers
 * and BodyProcessors, e.g. import static
 * jdk.incubator.http.HttpResponse.BodyHandler.asString
 */
 return response.body();
 }
 /**
-* Exercise 2.
+* Exercise 3.
 *
-* Retrieve the response body from a given URI, streaming teh body
+* Retrieve the response body from a given URI, streaming the body
 * out to a file. Return the file's Path.
 *
 * Hint: use {@linkplain BodyHandler#asFile} to stream the HTTP
 * response body to a file.
+*
+* Hint: if a file already exists from a previous test run, either
+* remove it or use the {@link java.nio.file.StandardOpenOption#CREATE}
+* along with the {@link java.nio.file.StandardOpenOption#TRUNCATE_EXISTING}
+* to create or truncate as needed.
 */
 public static Path retrieveResourceAsFile(URI uri)
 throws IOException, InterruptedException
 {
 HttpClient client = HttpClient.newBuilder().build();
 .uri(uri)
 .version(HTTP_1_1)
 .GET()
 .build();
 HttpResponse<Path> response = client.send(request,
-asFile(Paths.get("retrieveResourceAsFile.txt"), StandardOpenOption.TRUNCATE_EXISTING, StandardOpenOption.WRITE));
+asFile(Paths.get("retrieveResourceAsFile.txt"),
+StandardOpenOption.CREATE,
-System.out.println("CHEGAR:   sc=" + response.statusCode());
+StandardOpenOption.TRUNCATE_EXISTING,
-System.out.println("CHEGAR:   by=" + Files.readAllLines(response.body()).stream().collect(joining()));
+StandardOpenOption.WRITE));
 return response.body();
 }
 /**
-* Asserts that the response code is 200 ( OK ).
+* A helper method, NOT an exercise.
+*
+* Asserts that the response code is 200 ( OK ). Throws IOException if
+* the response code is not 200.
 *
 * Can be used in CompletableFuture pipelines when checking the
 * response of an {@linkplain HttpClient#sendAsync} call. For
 * example:
 *    client.sendAsync(request, bodyHandler)
 }
 return response;
 }
 /**
-*  Exercise 3.
+* Exercise 4.
 *
-* Retrieve the response body from a given URI, using the
+* Retrieve the response body from a given URI, using thea synchronous
-* asynchronous send API, sendAsync. Return a CompletableFuture that
+* send API, {@link HttpClient#sendAsync(HttpRequest, BodyHandler)}.
-* completes with the response body as a String.
+* Return a CompletableFuture that completes with the response body
+* as a String.
 *
 * Hint: The {@linkplain CompletableFuture#thenApply(Function)}
 * method can be used to map the HttpResponse to a String.
 */
 public static CompletableFuture<String> retrieveResourceAsStringUsingAsyncAPI(URI uri) {
+// TODO: why version needed?
 return HttpClient.newHttpClient()
-.sendAsync(HttpRequest.newBuilder(uri).version(HTTP_1_1).build(), asString())  // TODO: why version needed?
+.sendAsync(HttpRequest.newBuilder(uri).version(HTTP_1_1).build(), asString())
 .thenApply(Retrievals::require200StatusCode)
 .thenApply(HttpResponse::body);
 }
 /**
+* A helper method, NOT an exercise.
+*
 * Wrapper around Jackson's ObjectMapper that provides an unchecked
 * {@code readValue}, what can be used to help solve the next
-* exercise, 4.
+* exercise, 5.
 */
 public static class UncheckedObjectMapper extends ObjectMapper {
 /** Parses the given JSON string into a Map. */
 Map<String,String> readValue(String content) {
 }
 }
 }
 /**
-* Exercise 4.
+* Exercise 5.
 *
 * Retrieve the response body from a given URI. The response body
 * will be in the JSON format. The Jackson based UncheckedObjectMapper
 * ( above ) can be used to parse the String response body into a
-* Map.
+* Map. Return the response body as a Map.
 *
 * Hint: The asynchronous send API will allow construction of a
 * pipeline of CompletableFutures.
 *
 * Hint: The {@linkplain CompletableFuture#thenApply(Function)}
 * method can be used to map the HttpResponse to a String, and then
-* again from a Sting to a Map ( via the object mapper ).
+* again from a String ( of JSON ) to a Map ( via the object mapper ).
 */
 public CompletableFuture<Map<String,String>> JSONBodyAsMap(URI uri) {
 UncheckedObjectMapper objectMapper = new UncheckedObjectMapper();
 return HttpClient.newHttpClient()
 .sendAsync(HttpRequest.newBuilder(uri).version(HTTP_1_1).build(), asString())
 }
 /**
+* Exercise 6.
+*
 * Post the given {@code data}, and receive the same data in
 * response. Return the response body data as a String.
 */
 public static String postData(URI uri, String data)
 throws IOException, InterruptedException
 HttpResponse<String> response = client.send(request, asString());
 return response.body();
 }
-// JSON processor
 }

branch	http-client-tutorial
changeset 56018	40e766eb611b
parent 56017	fc030486080e