author | phh |
Sat, 30 Nov 2019 14:33:05 -0800 | |
changeset 59330 | 5b96c12f909d |
parent 50351 | 9289c4214a35 |
permissions | -rw-r--r-- |
50351
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
1 |
/* |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
2 |
* Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
4 |
* |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
5 |
* This code is free software; you can redistribute it and/or modify it |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
7 |
* published by the Free Software Foundation. |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
8 |
* |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
13 |
* accompanied this code). |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
14 |
* |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
15 |
* You should have received a copy of the GNU General Public License version |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
18 |
* |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
21 |
* questions. |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
22 |
*/ |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
23 |
|
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
24 |
import java.beans.BeanInfo; |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
25 |
import java.beans.Introspector; |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
26 |
import java.beans.PropertyDescriptor; |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
27 |
import java.lang.reflect.Method; |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
28 |
|
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
29 |
/** |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
30 |
* @test |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
31 |
* @bug 8196373 |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
32 |
* @summary Introspector should work with overridden generic setter method |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
33 |
*/ |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
34 |
public final class OverriddenGenericSetter { |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
35 |
|
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
36 |
static class Parent<T> { |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
37 |
private T value; |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
38 |
public final T getValue() {return value;} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
39 |
protected void setValue(T value) {this.value = value;} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
40 |
} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
41 |
|
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
42 |
static class ChildO extends Parent<Object> { |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
43 |
public ChildO() {} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
44 |
@Override |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
45 |
public void setValue(Object value) {super.setValue(value);} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
46 |
} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
47 |
|
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
48 |
// For overridden setXXX javac will generate the "synthetic bridge" method |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
49 |
// setValue(Ljava/lang/Object). We will use two different types which may be |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
50 |
// placed before/after bridge method. |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
51 |
static class ChildA extends Parent<ArithmeticException> { |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
52 |
public ChildA() {} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
53 |
@Override |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
54 |
public void setValue(ArithmeticException value) {super.setValue(value);} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
55 |
} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
56 |
|
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
57 |
static class ChildS extends Parent<String> { |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
58 |
public ChildS() {} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
59 |
@Override |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
60 |
public void setValue(String value) {super.setValue(value);} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
61 |
} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
62 |
|
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
63 |
public static void main(String[] args) throws Exception { |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
64 |
testBehaviour(ChildA.class); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
65 |
testBehaviour(ChildO.class); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
66 |
testBehaviour(ChildS.class); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
67 |
testProperty(ChildA.class, ArithmeticException.class); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
68 |
testProperty(ChildO.class, Object.class); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
69 |
testProperty(ChildS.class, String.class); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
70 |
} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
71 |
|
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
72 |
private static void testBehaviour(Class<?> beanClass) throws Exception { |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
73 |
BeanInfo beanInfo = Introspector.getBeanInfo(beanClass, Object.class); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
74 |
PropertyDescriptor pd = beanInfo.getPropertyDescriptors()[0]; |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
75 |
Object bean = beanClass.getConstructor().newInstance(); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
76 |
Method readMethod = pd.getReadMethod(); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
77 |
Method writeMethod = pd.getWriteMethod(); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
78 |
|
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
79 |
// check roundtrip for default null values |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
80 |
writeMethod.invoke(bean,readMethod.invoke(bean)); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
81 |
writeMethod.invoke(bean,readMethod.invoke(bean)); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
82 |
|
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
83 |
// set property to non-default value |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
84 |
// check roundtrip for non-default values |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
85 |
Object param = pd.getPropertyType().getConstructor().newInstance(); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
86 |
writeMethod.invoke(bean, param); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
87 |
writeMethod.invoke(bean, readMethod.invoke(bean)); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
88 |
writeMethod.invoke(bean, readMethod.invoke(bean)); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
89 |
} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
90 |
|
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
91 |
private static void testProperty(Class<?> beanClass, Class<?> type) throws Exception { |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
92 |
BeanInfo beanInfo = Introspector.getBeanInfo(beanClass, Object.class); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
93 |
PropertyDescriptor[] pds = beanInfo.getPropertyDescriptors(); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
94 |
if (pds.length != 1) { |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
95 |
throw new RuntimeException("Wrong number of properties"); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
96 |
} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
97 |
PropertyDescriptor pd = pds[0]; |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
98 |
System.out.println("pd = " + pd); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
99 |
String name = pd.getName(); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
100 |
if (!name.equals("value")) { |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
101 |
throw new RuntimeException("Wrong name: " + name); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
102 |
} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
103 |
Class<?> propertyType = pd.getPropertyType(); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
104 |
if (propertyType != type) { |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
105 |
throw new RuntimeException("Wrong property type: " + propertyType); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
106 |
} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
107 |
Method readMethod = pd.getReadMethod(); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
108 |
if (readMethod == null) { |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
109 |
throw new RuntimeException("Read method is null"); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
110 |
} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
111 |
Class<?> returnType = readMethod.getReturnType(); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
112 |
if (returnType != Object.class) { |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
113 |
throw new RuntimeException("Wrong return type; " + returnType); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
114 |
} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
115 |
Method writeMethod = pd.getWriteMethod(); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
116 |
if (writeMethod == null) { |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
117 |
throw new RuntimeException("Write method is null"); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
118 |
} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
119 |
Class<?>[] parameterTypes = writeMethod.getParameterTypes(); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
120 |
if (parameterTypes.length != 1) { |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
121 |
throw new RuntimeException("Wrong parameters " + parameterTypes); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
122 |
} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
123 |
if (parameterTypes[0] != type) { |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
124 |
throw new RuntimeException("Wrong type: " + parameterTypes[0]); |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
125 |
} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
126 |
} |
9289c4214a35
8196373: Introspector does not see overridden generic setter method
serb
parents:
diff
changeset
|
127 |
} |