author | phh |
Sat, 30 Nov 2019 14:33:05 -0800 | |
changeset 59330 | 5b96c12f909d |
parent 47216 | 71c04702a3d5 |
permissions | -rw-r--r-- |
46525
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
1 |
/* |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
2 |
* Copyright (c) 2017, Red Hat, Inc. All rights reserved. |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
4 |
* |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
5 |
* This code is free software; you can redistribute it and/or modify it |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
7 |
* published by the Free Software Foundation. |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
8 |
* |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
13 |
* accompanied this code). |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
14 |
* |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
15 |
* You should have received a copy of the GNU General Public License version |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
18 |
* |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
21 |
* questions. |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
22 |
*/ |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
23 |
|
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
24 |
/** |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
25 |
* @test |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
26 |
* @bug 8176506 |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
27 |
* @summary cast before unsafe access moved in dominating null check null path causes crash |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
28 |
* @modules java.base/jdk.internal.misc:+open |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
29 |
* |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
30 |
* @run main/othervm -Xbatch -XX:-UseOnStackReplacement TestMaybeNullUnsafeAccess |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
31 |
* |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
32 |
*/ |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
33 |
|
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
34 |
import jdk.internal.misc.Unsafe; |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
35 |
import java.lang.reflect.Field; |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
36 |
|
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
37 |
public class TestMaybeNullUnsafeAccess { |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
38 |
|
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
39 |
static final jdk.internal.misc.Unsafe UNSAFE = Unsafe.getUnsafe(); |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
40 |
static final long F_OFFSET; |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
41 |
|
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
42 |
static class A { |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
43 |
int f; |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
44 |
A(int f) { |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
45 |
this.f = f; |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
46 |
} |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
47 |
} |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
48 |
|
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
49 |
static { |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
50 |
try { |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
51 |
Field fField = A.class.getDeclaredField("f"); |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
52 |
F_OFFSET = UNSAFE.objectFieldOffset(fField); |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
53 |
} catch (Exception e) { |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
54 |
throw new RuntimeException(e); |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
55 |
} |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
56 |
} |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
57 |
|
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
58 |
static A test_helper(Object o) { |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
59 |
// this includes a check for null with both branches taken |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
60 |
return (A)o; |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
61 |
} |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
62 |
|
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
63 |
|
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
64 |
// Loop is unswitched because of the test for null from the |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
65 |
// checkcast above, unsafe access is copied in each branch, the |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
66 |
// compiler sees a memory access to a null object |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
67 |
static int test1(Object o, long offset) { |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
68 |
int f = 0; |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
69 |
for (int i = 0; i < 100; i++) { |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
70 |
A a = test_helper(o); |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
71 |
f = UNSAFE.getInt(a, offset); |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
72 |
} |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
73 |
return f; |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
74 |
} |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
75 |
|
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
76 |
// Same as above except because we know the offset of the access |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
77 |
// is small, we can deduce object a cannot be null |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
78 |
static int test2(Object o) { |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
79 |
int f = 0; |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
80 |
for (int i = 0; i < 100; i++) { |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
81 |
A a = test_helper(o); |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
82 |
f = UNSAFE.getInt(a, F_OFFSET); |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
83 |
} |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
84 |
return f; |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
85 |
} |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
86 |
|
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
87 |
static public void main(String[] args) { |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
88 |
A a = new A(0x42); |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
89 |
for (int i = 0; i < 20000; i++) { |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
90 |
test_helper(null); |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
91 |
test_helper(a); |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
92 |
test1(a, F_OFFSET); |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
93 |
test2(a); |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
94 |
} |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
95 |
} |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
96 |
|
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
diff
changeset
|
97 |
} |