hotspot/src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp
author jmasa
Tue, 09 Aug 2011 10:16:01 -0700
changeset 11174 fccee5238e70
parent 10524 6594ca81279a
child 13728 882756847a04
permissions -rw-r--r--
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads Summary: Select number of GC threads dynamically based on heap usage and number of Java threads Reviewed-by: johnc, ysr, jcoomes
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
     1
/*
8921
14bfe81f2a9d 7010070: Update all 2010 Oracle-changed OpenJDK files to have the proper copyright dates - second pass
trims
parents: 8076
diff changeset
     2
 * Copyright (c) 2005, 2011, Oracle and/or its affiliates. All rights reserved.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
489c9b5090e2 Initial load
duke
parents:
diff changeset
     4
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
489c9b5090e2 Initial load
duke
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
489c9b5090e2 Initial load
duke
parents:
diff changeset
     7
 * published by the Free Software Foundation.
489c9b5090e2 Initial load
duke
parents:
diff changeset
     8
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
489c9b5090e2 Initial load
duke
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
489c9b5090e2 Initial load
duke
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
489c9b5090e2 Initial load
duke
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
489c9b5090e2 Initial load
duke
parents:
diff changeset
    13
 * accompanied this code).
489c9b5090e2 Initial load
duke
parents:
diff changeset
    14
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
489c9b5090e2 Initial load
duke
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
489c9b5090e2 Initial load
duke
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    18
 *
5547
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 5076
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 5076
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 5076
diff changeset
    21
 * questions.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    22
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
    23
 */
489c9b5090e2 Initial load
duke
parents:
diff changeset
    24
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6762
diff changeset
    25
#include "precompiled.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6762
diff changeset
    26
#include "classfile/systemDictionary.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6762
diff changeset
    27
#include "code/codeCache.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6762
diff changeset
    28
#include "gc_implementation/parallelScavenge/pcTasks.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6762
diff changeset
    29
#include "gc_implementation/parallelScavenge/psParallelCompact.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6762
diff changeset
    30
#include "gc_interface/collectedHeap.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6762
diff changeset
    31
#include "memory/universe.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6762
diff changeset
    32
#include "oops/objArrayKlass.inline.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6762
diff changeset
    33
#include "oops/oop.inline.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6762
diff changeset
    34
#include "oops/oop.pcgc.inline.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6762
diff changeset
    35
#include "prims/jvmtiExport.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6762
diff changeset
    36
#include "runtime/fprofiler.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6762
diff changeset
    37
#include "runtime/jniHandles.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6762
diff changeset
    38
#include "runtime/thread.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6762
diff changeset
    39
#include "runtime/vmThread.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6762
diff changeset
    40
#include "services/management.hpp"
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    41
489c9b5090e2 Initial load
duke
parents:
diff changeset
    42
//
489c9b5090e2 Initial load
duke
parents:
diff changeset
    43
// ThreadRootsMarkingTask
489c9b5090e2 Initial load
duke
parents:
diff changeset
    44
//
489c9b5090e2 Initial load
duke
parents:
diff changeset
    45
489c9b5090e2 Initial load
duke
parents:
diff changeset
    46
void ThreadRootsMarkingTask::do_it(GCTaskManager* manager, uint which) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    47
  assert(Universe::heap()->is_gc_active(), "called outside gc");
489c9b5090e2 Initial load
duke
parents:
diff changeset
    48
489c9b5090e2 Initial load
duke
parents:
diff changeset
    49
  ResourceMark rm;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    50
489c9b5090e2 Initial load
duke
parents:
diff changeset
    51
  NOT_PRODUCT(TraceTime tm("ThreadRootsMarkingTask",
489c9b5090e2 Initial load
duke
parents:
diff changeset
    52
    PrintGCDetails && TraceParallelOldGCTasks, true, gclog_or_tty));
489c9b5090e2 Initial load
duke
parents:
diff changeset
    53
  ParCompactionManager* cm =
489c9b5090e2 Initial load
duke
parents:
diff changeset
    54
    ParCompactionManager::gc_thread_compaction_manager(which);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    55
  PSParallelCompact::MarkAndPushClosure mark_and_push_closure(cm);
3908
24b55ad4c228 6863023: need non-perm oops in code cache for JSR 292
jrose
parents: 1407
diff changeset
    56
  CodeBlobToOopClosure mark_and_push_in_blobs(&mark_and_push_closure, /*do_marking=*/ true);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    57
489c9b5090e2 Initial load
duke
parents:
diff changeset
    58
  if (_java_thread != NULL)
3908
24b55ad4c228 6863023: need non-perm oops in code cache for JSR 292
jrose
parents: 1407
diff changeset
    59
    _java_thread->oops_do(&mark_and_push_closure, &mark_and_push_in_blobs);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    60
489c9b5090e2 Initial load
duke
parents:
diff changeset
    61
  if (_vm_thread != NULL)
3908
24b55ad4c228 6863023: need non-perm oops in code cache for JSR 292
jrose
parents: 1407
diff changeset
    62
    _vm_thread->oops_do(&mark_and_push_closure, &mark_and_push_in_blobs);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    63
489c9b5090e2 Initial load
duke
parents:
diff changeset
    64
  // Do the real work
5076
8b74a4b60b31 4396719: Mark Sweep stack overflow on deeply nested Object arrays
jcoomes
parents: 3919
diff changeset
    65
  cm->follow_marking_stacks();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    66
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    67
489c9b5090e2 Initial load
duke
parents:
diff changeset
    68
489c9b5090e2 Initial load
duke
parents:
diff changeset
    69
void MarkFromRootsTask::do_it(GCTaskManager* manager, uint which) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    70
  assert(Universe::heap()->is_gc_active(), "called outside gc");
489c9b5090e2 Initial load
duke
parents:
diff changeset
    71
489c9b5090e2 Initial load
duke
parents:
diff changeset
    72
  NOT_PRODUCT(TraceTime tm("MarkFromRootsTask",
489c9b5090e2 Initial load
duke
parents:
diff changeset
    73
    PrintGCDetails && TraceParallelOldGCTasks, true, gclog_or_tty));
489c9b5090e2 Initial load
duke
parents:
diff changeset
    74
  ParCompactionManager* cm =
489c9b5090e2 Initial load
duke
parents:
diff changeset
    75
    ParCompactionManager::gc_thread_compaction_manager(which);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    76
  PSParallelCompact::MarkAndPushClosure mark_and_push_closure(cm);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    77
489c9b5090e2 Initial load
duke
parents:
diff changeset
    78
  switch (_root_type) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    79
    case universe:
489c9b5090e2 Initial load
duke
parents:
diff changeset
    80
      Universe::oops_do(&mark_and_push_closure);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    81
      break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    82
489c9b5090e2 Initial load
duke
parents:
diff changeset
    83
    case jni_handles:
489c9b5090e2 Initial load
duke
parents:
diff changeset
    84
      JNIHandles::oops_do(&mark_and_push_closure);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    85
      break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    86
489c9b5090e2 Initial load
duke
parents:
diff changeset
    87
    case threads:
489c9b5090e2 Initial load
duke
parents:
diff changeset
    88
    {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    89
      ResourceMark rm;
3908
24b55ad4c228 6863023: need non-perm oops in code cache for JSR 292
jrose
parents: 1407
diff changeset
    90
      CodeBlobToOopClosure each_active_code_blob(&mark_and_push_closure, /*do_marking=*/ true);
24b55ad4c228 6863023: need non-perm oops in code cache for JSR 292
jrose
parents: 1407
diff changeset
    91
      Threads::oops_do(&mark_and_push_closure, &each_active_code_blob);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    92
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
    93
    break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    94
489c9b5090e2 Initial load
duke
parents:
diff changeset
    95
    case object_synchronizer:
489c9b5090e2 Initial load
duke
parents:
diff changeset
    96
      ObjectSynchronizer::oops_do(&mark_and_push_closure);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    97
      break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    98
489c9b5090e2 Initial load
duke
parents:
diff changeset
    99
    case flat_profiler:
489c9b5090e2 Initial load
duke
parents:
diff changeset
   100
      FlatProfiler::oops_do(&mark_and_push_closure);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   101
      break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   102
489c9b5090e2 Initial load
duke
parents:
diff changeset
   103
    case management:
489c9b5090e2 Initial load
duke
parents:
diff changeset
   104
      Management::oops_do(&mark_and_push_closure);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   105
      break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   106
489c9b5090e2 Initial load
duke
parents:
diff changeset
   107
    case jvmti:
489c9b5090e2 Initial load
duke
parents:
diff changeset
   108
      JvmtiExport::oops_do(&mark_and_push_closure);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   109
      break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   110
489c9b5090e2 Initial load
duke
parents:
diff changeset
   111
    case system_dictionary:
489c9b5090e2 Initial load
duke
parents:
diff changeset
   112
      SystemDictionary::always_strong_oops_do(&mark_and_push_closure);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   113
      break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   114
3908
24b55ad4c228 6863023: need non-perm oops in code cache for JSR 292
jrose
parents: 1407
diff changeset
   115
    case code_cache:
24b55ad4c228 6863023: need non-perm oops in code cache for JSR 292
jrose
parents: 1407
diff changeset
   116
      // Do not treat nmethods as strong roots for mark/sweep, since we can unload them.
24b55ad4c228 6863023: need non-perm oops in code cache for JSR 292
jrose
parents: 1407
diff changeset
   117
      //CodeCache::scavenge_root_nmethods_do(CodeBlobToOopClosure(&mark_and_push_closure));
24b55ad4c228 6863023: need non-perm oops in code cache for JSR 292
jrose
parents: 1407
diff changeset
   118
      break;
24b55ad4c228 6863023: need non-perm oops in code cache for JSR 292
jrose
parents: 1407
diff changeset
   119
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   120
    default:
489c9b5090e2 Initial load
duke
parents:
diff changeset
   121
      fatal("Unknown root type");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   122
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   123
489c9b5090e2 Initial load
duke
parents:
diff changeset
   124
  // Do the real work
5076
8b74a4b60b31 4396719: Mark Sweep stack overflow on deeply nested Object arrays
jcoomes
parents: 3919
diff changeset
   125
  cm->follow_marking_stacks();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   126
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   127
489c9b5090e2 Initial load
duke
parents:
diff changeset
   128
489c9b5090e2 Initial load
duke
parents:
diff changeset
   129
//
489c9b5090e2 Initial load
duke
parents:
diff changeset
   130
// RefProcTaskProxy
489c9b5090e2 Initial load
duke
parents:
diff changeset
   131
//
489c9b5090e2 Initial load
duke
parents:
diff changeset
   132
489c9b5090e2 Initial load
duke
parents:
diff changeset
   133
void RefProcTaskProxy::do_it(GCTaskManager* manager, uint which)
489c9b5090e2 Initial load
duke
parents:
diff changeset
   134
{
489c9b5090e2 Initial load
duke
parents:
diff changeset
   135
  assert(Universe::heap()->is_gc_active(), "called outside gc");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   136
489c9b5090e2 Initial load
duke
parents:
diff changeset
   137
  NOT_PRODUCT(TraceTime tm("RefProcTask",
489c9b5090e2 Initial load
duke
parents:
diff changeset
   138
    PrintGCDetails && TraceParallelOldGCTasks, true, gclog_or_tty));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   139
  ParCompactionManager* cm =
489c9b5090e2 Initial load
duke
parents:
diff changeset
   140
    ParCompactionManager::gc_thread_compaction_manager(which);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   141
  PSParallelCompact::MarkAndPushClosure mark_and_push_closure(cm);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   142
  PSParallelCompact::FollowStackClosure follow_stack_closure(cm);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   143
  _rp_task.work(_work_id, *PSParallelCompact::is_alive_closure(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
   144
                mark_and_push_closure, follow_stack_closure);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   145
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   146
489c9b5090e2 Initial load
duke
parents:
diff changeset
   147
//
489c9b5090e2 Initial load
duke
parents:
diff changeset
   148
// RefProcTaskExecutor
489c9b5090e2 Initial load
duke
parents:
diff changeset
   149
//
489c9b5090e2 Initial load
duke
parents:
diff changeset
   150
489c9b5090e2 Initial load
duke
parents:
diff changeset
   151
void RefProcTaskExecutor::execute(ProcessTask& task)
489c9b5090e2 Initial load
duke
parents:
diff changeset
   152
{
489c9b5090e2 Initial load
duke
parents:
diff changeset
   153
  ParallelScavengeHeap* heap = PSParallelCompact::gc_heap();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   154
  uint parallel_gc_threads = heap->gc_task_manager()->workers();
11174
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   155
  uint active_gc_threads = heap->gc_task_manager()->active_workers();
1407
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   156
  RegionTaskQueueSet* qset = ParCompactionManager::region_array();
11174
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   157
  ParallelTaskTerminator terminator(active_gc_threads, qset);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   158
  GCTaskQueue* q = GCTaskQueue::create();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   159
  for(uint i=0; i<parallel_gc_threads; i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   160
    q->enqueue(new RefProcTaskProxy(task, i));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   161
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   162
  if (task.marks_oops_alive()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   163
    if (parallel_gc_threads>1) {
11174
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   164
      for (uint j=0; j<active_gc_threads; j++) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   165
        q->enqueue(new StealMarkingTask(&terminator));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   166
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   167
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   168
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   169
  PSParallelCompact::gc_task_manager()->execute_and_wait(q);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   170
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   171
489c9b5090e2 Initial load
duke
parents:
diff changeset
   172
void RefProcTaskExecutor::execute(EnqueueTask& task)
489c9b5090e2 Initial load
duke
parents:
diff changeset
   173
{
489c9b5090e2 Initial load
duke
parents:
diff changeset
   174
  ParallelScavengeHeap* heap = PSParallelCompact::gc_heap();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   175
  uint parallel_gc_threads = heap->gc_task_manager()->workers();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   176
  GCTaskQueue* q = GCTaskQueue::create();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   177
  for(uint i=0; i<parallel_gc_threads; i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   178
    q->enqueue(new RefEnqueueTaskProxy(task, i));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   179
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   180
  PSParallelCompact::gc_task_manager()->execute_and_wait(q);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   181
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   182
489c9b5090e2 Initial load
duke
parents:
diff changeset
   183
//
489c9b5090e2 Initial load
duke
parents:
diff changeset
   184
// StealMarkingTask
489c9b5090e2 Initial load
duke
parents:
diff changeset
   185
//
489c9b5090e2 Initial load
duke
parents:
diff changeset
   186
489c9b5090e2 Initial load
duke
parents:
diff changeset
   187
StealMarkingTask::StealMarkingTask(ParallelTaskTerminator* t) :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   188
  _terminator(t) {}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   189
489c9b5090e2 Initial load
duke
parents:
diff changeset
   190
void StealMarkingTask::do_it(GCTaskManager* manager, uint which) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   191
  assert(Universe::heap()->is_gc_active(), "called outside gc");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   192
489c9b5090e2 Initial load
duke
parents:
diff changeset
   193
  NOT_PRODUCT(TraceTime tm("StealMarkingTask",
489c9b5090e2 Initial load
duke
parents:
diff changeset
   194
    PrintGCDetails && TraceParallelOldGCTasks, true, gclog_or_tty));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   195
489c9b5090e2 Initial load
duke
parents:
diff changeset
   196
  ParCompactionManager* cm =
489c9b5090e2 Initial load
duke
parents:
diff changeset
   197
    ParCompactionManager::gc_thread_compaction_manager(which);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   198
  PSParallelCompact::MarkAndPushClosure mark_and_push_closure(cm);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   199
489c9b5090e2 Initial load
duke
parents:
diff changeset
   200
  oop obj = NULL;
5076
8b74a4b60b31 4396719: Mark Sweep stack overflow on deeply nested Object arrays
jcoomes
parents: 3919
diff changeset
   201
  ObjArrayTask task;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   202
  int random_seed = 17;
5076
8b74a4b60b31 4396719: Mark Sweep stack overflow on deeply nested Object arrays
jcoomes
parents: 3919
diff changeset
   203
  do {
8b74a4b60b31 4396719: Mark Sweep stack overflow on deeply nested Object arrays
jcoomes
parents: 3919
diff changeset
   204
    while (ParCompactionManager::steal_objarray(which, &random_seed, task)) {
8b74a4b60b31 4396719: Mark Sweep stack overflow on deeply nested Object arrays
jcoomes
parents: 3919
diff changeset
   205
      objArrayKlass* const k = (objArrayKlass*)task.obj()->blueprint();
8b74a4b60b31 4396719: Mark Sweep stack overflow on deeply nested Object arrays
jcoomes
parents: 3919
diff changeset
   206
      k->oop_follow_contents(cm, task.obj(), task.index());
8b74a4b60b31 4396719: Mark Sweep stack overflow on deeply nested Object arrays
jcoomes
parents: 3919
diff changeset
   207
      cm->follow_marking_stacks();
8b74a4b60b31 4396719: Mark Sweep stack overflow on deeply nested Object arrays
jcoomes
parents: 3919
diff changeset
   208
    }
8b74a4b60b31 4396719: Mark Sweep stack overflow on deeply nested Object arrays
jcoomes
parents: 3919
diff changeset
   209
    while (ParCompactionManager::steal(which, &random_seed, obj)) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   210
      obj->follow_contents(cm);
5076
8b74a4b60b31 4396719: Mark Sweep stack overflow on deeply nested Object arrays
jcoomes
parents: 3919
diff changeset
   211
      cm->follow_marking_stacks();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   212
    }
5076
8b74a4b60b31 4396719: Mark Sweep stack overflow on deeply nested Object arrays
jcoomes
parents: 3919
diff changeset
   213
  } while (!terminator()->offer_termination());
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   214
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   215
489c9b5090e2 Initial load
duke
parents:
diff changeset
   216
//
1407
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   217
// StealRegionCompactionTask
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   218
//
489c9b5090e2 Initial load
duke
parents:
diff changeset
   219
1407
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   220
StealRegionCompactionTask::StealRegionCompactionTask(ParallelTaskTerminator* t):
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   221
  _terminator(t) {}
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   222
1407
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   223
void StealRegionCompactionTask::do_it(GCTaskManager* manager, uint which) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   224
  assert(Universe::heap()->is_gc_active(), "called outside gc");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   225
1407
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   226
  NOT_PRODUCT(TraceTime tm("StealRegionCompactionTask",
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   227
    PrintGCDetails && TraceParallelOldGCTasks, true, gclog_or_tty));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   228
489c9b5090e2 Initial load
duke
parents:
diff changeset
   229
  ParCompactionManager* cm =
489c9b5090e2 Initial load
duke
parents:
diff changeset
   230
    ParCompactionManager::gc_thread_compaction_manager(which);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   231
11174
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   232
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   233
  // If not all threads are active, get a draining stack
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   234
  // from the list.  Else, just use this threads draining stack.
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   235
  uint which_stack_index;
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   236
  bool use_all_workers = manager->all_workers_active();
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   237
  if (use_all_workers) {
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   238
    which_stack_index = which;
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   239
    assert(manager->active_workers() == ParallelGCThreads,
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   240
           err_msg("all_workers_active has been incorrectly set: "
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   241
                   " active %d  ParallelGCThreads %d", manager->active_workers(),
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   242
                   ParallelGCThreads));
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   243
  } else {
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   244
    which_stack_index = ParCompactionManager::pop_recycled_stack_index();
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   245
  }
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   246
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   247
  cm->set_region_stack_index(which_stack_index);
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   248
  cm->set_region_stack(ParCompactionManager::region_list(which_stack_index));
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   249
  if (TraceDynamicGCThreads) {
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   250
    gclog_or_tty->print_cr("StealRegionCompactionTask::do_it "
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   251
                           "region_stack_index %d region_stack = 0x%x "
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   252
                           " empty (%d) use all workers %d",
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   253
    which_stack_index, ParCompactionManager::region_list(which_stack_index),
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   254
    cm->region_stack()->is_empty(),
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   255
    use_all_workers);
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   256
  }
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   257
1407
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   258
  // Has to drain stacks first because there may be regions on
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   259
  // preloaded onto the stack and this thread may never have
489c9b5090e2 Initial load
duke
parents:
diff changeset
   260
  // done a draining task.  Are the draining tasks needed?
489c9b5090e2 Initial load
duke
parents:
diff changeset
   261
1407
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   262
  cm->drain_region_stacks();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   263
1407
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   264
  size_t region_index = 0;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   265
  int random_seed = 17;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   266
489c9b5090e2 Initial load
duke
parents:
diff changeset
   267
  // If we're the termination task, try 10 rounds of stealing before
489c9b5090e2 Initial load
duke
parents:
diff changeset
   268
  // setting the termination flag
489c9b5090e2 Initial load
duke
parents:
diff changeset
   269
489c9b5090e2 Initial load
duke
parents:
diff changeset
   270
  while(true) {
1407
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   271
    if (ParCompactionManager::steal(which, &random_seed, region_index)) {
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   272
      PSParallelCompact::fill_and_update_region(cm, region_index);
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   273
      cm->drain_region_stacks();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   274
    } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   275
      if (terminator()->offer_termination()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   276
        break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   277
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   278
      // Go around again.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   279
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   280
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   281
  return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   282
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   283
489c9b5090e2 Initial load
duke
parents:
diff changeset
   284
UpdateDensePrefixTask::UpdateDensePrefixTask(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   285
                                   PSParallelCompact::SpaceId space_id,
1407
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   286
                                   size_t region_index_start,
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   287
                                   size_t region_index_end) :
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   288
  _space_id(space_id), _region_index_start(region_index_start),
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   289
  _region_index_end(region_index_end) {}
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   290
489c9b5090e2 Initial load
duke
parents:
diff changeset
   291
void UpdateDensePrefixTask::do_it(GCTaskManager* manager, uint which) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   292
489c9b5090e2 Initial load
duke
parents:
diff changeset
   293
  NOT_PRODUCT(TraceTime tm("UpdateDensePrefixTask",
489c9b5090e2 Initial load
duke
parents:
diff changeset
   294
    PrintGCDetails && TraceParallelOldGCTasks, true, gclog_or_tty));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   295
489c9b5090e2 Initial load
duke
parents:
diff changeset
   296
  ParCompactionManager* cm =
489c9b5090e2 Initial load
duke
parents:
diff changeset
   297
    ParCompactionManager::gc_thread_compaction_manager(which);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   298
489c9b5090e2 Initial load
duke
parents:
diff changeset
   299
  PSParallelCompact::update_and_deadwood_in_dense_prefix(cm,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   300
                                                         _space_id,
1407
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   301
                                                         _region_index_start,
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   302
                                                         _region_index_end);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   303
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   304
489c9b5090e2 Initial load
duke
parents:
diff changeset
   305
void DrainStacksCompactionTask::do_it(GCTaskManager* manager, uint which) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   306
  assert(Universe::heap()->is_gc_active(), "called outside gc");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   307
489c9b5090e2 Initial load
duke
parents:
diff changeset
   308
  NOT_PRODUCT(TraceTime tm("DrainStacksCompactionTask",
489c9b5090e2 Initial load
duke
parents:
diff changeset
   309
    PrintGCDetails && TraceParallelOldGCTasks, true, gclog_or_tty));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   310
489c9b5090e2 Initial load
duke
parents:
diff changeset
   311
  ParCompactionManager* cm =
489c9b5090e2 Initial load
duke
parents:
diff changeset
   312
    ParCompactionManager::gc_thread_compaction_manager(which);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   313
11174
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   314
  uint which_stack_index;
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   315
  bool use_all_workers = manager->all_workers_active();
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   316
  if (use_all_workers) {
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   317
    which_stack_index = which;
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   318
    assert(manager->active_workers() == ParallelGCThreads,
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   319
           err_msg("all_workers_active has been incorrectly set: "
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   320
                   " active %d  ParallelGCThreads %d", manager->active_workers(),
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   321
                   ParallelGCThreads));
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   322
  } else {
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   323
    which_stack_index = stack_index();
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   324
  }
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   325
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   326
  cm->set_region_stack(ParCompactionManager::region_list(which_stack_index));
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   327
  if (TraceDynamicGCThreads) {
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   328
    gclog_or_tty->print_cr("DrainStacksCompactionTask::do_it which = %d "
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   329
                           "which_stack_index = %d/empty(%d) "
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   330
                           "use all workers %d",
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   331
                           which, which_stack_index,
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   332
                           cm->region_stack()->is_empty(),
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   333
                           use_all_workers);
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   334
  }
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   335
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   336
  cm->set_region_stack_index(which_stack_index);
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   337
1407
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   338
  // Process any regions already in the compaction managers stacks.
9006b01ba3fd 6725697: par compact - rename class ChunkData to RegionData
jcoomes
parents: 670
diff changeset
   339
  cm->drain_region_stacks();
11174
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   340
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   341
  assert(cm->region_stack()->is_empty(), "Not empty");
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   342
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   343
  if (!use_all_workers) {
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   344
    // Always give up the region stack.
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   345
    assert(cm->region_stack() ==
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   346
           ParCompactionManager::region_list(cm->region_stack_index()),
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   347
           "region_stack and region_stack_index are inconsistent");
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   348
    ParCompactionManager::push_recycled_stack_index(cm->region_stack_index());
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   349
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   350
    if (TraceDynamicGCThreads) {
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   351
      void* old_region_stack = (void*) cm->region_stack();
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   352
      int old_region_stack_index = cm->region_stack_index();
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   353
      gclog_or_tty->print_cr("Pushing region stack 0x%x/%d",
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   354
        old_region_stack, old_region_stack_index);
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   355
    }
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   356
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   357
    cm->set_region_stack(NULL);
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   358
    cm->set_region_stack_index((uint)max_uintx);
fccee5238e70 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents: 10524
diff changeset
   359
  }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   360
}