author | stefank |
Thu, 09 May 2019 14:28:30 +0200 | |
changeset 54786 | ebf733a324d4 |
parent 53652 | 262afafdb266 |
child 57603 | f9d9bed12d1a |
child 58678 | 9cf78a70fa4f |
permissions | -rw-r--r-- |
1 | 1 |
/* |
48858
e50e326a2bfc
8194990: 3 Null pointer dereference defect groups related to CodeCache::find_blob_unsafe()
dlong
parents:
48824
diff
changeset
|
2 |
* Copyright (c) 1997, 2018, Oracle and/or its affiliates. All rights reserved. |
1 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
5547
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1
diff
changeset
|
21 |
* questions. |
1 | 22 |
* |
23 |
*/ |
|
24 |
||
7397 | 25 |
#include "precompiled.hpp" |
26 |
#include "classfile/systemDictionary.hpp" |
|
52384
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
27 |
#include "code/codeBehaviours.hpp" |
7397 | 28 |
#include "code/codeCache.hpp" |
29 |
#include "code/compiledIC.hpp" |
|
30 |
#include "code/icBuffer.hpp" |
|
31 |
#include "code/nmethod.hpp" |
|
32 |
#include "code/vtableStubs.hpp" |
|
33 |
#include "interpreter/interpreter.hpp" |
|
34 |
#include "interpreter/linkResolver.hpp" |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
35 |
#include "memory/metadataFactory.hpp" |
7397 | 36 |
#include "memory/oopFactory.hpp" |
37248 | 37 |
#include "memory/resourceArea.hpp" |
54786 | 38 |
#include "memory/universe.hpp" |
49340
4e82736053ae
8191102: Incorrect include file use in classLoader.hpp
hseigel
parents:
48858
diff
changeset
|
39 |
#include "oops/method.inline.hpp" |
7397 | 40 |
#include "oops/oop.inline.hpp" |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
41 |
#include "oops/symbol.hpp" |
49361
1956d0ec092a
8199319: Remove handles.inline.hpp include from reflectionUtils.hpp
stefank
parents:
49340
diff
changeset
|
42 |
#include "runtime/handles.inline.hpp" |
7397 | 43 |
#include "runtime/icache.hpp" |
44 |
#include "runtime/sharedRuntime.hpp" |
|
45 |
#include "runtime/stubRoutines.hpp" |
|
46 |
#include "utilities/events.hpp" |
|
1 | 47 |
|
48 |
||
49 |
// Every time a compiled IC is changed or its type is being accessed, |
|
50 |
// either the CompiledIC_lock must be set or we must be at a safe point. |
|
51 |
||
52384
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
52 |
CompiledICLocker::CompiledICLocker(CompiledMethod* method) |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
53 |
: _method(method), |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
54 |
_behaviour(CompiledICProtectionBehaviour::current()), |
53651
0331b08811ad
8216541: CompiledICHolders of VM locked unloaded nmethods are released too late
eosterlund
parents:
52858
diff
changeset
|
55 |
_locked(_behaviour->lock(_method)), |
0331b08811ad
8216541: CompiledICHolders of VM locked unloaded nmethods are released too late
eosterlund
parents:
52858
diff
changeset
|
56 |
_nsv(true, !SafepointSynchronize::is_at_safepoint()) { |
52384
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
57 |
} |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
58 |
|
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
59 |
CompiledICLocker::~CompiledICLocker() { |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
60 |
if (_locked) { |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
61 |
_behaviour->unlock(_method); |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
62 |
} |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
63 |
} |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
64 |
|
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
65 |
bool CompiledICLocker::is_safe(CompiledMethod* method) { |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
66 |
return CompiledICProtectionBehaviour::current()->is_safe(method); |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
67 |
} |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
68 |
|
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
69 |
bool CompiledICLocker::is_safe(address code) { |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
70 |
CodeBlob* cb = CodeCache::find_blob_unsafe(code); |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
71 |
assert(cb != NULL && cb->is_compiled(), "must be compiled"); |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
72 |
CompiledMethod* cm = cb->as_compiled_method(); |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
73 |
return CompiledICProtectionBehaviour::current()->is_safe(cm); |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
74 |
} |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
75 |
|
1 | 76 |
//----------------------------------------------------------------------------- |
77 |
// Low-level access to an inline cache. Private, since they might not be |
|
78 |
// MT-safe to use. |
|
79 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
80 |
void* CompiledIC::cached_value() const { |
52384
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
81 |
assert(CompiledICLocker::is_safe(_method), "mt unsafe call"); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
82 |
assert (!is_optimized(), "an optimized virtual call does not have a cached metadata"); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
83 |
|
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
84 |
if (!is_in_transition_state()) { |
42650 | 85 |
void* data = get_data(); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
86 |
// If we let the metadata value here be initialized to zero... |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
87 |
assert(data != NULL || Universe::non_oop_word() == NULL, |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
88 |
"no raw nulls in CompiledIC metadatas, because of patching races"); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
89 |
return (data == (void*)Universe::non_oop_word()) ? NULL : data; |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
90 |
} else { |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
91 |
return InlineCacheBuffer::cached_value_for((CompiledIC *)this); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
92 |
} |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
93 |
} |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
94 |
|
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
95 |
|
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
96 |
void CompiledIC::internal_set_ic_destination(address entry_point, bool is_icstub, void* cache, bool is_icholder) { |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
97 |
assert(entry_point != NULL, "must set legal entry point"); |
52384
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
98 |
assert(CompiledICLocker::is_safe(_method), "mt unsafe call"); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
99 |
assert (!is_optimized() || cache == NULL, "an optimized virtual call does not have a cached metadata"); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
100 |
assert (cache == NULL || cache != (Metadata*)badOopVal, "invalid metadata"); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
101 |
|
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
102 |
assert(!is_icholder || is_icholder_entry(entry_point), "must be"); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
103 |
|
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
104 |
// Don't use ic_destination for this test since that forwards |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
105 |
// through ICBuffer instead of returning the actual current state of |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
106 |
// the CompiledIC. |
42650 | 107 |
if (is_icholder_entry(_call->destination())) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
108 |
// When patching for the ICStub case the cached value isn't |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
109 |
// overwritten until the ICStub copied into the CompiledIC during |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
110 |
// the next safepoint. Make sure that the CompiledICHolder* is |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
111 |
// marked for release at this point since it won't be identifiable |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
112 |
// once the entry point is overwritten. |
42650 | 113 |
InlineCacheBuffer::queue_for_release((CompiledICHolder*)get_data()); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
114 |
} |
1 | 115 |
|
116 |
if (TraceCompiledIC) { |
|
117 |
tty->print(" "); |
|
118 |
print_compiled_ic(); |
|
24424
2658d7834c6e
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
22223
diff
changeset
|
119 |
tty->print(" changing destination to " INTPTR_FORMAT, p2i(entry_point)); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
120 |
if (!is_optimized()) { |
24424
2658d7834c6e
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
22223
diff
changeset
|
121 |
tty->print(" changing cached %s to " INTPTR_FORMAT, is_icholder ? "icholder" : "metadata", p2i((address)cache)); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
122 |
} |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
123 |
if (is_icstub) { |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
124 |
tty->print(" (icstub)"); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
125 |
} |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
126 |
tty->cr(); |
1 | 127 |
} |
128 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
129 |
{ |
42650 | 130 |
CodeBlob* cb = CodeCache::find_blob_unsafe(_call->instruction_address()); |
38133
78b95467b9f1
8151956: Support non-continuous CodeBlobs in HotSpot
rbackman
parents:
38035
diff
changeset
|
131 |
assert(cb != NULL && cb->is_compiled(), "must be compiled"); |
42650 | 132 |
_call->set_destination_mt_safe(entry_point); |
25492
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
133 |
} |
1 | 134 |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
135 |
if (is_optimized() || is_icstub) { |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
136 |
// Optimized call sites don't have a cache value and ICStub call |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
137 |
// sites only change the entry point. Changing the value in that |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
138 |
// case could lead to MT safety issues. |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
139 |
assert(cache == NULL, "must be null"); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
140 |
return; |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
141 |
} |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
142 |
|
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
143 |
if (cache == NULL) cache = (void*)Universe::non_oop_word(); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
144 |
|
42650 | 145 |
set_data((intptr_t)cache); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
146 |
} |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
147 |
|
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
148 |
|
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
149 |
void CompiledIC::set_ic_destination(ICStub* stub) { |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
150 |
internal_set_ic_destination(stub->code_begin(), true, NULL, false); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
151 |
} |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
152 |
|
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
153 |
|
1 | 154 |
|
155 |
address CompiledIC::ic_destination() const { |
|
52384
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
156 |
assert(CompiledICLocker::is_safe(_method), "mt unsafe call"); |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
157 |
if (!is_in_transition_state()) { |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
158 |
return _call->destination(); |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
159 |
} else { |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
160 |
return InlineCacheBuffer::ic_destination_for((CompiledIC *)this); |
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
161 |
} |
1 | 162 |
} |
163 |
||
164 |
||
165 |
bool CompiledIC::is_in_transition_state() const { |
|
52384
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
166 |
assert(CompiledICLocker::is_safe(_method), "mt unsafe call"); |
42650 | 167 |
return InlineCacheBuffer::contains(_call->destination());; |
1 | 168 |
} |
169 |
||
170 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
171 |
bool CompiledIC::is_icholder_call() const { |
52384
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
172 |
assert(CompiledICLocker::is_safe(_method), "mt unsafe call"); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
173 |
return !_is_optimized && is_icholder_entry(ic_destination()); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
174 |
} |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
175 |
|
1 | 176 |
// Returns native address of 'call' instruction in inline-cache. Used by |
177 |
// the InlineCacheBuffer when it needs to find the stub. |
|
178 |
address CompiledIC::stub_address() const { |
|
179 |
assert(is_in_transition_state(), "should only be called when we are in a transition state"); |
|
42650 | 180 |
return _call->destination(); |
1 | 181 |
} |
182 |
||
26912
19021f626ad2
8058737: CodeCache::find_blob fails with 'unsafe access to zombie method'
thartmann
parents:
26580
diff
changeset
|
183 |
// Clears the IC stub if the compiled IC is in transition state |
19021f626ad2
8058737: CodeCache::find_blob fails with 'unsafe access to zombie method'
thartmann
parents:
26580
diff
changeset
|
184 |
void CompiledIC::clear_ic_stub() { |
19021f626ad2
8058737: CodeCache::find_blob fails with 'unsafe access to zombie method'
thartmann
parents:
26580
diff
changeset
|
185 |
if (is_in_transition_state()) { |
19021f626ad2
8058737: CodeCache::find_blob fails with 'unsafe access to zombie method'
thartmann
parents:
26580
diff
changeset
|
186 |
ICStub* stub = ICStub_from_destination_address(stub_address()); |
19021f626ad2
8058737: CodeCache::find_blob fails with 'unsafe access to zombie method'
thartmann
parents:
26580
diff
changeset
|
187 |
stub->clear(); |
19021f626ad2
8058737: CodeCache::find_blob fails with 'unsafe access to zombie method'
thartmann
parents:
26580
diff
changeset
|
188 |
} |
19021f626ad2
8058737: CodeCache::find_blob fails with 'unsafe access to zombie method'
thartmann
parents:
26580
diff
changeset
|
189 |
} |
19021f626ad2
8058737: CodeCache::find_blob fails with 'unsafe access to zombie method'
thartmann
parents:
26580
diff
changeset
|
190 |
|
1 | 191 |
//----------------------------------------------------------------------------- |
192 |
// High-level access to an inline cache. Guaranteed to be MT-safe. |
|
193 |
||
25486
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
194 |
void CompiledIC::initialize_from_iter(RelocIterator* iter) { |
42650 | 195 |
assert(iter->addr() == _call->instruction_address(), "must find ic_call"); |
25486
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
196 |
|
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
197 |
if (iter->type() == relocInfo::virtual_call_type) { |
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
198 |
virtual_call_Relocation* r = iter->virtual_call_reloc(); |
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
199 |
_is_optimized = false; |
42650 | 200 |
_value = _call->get_load_instruction(r); |
25486
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
201 |
} else { |
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
202 |
assert(iter->type() == relocInfo::opt_virtual_call_type, "must be a virtual call"); |
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
203 |
_is_optimized = true; |
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
204 |
_value = NULL; |
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
205 |
} |
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
206 |
} |
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
207 |
|
38133
78b95467b9f1
8151956: Support non-continuous CodeBlobs in HotSpot
rbackman
parents:
38035
diff
changeset
|
208 |
CompiledIC::CompiledIC(CompiledMethod* cm, NativeCall* call) |
42650 | 209 |
: _method(cm) |
25359
8a19ff205f89
8047326: Consolidate all CompiledIC::CompiledIC implementations and move it to compiledIC.cpp
stefank
parents:
24424
diff
changeset
|
210 |
{ |
42650 | 211 |
_call = _method->call_wrapper_at((address) call); |
212 |
address ic_call = _call->instruction_address(); |
|
25359
8a19ff205f89
8047326: Consolidate all CompiledIC::CompiledIC implementations and move it to compiledIC.cpp
stefank
parents:
24424
diff
changeset
|
213 |
|
8a19ff205f89
8047326: Consolidate all CompiledIC::CompiledIC implementations and move it to compiledIC.cpp
stefank
parents:
24424
diff
changeset
|
214 |
assert(ic_call != NULL, "ic_call address must be set"); |
38133
78b95467b9f1
8151956: Support non-continuous CodeBlobs in HotSpot
rbackman
parents:
38035
diff
changeset
|
215 |
assert(cm != NULL, "must pass compiled method"); |
78b95467b9f1
8151956: Support non-continuous CodeBlobs in HotSpot
rbackman
parents:
38035
diff
changeset
|
216 |
assert(cm->contains(ic_call), "must be in compiled method"); |
25359
8a19ff205f89
8047326: Consolidate all CompiledIC::CompiledIC implementations and move it to compiledIC.cpp
stefank
parents:
24424
diff
changeset
|
217 |
|
8a19ff205f89
8047326: Consolidate all CompiledIC::CompiledIC implementations and move it to compiledIC.cpp
stefank
parents:
24424
diff
changeset
|
218 |
// Search for the ic_call at the given address. |
38133
78b95467b9f1
8151956: Support non-continuous CodeBlobs in HotSpot
rbackman
parents:
38035
diff
changeset
|
219 |
RelocIterator iter(cm, ic_call, ic_call+1); |
25359
8a19ff205f89
8047326: Consolidate all CompiledIC::CompiledIC implementations and move it to compiledIC.cpp
stefank
parents:
24424
diff
changeset
|
220 |
bool ret = iter.next(); |
8a19ff205f89
8047326: Consolidate all CompiledIC::CompiledIC implementations and move it to compiledIC.cpp
stefank
parents:
24424
diff
changeset
|
221 |
assert(ret == true, "relocInfo must exist at this address"); |
8a19ff205f89
8047326: Consolidate all CompiledIC::CompiledIC implementations and move it to compiledIC.cpp
stefank
parents:
24424
diff
changeset
|
222 |
assert(iter.addr() == ic_call, "must find ic_call"); |
25486
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
223 |
|
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
224 |
initialize_from_iter(&iter); |
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
225 |
} |
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
226 |
|
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
227 |
CompiledIC::CompiledIC(RelocIterator* iter) |
42650 | 228 |
: _method(iter->code()) |
25486
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
229 |
{ |
42650 | 230 |
_call = _method->call_wrapper_at(iter->addr()); |
231 |
address ic_call = _call->instruction_address(); |
|
25486
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
232 |
|
38133
78b95467b9f1
8151956: Support non-continuous CodeBlobs in HotSpot
rbackman
parents:
38035
diff
changeset
|
233 |
CompiledMethod* nm = iter->code(); |
25486
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
234 |
assert(ic_call != NULL, "ic_call address must be set"); |
38133
78b95467b9f1
8151956: Support non-continuous CodeBlobs in HotSpot
rbackman
parents:
38035
diff
changeset
|
235 |
assert(nm != NULL, "must pass compiled method"); |
78b95467b9f1
8151956: Support non-continuous CodeBlobs in HotSpot
rbackman
parents:
38035
diff
changeset
|
236 |
assert(nm->contains(ic_call), "must be in compiled method"); |
25486
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
237 |
|
be44827be5e7
8047362: Add a version of CompiledIC_at that doesn't create a new RelocIterator
stefank
parents:
25359
diff
changeset
|
238 |
initialize_from_iter(iter); |
25359
8a19ff205f89
8047326: Consolidate all CompiledIC::CompiledIC implementations and move it to compiledIC.cpp
stefank
parents:
24424
diff
changeset
|
239 |
} |
1 | 240 |
|
52857
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
241 |
// This function may fail for two reasons: either due to running out of vtable |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
242 |
// stubs, or due to running out of IC stubs in an attempted transition to a |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
243 |
// transitional state. The needs_ic_stub_refill value will be set if the failure |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
244 |
// was due to running out of IC stubs, in which case the caller will refill IC |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
245 |
// stubs and retry. |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
246 |
bool CompiledIC::set_to_megamorphic(CallInfo* call_info, Bytecodes::Code bytecode, |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
247 |
bool& needs_ic_stub_refill, TRAPS) { |
52384
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
248 |
assert(CompiledICLocker::is_safe(_method), "mt unsafe call"); |
1 | 249 |
assert(!is_optimized(), "cannot set an optimized virtual call to megamorphic"); |
250 |
assert(is_call_to_compiled() || is_call_to_interpreted(), "going directly to megamorphic?"); |
|
251 |
||
252 |
address entry; |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17094
diff
changeset
|
253 |
if (call_info->call_kind() == CallInfo::itable_call) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17094
diff
changeset
|
254 |
assert(bytecode == Bytecodes::_invokeinterface, ""); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17094
diff
changeset
|
255 |
int itable_index = call_info->itable_index(); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17094
diff
changeset
|
256 |
entry = VtableStubs::find_itable_stub(itable_index); |
48824 | 257 |
if (entry == NULL) { |
20072 | 258 |
return false; |
259 |
} |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17094
diff
changeset
|
260 |
#ifdef ASSERT |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17094
diff
changeset
|
261 |
int index = call_info->resolved_method()->itable_index(); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17094
diff
changeset
|
262 |
assert(index == itable_index, "CallInfo pre-computes this"); |
14391
df0a1573d5bd
8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
coleenp
parents:
13728
diff
changeset
|
263 |
InstanceKlass* k = call_info->resolved_method()->method_holder(); |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17094
diff
changeset
|
264 |
assert(k->verify_itable_index(itable_index), "sanity check"); |
48557 | 265 |
#endif //ASSERT |
266 |
CompiledICHolder* holder = new CompiledICHolder(call_info->resolved_method()->method_holder(), |
|
49655
d6893a76c554
8199406: Performance drop with Java JDK 1.8.0_162-b32
poonam
parents:
49361
diff
changeset
|
267 |
call_info->resolved_klass(), false); |
48557 | 268 |
holder->claim(); |
52857
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
269 |
if (!InlineCacheBuffer::create_transition_stub(this, holder, entry)) { |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
270 |
delete holder; |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
271 |
needs_ic_stub_refill = true; |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
272 |
return false; |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
273 |
} |
1 | 274 |
} else { |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17094
diff
changeset
|
275 |
assert(call_info->call_kind() == CallInfo::vtable_call, "either itable or vtable"); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17094
diff
changeset
|
276 |
// Can be different than selected_method->vtable_index(), due to package-private etc. |
1 | 277 |
int vtable_index = call_info->vtable_index(); |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17094
diff
changeset
|
278 |
assert(call_info->resolved_klass()->verify_vtable_index(vtable_index), "sanity check"); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17094
diff
changeset
|
279 |
entry = VtableStubs::find_vtable_stub(vtable_index); |
20072 | 280 |
if (entry == NULL) { |
281 |
return false; |
|
282 |
} |
|
52857
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
283 |
if (!InlineCacheBuffer::create_transition_stub(this, NULL, entry)) { |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
284 |
needs_ic_stub_refill = true; |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
285 |
return false; |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
286 |
} |
1 | 287 |
} |
288 |
||
289 |
if (TraceICs) { |
|
290 |
ResourceMark rm; |
|
51314
82adcc8ad853
8208604: Metadata::print_value_string() compares 'this' to NULL
hseigel
parents:
50416
diff
changeset
|
291 |
assert(!call_info->selected_method().is_null(), "Unexpected null selected method"); |
1 | 292 |
tty->print_cr ("IC@" INTPTR_FORMAT ": to megamorphic %s entry: " INTPTR_FORMAT, |
24424
2658d7834c6e
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
22223
diff
changeset
|
293 |
p2i(instruction_address()), call_info->selected_method()->print_value_string(), p2i(entry)); |
1 | 294 |
} |
295 |
||
296 |
// We can't check this anymore. With lazy deopt we could have already |
|
297 |
// cleaned this IC entry before we even return. This is possible if |
|
298 |
// we ran out of space in the inline cache buffer trying to do the |
|
299 |
// set_next and we safepointed to free up space. This is a benign |
|
300 |
// race because the IC entry was complete when we safepointed so |
|
301 |
// cleaning it immediately is harmless. |
|
302 |
// assert(is_megamorphic(), "sanity check"); |
|
20072 | 303 |
return true; |
1 | 304 |
} |
305 |
||
306 |
||
307 |
// true if destination is megamorphic stub |
|
308 |
bool CompiledIC::is_megamorphic() const { |
|
52384
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
309 |
assert(CompiledICLocker::is_safe(_method), "mt unsafe call"); |
1 | 310 |
assert(!is_optimized(), "an optimized call cannot be megamorphic"); |
311 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
312 |
// Cannot rely on cached_value. It is either an interface or a method. |
49655
d6893a76c554
8199406: Performance drop with Java JDK 1.8.0_162-b32
poonam
parents:
49361
diff
changeset
|
313 |
return VtableStubs::entry_point(ic_destination()) != NULL; |
1 | 314 |
} |
315 |
||
316 |
bool CompiledIC::is_call_to_compiled() const { |
|
52384
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
317 |
assert(CompiledICLocker::is_safe(_method), "mt unsafe call"); |
1 | 318 |
|
319 |
// Use unsafe, since an inline cache might point to a zombie method. However, the zombie |
|
320 |
// method is guaranteed to still exist, since we only remove methods after all inline caches |
|
321 |
// has been cleaned up |
|
322 |
CodeBlob* cb = CodeCache::find_blob_unsafe(ic_destination()); |
|
38133
78b95467b9f1
8151956: Support non-continuous CodeBlobs in HotSpot
rbackman
parents:
38035
diff
changeset
|
323 |
bool is_monomorphic = (cb != NULL && cb->is_compiled()); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
324 |
// Check that the cached_value is a klass for non-optimized monomorphic calls |
1 | 325 |
// This assertion is invalid for compiler1: a call that does not look optimized (no static stub) can be used |
33160
c59f1676d27e
8136421: JEP 243: Java-Level JVM Compiler Interface
twisti
parents:
32466
diff
changeset
|
326 |
// for calling directly to vep without using the inline cache (i.e., cached_value == NULL). |
c59f1676d27e
8136421: JEP 243: Java-Level JVM Compiler Interface
twisti
parents:
32466
diff
changeset
|
327 |
// For JVMCI this occurs because CHA is only used to improve inlining so call sites which could be optimized |
c59f1676d27e
8136421: JEP 243: Java-Level JVM Compiler Interface
twisti
parents:
32466
diff
changeset
|
328 |
// virtuals because there are no currently loaded subclasses of a type are left as virtual call sites. |
1 | 329 |
#ifdef ASSERT |
330 |
CodeBlob* caller = CodeCache::find_blob_unsafe(instruction_address()); |
|
33160
c59f1676d27e
8136421: JEP 243: Java-Level JVM Compiler Interface
twisti
parents:
32466
diff
changeset
|
331 |
bool is_c1_or_jvmci_method = caller->is_compiled_by_c1() || caller->is_compiled_by_jvmci(); |
c59f1676d27e
8136421: JEP 243: Java-Level JVM Compiler Interface
twisti
parents:
32466
diff
changeset
|
332 |
assert( is_c1_or_jvmci_method || |
1 | 333 |
!is_monomorphic || |
334 |
is_optimized() || |
|
32466
915d0c3d25aa
8134493: Cleaning inline caches of unloaded nmethods should be done in sweeper
thartmann
parents:
32401
diff
changeset
|
335 |
!caller->is_alive() || |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
336 |
(cached_metadata() != NULL && cached_metadata()->is_klass()), "sanity check"); |
1 | 337 |
#endif // ASSERT |
338 |
return is_monomorphic; |
|
339 |
} |
|
340 |
||
341 |
||
342 |
bool CompiledIC::is_call_to_interpreted() const { |
|
52384
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
343 |
assert(CompiledICLocker::is_safe(_method), "mt unsafe call"); |
1 | 344 |
// Call to interpreter if destination is either calling to a stub (if it |
345 |
// is optimized), or calling to an I2C blob |
|
346 |
bool is_call_to_interpreted = false; |
|
347 |
if (!is_optimized()) { |
|
348 |
// must use unsafe because the destination can be a zombie (and we're cleaning) |
|
349 |
// and the print_compiled_ic code wants to know if site (in the non-zombie) |
|
350 |
// is to the interpreter. |
|
351 |
CodeBlob* cb = CodeCache::find_blob_unsafe(ic_destination()); |
|
352 |
is_call_to_interpreted = (cb != NULL && cb->is_adapter_blob()); |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
353 |
assert(!is_call_to_interpreted || (is_icholder_call() && cached_icholder() != NULL), "sanity check"); |
1 | 354 |
} else { |
355 |
// Check if we are calling into our own codeblob (i.e., to a stub) |
|
356 |
address dest = ic_destination(); |
|
357 |
#ifdef ASSERT |
|
358 |
{ |
|
42650 | 359 |
_call->verify_resolve_call(dest); |
1 | 360 |
} |
361 |
#endif /* ASSERT */ |
|
42650 | 362 |
is_call_to_interpreted = _call->is_call_to_interpreted(dest); |
1 | 363 |
} |
364 |
return is_call_to_interpreted; |
|
365 |
} |
|
366 |
||
52857
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
367 |
bool CompiledIC::set_to_clean(bool in_use) { |
52384
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
368 |
assert(CompiledICLocker::is_safe(_method), "mt unsafe call"); |
1 | 369 |
if (TraceInlineCacheClearing || TraceICs) { |
24424
2658d7834c6e
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
22223
diff
changeset
|
370 |
tty->print_cr("IC@" INTPTR_FORMAT ": set to clean", p2i(instruction_address())); |
1 | 371 |
print(); |
372 |
} |
|
373 |
||
42650 | 374 |
address entry = _call->get_resolve_call_stub(is_optimized()); |
1 | 375 |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
376 |
// A zombie transition will always be safe, since the metadata has already been set to NULL, so |
1 | 377 |
// we only need to patch the destination |
52858
dad45affbdaa
8214257: IC cache not clean after cleaning assertion failure
eosterlund
parents:
52857
diff
changeset
|
378 |
bool safe_transition = _call->is_safe_for_patching() || !in_use || is_optimized() || SafepointSynchronize::is_at_safepoint(); |
1 | 379 |
|
380 |
if (safe_transition) { |
|
381 |
// Kill any leftover stub we might have too |
|
26912
19021f626ad2
8058737: CodeCache::find_blob fails with 'unsafe access to zombie method'
thartmann
parents:
26580
diff
changeset
|
382 |
clear_ic_stub(); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
383 |
if (is_optimized()) { |
32401
cc58aeaec340
8075805: Crash while trying to release CompiledICHolder
thartmann
parents:
26912
diff
changeset
|
384 |
set_ic_destination(entry); |
cc58aeaec340
8075805: Crash while trying to release CompiledICHolder
thartmann
parents:
26912
diff
changeset
|
385 |
} else { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
386 |
set_ic_destination_and_value(entry, (void*)NULL); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
387 |
} |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
388 |
} else { |
1 | 389 |
// Unsafe transition - create stub. |
52857
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
390 |
if (!InlineCacheBuffer::create_transition_stub(this, NULL, entry)) { |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
391 |
return false; |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
392 |
} |
1 | 393 |
} |
394 |
// We can't check this anymore. With lazy deopt we could have already |
|
395 |
// cleaned this IC entry before we even return. This is possible if |
|
396 |
// we ran out of space in the inline cache buffer trying to do the |
|
397 |
// set_next and we safepointed to free up space. This is a benign |
|
398 |
// race because the IC entry was complete when we safepointed so |
|
399 |
// cleaning it immediately is harmless. |
|
400 |
// assert(is_clean(), "sanity check"); |
|
52857
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
401 |
return true; |
1 | 402 |
} |
403 |
||
404 |
bool CompiledIC::is_clean() const { |
|
52384
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
405 |
assert(CompiledICLocker::is_safe(_method), "mt unsafe call"); |
1 | 406 |
bool is_clean = false; |
407 |
address dest = ic_destination(); |
|
42650 | 408 |
is_clean = dest == _call->get_resolve_call_stub(is_optimized()); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
409 |
assert(!is_clean || is_optimized() || cached_value() == NULL, "sanity check"); |
1 | 410 |
return is_clean; |
411 |
} |
|
412 |
||
52857
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
413 |
bool CompiledIC::set_to_monomorphic(CompiledICInfo& info) { |
52384
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
414 |
assert(CompiledICLocker::is_safe(_method), "mt unsafe call"); |
1 | 415 |
// Updating a cache to the wrong entry can cause bugs that are very hard |
416 |
// to track down - if cache entry gets invalid - we just clean it. In |
|
417 |
// this way it is always the same code path that is responsible for |
|
418 |
// updating and resolving an inline cache |
|
419 |
// |
|
420 |
// The above is no longer true. SharedRuntime::fixup_callers_callsite will change optimized |
|
421 |
// callsites. In addition ic_miss code will update a site to monomorphic if it determines |
|
422 |
// that an monomorphic call to the interpreter can now be monomorphic to compiled code. |
|
423 |
// |
|
424 |
// In both of these cases the only thing being modifed is the jump/call target and these |
|
425 |
// transitions are mt_safe |
|
426 |
||
427 |
Thread *thread = Thread::current(); |
|
42650 | 428 |
if (info.to_interpreter() || info.to_aot()) { |
1 | 429 |
// Call to interpreter |
430 |
if (info.is_optimized() && is_optimized()) { |
|
52858
dad45affbdaa
8214257: IC cache not clean after cleaning assertion failure
eosterlund
parents:
52857
diff
changeset
|
431 |
assert(is_clean(), "unsafe IC path"); |
1 | 432 |
// the call analysis (callee structure) specifies that the call is optimized |
433 |
// (either because of CHA or the static target is final) |
|
434 |
// At code generation time, this call has been emitted as static call |
|
435 |
// Call via stub |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
436 |
assert(info.cached_metadata() != NULL && info.cached_metadata()->is_method(), "sanity check"); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
437 |
methodHandle method (thread, (Method*)info.cached_metadata()); |
42650 | 438 |
_call->set_to_interpreted(method, info); |
439 |
||
1 | 440 |
if (TraceICs) { |
441 |
ResourceMark rm(thread); |
|
42650 | 442 |
tty->print_cr ("IC@" INTPTR_FORMAT ": monomorphic to %s: %s", |
24424
2658d7834c6e
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
22223
diff
changeset
|
443 |
p2i(instruction_address()), |
42650 | 444 |
(info.to_aot() ? "aot" : "interpreter"), |
1 | 445 |
method->print_value_string()); |
446 |
} |
|
447 |
} else { |
|
448 |
// Call via method-klass-holder |
|
52857
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
449 |
CompiledICHolder* holder = info.claim_cached_icholder(); |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
450 |
if (!InlineCacheBuffer::create_transition_stub(this, holder, info.entry())) { |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
451 |
delete holder; |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
452 |
return false; |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
453 |
} |
1 | 454 |
if (TraceICs) { |
455 |
ResourceMark rm(thread); |
|
24424
2658d7834c6e
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
22223
diff
changeset
|
456 |
tty->print_cr ("IC@" INTPTR_FORMAT ": monomorphic to interpreter via icholder ", p2i(instruction_address())); |
1 | 457 |
} |
458 |
} |
|
459 |
} else { |
|
460 |
// Call to compiled code |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
461 |
bool static_bound = info.is_optimized() || (info.cached_metadata() == NULL); |
1 | 462 |
#ifdef ASSERT |
463 |
CodeBlob* cb = CodeCache::find_blob_unsafe(info.entry()); |
|
48858
e50e326a2bfc
8194990: 3 Null pointer dereference defect groups related to CodeCache::find_blob_unsafe()
dlong
parents:
48824
diff
changeset
|
464 |
assert (cb != NULL && cb->is_compiled(), "must be compiled!"); |
1 | 465 |
#endif /* ASSERT */ |
466 |
||
467 |
// This is MT safe if we come from a clean-cache and go through a |
|
468 |
// non-verified entry point |
|
469 |
bool safe = SafepointSynchronize::is_at_safepoint() || |
|
470 |
(!is_in_transition_state() && (info.is_optimized() || static_bound || is_clean())); |
|
471 |
||
472 |
if (!safe) { |
|
52857
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
473 |
if (!InlineCacheBuffer::create_transition_stub(this, info.cached_metadata(), info.entry())) { |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
474 |
return false; |
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
475 |
} |
1 | 476 |
} else { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
477 |
if (is_optimized()) { |
35086
bbf32241d851
8072008: Emit direct call instead of linkTo* for recursive indy/MH.invoke* calls
vlivanov
parents:
33593
diff
changeset
|
478 |
set_ic_destination(info.entry()); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
479 |
} else { |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
480 |
set_ic_destination_and_value(info.entry(), info.cached_metadata()); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
481 |
} |
1 | 482 |
} |
483 |
||
484 |
if (TraceICs) { |
|
485 |
ResourceMark rm(thread); |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
486 |
assert(info.cached_metadata() == NULL || info.cached_metadata()->is_klass(), "must be"); |
53415 | 487 |
tty->print_cr ("IC@" INTPTR_FORMAT ": monomorphic to compiled (rcvr klass = %s) %s", |
24424
2658d7834c6e
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
22223
diff
changeset
|
488 |
p2i(instruction_address()), |
53415 | 489 |
(info.cached_metadata() != NULL) ? ((Klass*)info.cached_metadata())->print_value_string() : "NULL", |
490 |
(safe) ? "" : " via stub"); |
|
1 | 491 |
} |
492 |
} |
|
493 |
// We can't check this anymore. With lazy deopt we could have already |
|
494 |
// cleaned this IC entry before we even return. This is possible if |
|
495 |
// we ran out of space in the inline cache buffer trying to do the |
|
496 |
// set_next and we safepointed to free up space. This is a benign |
|
497 |
// race because the IC entry was complete when we safepointed so |
|
498 |
// cleaning it immediately is harmless. |
|
499 |
// assert(is_call_to_compiled() || is_call_to_interpreted(), "sanity check"); |
|
52857
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
500 |
return true; |
1 | 501 |
} |
502 |
||
503 |
||
42544
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
504 |
// is_optimized: Compiler has generated an optimized call (i.e. fixed, no inline cache) |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
505 |
// static_bound: The call can be static bound. If it isn't also optimized, the property |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
506 |
// wasn't provable at time of compilation. An optimized call will have any necessary |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
507 |
// null check, while a static_bound won't. A static_bound (but not optimized) must |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
508 |
// therefore use the unverified entry point. |
33593
60764a78fa5c
8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents:
33160
diff
changeset
|
509 |
void CompiledIC::compute_monomorphic_entry(const methodHandle& method, |
46329
53ccc37bda19
8155672: Remove instanceKlassHandles and KlassHandles
coleenp
parents:
42650
diff
changeset
|
510 |
Klass* receiver_klass, |
1 | 511 |
bool is_optimized, |
512 |
bool static_bound, |
|
42650 | 513 |
bool caller_is_nmethod, |
1 | 514 |
CompiledICInfo& info, |
515 |
TRAPS) { |
|
38133
78b95467b9f1
8151956: Support non-continuous CodeBlobs in HotSpot
rbackman
parents:
38035
diff
changeset
|
516 |
CompiledMethod* method_code = method->code(); |
78b95467b9f1
8151956: Support non-continuous CodeBlobs in HotSpot
rbackman
parents:
38035
diff
changeset
|
517 |
|
1 | 518 |
address entry = NULL; |
22223 | 519 |
if (method_code != NULL && method_code->is_in_use()) { |
38133
78b95467b9f1
8151956: Support non-continuous CodeBlobs in HotSpot
rbackman
parents:
38035
diff
changeset
|
520 |
assert(method_code->is_compiled(), "must be compiled"); |
1 | 521 |
// Call to compiled code |
42544
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
522 |
// |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
523 |
// Note: the following problem exists with Compiler1: |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
524 |
// - at compile time we may or may not know if the destination is final |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
525 |
// - if we know that the destination is final (is_optimized), we will emit |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
526 |
// an optimized virtual call (no inline cache), and need a Method* to make |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
527 |
// a call to the interpreter |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
528 |
// - if we don't know if the destination is final, we emit a standard |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
529 |
// virtual call, and use CompiledICHolder to call interpreted code |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
530 |
// (no static call stub has been generated) |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
531 |
// - In the case that we here notice the call is static bound we |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
532 |
// convert the call into what looks to be an optimized virtual call, |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
533 |
// but we must use the unverified entry point (since there will be no |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
534 |
// null check on a call when the target isn't loaded). |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
535 |
// This causes problems when verifying the IC because |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
536 |
// it looks vanilla but is optimized. Code in is_call_to_interpreted |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
537 |
// is aware of this and weakens its asserts. |
58de8aaf9365
8160543: C1: Crash in java.lang.String.indexOf in some java.sql tests
neliasso
parents:
38133
diff
changeset
|
538 |
if (is_optimized) { |
1 | 539 |
entry = method_code->verified_entry_point(); |
540 |
} else { |
|
541 |
entry = method_code->entry_point(); |
|
542 |
} |
|
543 |
} |
|
42650 | 544 |
bool far_c2a = entry != NULL && caller_is_nmethod && method_code->is_far_code(); |
545 |
if (entry != NULL && !far_c2a) { |
|
546 |
// Call to near compiled code (nmethod or aot). |
|
48001
600868bd3a8c
8169766: c1 + Xcomp reresolving call target every invocation
neliasso
parents:
47216
diff
changeset
|
547 |
info.set_compiled_entry(entry, is_optimized ? NULL : receiver_klass, is_optimized); |
1 | 548 |
} else { |
549 |
if (is_optimized) { |
|
42650 | 550 |
if (far_c2a) { |
551 |
// Call to aot code from nmethod. |
|
552 |
info.set_aot_entry(entry, method()); |
|
553 |
} else { |
|
554 |
// Use stub entry |
|
555 |
info.set_interpreter_entry(method()->get_c2i_entry(), method()); |
|
556 |
} |
|
1 | 557 |
} else { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
558 |
// Use icholder entry |
38133
78b95467b9f1
8151956: Support non-continuous CodeBlobs in HotSpot
rbackman
parents:
38035
diff
changeset
|
559 |
assert(method_code == NULL || method_code->is_compiled(), "must be compiled"); |
46329
53ccc37bda19
8155672: Remove instanceKlassHandles and KlassHandles
coleenp
parents:
42650
diff
changeset
|
560 |
CompiledICHolder* holder = new CompiledICHolder(method(), receiver_klass); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
561 |
info.set_icholder_entry(method()->get_c2i_unverified_entry(), holder); |
1 | 562 |
} |
563 |
} |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
564 |
assert(info.is_optimized() == is_optimized, "must agree"); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
565 |
} |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
566 |
|
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
567 |
|
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
568 |
bool CompiledIC::is_icholder_entry(address entry) { |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
569 |
CodeBlob* cb = CodeCache::find_blob_unsafe(entry); |
48557 | 570 |
if (cb != NULL && cb->is_adapter_blob()) { |
571 |
return true; |
|
572 |
} |
|
573 |
// itable stubs also use CompiledICHolder |
|
49655
d6893a76c554
8199406: Performance drop with Java JDK 1.8.0_162-b32
poonam
parents:
49361
diff
changeset
|
574 |
if (cb != NULL && cb->is_vtable_blob()) { |
d6893a76c554
8199406: Performance drop with Java JDK 1.8.0_162-b32
poonam
parents:
49361
diff
changeset
|
575 |
VtableStub* s = VtableStubs::entry_point(entry); |
d6893a76c554
8199406: Performance drop with Java JDK 1.8.0_162-b32
poonam
parents:
49361
diff
changeset
|
576 |
return (s != NULL) && s->is_itable_stub(); |
48557 | 577 |
} |
49655
d6893a76c554
8199406: Performance drop with Java JDK 1.8.0_162-b32
poonam
parents:
49361
diff
changeset
|
578 |
|
48557 | 579 |
return false; |
1 | 580 |
} |
581 |
||
42650 | 582 |
bool CompiledIC::is_icholder_call_site(virtual_call_Relocation* call_site, const CompiledMethod* cm) { |
583 |
// This call site might have become stale so inspect it carefully. |
|
584 |
address dest = cm->call_wrapper_at(call_site->addr())->destination(); |
|
585 |
return is_icholder_entry(dest); |
|
586 |
} |
|
587 |
||
1 | 588 |
// ---------------------------------------------------------------------------- |
589 |
||
52857
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
590 |
bool CompiledStaticCall::set_to_clean(bool in_use) { |
50416
ef980b9ac191
8203837: Split nmethod unloading from inline cache cleaning
coleenp
parents:
49655
diff
changeset
|
591 |
// in_use is unused but needed to match template function in CompiledMethod |
52384
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
592 |
assert(CompiledICLocker::is_safe(instruction_address()), "mt unsafe call"); |
1 | 593 |
// Reset call site |
42650 | 594 |
set_destination_mt_safe(resolve_call_stub()); |
1 | 595 |
|
596 |
// Do not reset stub here: It is too expensive to call find_stub. |
|
597 |
// Instead, rely on caller (nmethod::clear_inline_caches) to clear |
|
598 |
// both the call and its stub. |
|
52857
7e268f863ff0
8214338: Move IC stub refilling out of IC cache transitions
eosterlund
parents:
52384
diff
changeset
|
599 |
return true; |
1 | 600 |
} |
601 |
||
602 |
bool CompiledStaticCall::is_clean() const { |
|
42650 | 603 |
return destination() == resolve_call_stub(); |
1 | 604 |
} |
605 |
||
606 |
bool CompiledStaticCall::is_call_to_compiled() const { |
|
607 |
return CodeCache::contains(destination()); |
|
608 |
} |
|
609 |
||
42650 | 610 |
bool CompiledDirectStaticCall::is_call_to_interpreted() const { |
1 | 611 |
// It is a call to interpreted, if it calls to a stub. Hence, the destination |
612 |
// must be in the stub part of the nmethod that contains the call |
|
38133
78b95467b9f1
8151956: Support non-continuous CodeBlobs in HotSpot
rbackman
parents:
38035
diff
changeset
|
613 |
CompiledMethod* cm = CodeCache::find_compiled(instruction_address()); |
78b95467b9f1
8151956: Support non-continuous CodeBlobs in HotSpot
rbackman
parents:
38035
diff
changeset
|
614 |
return cm->stub_contains(destination()); |
1 | 615 |
} |
616 |
||
42650 | 617 |
bool CompiledDirectStaticCall::is_call_to_far() const { |
618 |
// It is a call to aot method, if it calls to a stub. Hence, the destination |
|
619 |
// must be in the stub part of the nmethod that contains the call |
|
620 |
CodeBlob* desc = CodeCache::find_blob(instruction_address()); |
|
621 |
return desc->as_compiled_method()->stub_contains(destination()); |
|
622 |
} |
|
623 |
||
624 |
void CompiledStaticCall::set_to_compiled(address entry) { |
|
625 |
if (TraceICs) { |
|
626 |
ResourceMark rm; |
|
627 |
tty->print_cr("%s@" INTPTR_FORMAT ": set_to_compiled " INTPTR_FORMAT, |
|
628 |
name(), |
|
629 |
p2i(instruction_address()), |
|
630 |
p2i(entry)); |
|
631 |
} |
|
632 |
// Call to compiled code |
|
633 |
assert(CodeCache::contains(entry), "wrong entry point"); |
|
634 |
set_destination_mt_safe(entry); |
|
635 |
} |
|
636 |
||
1 | 637 |
void CompiledStaticCall::set(const StaticCallInfo& info) { |
52384
d6dc479bcdd3
8212681: Refactor IC locking to use a fine grained CompiledICLocker
eosterlund
parents:
51314
diff
changeset
|
638 |
assert(CompiledICLocker::is_safe(instruction_address()), "mt unsafe call"); |
1 | 639 |
// Updating a cache to the wrong entry can cause bugs that are very hard |
640 |
// to track down - if cache entry gets invalid - we just clean it. In |
|
641 |
// this way it is always the same code path that is responsible for |
|
642 |
// updating and resolving an inline cache |
|
643 |
assert(is_clean(), "do not update a call entry - use clean"); |
|
644 |
||
645 |
if (info._to_interpreter) { |
|
646 |
// Call to interpreted code |
|
647 |
set_to_interpreted(info.callee(), info.entry()); |
|
42650 | 648 |
#if INCLUDE_AOT |
649 |
} else if (info._to_aot) { |
|
650 |
// Call to far code |
|
651 |
set_to_far(info.callee(), info.entry()); |
|
652 |
#endif |
|
1 | 653 |
} else { |
42650 | 654 |
set_to_compiled(info.entry()); |
1 | 655 |
} |
656 |
} |
|
657 |
||
658 |
// Compute settings for a CompiledStaticCall. Since we might have to set |
|
659 |
// the stub when calling to the interpreter, we need to return arguments. |
|
42650 | 660 |
void CompiledStaticCall::compute_entry(const methodHandle& m, bool caller_is_nmethod, StaticCallInfo& info) { |
38133
78b95467b9f1
8151956: Support non-continuous CodeBlobs in HotSpot
rbackman
parents:
38035
diff
changeset
|
661 |
CompiledMethod* m_code = m->code(); |
1 | 662 |
info._callee = m; |
22223 | 663 |
if (m_code != NULL && m_code->is_in_use()) { |
42650 | 664 |
if (caller_is_nmethod && m_code->is_far_code()) { |
665 |
// Call to far aot code from nmethod. |
|
666 |
info._to_aot = true; |
|
667 |
} else { |
|
668 |
info._to_aot = false; |
|
669 |
} |
|
1 | 670 |
info._to_interpreter = false; |
671 |
info._entry = m_code->verified_entry_point(); |
|
672 |
} else { |
|
673 |
// Callee is interpreted code. In any case entering the interpreter |
|
674 |
// puts a converter-frame on the stack to save arguments. |
|
26580
8cca7fbe77b8
8056154: JVM crash with EXCEPTION_ACCESS_VIOLATION when there are many threads running
iveresov
parents:
25492
diff
changeset
|
675 |
assert(!m->is_method_handle_intrinsic(), "Compiled code should never call interpreter MH intrinsics"); |
1 | 676 |
info._to_interpreter = true; |
677 |
info._entry = m()->get_c2i_entry(); |
|
678 |
} |
|
679 |
} |
|
680 |
||
42650 | 681 |
address CompiledDirectStaticCall::find_stub_for(address instruction, bool is_aot) { |
1 | 682 |
// Find reloc. information containing this call-site |
42650 | 683 |
RelocIterator iter((nmethod*)NULL, instruction); |
1 | 684 |
while (iter.next()) { |
42650 | 685 |
if (iter.addr() == instruction) { |
1 | 686 |
switch(iter.type()) { |
687 |
case relocInfo::static_call_type: |
|
42650 | 688 |
return iter.static_call_reloc()->static_stub(is_aot); |
1 | 689 |
// We check here for opt_virtual_call_type, since we reuse the code |
690 |
// from the CompiledIC implementation |
|
691 |
case relocInfo::opt_virtual_call_type: |
|
42650 | 692 |
return iter.opt_virtual_call_reloc()->static_stub(is_aot); |
1 | 693 |
case relocInfo::poll_type: |
694 |
case relocInfo::poll_return_type: // A safepoint can't overlap a call. |
|
695 |
default: |
|
696 |
ShouldNotReachHere(); |
|
697 |
} |
|
698 |
} |
|
699 |
} |
|
700 |
return NULL; |
|
701 |
} |
|
702 |
||
42650 | 703 |
address CompiledDirectStaticCall::find_stub(bool is_aot) { |
704 |
return CompiledDirectStaticCall::find_stub_for(instruction_address(), is_aot); |
|
705 |
} |
|
706 |
||
707 |
address CompiledDirectStaticCall::resolve_call_stub() const { |
|
708 |
return SharedRuntime::get_resolve_static_call_stub(); |
|
709 |
} |
|
1 | 710 |
|
711 |
//----------------------------------------------------------------------------- |
|
712 |
// Non-product mode code |
|
713 |
#ifndef PRODUCT |
|
714 |
||
715 |
void CompiledIC::verify() { |
|
42650 | 716 |
_call->verify(); |
1 | 717 |
assert(is_clean() || is_call_to_compiled() || is_call_to_interpreted() |
718 |
|| is_optimized() || is_megamorphic(), "sanity check"); |
|
719 |
} |
|
720 |
||
721 |
void CompiledIC::print() { |
|
722 |
print_compiled_ic(); |
|
723 |
tty->cr(); |
|
724 |
} |
|
725 |
||
726 |
void CompiledIC::print_compiled_ic() { |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
11636
diff
changeset
|
727 |
tty->print("Inline cache at " INTPTR_FORMAT ", calling %s " INTPTR_FORMAT " cached_value " INTPTR_FORMAT, |
24424
2658d7834c6e
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
22223
diff
changeset
|
728 |
p2i(instruction_address()), is_call_to_interpreted() ? "interpreted " : "", p2i(ic_destination()), p2i(is_optimized() ? NULL : cached_value())); |
1 | 729 |
} |
730 |
||
42650 | 731 |
void CompiledDirectStaticCall::print() { |
24424
2658d7834c6e
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
22223
diff
changeset
|
732 |
tty->print("static call at " INTPTR_FORMAT " -> ", p2i(instruction_address())); |
1 | 733 |
if (is_clean()) { |
734 |
tty->print("clean"); |
|
735 |
} else if (is_call_to_compiled()) { |
|
736 |
tty->print("compiled"); |
|
42650 | 737 |
} else if (is_call_to_far()) { |
738 |
tty->print("far"); |
|
1 | 739 |
} else if (is_call_to_interpreted()) { |
740 |
tty->print("interpreted"); |
|
741 |
} |
|
742 |
tty->cr(); |
|
743 |
} |
|
744 |
||
17094
29c4955396d2
8003853: specify offset of IC load in java_to_interp stub
dlong
parents:
16377
diff
changeset
|
745 |
#endif // !PRODUCT |