src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyUnsafeAccess.java
author jwilhelm
Thu, 27 Jun 2019 03:33:44 +0200
changeset 55509 d58442b8abc1
parent 54328 37648a9c4a6a
permissions -rw-r--r--
8225497: Update Graal Reviewed-by: kvn
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
54328
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     1
/*
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     2
 * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     4
 *
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     7
 * published by the Free Software Foundation.
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     8
 *
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    13
 * accompanied this code).
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    14
 *
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    18
 *
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    21
 * questions.
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    22
 */
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    23
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    24
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    25
package org.graalvm.compiler.core.test;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    26
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    27
import static java.lang.reflect.Modifier.isProtected;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    28
import static java.lang.reflect.Modifier.isPublic;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    29
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    30
import java.lang.reflect.Field;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    31
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    32
import org.graalvm.compiler.core.common.type.TypeReference;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    33
import org.graalvm.compiler.nodes.StructuredGraph;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    34
import org.graalvm.compiler.nodes.java.InstanceOfNode;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    35
import org.graalvm.compiler.nodes.java.MethodCallTargetNode;
55509
d58442b8abc1 8225497: Update Graal
jwilhelm
parents: 54328
diff changeset
    36
import org.graalvm.compiler.nodes.spi.CoreProviders;
54328
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    37
import org.graalvm.compiler.phases.VerifyPhase;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    38
import org.graalvm.compiler.serviceprovider.GraalUnsafeAccess;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    39
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    40
import jdk.vm.ci.meta.MetaAccessProvider;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    41
import jdk.vm.ci.meta.ResolvedJavaMethod;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    42
import jdk.vm.ci.meta.ResolvedJavaType;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    43
import sun.misc.Unsafe;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    44
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    45
/**
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    46
 * Checks that the {@link Unsafe} singleton instance is only accessed via well known classes such as
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    47
 * {@link GraalUnsafeAccess}.
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    48
 */
55509
d58442b8abc1 8225497: Update Graal
jwilhelm
parents: 54328
diff changeset
    49
public class VerifyUnsafeAccess extends VerifyPhase<CoreProviders> {
54328
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    50
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    51
    @Override
55509
d58442b8abc1 8225497: Update Graal
jwilhelm
parents: 54328
diff changeset
    52
    protected void verify(StructuredGraph graph, CoreProviders context) {
54328
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    53
        MetaAccessProvider metaAccess = context.getMetaAccess();
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    54
        final ResolvedJavaType unsafeType = metaAccess.lookupJavaType(Unsafe.class);
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    55
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    56
        ResolvedJavaMethod caller = graph.method();
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    57
        String holderQualified = caller.format("%H");
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    58
        String holderUnqualified = caller.format("%h");
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    59
        String packageName = holderQualified.equals(holderUnqualified) ? "" : holderQualified.substring(0, holderQualified.length() - holderUnqualified.length() - 1);
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    60
        if ((holderQualified.equals(GraalUnsafeAccess.class.getName()) ||
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    61
                        holderQualified.equals("jdk.vm.ci.hotspot.UnsafeAccess")) &&
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    62
                        caller.getName().equals("initUnsafe")) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    63
            // This is the blessed way access Unsafe in Graal and JVMCI
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    64
            return;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    65
        } else if (packageName.startsWith("com.oracle.truffle") || packageName.startsWith("org.graalvm.compiler.truffle.runtime")) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    66
            // Truffle and GraalTruffleRuntime do not depend on Graal and so cannot use
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    67
            // GraalUnsafeAccess
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    68
            return;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    69
        }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    70
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    71
        if (caller.getSignature().getReturnType(caller.getDeclaringClass()).equals(unsafeType)) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    72
            if (caller.isPublic()) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    73
                if (holderQualified.equals(GraalUnsafeAccess.class.getName()) && caller.getName().equals("getUnsafe")) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    74
                    // pass
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    75
                } else {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    76
                    throw new VerificationError("Cannot leak Unsafe from public method %s",
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    77
                                    caller.format("%H.%n(%p)"));
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    78
                }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    79
            }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    80
        }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    81
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    82
        for (InstanceOfNode node : graph.getNodes().filter(InstanceOfNode.class)) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    83
            TypeReference typeRef = node.type();
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    84
            if (typeRef != null) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    85
                if (unsafeType.isAssignableFrom(typeRef.getType())) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    86
                    throw new VerificationError("Cast to %s in %s is prohibited as it implies accessing Unsafe.theUnsafe via reflection. Use %s.getUnsafe() instead.",
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    87
                                    unsafeType.toJavaName(),
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    88
                                    caller.format("%H.%n(%p)"),
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    89
                                    GraalUnsafeAccess.class.getName());
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    90
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    91
                }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    92
            }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    93
        }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    94
        for (MethodCallTargetNode t : graph.getNodes(MethodCallTargetNode.TYPE)) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    95
            ResolvedJavaMethod callee = t.targetMethod();
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    96
            if (callee.getDeclaringClass().equals(unsafeType)) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    97
                if (callee.getName().equals("getUnsafe")) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    98
                    throw new VerificationError("Call to %s at callsite %s is prohibited. Use %s.getUnsafe() instead.",
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    99
                                    callee.format("%H.%n(%p)"),
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   100
                                    caller.format("%H.%n(%p)"),
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   101
                                    GraalUnsafeAccess.class.getName());
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   102
                }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   103
            }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   104
        }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   105
    }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   106
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   107
    @Override
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   108
    public void verifyClass(Class<?> c, MetaAccessProvider metaAccess) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   109
        for (Field field : c.getDeclaredFields()) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   110
            int modifiers = field.getModifiers();
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   111
            if (field.getType() == Unsafe.class && (isPublic(modifiers) || isProtected(modifiers))) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   112
                throw new VerificationError("Field of type %s must be private or package-private: %s", Unsafe.class.getName(), field);
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   113
            }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   114
        }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   115
    }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   116
}