hotspot/src/share/vm/services/memoryManager.cpp
author coleenp
Fri, 23 Mar 2012 11:16:05 -0400
changeset 12263 d20640f4f8fe
parent 11591 854c0dff3844
child 13195 be27e1b6a4b9
permissions -rw-r--r--
7150058: Allocate symbols from null boot loader to an arena for NMT Summary: Move symbol allocation to an arena so NMT doesn't have to track them at startup. Reviewed-by: never, kamg, zgu
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
     1
/*
8921
14bfe81f2a9d 7010070: Update all 2010 Oracle-changed OpenJDK files to have the proper copyright dates - second pass
trims
parents: 8076
diff changeset
     2
 * Copyright (c) 2003, 2011, Oracle and/or its affiliates. All rights reserved.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
489c9b5090e2 Initial load
duke
parents:
diff changeset
     4
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
489c9b5090e2 Initial load
duke
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
489c9b5090e2 Initial load
duke
parents:
diff changeset
     7
 * published by the Free Software Foundation.
489c9b5090e2 Initial load
duke
parents:
diff changeset
     8
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
489c9b5090e2 Initial load
duke
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
489c9b5090e2 Initial load
duke
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
489c9b5090e2 Initial load
duke
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
489c9b5090e2 Initial load
duke
parents:
diff changeset
    13
 * accompanied this code).
489c9b5090e2 Initial load
duke
parents:
diff changeset
    14
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
489c9b5090e2 Initial load
duke
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
489c9b5090e2 Initial load
duke
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    18
 *
5547
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4459
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4459
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4459
diff changeset
    21
 * questions.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    22
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
    23
 */
489c9b5090e2 Initial load
duke
parents:
diff changeset
    24
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6245
diff changeset
    25
#include "precompiled.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6245
diff changeset
    26
#include "classfile/systemDictionary.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6245
diff changeset
    27
#include "classfile/vmSymbols.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6245
diff changeset
    28
#include "oops/oop.inline.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6245
diff changeset
    29
#include "runtime/handles.inline.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6245
diff changeset
    30
#include "runtime/javaCalls.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6245
diff changeset
    31
#include "services/lowMemoryDetector.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6245
diff changeset
    32
#include "services/management.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6245
diff changeset
    33
#include "services/memoryManager.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6245
diff changeset
    34
#include "services/memoryPool.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6245
diff changeset
    35
#include "services/memoryService.hpp"
9623
151c0b638488 7036199: Adding a notification to the implementation of GarbageCollectorMXBeans
fparain
parents: 8921
diff changeset
    36
#include "services/gcNotifier.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6245
diff changeset
    37
#include "utilities/dtrace.hpp"
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    38
10739
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
    39
#ifndef USDT2
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    40
HS_DTRACE_PROBE_DECL8(hotspot, mem__pool__gc__begin, char*, int, char*, int,
489c9b5090e2 Initial load
duke
parents:
diff changeset
    41
  size_t, size_t, size_t, size_t);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    42
HS_DTRACE_PROBE_DECL8(hotspot, mem__pool__gc__end, char*, int, char*, int,
489c9b5090e2 Initial load
duke
parents:
diff changeset
    43
  size_t, size_t, size_t, size_t);
10739
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
    44
#endif /* !USDT2 */
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    45
489c9b5090e2 Initial load
duke
parents:
diff changeset
    46
MemoryManager::MemoryManager() {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    47
  _num_pools = 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    48
  _memory_mgr_obj = NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    49
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    50
489c9b5090e2 Initial load
duke
parents:
diff changeset
    51
void MemoryManager::add_pool(MemoryPool* pool) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    52
  assert(_num_pools < MemoryManager::max_num_pools, "_num_pools exceeds the max");
489c9b5090e2 Initial load
duke
parents:
diff changeset
    53
  if (_num_pools < MemoryManager::max_num_pools) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    54
    _pools[_num_pools] = pool;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    55
    _num_pools++;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    56
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
    57
  pool->add_manager(this);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    58
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    59
489c9b5090e2 Initial load
duke
parents:
diff changeset
    60
MemoryManager* MemoryManager::get_code_cache_memory_manager() {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    61
  return (MemoryManager*) new CodeCacheMemoryManager();
489c9b5090e2 Initial load
duke
parents:
diff changeset
    62
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    63
489c9b5090e2 Initial load
duke
parents:
diff changeset
    64
GCMemoryManager* MemoryManager::get_copy_memory_manager() {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    65
  return (GCMemoryManager*) new CopyMemoryManager();
489c9b5090e2 Initial load
duke
parents:
diff changeset
    66
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    67
489c9b5090e2 Initial load
duke
parents:
diff changeset
    68
GCMemoryManager* MemoryManager::get_msc_memory_manager() {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    69
  return (GCMemoryManager*) new MSCMemoryManager();
489c9b5090e2 Initial load
duke
parents:
diff changeset
    70
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    71
489c9b5090e2 Initial load
duke
parents:
diff changeset
    72
GCMemoryManager* MemoryManager::get_parnew_memory_manager() {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    73
  return (GCMemoryManager*) new ParNewMemoryManager();
489c9b5090e2 Initial load
duke
parents:
diff changeset
    74
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    75
489c9b5090e2 Initial load
duke
parents:
diff changeset
    76
GCMemoryManager* MemoryManager::get_cms_memory_manager() {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    77
  return (GCMemoryManager*) new CMSMemoryManager();
489c9b5090e2 Initial load
duke
parents:
diff changeset
    78
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    79
489c9b5090e2 Initial load
duke
parents:
diff changeset
    80
GCMemoryManager* MemoryManager::get_psScavenge_memory_manager() {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    81
  return (GCMemoryManager*) new PSScavengeMemoryManager();
489c9b5090e2 Initial load
duke
parents:
diff changeset
    82
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    83
489c9b5090e2 Initial load
duke
parents:
diff changeset
    84
GCMemoryManager* MemoryManager::get_psMarkSweep_memory_manager() {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    85
  return (GCMemoryManager*) new PSMarkSweepMemoryManager();
489c9b5090e2 Initial load
duke
parents:
diff changeset
    86
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    87
4459
eb506d590394 6815790: G1: Missing MemoryPoolMXBeans with -XX:+UseG1GC
tonyp
parents: 1
diff changeset
    88
GCMemoryManager* MemoryManager::get_g1YoungGen_memory_manager() {
eb506d590394 6815790: G1: Missing MemoryPoolMXBeans with -XX:+UseG1GC
tonyp
parents: 1
diff changeset
    89
  return (GCMemoryManager*) new G1YoungGenMemoryManager();
eb506d590394 6815790: G1: Missing MemoryPoolMXBeans with -XX:+UseG1GC
tonyp
parents: 1
diff changeset
    90
}
eb506d590394 6815790: G1: Missing MemoryPoolMXBeans with -XX:+UseG1GC
tonyp
parents: 1
diff changeset
    91
eb506d590394 6815790: G1: Missing MemoryPoolMXBeans with -XX:+UseG1GC
tonyp
parents: 1
diff changeset
    92
GCMemoryManager* MemoryManager::get_g1OldGen_memory_manager() {
eb506d590394 6815790: G1: Missing MemoryPoolMXBeans with -XX:+UseG1GC
tonyp
parents: 1
diff changeset
    93
  return (GCMemoryManager*) new G1OldGenMemoryManager();
eb506d590394 6815790: G1: Missing MemoryPoolMXBeans with -XX:+UseG1GC
tonyp
parents: 1
diff changeset
    94
}
eb506d590394 6815790: G1: Missing MemoryPoolMXBeans with -XX:+UseG1GC
tonyp
parents: 1
diff changeset
    95
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    96
instanceOop MemoryManager::get_memory_manager_instance(TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    97
  // Must do an acquire so as to force ordering of subsequent
489c9b5090e2 Initial load
duke
parents:
diff changeset
    98
  // loads from anything _memory_mgr_obj points to or implies.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    99
  instanceOop mgr_obj = (instanceOop)OrderAccess::load_ptr_acquire(&_memory_mgr_obj);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   100
  if (mgr_obj == NULL) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   101
    // It's ok for more than one thread to execute the code up to the locked region.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   102
    // Extra manager instances will just be gc'ed.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   103
    klassOop k = Management::sun_management_ManagementFactory_klass(CHECK_0);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   104
    instanceKlassHandle ik(THREAD, k);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   105
489c9b5090e2 Initial load
duke
parents:
diff changeset
   106
    Handle mgr_name = java_lang_String::create_from_str(name(), CHECK_0);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   107
489c9b5090e2 Initial load
duke
parents:
diff changeset
   108
    JavaValue result(T_OBJECT);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   109
    JavaCallArguments args;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   110
    args.push_oop(mgr_name);    // Argument 1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   111
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7397
diff changeset
   112
    Symbol* method_name = NULL;
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7397
diff changeset
   113
    Symbol* signature = NULL;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   114
    if (is_gc_memory_manager()) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7397
diff changeset
   115
      method_name = vmSymbols::createGarbageCollector_name();
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7397
diff changeset
   116
      signature = vmSymbols::createGarbageCollector_signature();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   117
      args.push_oop(Handle());      // Argument 2 (for future extension)
489c9b5090e2 Initial load
duke
parents:
diff changeset
   118
    } else {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7397
diff changeset
   119
      method_name = vmSymbols::createMemoryManager_name();
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7397
diff changeset
   120
      signature = vmSymbols::createMemoryManager_signature();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   121
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   122
489c9b5090e2 Initial load
duke
parents:
diff changeset
   123
    JavaCalls::call_static(&result,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   124
                           ik,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   125
                           method_name,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   126
                           signature,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   127
                           &args,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   128
                           CHECK_0);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   129
489c9b5090e2 Initial load
duke
parents:
diff changeset
   130
    instanceOop m = (instanceOop) result.get_jobject();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   131
    instanceHandle mgr(THREAD, m);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   132
489c9b5090e2 Initial load
duke
parents:
diff changeset
   133
    {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   134
      // Get lock before setting _memory_mgr_obj
489c9b5090e2 Initial load
duke
parents:
diff changeset
   135
      // since another thread may have created the instance
489c9b5090e2 Initial load
duke
parents:
diff changeset
   136
      MutexLocker ml(Management_lock);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   137
489c9b5090e2 Initial load
duke
parents:
diff changeset
   138
      // Check if another thread has created the management object.  We reload
489c9b5090e2 Initial load
duke
parents:
diff changeset
   139
      // _memory_mgr_obj here because some other thread may have initialized
489c9b5090e2 Initial load
duke
parents:
diff changeset
   140
      // it while we were executing the code before the lock.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   141
      //
489c9b5090e2 Initial load
duke
parents:
diff changeset
   142
      // The lock has done an acquire, so the load can't float above it, but
489c9b5090e2 Initial load
duke
parents:
diff changeset
   143
      // we need to do a load_acquire as above.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   144
      mgr_obj = (instanceOop)OrderAccess::load_ptr_acquire(&_memory_mgr_obj);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   145
      if (mgr_obj != NULL) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   146
         return mgr_obj;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   147
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   148
489c9b5090e2 Initial load
duke
parents:
diff changeset
   149
      // Get the address of the object we created via call_special.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   150
      mgr_obj = mgr();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   151
489c9b5090e2 Initial load
duke
parents:
diff changeset
   152
      // Use store barrier to make sure the memory accesses associated
489c9b5090e2 Initial load
duke
parents:
diff changeset
   153
      // with creating the management object are visible before publishing
489c9b5090e2 Initial load
duke
parents:
diff changeset
   154
      // its address.  The unlock will publish the store to _memory_mgr_obj
489c9b5090e2 Initial load
duke
parents:
diff changeset
   155
      // because it does a release first.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   156
      OrderAccess::release_store_ptr(&_memory_mgr_obj, mgr_obj);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   157
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   158
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   159
489c9b5090e2 Initial load
duke
parents:
diff changeset
   160
  return mgr_obj;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   161
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   162
489c9b5090e2 Initial load
duke
parents:
diff changeset
   163
void MemoryManager::oops_do(OopClosure* f) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   164
  f->do_oop((oop*) &_memory_mgr_obj);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   165
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   166
489c9b5090e2 Initial load
duke
parents:
diff changeset
   167
GCStatInfo::GCStatInfo(int num_pools) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   168
  // initialize the arrays for memory usage
489c9b5090e2 Initial load
duke
parents:
diff changeset
   169
  _before_gc_usage_array = (MemoryUsage*) NEW_C_HEAP_ARRAY(MemoryUsage, num_pools);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   170
  _after_gc_usage_array  = (MemoryUsage*) NEW_C_HEAP_ARRAY(MemoryUsage, num_pools);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   171
  _usage_array_size = num_pools;
11171
02c21e3d0a66 7110173: GCNotifier::pushNotification publishes stale data.
johnc
parents: 10739
diff changeset
   172
  clear();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   173
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   174
489c9b5090e2 Initial load
duke
parents:
diff changeset
   175
GCStatInfo::~GCStatInfo() {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   176
  FREE_C_HEAP_ARRAY(MemoryUsage*, _before_gc_usage_array);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   177
  FREE_C_HEAP_ARRAY(MemoryUsage*, _after_gc_usage_array);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   178
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   179
489c9b5090e2 Initial load
duke
parents:
diff changeset
   180
void GCStatInfo::set_gc_usage(int pool_index, MemoryUsage usage, bool before_gc) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   181
  MemoryUsage* gc_usage_array;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   182
  if (before_gc) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   183
    gc_usage_array = _before_gc_usage_array;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   184
  } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   185
    gc_usage_array = _after_gc_usage_array;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   186
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   187
  gc_usage_array[pool_index] = usage;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   188
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   189
6245
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   190
void GCStatInfo::clear() {
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   191
  _index = 0;
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   192
  _start_time = 0L;
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   193
  _end_time = 0L;
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   194
  size_t len = _usage_array_size * sizeof(MemoryUsage);
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   195
  memset(_before_gc_usage_array, 0, len);
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   196
  memset(_after_gc_usage_array, 0, len);
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   197
}
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   198
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   199
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   200
GCMemoryManager::GCMemoryManager() : MemoryManager() {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   201
  _num_collections = 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   202
  _last_gc_stat = NULL;
6245
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   203
  _last_gc_lock = new Mutex(Mutex::leaf, "_last_gc_lock", true);
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   204
  _current_gc_stat = NULL;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   205
  _num_gc_threads = 1;
9623
151c0b638488 7036199: Adding a notification to the implementation of GarbageCollectorMXBeans
fparain
parents: 8921
diff changeset
   206
  _notification_enabled = false;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   207
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   208
489c9b5090e2 Initial load
duke
parents:
diff changeset
   209
GCMemoryManager::~GCMemoryManager() {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   210
  delete _last_gc_stat;
6245
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   211
  delete _last_gc_lock;
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   212
  delete _current_gc_stat;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   213
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   214
489c9b5090e2 Initial load
duke
parents:
diff changeset
   215
void GCMemoryManager::initialize_gc_stat_info() {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   216
  assert(MemoryService::num_memory_pools() > 0, "should have one or more memory pools");
11591
854c0dff3844 7066129: GarbageCollectorMXBean#getLastGcInfo leaks native memory
dsamersoff
parents: 11171
diff changeset
   217
  _last_gc_stat = new(ResourceObj::C_HEAP) GCStatInfo(MemoryService::num_memory_pools());
854c0dff3844 7066129: GarbageCollectorMXBean#getLastGcInfo leaks native memory
dsamersoff
parents: 11171
diff changeset
   218
  _current_gc_stat = new(ResourceObj::C_HEAP) GCStatInfo(MemoryService::num_memory_pools());
6245
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   219
  // tracking concurrent collections we need two objects: one to update, and one to
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   220
  // hold the publicly available "last (completed) gc" information.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   221
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   222
6245
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   223
void GCMemoryManager::gc_begin(bool recordGCBeginTime, bool recordPreGCUsage,
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   224
                               bool recordAccumulatedGCTime) {
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   225
  assert(_last_gc_stat != NULL && _current_gc_stat != NULL, "Just checking");
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   226
  if (recordAccumulatedGCTime) {
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   227
    _accumulated_timer.start();
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   228
  }
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   229
  // _num_collections now increases in gc_end, to count completed collections
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   230
  if (recordGCBeginTime) {
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   231
    _current_gc_stat->set_index(_num_collections+1);
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   232
    _current_gc_stat->set_start_time(Management::timestamp());
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   233
  }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   234
6245
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   235
  if (recordPreGCUsage) {
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   236
    // Keep memory usage of all memory pools
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   237
    for (int i = 0; i < MemoryService::num_memory_pools(); i++) {
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   238
      MemoryPool* pool = MemoryService::get_memory_pool(i);
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   239
      MemoryUsage usage = pool->get_memory_usage();
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   240
      _current_gc_stat->set_before_gc_usage(i, usage);
10739
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
   241
#ifndef USDT2
6245
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   242
      HS_DTRACE_PROBE8(hotspot, mem__pool__gc__begin,
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   243
        name(), strlen(name()),
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   244
        pool->name(), strlen(pool->name()),
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   245
        usage.init_size(), usage.used(),
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   246
        usage.committed(), usage.max_size());
10739
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
   247
#else /* USDT2 */
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
   248
      HOTSPOT_MEM_POOL_GC_BEGIN(
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
   249
        (char *) name(), strlen(name()),
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
   250
        (char *) pool->name(), strlen(pool->name()),
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
   251
        usage.init_size(), usage.used(),
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
   252
        usage.committed(), usage.max_size());
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
   253
#endif /* USDT2 */
6245
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   254
    }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   255
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   256
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   257
6245
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   258
// A collector MUST, even if it does not complete for some reason,
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   259
// make a TraceMemoryManagerStats object where countCollection is true,
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   260
// to ensure the current gc stat is placed in _last_gc_stat.
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   261
void GCMemoryManager::gc_end(bool recordPostGCUsage,
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   262
                             bool recordAccumulatedGCTime,
9623
151c0b638488 7036199: Adding a notification to the implementation of GarbageCollectorMXBeans
fparain
parents: 8921
diff changeset
   263
                             bool recordGCEndTime, bool countCollection,
151c0b638488 7036199: Adding a notification to the implementation of GarbageCollectorMXBeans
fparain
parents: 8921
diff changeset
   264
                             GCCause::Cause cause) {
6245
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   265
  if (recordAccumulatedGCTime) {
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   266
    _accumulated_timer.stop();
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   267
  }
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   268
  if (recordGCEndTime) {
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   269
    _current_gc_stat->set_end_time(Management::timestamp());
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   270
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   271
6245
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   272
  if (recordPostGCUsage) {
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   273
    int i;
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   274
    // keep the last gc statistics for all memory pools
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   275
    for (i = 0; i < MemoryService::num_memory_pools(); i++) {
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   276
      MemoryPool* pool = MemoryService::get_memory_pool(i);
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   277
      MemoryUsage usage = pool->get_memory_usage();
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   278
10739
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
   279
#ifndef USDT2
6245
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   280
      HS_DTRACE_PROBE8(hotspot, mem__pool__gc__end,
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   281
        name(), strlen(name()),
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   282
        pool->name(), strlen(pool->name()),
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   283
        usage.init_size(), usage.used(),
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   284
        usage.committed(), usage.max_size());
10739
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
   285
#else /* USDT2 */
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
   286
      HOTSPOT_MEM_POOL_GC_END(
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
   287
        (char *) name(), strlen(name()),
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
   288
        (char *) pool->name(), strlen(pool->name()),
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
   289
        usage.init_size(), usage.used(),
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
   290
        usage.committed(), usage.max_size());
91935236600e 7098194: integrate macosx-port changes
dcubed
parents: 9623
diff changeset
   291
#endif /* USDT2 */
6245
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   292
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   293
      _current_gc_stat->set_after_gc_usage(i, usage);
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   294
    }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   295
6245
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   296
    // Set last collection usage of the memory pools managed by this collector
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   297
    for (i = 0; i < num_memory_pools(); i++) {
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   298
      MemoryPool* pool = get_memory_pool(i);
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   299
      MemoryUsage usage = pool->get_memory_usage();
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   300
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   301
      // Compare with GC usage threshold
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   302
      pool->set_last_collection_usage(usage);
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   303
      LowMemoryDetector::detect_after_gc_memory(pool);
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   304
    }
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   305
  }
11171
02c21e3d0a66 7110173: GCNotifier::pushNotification publishes stale data.
johnc
parents: 10739
diff changeset
   306
6245
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   307
  if (countCollection) {
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   308
    _num_collections++;
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   309
    // alternately update two objects making one public when complete
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   310
    {
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   311
      MutexLockerEx ml(_last_gc_lock, Mutex::_no_safepoint_check_flag);
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   312
      GCStatInfo *tmp = _last_gc_stat;
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   313
      _last_gc_stat = _current_gc_stat;
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   314
      _current_gc_stat = tmp;
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   315
      // reset the current stat for diagnosability purposes
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   316
      _current_gc_stat->clear();
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   317
    }
11171
02c21e3d0a66 7110173: GCNotifier::pushNotification publishes stale data.
johnc
parents: 10739
diff changeset
   318
02c21e3d0a66 7110173: GCNotifier::pushNotification publishes stale data.
johnc
parents: 10739
diff changeset
   319
    if (is_notification_enabled()) {
02c21e3d0a66 7110173: GCNotifier::pushNotification publishes stale data.
johnc
parents: 10739
diff changeset
   320
      bool isMajorGC = this == MemoryService::get_major_gc_manager();
02c21e3d0a66 7110173: GCNotifier::pushNotification publishes stale data.
johnc
parents: 10739
diff changeset
   321
      GCNotifier::pushNotification(this, isMajorGC ? "end of major GC" : "end of minor GC",
02c21e3d0a66 7110173: GCNotifier::pushNotification publishes stale data.
johnc
parents: 10739
diff changeset
   322
                                   GCCause::to_string(cause));
02c21e3d0a66 7110173: GCNotifier::pushNotification publishes stale data.
johnc
parents: 10739
diff changeset
   323
    }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   324
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   325
}
6245
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   326
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   327
size_t GCMemoryManager::get_last_gc_stat(GCStatInfo* dest) {
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   328
  MutexLockerEx ml(_last_gc_lock, Mutex::_no_safepoint_check_flag);
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   329
  if (_last_gc_stat->gc_index() != 0) {
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   330
    dest->set_index(_last_gc_stat->gc_index());
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   331
    dest->set_start_time(_last_gc_stat->start_time());
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   332
    dest->set_end_time(_last_gc_stat->end_time());
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   333
    assert(dest->usage_array_size() == _last_gc_stat->usage_array_size(),
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   334
           "Must have same array size");
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   335
    size_t len = dest->usage_array_size() * sizeof(MemoryUsage);
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   336
    memcpy(dest->before_gc_usage_array(), _last_gc_stat->before_gc_usage_array(), len);
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   337
    memcpy(dest->after_gc_usage_array(), _last_gc_stat->after_gc_usage_array(), len);
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   338
  }
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   339
  return _last_gc_stat->gc_index();
c37d2cf6de1a 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
kevinw
parents: 5547
diff changeset
   340
}