author | coleenp |
Fri, 29 May 2015 11:35:51 -0400 | |
changeset 31019 | d05fcdd70109 |
parent 30768 | 66b53dcce510 |
child 32189 | 5264b560ab1b |
permissions | -rw-r--r-- |
1 | 1 |
/* |
28373
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
2 |
* Copyright (c) 1997, 2015, Oracle and/or its affiliates. All rights reserved. |
1 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
5547
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
5403
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
5403
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
5403
diff
changeset
|
21 |
* questions. |
1 | 22 |
* |
23 |
*/ |
|
24 |
||
7397 | 25 |
#include "precompiled.hpp" |
26 |
#include "classfile/systemDictionary.hpp" |
|
27 |
#include "classfile/vmSymbols.hpp" |
|
30764 | 28 |
#include "gc/shared/gcLocker.hpp" |
7397 | 29 |
#include "memory/resourceArea.hpp" |
30 |
#include "memory/universe.inline.hpp" |
|
31 |
#include "oops/instanceKlass.hpp" |
|
32 |
#include "oops/klassVtable.hpp" |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
33 |
#include "oops/method.hpp" |
7397 | 34 |
#include "oops/objArrayOop.hpp" |
35 |
#include "oops/oop.inline.hpp" |
|
36 |
#include "prims/jvmtiRedefineClassesTrace.hpp" |
|
37 |
#include "runtime/arguments.hpp" |
|
38 |
#include "runtime/handles.inline.hpp" |
|
39 |
#include "utilities/copy.hpp" |
|
1 | 40 |
|
24424
2658d7834c6e
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
23999
diff
changeset
|
41 |
PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC |
2658d7834c6e
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
23999
diff
changeset
|
42 |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
43 |
inline InstanceKlass* klassVtable::ik() const { |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
44 |
Klass* k = _klass(); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
45 |
assert(k->oop_is_instance(), "not an InstanceKlass"); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
46 |
return (InstanceKlass*)k; |
1 | 47 |
} |
48 |
||
49 |
||
50 |
// this function computes the vtable size (including the size needed for miranda |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
51 |
// methods) and the number of miranda methods in this class. |
1 | 52 |
// Note on Miranda methods: Let's say there is a class C that implements |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
53 |
// interface I, and none of C's superclasses implements I. |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
54 |
// Let's say there is an abstract method m in I that neither C |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
55 |
// nor any of its super classes implement (i.e there is no method of any access, |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
56 |
// with the same name and signature as m), then m is a Miranda method which is |
1 | 57 |
// entered as a public abstract method in C's vtable. From then on it should |
58 |
// treated as any other public method in C for method over-ride purposes. |
|
14385 | 59 |
void klassVtable::compute_vtable_size_and_num_mirandas( |
60 |
int* vtable_length_ret, int* num_new_mirandas, |
|
61 |
GrowableArray<Method*>* all_mirandas, Klass* super, |
|
62 |
Array<Method*>* methods, AccessFlags class_flags, |
|
63 |
Handle classloader, Symbol* classname, Array<Klass*>* local_interfaces, |
|
64 |
TRAPS) { |
|
1 | 65 |
No_Safepoint_Verifier nsv; |
66 |
||
67 |
// set up default result values |
|
14385 | 68 |
int vtable_length = 0; |
1 | 69 |
|
70 |
// start off with super's vtable length |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
71 |
InstanceKlass* sk = (InstanceKlass*)super; |
1 | 72 |
vtable_length = super == NULL ? 0 : sk->vtable_length(); |
73 |
||
74 |
// go thru each method in the methods table to see if it needs a new entry |
|
75 |
int len = methods->length(); |
|
76 |
for (int i = 0; i < len; i++) { |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
77 |
assert(methods->at(i)->is_method(), "must be a Method*"); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
78 |
methodHandle mh(THREAD, methods->at(i)); |
1 | 79 |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
80 |
if (needs_new_vtable_entry(mh, super, classloader, classname, class_flags, THREAD)) { |
1 | 81 |
vtable_length += vtableEntry::size(); // we need a new entry |
82 |
} |
|
83 |
} |
|
84 |
||
14385 | 85 |
GrowableArray<Method*> new_mirandas(20); |
1 | 86 |
// compute the number of mirandas methods that must be added to the end |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
87 |
get_mirandas(&new_mirandas, all_mirandas, super, methods, NULL, local_interfaces); |
14385 | 88 |
*num_new_mirandas = new_mirandas.length(); |
89 |
||
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
90 |
// Interfaces do not need interface methods in their vtables |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
91 |
// This includes miranda methods and during later processing, default methods |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
92 |
if (!class_flags.is_interface()) { |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
93 |
vtable_length += *num_new_mirandas * vtableEntry::size(); |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
94 |
} |
1 | 95 |
|
96 |
if (Universe::is_bootstrapping() && vtable_length == 0) { |
|
97 |
// array classes don't have their superclass set correctly during |
|
98 |
// bootstrapping |
|
99 |
vtable_length = Universe::base_vtable_size(); |
|
100 |
} |
|
101 |
||
28373
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
102 |
if (super == NULL && vtable_length != Universe::base_vtable_size()) { |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
103 |
if (Universe::is_bootstrapping()) { |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
104 |
// Someone is attempting to override java.lang.Object incorrectly on the |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
105 |
// bootclasspath. The JVM cannot recover from this error including throwing |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
106 |
// an exception |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
107 |
vm_exit_during_initialization("Incompatible definition of java.lang.Object"); |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
108 |
} else { |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
109 |
// Someone is attempting to redefine java.lang.Object incorrectly. The |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
110 |
// only way this should happen is from |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
111 |
// SystemDictionary::resolve_from_stream(), which will detect this later |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
112 |
// and throw a security exception. So don't assert here to let |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
113 |
// the exception occur. |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
114 |
vtable_length = Universe::base_vtable_size(); |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
115 |
} |
1 | 116 |
} |
117 |
assert(vtable_length % vtableEntry::size() == 0, "bad vtable length"); |
|
118 |
assert(vtable_length >= Universe::base_vtable_size(), "vtable too small"); |
|
14385 | 119 |
|
120 |
*vtable_length_ret = vtable_length; |
|
1 | 121 |
} |
122 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
123 |
int klassVtable::index_of(Method* m, int len) const { |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
124 |
assert(m->has_vtable_index(), "do not ask this of non-vtable methods"); |
1 | 125 |
return m->vtable_index(); |
126 |
} |
|
127 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
128 |
// Copy super class's vtable to the first part (prefix) of this class's vtable, |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
129 |
// and return the number of entries copied. Expects that 'super' is the Java |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
130 |
// super class (arrays can have "array" super classes that must be skipped). |
1 | 131 |
int klassVtable::initialize_from_super(KlassHandle super) { |
132 |
if (super.is_null()) { |
|
133 |
return 0; |
|
134 |
} else { |
|
135 |
// copy methods from superKlass |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
136 |
// can't inherit from array class, so must be InstanceKlass |
1 | 137 |
assert(super->oop_is_instance(), "must be instance klass"); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
138 |
InstanceKlass* sk = (InstanceKlass*)super(); |
1 | 139 |
klassVtable* superVtable = sk->vtable(); |
140 |
assert(superVtable->length() <= _length, "vtable too short"); |
|
141 |
#ifdef ASSERT |
|
142 |
superVtable->verify(tty, true); |
|
143 |
#endif |
|
144 |
superVtable->copy_vtable_to(table()); |
|
145 |
#ifndef PRODUCT |
|
146 |
if (PrintVtables && Verbose) { |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
147 |
ResourceMark rm; |
1 | 148 |
tty->print_cr("copy vtable from %s to %s size %d", sk->internal_name(), klass()->internal_name(), _length); |
149 |
} |
|
150 |
#endif |
|
151 |
return superVtable->length(); |
|
152 |
} |
|
153 |
} |
|
154 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
155 |
// |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
156 |
// Revised lookup semantics introduced 1.3 (Kestrel beta) |
1 | 157 |
void klassVtable::initialize_vtable(bool checkconstraints, TRAPS) { |
158 |
||
159 |
// Note: Arrays can have intermediate array supers. Use java_super to skip them. |
|
160 |
KlassHandle super (THREAD, klass()->java_super()); |
|
161 |
int nofNewEntries = 0; |
|
162 |
||
163 |
if (PrintVtables && !klass()->oop_is_array()) { |
|
164 |
ResourceMark rm(THREAD); |
|
165 |
tty->print_cr("Initializing: %s", _klass->name()->as_C_string()); |
|
166 |
} |
|
167 |
||
168 |
#ifdef ASSERT |
|
169 |
oop* end_of_obj = (oop*)_klass() + _klass()->size(); |
|
170 |
oop* end_of_vtable = (oop*)&table()[_length]; |
|
171 |
assert(end_of_vtable <= end_of_obj, "vtable extends beyond end"); |
|
172 |
#endif |
|
173 |
||
174 |
if (Universe::is_bootstrapping()) { |
|
175 |
// just clear everything |
|
176 |
for (int i = 0; i < _length; i++) table()[i].clear(); |
|
177 |
return; |
|
178 |
} |
|
179 |
||
180 |
int super_vtable_len = initialize_from_super(super); |
|
181 |
if (klass()->oop_is_array()) { |
|
182 |
assert(super_vtable_len == _length, "arrays shouldn't introduce new methods"); |
|
183 |
} else { |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
184 |
assert(_klass->oop_is_instance(), "must be InstanceKlass"); |
1 | 185 |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
186 |
Array<Method*>* methods = ik()->methods(); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
187 |
int len = methods->length(); |
1 | 188 |
int initialized = super_vtable_len; |
189 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
190 |
// Check each of this class's methods against super; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
191 |
// if override, replace in copy of super vtable, otherwise append to end |
1 | 192 |
for (int i = 0; i < len; i++) { |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
193 |
// update_inherited_vtable can stop for gc - ensure using handles |
1 | 194 |
HandleMark hm(THREAD); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
195 |
assert(methods->at(i)->is_method(), "must be a Method*"); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
196 |
methodHandle mh(THREAD, methods->at(i)); |
1 | 197 |
|
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
198 |
bool needs_new_entry = update_inherited_vtable(ik(), mh, super_vtable_len, -1, checkconstraints, CHECK); |
1 | 199 |
|
200 |
if (needs_new_entry) { |
|
201 |
put_method_at(mh(), initialized); |
|
202 |
mh()->set_vtable_index(initialized); // set primary vtable index |
|
203 |
initialized++; |
|
204 |
} |
|
205 |
} |
|
206 |
||
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
207 |
// update vtable with default_methods |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
208 |
Array<Method*>* default_methods = ik()->default_methods(); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
209 |
if (default_methods != NULL) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
210 |
len = default_methods->length(); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
211 |
if (len > 0) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
212 |
Array<int>* def_vtable_indices = NULL; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
213 |
if ((def_vtable_indices = ik()->default_vtable_indices()) == NULL) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
214 |
def_vtable_indices = ik()->create_new_default_vtable_indices(len, CHECK); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
215 |
} else { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
216 |
assert(def_vtable_indices->length() == len, "reinit vtable len?"); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
217 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
218 |
for (int i = 0; i < len; i++) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
219 |
HandleMark hm(THREAD); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
220 |
assert(default_methods->at(i)->is_method(), "must be a Method*"); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
221 |
methodHandle mh(THREAD, default_methods->at(i)); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
222 |
|
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
223 |
bool needs_new_entry = update_inherited_vtable(ik(), mh, super_vtable_len, i, checkconstraints, CHECK); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
224 |
|
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
225 |
// needs new entry |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
226 |
if (needs_new_entry) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
227 |
put_method_at(mh(), initialized); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
228 |
def_vtable_indices->at_put(i, initialized); //set vtable index |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
229 |
initialized++; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
230 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
231 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
232 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
233 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
234 |
|
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
235 |
// add miranda methods; it will also return the updated initialized |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
236 |
// Interfaces do not need interface methods in their vtables |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
237 |
// This includes miranda methods and during later processing, default methods |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
238 |
if (!ik()->is_interface()) { |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
239 |
initialized = fill_in_mirandas(initialized); |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
240 |
} |
1 | 241 |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
242 |
// In class hierarchies where the accessibility is not increasing (i.e., going from private -> |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
243 |
// package_private -> public/protected), the vtable might actually be smaller than our initial |
1 | 244 |
// calculation. |
245 |
assert(initialized <= _length, "vtable initialization failed"); |
|
246 |
for(;initialized < _length; initialized++) { |
|
247 |
put_method_at(NULL, initialized); |
|
248 |
} |
|
249 |
NOT_PRODUCT(verify(tty, true)); |
|
250 |
} |
|
251 |
} |
|
252 |
||
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
253 |
// Called for cases where a method does not override its superclass' vtable entry |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
254 |
// For bytecodes not produced by javac together it is possible that a method does not override |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
255 |
// the superclass's method, but might indirectly override a super-super class's vtable entry |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
256 |
// If none found, return a null superk, else return the superk of the method this does override |
25504
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
257 |
// For public and protected methods: if they override a superclass, they will |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
258 |
// also be overridden themselves appropriately. |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
259 |
// Private methods do not override and are not overridden. |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
260 |
// Package Private methods are trickier: |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
261 |
// e.g. P1.A, pub m |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
262 |
// P2.B extends A, package private m |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
263 |
// P1.C extends B, public m |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
264 |
// P1.C.m needs to override P1.A.m and can not override P2.B.m |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
265 |
// Therefore: all package private methods need their own vtable entries for |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
266 |
// them to be the root of an inheritance overriding decision |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
267 |
// Package private methods may also override other vtable entries |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
268 |
InstanceKlass* klassVtable::find_transitive_override(InstanceKlass* initialsuper, methodHandle target_method, |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
269 |
int vtable_index, Handle target_loader, Symbol* target_classname, Thread * THREAD) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
270 |
InstanceKlass* superk = initialsuper; |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
271 |
while (superk != NULL && superk->super() != NULL) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
272 |
InstanceKlass* supersuperklass = InstanceKlass::cast(superk->super()); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
273 |
klassVtable* ssVtable = supersuperklass->vtable(); |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
274 |
if (vtable_index < ssVtable->length()) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
275 |
Method* super_method = ssVtable->method_at(vtable_index); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
276 |
#ifndef PRODUCT |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
277 |
Symbol* name= target_method()->name(); |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
278 |
Symbol* signature = target_method()->signature(); |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
279 |
assert(super_method->name() == name && super_method->signature() == signature, "vtable entry name/sig mismatch"); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
280 |
#endif |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
281 |
if (supersuperklass->is_override(super_method, target_loader, target_classname, THREAD)) { |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
282 |
#ifndef PRODUCT |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
283 |
if (PrintVtables && Verbose) { |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
284 |
ResourceMark rm(THREAD); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
285 |
char* sig = target_method()->name_and_sig_as_C_string(); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
286 |
tty->print("transitive overriding superclass %s with %s::%s index %d, original flags: ", |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
287 |
supersuperklass->internal_name(), |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
288 |
_klass->internal_name(), sig, vtable_index); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
289 |
super_method->access_flags().print_on(tty); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
290 |
if (super_method->is_default_method()) { |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
291 |
tty->print("default "); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
292 |
} |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
293 |
tty->print("overriders flags: "); |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
294 |
target_method->access_flags().print_on(tty); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
295 |
if (target_method->is_default_method()) { |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
296 |
tty->print("default "); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
297 |
} |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
298 |
} |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
299 |
#endif /*PRODUCT*/ |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
300 |
break; // return found superk |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
301 |
} |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
302 |
} else { |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
303 |
// super class has no vtable entry here, stop transitive search |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
304 |
superk = (InstanceKlass*)NULL; |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
305 |
break; |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
306 |
} |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
307 |
// if no override found yet, continue to search up |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
308 |
superk = InstanceKlass::cast(superk->super()); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
309 |
} |
1 | 310 |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
311 |
return superk; |
1 | 312 |
} |
313 |
||
314 |
// Update child's copy of super vtable for overrides |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
315 |
// OR return true if a new vtable entry is required. |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
316 |
// Only called for InstanceKlass's, i.e. not for arrays |
1 | 317 |
// If that changed, could not use _klass as handle for klass |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
318 |
bool klassVtable::update_inherited_vtable(InstanceKlass* klass, methodHandle target_method, |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
319 |
int super_vtable_len, int default_index, |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
320 |
bool checkconstraints, TRAPS) { |
1 | 321 |
ResourceMark rm; |
322 |
bool allocate_new = true; |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
323 |
assert(klass->oop_is_instance(), "must be InstanceKlass"); |
1 | 324 |
|
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
325 |
Array<int>* def_vtable_indices = NULL; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
326 |
bool is_default = false; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
327 |
// default methods are concrete methods in superinterfaces which are added to the vtable |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
328 |
// with their real method_holder |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
329 |
// Since vtable and itable indices share the same storage, don't touch |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
330 |
// the default method's real vtable/itable index |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
331 |
// default_vtable_indices stores the vtable value relative to this inheritor |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
332 |
if (default_index >= 0 ) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
333 |
is_default = true; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
334 |
def_vtable_indices = klass->default_vtable_indices(); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
335 |
assert(def_vtable_indices != NULL, "def vtable alloc?"); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
336 |
assert(default_index <= def_vtable_indices->length(), "def vtable len?"); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
337 |
} else { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
338 |
assert(klass == target_method()->method_holder(), "caller resp."); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
339 |
// Initialize the method's vtable index to "nonvirtual". |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
340 |
// If we allocate a vtable entry, we will update it to a non-negative number. |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
341 |
target_method()->set_vtable_index(Method::nonvirtual_vtable_index); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
342 |
} |
1 | 343 |
|
344 |
// Static and <init> methods are never in |
|
345 |
if (target_method()->is_static() || target_method()->name() == vmSymbols::object_initializer_name()) { |
|
346 |
return false; |
|
347 |
} |
|
348 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
349 |
if (target_method->is_final_method(klass->access_flags())) { |
1 | 350 |
// a final method never needs a new entry; final methods can be statically |
351 |
// resolved and they have to be present in the vtable only if they override |
|
352 |
// a super's method, in which case they re-use its entry |
|
353 |
allocate_new = false; |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
354 |
} else if (klass->is_interface()) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
355 |
allocate_new = false; // see note below in needs_new_vtable_entry |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
356 |
// An interface never allocates new vtable slots, only inherits old ones. |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
357 |
// This method will either be assigned its own itable index later, |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
358 |
// or be assigned an inherited vtable index in the loop below. |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
359 |
// default methods inherited by classes store their vtable indices |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
360 |
// in the inheritor's default_vtable_indices |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
361 |
// default methods inherited by interfaces may already have a |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
362 |
// valid itable index, if so, don't change it |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
363 |
// overpass methods in an interface will be assigned an itable index later |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
364 |
// by an inheriting class |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
365 |
if (!is_default || !target_method()->has_itable_index()) { |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
366 |
target_method()->set_vtable_index(Method::pending_itable_index); |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
367 |
} |
1 | 368 |
} |
369 |
||
370 |
// we need a new entry if there is no superclass |
|
371 |
if (klass->super() == NULL) { |
|
372 |
return allocate_new; |
|
373 |
} |
|
374 |
||
20284
595a25ab9474
8011311: Private interface methods. Default conflicts:ICCE. no erased_super_default.
acorn
parents:
20017
diff
changeset
|
375 |
// private methods in classes always have a new entry in the vtable |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
376 |
// specification interpretation since classic has |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
377 |
// private methods not overriding |
20284
595a25ab9474
8011311: Private interface methods. Default conflicts:ICCE. no erased_super_default.
acorn
parents:
20017
diff
changeset
|
378 |
// JDK8 adds private methods in interfaces which require invokespecial |
1 | 379 |
if (target_method()->is_private()) { |
380 |
return allocate_new; |
|
381 |
} |
|
382 |
||
383 |
// search through the vtable and update overridden entries |
|
384 |
// Since check_signature_loaders acquires SystemDictionary_lock |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
385 |
// which can block for gc, once we are in this loop, use handles |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
386 |
// For classfiles built with >= jdk7, we now look for transitive overrides |
1 | 387 |
|
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
388 |
Symbol* name = target_method()->name(); |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
389 |
Symbol* signature = target_method()->signature(); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
390 |
|
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
391 |
KlassHandle target_klass(THREAD, target_method()->method_holder()); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
392 |
if (target_klass == NULL) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
393 |
target_klass = _klass; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
394 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
395 |
|
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
396 |
Handle target_loader(THREAD, target_klass->class_loader()); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
397 |
|
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
398 |
Symbol* target_classname = target_klass->name(); |
1 | 399 |
for(int i = 0; i < super_vtable_len; i++) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
400 |
Method* super_method = method_at(i); |
1 | 401 |
// Check if method name matches |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
402 |
if (super_method->name() == name && super_method->signature() == signature) { |
1 | 403 |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
404 |
// get super_klass for method_holder for the found method |
14391
df0a1573d5bd
8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
coleenp
parents:
14385
diff
changeset
|
405 |
InstanceKlass* super_klass = super_method->method_holder(); |
1 | 406 |
|
29871 | 407 |
// private methods are also never overridden |
408 |
if (!super_method->is_private() && |
|
409 |
(is_default |
|
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
410 |
|| ((super_klass->is_override(super_method, target_loader, target_classname, THREAD)) |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
411 |
|| ((klass->major_version() >= VTABLE_TRANSITIVE_OVERRIDE_VERSION) |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
412 |
&& ((super_klass = find_transitive_override(super_klass, |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
413 |
target_method, i, target_loader, |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
414 |
target_classname, THREAD)) |
29871 | 415 |
!= (InstanceKlass*)NULL))))) |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
416 |
{ |
25504
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
417 |
// Package private methods always need a new entry to root their own |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
418 |
// overriding. They may also override other methods. |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
419 |
if (!target_method()->is_package_private()) { |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
420 |
allocate_new = false; |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
421 |
} |
1 | 422 |
|
423 |
if (checkconstraints) { |
|
424 |
// Override vtable entry if passes loader constraint check |
|
425 |
// if loader constraint checking requested |
|
426 |
// No need to visit his super, since he and his super |
|
427 |
// have already made any needed loader constraints. |
|
428 |
// Since loader constraints are transitive, it is enough |
|
429 |
// to link to the first super, and we get all the others. |
|
430 |
Handle super_loader(THREAD, super_klass->class_loader()); |
|
431 |
||
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
432 |
if (target_loader() != super_loader()) { |
1 | 433 |
ResourceMark rm(THREAD); |
16591
73047b0eb568
8009731: Confusing error message for loader constraint violation
acorn
parents:
15591
diff
changeset
|
434 |
Symbol* failed_type_symbol = |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
435 |
SystemDictionary::check_signature_loaders(signature, target_loader, |
1 | 436 |
super_loader, true, |
437 |
CHECK_(false)); |
|
16591
73047b0eb568
8009731: Confusing error message for loader constraint violation
acorn
parents:
15591
diff
changeset
|
438 |
if (failed_type_symbol != NULL) { |
1 | 439 |
const char* msg = "loader constraint violation: when resolving " |
440 |
"overridden method \"%s\" the class loader (instance" |
|
441 |
" of %s) of the current class, %s, and its superclass loader " |
|
442 |
"(instance of %s), have different Class objects for the type " |
|
443 |
"%s used in the signature"; |
|
444 |
char* sig = target_method()->name_and_sig_as_C_string(); |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
445 |
const char* loader1 = SystemDictionary::loader_name(target_loader()); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
446 |
char* current = target_klass->name()->as_C_string(); |
1 | 447 |
const char* loader2 = SystemDictionary::loader_name(super_loader()); |
16591
73047b0eb568
8009731: Confusing error message for loader constraint violation
acorn
parents:
15591
diff
changeset
|
448 |
char* failed_type_name = failed_type_symbol->as_C_string(); |
1 | 449 |
size_t buflen = strlen(msg) + strlen(sig) + strlen(loader1) + |
450 |
strlen(current) + strlen(loader2) + strlen(failed_type_name); |
|
451 |
char* buf = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, buflen); |
|
452 |
jio_snprintf(buf, buflen, msg, sig, loader1, current, loader2, |
|
453 |
failed_type_name); |
|
454 |
THROW_MSG_(vmSymbols::java_lang_LinkageError(), buf, false); |
|
455 |
} |
|
456 |
} |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
457 |
} |
1 | 458 |
|
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
459 |
put_method_at(target_method(), i); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
460 |
if (!is_default) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
461 |
target_method()->set_vtable_index(i); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
462 |
} else { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
463 |
if (def_vtable_indices != NULL) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
464 |
def_vtable_indices->at_put(default_index, i); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
465 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
466 |
assert(super_method->is_default_method() || super_method->is_overpass() |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
467 |
|| super_method->is_abstract(), "default override error"); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
468 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
469 |
|
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
470 |
|
1 | 471 |
#ifndef PRODUCT |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
472 |
if (PrintVtables && Verbose) { |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
473 |
ResourceMark rm(THREAD); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
474 |
char* sig = target_method()->name_and_sig_as_C_string(); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
475 |
tty->print("overriding with %s::%s index %d, original flags: ", |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
476 |
target_klass->internal_name(), sig, i); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
477 |
super_method->access_flags().print_on(tty); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
478 |
if (super_method->is_default_method()) { |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
479 |
tty->print("default "); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
480 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
481 |
if (super_method->is_overpass()) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
482 |
tty->print("overpass"); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
483 |
} |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
484 |
tty->print("overriders flags: "); |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
485 |
target_method->access_flags().print_on(tty); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
486 |
if (target_method->is_default_method()) { |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
487 |
tty->print("default "); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
488 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
489 |
if (target_method->is_overpass()) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
490 |
tty->print("overpass"); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
491 |
} |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
492 |
tty->cr(); |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
493 |
} |
1 | 494 |
#endif /*PRODUCT*/ |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
495 |
} else { |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
496 |
// allocate_new = true; default. We might override one entry, |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
497 |
// but not override another. Once we override one, not need new |
1 | 498 |
#ifndef PRODUCT |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
499 |
if (PrintVtables && Verbose) { |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
500 |
ResourceMark rm(THREAD); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
501 |
char* sig = target_method()->name_and_sig_as_C_string(); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
502 |
tty->print("NOT overriding with %s::%s index %d, original flags: ", |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
503 |
target_klass->internal_name(), sig,i); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
504 |
super_method->access_flags().print_on(tty); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
505 |
if (super_method->is_default_method()) { |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
506 |
tty->print("default "); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
507 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
508 |
if (super_method->is_overpass()) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
509 |
tty->print("overpass"); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
510 |
} |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
511 |
tty->print("overriders flags: "); |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
512 |
target_method->access_flags().print_on(tty); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
513 |
if (target_method->is_default_method()) { |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
514 |
tty->print("default "); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
515 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
516 |
if (target_method->is_overpass()) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
517 |
tty->print("overpass"); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
518 |
} |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
519 |
tty->cr(); |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
520 |
} |
1 | 521 |
#endif /*PRODUCT*/ |
522 |
} |
|
523 |
} |
|
524 |
} |
|
525 |
return allocate_new; |
|
526 |
} |
|
527 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
528 |
void klassVtable::put_method_at(Method* m, int index) { |
1 | 529 |
#ifndef PRODUCT |
530 |
if (PrintVtables && Verbose) { |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
531 |
ResourceMark rm; |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
532 |
const char* sig = (m != NULL) ? m->name_and_sig_as_C_string() : "<NULL>"; |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
533 |
tty->print("adding %s at index %d, flags: ", sig, index); |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
534 |
if (m != NULL) { |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
535 |
m->access_flags().print_on(tty); |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
536 |
if (m->is_default_method()) { |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
537 |
tty->print("default "); |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
538 |
} |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
539 |
if (m->is_overpass()) { |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
540 |
tty->print("overpass"); |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
541 |
} |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
542 |
} |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
543 |
tty->cr(); |
1 | 544 |
} |
545 |
#endif |
|
546 |
table()[index].set(m); |
|
547 |
} |
|
548 |
||
549 |
// Find out if a method "m" with superclass "super", loader "classloader" and |
|
550 |
// name "classname" needs a new vtable entry. Let P be a class package defined |
|
551 |
// by "classloader" and "classname". |
|
552 |
// NOTE: The logic used here is very similar to the one used for computing |
|
553 |
// the vtables indices for a method. We cannot directly use that function because, |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
554 |
// we allocate the InstanceKlass at load time, and that requires that the |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
555 |
// superclass has been loaded. |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
556 |
// However, the vtable entries are filled in at link time, and therefore |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
557 |
// the superclass' vtable may not yet have been filled in. |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
558 |
bool klassVtable::needs_new_vtable_entry(methodHandle target_method, |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
559 |
Klass* super, |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
560 |
Handle classloader, |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
561 |
Symbol* classname, |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
562 |
AccessFlags class_flags, |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
563 |
TRAPS) { |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
564 |
if (class_flags.is_interface()) { |
25504
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
565 |
// Interfaces do not use vtables, except for java.lang.Object methods, |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
566 |
// so there is no point to assigning |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
567 |
// a vtable index to any of their local methods. If we refrain from doing this, |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
568 |
// we can use Method::_vtable_index to hold the itable index |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
569 |
return false; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
570 |
} |
14385 | 571 |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
572 |
if (target_method->is_final_method(class_flags) || |
1 | 573 |
// a final method never needs a new entry; final methods can be statically |
574 |
// resolved and they have to be present in the vtable only if they override |
|
575 |
// a super's method, in which case they re-use its entry |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
576 |
(target_method()->is_static()) || |
1 | 577 |
// static methods don't need to be in vtable |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
578 |
(target_method()->name() == vmSymbols::object_initializer_name()) |
1 | 579 |
// <init> is never called dynamically-bound |
580 |
) { |
|
581 |
return false; |
|
582 |
} |
|
583 |
||
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
584 |
// Concrete interface methods do not need new entries, they override |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
585 |
// abstract method entries using default inheritance rules |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
586 |
if (target_method()->method_holder() != NULL && |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
587 |
target_method()->method_holder()->is_interface() && |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
588 |
!target_method()->is_abstract() ) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
589 |
return false; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
590 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
591 |
|
1 | 592 |
// we need a new entry if there is no superclass |
593 |
if (super == NULL) { |
|
594 |
return true; |
|
595 |
} |
|
596 |
||
20284
595a25ab9474
8011311: Private interface methods. Default conflicts:ICCE. no erased_super_default.
acorn
parents:
20017
diff
changeset
|
597 |
// private methods in classes always have a new entry in the vtable |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
598 |
// specification interpretation since classic has |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
599 |
// private methods not overriding |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
600 |
// JDK8 adds private methods in interfaces which require invokespecial |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
601 |
if (target_method()->is_private()) { |
1 | 602 |
return true; |
603 |
} |
|
604 |
||
25504
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
605 |
// Package private methods always need a new entry to root their own |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
606 |
// overriding. This allows transitive overriding to work. |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
607 |
if (target_method()->is_package_private()) { |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
608 |
return true; |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
609 |
} |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
610 |
|
1 | 611 |
// search through the super class hierarchy to see if we need |
612 |
// a new entry |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
613 |
ResourceMark rm; |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
614 |
Symbol* name = target_method()->name(); |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
615 |
Symbol* signature = target_method()->signature(); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
616 |
Klass* k = super; |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
617 |
Method* super_method = NULL; |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
618 |
InstanceKlass *holder = NULL; |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
619 |
Method* recheck_method = NULL; |
1 | 620 |
while (k != NULL) { |
621 |
// lookup through the hierarchy for a method with matching name and sign. |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
622 |
super_method = InstanceKlass::cast(k)->lookup_method(name, signature); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
623 |
if (super_method == NULL) { |
1 | 624 |
break; // we still have to search for a matching miranda method |
625 |
} |
|
626 |
// get the class holding the matching method |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
627 |
// make sure you use that class for is_override |
14391
df0a1573d5bd
8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
coleenp
parents:
14385
diff
changeset
|
628 |
InstanceKlass* superk = super_method->method_holder(); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
629 |
// we want only instance method matches |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
630 |
// pretend private methods are not in the super vtable |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
631 |
// since we do override around them: e.g. a.m pub/b.m private/c.m pub, |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
632 |
// ignore private, c.m pub does override a.m pub |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
633 |
// For classes that were not javac'd together, we also do transitive overriding around |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
634 |
// methods that have less accessibility |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
635 |
if ((!super_method->is_static()) && |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
636 |
(!super_method->is_private())) { |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
637 |
if (superk->is_override(super_method, classloader, classname, THREAD)) { |
1 | 638 |
return false; |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
639 |
// else keep looking for transitive overrides |
1 | 640 |
} |
641 |
} |
|
642 |
||
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
643 |
// Start with lookup result and continue to search up |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
644 |
k = superk->super(); // haven't found an override match yet; continue to look |
1 | 645 |
} |
646 |
||
647 |
// if the target method is public or protected it may have a matching |
|
648 |
// miranda method in the super, whose entry it should re-use. |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
649 |
// Actually, to handle cases that javac would not generate, we need |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
650 |
// this check for all access permissions. |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
651 |
InstanceKlass *sk = InstanceKlass::cast(super); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
652 |
if (sk->has_miranda_methods()) { |
28731
f7339cba0a6a
8067480: Crash in klassItable::initialize_itable_for_interface when running vm.runtime.defmeth.StaticMethodsTest.
lfoltan
parents:
28373
diff
changeset
|
653 |
if (sk->lookup_method_in_all_interfaces(name, signature, Klass::find_defaults) != NULL) { |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
654 |
return false; // found a matching miranda; we do not need a new entry |
1 | 655 |
} |
656 |
} |
|
657 |
return true; // found no match; we need a new entry |
|
658 |
} |
|
659 |
||
660 |
// Support for miranda methods |
|
661 |
||
662 |
// get the vtable index of a miranda method with matching "name" and "signature" |
|
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
663 |
int klassVtable::index_of_miranda(Symbol* name, Symbol* signature) { |
1 | 664 |
// search from the bottom, might be faster |
665 |
for (int i = (length() - 1); i >= 0; i--) { |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
666 |
Method* m = table()[i].method(); |
1 | 667 |
if (is_miranda_entry_at(i) && |
668 |
m->name() == name && m->signature() == signature) { |
|
669 |
return i; |
|
670 |
} |
|
671 |
} |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
672 |
return Method::invalid_vtable_index; |
1 | 673 |
} |
674 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
675 |
// check if an entry at an index is miranda |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
676 |
// requires that method m at entry be declared ("held") by an interface. |
1 | 677 |
bool klassVtable::is_miranda_entry_at(int i) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
678 |
Method* m = method_at(i); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
679 |
Klass* method_holder = m->method_holder(); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
680 |
InstanceKlass *mhk = InstanceKlass::cast(method_holder); |
1 | 681 |
|
20284
595a25ab9474
8011311: Private interface methods. Default conflicts:ICCE. no erased_super_default.
acorn
parents:
20017
diff
changeset
|
682 |
// miranda methods are public abstract instance interface methods in a class's vtable |
1 | 683 |
if (mhk->is_interface()) { |
14385 | 684 |
assert(m->is_public(), "should be public"); |
1 | 685 |
assert(ik()->implements_interface(method_holder) , "this class should implement the interface"); |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
686 |
// the search could find a miranda or a default method |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
687 |
if (is_miranda(m, ik()->methods(), ik()->default_methods(), ik()->super())) { |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
688 |
return true; |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
689 |
} |
1 | 690 |
} |
691 |
return false; |
|
692 |
} |
|
693 |
||
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
694 |
// check if a method is a miranda method, given a class's methods table, |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
695 |
// its default_method table and its super |
21913
0e2fd7282ac6
8028438: static superclass method masks default methods
acorn
parents:
21770
diff
changeset
|
696 |
// Miranda methods are calculated twice: |
29871 | 697 |
// first: before vtable size calculation: including abstract and superinterface default |
698 |
// We include potential default methods to give them space in the vtable. |
|
699 |
// During the first run, the default_methods list is empty |
|
21913
0e2fd7282ac6
8028438: static superclass method masks default methods
acorn
parents:
21770
diff
changeset
|
700 |
// This is seen by default method creation |
29871 | 701 |
// Second: recalculated during vtable initialization: only include abstract methods. |
702 |
// During the second run, default_methods is set up, so concrete methods from |
|
703 |
// superinterfaces with matching names/signatures to default_methods are already |
|
704 |
// in the default_methods list and do not need to be appended to the vtable |
|
705 |
// as mirandas |
|
21913
0e2fd7282ac6
8028438: static superclass method masks default methods
acorn
parents:
21770
diff
changeset
|
706 |
// This is seen by link resolution and selection. |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
707 |
// "miranda" means not static, not defined by this class. |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
708 |
// private methods in interfaces do not belong in the miranda list. |
1 | 709 |
// the caller must make sure that the method belongs to an interface implemented by the class |
20284
595a25ab9474
8011311: Private interface methods. Default conflicts:ICCE. no erased_super_default.
acorn
parents:
20017
diff
changeset
|
710 |
// Miranda methods only include public interface instance methods |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
711 |
// Not private methods, not static methods, not default == concrete abstract |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
712 |
// Miranda methods also do not include overpass methods in interfaces |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
713 |
bool klassVtable::is_miranda(Method* m, Array<Method*>* class_methods, |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
714 |
Array<Method*>* default_methods, Klass* super) { |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
715 |
if (m->is_static() || m->is_private() || m->is_overpass()) { |
17092
8d0bef547de9
8013418: assert(i == total_args_passed) in AdapterHandlerLibrary::get_adapter since 8-b87
bharadwaj
parents:
16591
diff
changeset
|
716 |
return false; |
8d0bef547de9
8013418: assert(i == total_args_passed) in AdapterHandlerLibrary::get_adapter since 8-b87
bharadwaj
parents:
16591
diff
changeset
|
717 |
} |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
718 |
Symbol* name = m->name(); |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
719 |
Symbol* signature = m->signature(); |
29871 | 720 |
Method* mo; |
21913
0e2fd7282ac6
8028438: static superclass method masks default methods
acorn
parents:
21770
diff
changeset
|
721 |
|
29871 | 722 |
if ((mo = InstanceKlass::find_instance_method(class_methods, name, signature)) == NULL) { |
7443
39c85d63abf2
6989076: JVM crashes in klassItable::initialize_itable_for_interface
dsamersoff
parents:
7397
diff
changeset
|
723 |
// did not find it in the method table of the current class |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
724 |
if ((default_methods == NULL) || |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
725 |
InstanceKlass::find_method(default_methods, name, signature) == NULL) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
726 |
if (super == NULL) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
727 |
// super doesn't exist |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
728 |
return true; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
729 |
} |
7443
39c85d63abf2
6989076: JVM crashes in klassItable::initialize_itable_for_interface
dsamersoff
parents:
7397
diff
changeset
|
730 |
|
29871 | 731 |
mo = InstanceKlass::cast(super)->lookup_method(name, signature); |
21913
0e2fd7282ac6
8028438: static superclass method masks default methods
acorn
parents:
21770
diff
changeset
|
732 |
while (mo != NULL && mo->access_flags().is_static() |
0e2fd7282ac6
8028438: static superclass method masks default methods
acorn
parents:
21770
diff
changeset
|
733 |
&& mo->method_holder() != NULL |
0e2fd7282ac6
8028438: static superclass method masks default methods
acorn
parents:
21770
diff
changeset
|
734 |
&& mo->method_holder()->super() != NULL) |
0e2fd7282ac6
8028438: static superclass method masks default methods
acorn
parents:
21770
diff
changeset
|
735 |
{ |
28731
f7339cba0a6a
8067480: Crash in klassItable::initialize_itable_for_interface when running vm.runtime.defmeth.StaticMethodsTest.
lfoltan
parents:
28373
diff
changeset
|
736 |
mo = mo->method_holder()->super()->uncached_lookup_method(name, signature, Klass::find_overpass); |
21913
0e2fd7282ac6
8028438: static superclass method masks default methods
acorn
parents:
21770
diff
changeset
|
737 |
} |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
738 |
if (mo == NULL || mo->access_flags().is_private() ) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
739 |
// super class hierarchy does not implement it or protection is different |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
740 |
return true; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
741 |
} |
1 | 742 |
} |
29871 | 743 |
} else { |
744 |
// if the local class has a private method, the miranda will not |
|
745 |
// override it, so a vtable slot is needed |
|
746 |
if (mo->access_flags().is_private()) { |
|
747 |
||
748 |
// Second round, weed out any superinterface methods that turned |
|
749 |
// into default methods, i.e. were concrete not abstract in the end |
|
750 |
if ((default_methods == NULL) || |
|
751 |
InstanceKlass::find_method(default_methods, name, signature) == NULL) { |
|
752 |
return true; |
|
753 |
} |
|
754 |
} |
|
1 | 755 |
} |
7443
39c85d63abf2
6989076: JVM crashes in klassItable::initialize_itable_for_interface
dsamersoff
parents:
7397
diff
changeset
|
756 |
|
1 | 757 |
return false; |
758 |
} |
|
759 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
760 |
// Scans current_interface_methods for miranda methods that do not |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
761 |
// already appear in new_mirandas, or default methods, and are also not defined-and-non-private |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
762 |
// in super (superclass). These mirandas are added to all_mirandas if it is |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
763 |
// not null; in addition, those that are not duplicates of miranda methods |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
764 |
// inherited by super from its interfaces are added to new_mirandas. |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
765 |
// Thus, new_mirandas will be the set of mirandas that this class introduces, |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
766 |
// all_mirandas will be the set of all mirandas applicable to this class |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
767 |
// including all defined in superclasses. |
14385 | 768 |
void klassVtable::add_new_mirandas_to_lists( |
769 |
GrowableArray<Method*>* new_mirandas, GrowableArray<Method*>* all_mirandas, |
|
770 |
Array<Method*>* current_interface_methods, Array<Method*>* class_methods, |
|
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
771 |
Array<Method*>* default_methods, Klass* super) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
772 |
|
1 | 773 |
// iterate thru the current interface's method to see if it a miranda |
774 |
int num_methods = current_interface_methods->length(); |
|
775 |
for (int i = 0; i < num_methods; i++) { |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
776 |
Method* im = current_interface_methods->at(i); |
1 | 777 |
bool is_duplicate = false; |
14385 | 778 |
int num_of_current_mirandas = new_mirandas->length(); |
1 | 779 |
// check for duplicate mirandas in different interfaces we implement |
780 |
for (int j = 0; j < num_of_current_mirandas; j++) { |
|
14385 | 781 |
Method* miranda = new_mirandas->at(j); |
1 | 782 |
if ((im->name() == miranda->name()) && |
783 |
(im->signature() == miranda->signature())) { |
|
784 |
is_duplicate = true; |
|
785 |
break; |
|
786 |
} |
|
787 |
} |
|
788 |
||
789 |
if (!is_duplicate) { // we don't want duplicate miranda entries in the vtable |
|
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
790 |
if (is_miranda(im, class_methods, default_methods, super)) { // is it a miranda at all? |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
791 |
InstanceKlass *sk = InstanceKlass::cast(super); |
1 | 792 |
// check if it is a duplicate of a super's miranda |
28731
f7339cba0a6a
8067480: Crash in klassItable::initialize_itable_for_interface when running vm.runtime.defmeth.StaticMethodsTest.
lfoltan
parents:
28373
diff
changeset
|
793 |
if (sk->lookup_method_in_all_interfaces(im->name(), im->signature(), Klass::find_defaults) == NULL) { |
14385 | 794 |
new_mirandas->append(im); |
795 |
} |
|
796 |
if (all_mirandas != NULL) { |
|
797 |
all_mirandas->append(im); |
|
1 | 798 |
} |
799 |
} |
|
800 |
} |
|
801 |
} |
|
802 |
} |
|
803 |
||
14385 | 804 |
void klassVtable::get_mirandas(GrowableArray<Method*>* new_mirandas, |
805 |
GrowableArray<Method*>* all_mirandas, |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
806 |
Klass* super, Array<Method*>* class_methods, |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
807 |
Array<Method*>* default_methods, |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
808 |
Array<Klass*>* local_interfaces) { |
14385 | 809 |
assert((new_mirandas->length() == 0) , "current mirandas must be 0"); |
1 | 810 |
|
811 |
// iterate thru the local interfaces looking for a miranda |
|
812 |
int num_local_ifs = local_interfaces->length(); |
|
813 |
for (int i = 0; i < num_local_ifs; i++) { |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
814 |
InstanceKlass *ik = InstanceKlass::cast(local_interfaces->at(i)); |
14385 | 815 |
add_new_mirandas_to_lists(new_mirandas, all_mirandas, |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
816 |
ik->methods(), class_methods, |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
817 |
default_methods, super); |
1 | 818 |
// iterate thru each local's super interfaces |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
819 |
Array<Klass*>* super_ifs = ik->transitive_interfaces(); |
1 | 820 |
int num_super_ifs = super_ifs->length(); |
821 |
for (int j = 0; j < num_super_ifs; j++) { |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
822 |
InstanceKlass *sik = InstanceKlass::cast(super_ifs->at(j)); |
14385 | 823 |
add_new_mirandas_to_lists(new_mirandas, all_mirandas, |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
824 |
sik->methods(), class_methods, |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
825 |
default_methods, super); |
1 | 826 |
} |
827 |
} |
|
828 |
} |
|
829 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
830 |
// Discover miranda methods ("miranda" = "interface abstract, no binding"), |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
831 |
// and append them into the vtable starting at index initialized, |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
832 |
// return the new value of initialized. |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
833 |
// Miranda methods use vtable entries, but do not get assigned a vtable_index |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
834 |
// The vtable_index is discovered by searching from the end of the vtable |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
835 |
int klassVtable::fill_in_mirandas(int initialized) { |
14385 | 836 |
GrowableArray<Method*> mirandas(20); |
837 |
get_mirandas(&mirandas, NULL, ik()->super(), ik()->methods(), |
|
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
838 |
ik()->default_methods(), ik()->local_interfaces()); |
14385 | 839 |
for (int i = 0; i < mirandas.length(); i++) { |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
840 |
if (PrintVtables && Verbose) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
841 |
Method* meth = mirandas.at(i); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
842 |
ResourceMark rm(Thread::current()); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
843 |
if (meth != NULL) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
844 |
char* sig = meth->name_and_sig_as_C_string(); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
845 |
tty->print("fill in mirandas with %s index %d, flags: ", |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
846 |
sig, initialized); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
847 |
meth->access_flags().print_on(tty); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
848 |
if (meth->is_default_method()) { |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
849 |
tty->print("default "); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
850 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
851 |
tty->cr(); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
852 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
853 |
} |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
854 |
put_method_at(mirandas.at(i), initialized); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
855 |
++initialized; |
1 | 856 |
} |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
857 |
return initialized; |
1 | 858 |
} |
859 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
860 |
// Copy this class's vtable to the vtable beginning at start. |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
861 |
// Used to copy superclass vtable to prefix of subclass's vtable. |
1 | 862 |
void klassVtable::copy_vtable_to(vtableEntry* start) { |
863 |
Copy::disjoint_words((HeapWord*)table(), (HeapWord*)start, _length * vtableEntry::size()); |
|
864 |
} |
|
865 |
||
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
866 |
#if INCLUDE_JVMTI |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
867 |
bool klassVtable::adjust_default_method(int vtable_index, Method* old_method, Method* new_method) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
868 |
// If old_method is default, find this vtable index in default_vtable_indices |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
869 |
// and replace that method in the _default_methods list |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
870 |
bool updated = false; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
871 |
|
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
872 |
Array<Method*>* default_methods = ik()->default_methods(); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
873 |
if (default_methods != NULL) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
874 |
int len = default_methods->length(); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
875 |
for (int idx = 0; idx < len; idx++) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
876 |
if (vtable_index == ik()->default_vtable_indices()->at(idx)) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
877 |
if (default_methods->at(idx) == old_method) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
878 |
default_methods->at_put(idx, new_method); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
879 |
updated = true; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
880 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
881 |
break; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
882 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
883 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
884 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
885 |
return updated; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
886 |
} |
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
887 |
|
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
888 |
// search the vtable for uses of either obsolete or EMCP methods |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
889 |
void klassVtable::adjust_method_entries(InstanceKlass* holder, bool * trace_name_printed) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
890 |
int prn_enabled = 0; |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
891 |
for (int index = 0; index < length(); index++) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
892 |
Method* old_method = unchecked_method_at(index); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
893 |
if (old_method == NULL || old_method->method_holder() != holder || !old_method->is_old()) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
894 |
continue; // skip uninteresting entries |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
895 |
} |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
896 |
assert(!old_method->is_deleted(), "vtable methods may not be deleted"); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
897 |
|
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
898 |
Method* new_method = holder->method_with_idnum(old_method->orig_method_idnum()); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
899 |
|
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
900 |
assert(new_method != NULL, "method_with_idnum() should not be NULL"); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
901 |
assert(old_method != new_method, "sanity check"); |
1 | 902 |
|
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
903 |
put_method_at(new_method, index); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
904 |
// For default methods, need to update the _default_methods array |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
905 |
// which can only have one method entry for a given signature |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
906 |
bool updated_default = false; |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
907 |
if (old_method->is_default_method()) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
908 |
updated_default = adjust_default_method(index, old_method, new_method); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
909 |
} |
1 | 910 |
|
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
911 |
if (RC_TRACE_IN_RANGE(0x00100000, 0x00400000)) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
912 |
if (!(*trace_name_printed)) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
913 |
// RC_TRACE_MESG macro has an embedded ResourceMark |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
914 |
RC_TRACE_MESG(("adjust: klassname=%s for methods from name=%s", |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
915 |
klass()->external_name(), |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
916 |
old_method->method_holder()->external_name())); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
917 |
*trace_name_printed = true; |
1 | 918 |
} |
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
919 |
// RC_TRACE macro has an embedded ResourceMark |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
920 |
RC_TRACE(0x00100000, ("vtable method update: %s(%s), updated default = %s", |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
921 |
new_method->name()->as_C_string(), |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
922 |
new_method->signature()->as_C_string(), |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
923 |
updated_default ? "true" : "false")); |
1 | 924 |
} |
925 |
} |
|
926 |
} |
|
927 |
||
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
928 |
// a vtable should never contain old or obsolete methods |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
929 |
bool klassVtable::check_no_old_or_obsolete_entries() { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
930 |
for (int i = 0; i < length(); i++) { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
931 |
Method* m = unchecked_method_at(i); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
932 |
if (m != NULL && |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
933 |
(NOT_PRODUCT(!m->is_valid() ||) m->is_old() || m->is_obsolete())) { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
934 |
return false; |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
935 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
936 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
937 |
return true; |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
938 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
939 |
|
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
940 |
void klassVtable::dump_vtable() { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
941 |
tty->print_cr("vtable dump --"); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
942 |
for (int i = 0; i < length(); i++) { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
943 |
Method* m = unchecked_method_at(i); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
944 |
if (m != NULL) { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
945 |
tty->print(" (%5d) ", i); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
946 |
m->access_flags().print_on(tty); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
947 |
if (m->is_default_method()) { |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
948 |
tty->print("default "); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
949 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
950 |
if (m->is_overpass()) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
951 |
tty->print("overpass"); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
952 |
} |
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
953 |
tty->print(" -- "); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
954 |
m->print_name(tty); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
955 |
tty->cr(); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
956 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
957 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
958 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
959 |
#endif // INCLUDE_JVMTI |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
960 |
|
9172
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
961 |
// CDS/RedefineClasses support - clear vtables so they can be reinitialized |
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
962 |
void klassVtable::clear_vtable() { |
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
963 |
for (int i = 0; i < _length; i++) table()[i].clear(); |
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
964 |
} |
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
965 |
|
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
966 |
bool klassVtable::is_initialized() { |
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
967 |
return _length == 0 || table()[0].method() != NULL; |
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
968 |
} |
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
969 |
|
1 | 970 |
//----------------------------------------------------------------------------------------- |
971 |
// Itable code |
|
972 |
||
973 |
// Initialize a itableMethodEntry |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
974 |
void itableMethodEntry::initialize(Method* m) { |
1 | 975 |
if (m == NULL) return; |
976 |
||
977 |
_method = m; |
|
978 |
} |
|
979 |
||
980 |
klassItable::klassItable(instanceKlassHandle klass) { |
|
981 |
_klass = klass; |
|
982 |
||
983 |
if (klass->itable_length() > 0) { |
|
984 |
itableOffsetEntry* offset_entry = (itableOffsetEntry*)klass->start_of_itable(); |
|
985 |
if (offset_entry != NULL && offset_entry->interface_klass() != NULL) { // Check that itable is initialized |
|
986 |
// First offset entry points to the first method_entry |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
987 |
intptr_t* method_entry = (intptr_t *)(((address)klass()) + offset_entry->offset()); |
1 | 988 |
intptr_t* end = klass->end_of_itable(); |
989 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
990 |
_table_offset = (intptr_t*)offset_entry - (intptr_t*)klass(); |
1 | 991 |
_size_offset_table = (method_entry - ((intptr_t*)offset_entry)) / itableOffsetEntry::size(); |
992 |
_size_method_table = (end - method_entry) / itableMethodEntry::size(); |
|
993 |
assert(_table_offset >= 0 && _size_offset_table >= 0 && _size_method_table >= 0, "wrong computation"); |
|
994 |
return; |
|
995 |
} |
|
996 |
} |
|
997 |
||
189
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
998 |
// The length of the itable was either zero, or it has not yet been initialized. |
1 | 999 |
_table_offset = 0; |
1000 |
_size_offset_table = 0; |
|
1001 |
_size_method_table = 0; |
|
1002 |
} |
|
1003 |
||
1004 |
static int initialize_count = 0; |
|
1005 |
||
1006 |
// Initialization |
|
1007 |
void klassItable::initialize_itable(bool checkconstraints, TRAPS) { |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1008 |
if (_klass->is_interface()) { |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1009 |
// This needs to go after vtable indices are assigned but |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1010 |
// before implementors need to know the number of itable indices. |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1011 |
assign_itable_indices_for_interface(_klass()); |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1012 |
} |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1013 |
|
189
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1014 |
// Cannot be setup doing bootstrapping, interfaces don't have |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1015 |
// itables, and klass with only ones entry have empty itables |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1016 |
if (Universe::is_bootstrapping() || |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1017 |
_klass->is_interface() || |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1018 |
_klass->itable_length() == itableOffsetEntry::size()) return; |
1 | 1019 |
|
189
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1020 |
// There's alway an extra itable entry so we can null-terminate it. |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1021 |
guarantee(size_offset_table() >= 1, "too small"); |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1022 |
int num_interfaces = size_offset_table() - 1; |
1 | 1023 |
if (num_interfaces > 0) { |
189
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1024 |
if (TraceItables) tty->print_cr("%3d: Initializing itables for %s", ++initialize_count, |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1025 |
_klass->name()->as_C_string()); |
1 | 1026 |
|
1027 |
||
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
1028 |
// Iterate through all interfaces |
1 | 1029 |
int i; |
1030 |
for(i = 0; i < num_interfaces; i++) { |
|
1031 |
itableOffsetEntry* ioe = offset_entry(i); |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1032 |
HandleMark hm(THREAD); |
1 | 1033 |
KlassHandle interf_h (THREAD, ioe->interface_klass()); |
1034 |
assert(interf_h() != NULL && ioe->offset() != 0, "bad offset entry in itable"); |
|
1035 |
initialize_itable_for_interface(ioe->offset(), interf_h, checkconstraints, CHECK); |
|
1036 |
} |
|
1037 |
||
1038 |
} |
|
189
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1039 |
// Check that the last entry is empty |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1040 |
itableOffsetEntry* ioe = offset_entry(size_offset_table() - 1); |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1041 |
guarantee(ioe->interface_klass() == NULL && ioe->offset() == 0, "terminator entry missing"); |
1 | 1042 |
} |
1043 |
||
1044 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1045 |
inline bool interface_method_needs_itable_index(Method* m) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1046 |
if (m->is_static()) return false; // e.g., Stream.empty |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1047 |
if (m->is_initializer()) return false; // <init> or <clinit> |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1048 |
// If an interface redeclares a method from java.lang.Object, |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1049 |
// it should already have a vtable index, don't touch it. |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1050 |
// e.g., CharSequence.toString (from initialize_vtable) |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1051 |
// if (m->has_vtable_index()) return false; // NO! |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1052 |
return true; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1053 |
} |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1054 |
|
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1055 |
int klassItable::assign_itable_indices_for_interface(Klass* klass) { |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1056 |
// an interface does not have an itable, but its methods need to be numbered |
30615
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1057 |
if (TraceItables) tty->print_cr("%3d: Initializing itable indices for interface %s", ++initialize_count, |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1058 |
klass->name()->as_C_string()); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1059 |
Array<Method*>* methods = InstanceKlass::cast(klass)->methods(); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1060 |
int nof_methods = methods->length(); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1061 |
int ime_num = 0; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1062 |
for (int i = 0; i < nof_methods; i++) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1063 |
Method* m = methods->at(i); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1064 |
if (interface_method_needs_itable_index(m)) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1065 |
assert(!m->is_final_method(), "no final interface methods"); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1066 |
// If m is already assigned a vtable index, do not disturb it. |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1067 |
if (TraceItables && Verbose) { |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1068 |
ResourceMark rm; |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1069 |
const char* sig = (m != NULL) ? m->name_and_sig_as_C_string() : "<NULL>"; |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1070 |
if (m->has_vtable_index()) { |
30615
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1071 |
tty->print("vtable index %d for method: %s, flags: ", m->vtable_index(), sig); |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1072 |
} else { |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1073 |
tty->print("itable index %d for method: %s, flags: ", ime_num, sig); |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1074 |
} |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1075 |
if (m != NULL) { |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1076 |
m->access_flags().print_on(tty); |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1077 |
if (m->is_default_method()) { |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1078 |
tty->print("default "); |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1079 |
} |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1080 |
if (m->is_overpass()) { |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1081 |
tty->print("overpass"); |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1082 |
} |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1083 |
} |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1084 |
tty->cr(); |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1085 |
} |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1086 |
if (!m->has_vtable_index()) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1087 |
assert(m->vtable_index() == Method::pending_itable_index, "set by initialize_vtable"); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1088 |
m->set_itable_index(ime_num); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1089 |
// Progress to next itable entry |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1090 |
ime_num++; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1091 |
} |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1092 |
} |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1093 |
} |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1094 |
assert(ime_num == method_count_for_interface(klass), "proper sizing"); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1095 |
return ime_num; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1096 |
} |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1097 |
|
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1098 |
int klassItable::method_count_for_interface(Klass* interf) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1099 |
assert(interf->oop_is_instance(), "must be"); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1100 |
assert(interf->is_interface(), "must be"); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1101 |
Array<Method*>* methods = InstanceKlass::cast(interf)->methods(); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1102 |
int nof_methods = methods->length(); |
30615
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1103 |
int length = 0; |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1104 |
while (nof_methods > 0) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1105 |
Method* m = methods->at(nof_methods-1); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1106 |
if (m->has_itable_index()) { |
30615
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1107 |
length = m->itable_index() + 1; |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1108 |
break; |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1109 |
} |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1110 |
nof_methods -= 1; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1111 |
} |
30615
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1112 |
#ifdef ASSERT |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1113 |
int nof_methods_copy = nof_methods; |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1114 |
while (nof_methods_copy > 0) { |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1115 |
Method* mm = methods->at(--nof_methods_copy); |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1116 |
assert(!mm->has_itable_index() || mm->itable_index() < length, ""); |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1117 |
} |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1118 |
#endif //ASSERT |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1119 |
// return the rightmost itable index, plus one; or 0 if no methods have |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1120 |
// itable indices |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1121 |
return length; |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1122 |
} |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1123 |
|
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1124 |
|
1 | 1125 |
void klassItable::initialize_itable_for_interface(int method_table_offset, KlassHandle interf_h, bool checkconstraints, TRAPS) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1126 |
Array<Method*>* methods = InstanceKlass::cast(interf_h())->methods(); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1127 |
int nof_methods = methods->length(); |
1 | 1128 |
HandleMark hm; |
5402
c51fd0c1d005
6888953: some calls to function-like macros are missing semicolons
jcoomes
parents:
2343
diff
changeset
|
1129 |
assert(nof_methods > 0, "at least one method must exist for interface to be in vtable"); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1130 |
Handle interface_loader (THREAD, InstanceKlass::cast(interf_h())->class_loader()); |
1 | 1131 |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1132 |
int ime_count = method_count_for_interface(interf_h()); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1133 |
for (int i = 0; i < nof_methods; i++) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1134 |
Method* m = methods->at(i); |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1135 |
methodHandle target; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1136 |
if (m->has_itable_index()) { |
22232
26acfad336c0
8027804: JCK resolveMethod test fails expecting AbstractMethodError
hseigel
parents:
21913
diff
changeset
|
1137 |
// This search must match the runtime resolution, i.e. selection search for invokeinterface |
26acfad336c0
8027804: JCK resolveMethod test fails expecting AbstractMethodError
hseigel
parents:
21913
diff
changeset
|
1138 |
// to correctly enforce loader constraints for interface method inheritance |
31019 | 1139 |
target = LinkResolver::lookup_instance_method_in_klasses(_klass, m->name(), m->signature(), CHECK); |
1 | 1140 |
} |
1141 |
if (target == NULL || !target->is_public() || target->is_abstract()) { |
|
21770
e8932d2fda2c
8016839: JSR292: AME instead of IAE when calling a method
drchase
parents:
21556
diff
changeset
|
1142 |
// Entry does not resolve. Leave it empty for AbstractMethodError. |
e8932d2fda2c
8016839: JSR292: AME instead of IAE when calling a method
drchase
parents:
21556
diff
changeset
|
1143 |
if (!(target == NULL) && !target->is_public()) { |
e8932d2fda2c
8016839: JSR292: AME instead of IAE when calling a method
drchase
parents:
21556
diff
changeset
|
1144 |
// Stuff an IllegalAccessError throwing method in there instead. |
e8932d2fda2c
8016839: JSR292: AME instead of IAE when calling a method
drchase
parents:
21556
diff
changeset
|
1145 |
itableOffsetEntry::method_entry(_klass(), method_table_offset)[m->itable_index()]. |
e8932d2fda2c
8016839: JSR292: AME instead of IAE when calling a method
drchase
parents:
21556
diff
changeset
|
1146 |
initialize(Universe::throw_illegal_access_error()); |
e8932d2fda2c
8016839: JSR292: AME instead of IAE when calling a method
drchase
parents:
21556
diff
changeset
|
1147 |
} |
1 | 1148 |
} else { |
1149 |
// Entry did resolve, check loader constraints before initializing |
|
1150 |
// if checkconstraints requested |
|
1151 |
if (checkconstraints) { |
|
14391
df0a1573d5bd
8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
coleenp
parents:
14385
diff
changeset
|
1152 |
Handle method_holder_loader (THREAD, target->method_holder()->class_loader()); |
1 | 1153 |
if (method_holder_loader() != interface_loader()) { |
1154 |
ResourceMark rm(THREAD); |
|
16591
73047b0eb568
8009731: Confusing error message for loader constraint violation
acorn
parents:
15591
diff
changeset
|
1155 |
Symbol* failed_type_symbol = |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1156 |
SystemDictionary::check_signature_loaders(m->signature(), |
1 | 1157 |
method_holder_loader, |
1158 |
interface_loader, |
|
1159 |
true, CHECK); |
|
16591
73047b0eb568
8009731: Confusing error message for loader constraint violation
acorn
parents:
15591
diff
changeset
|
1160 |
if (failed_type_symbol != NULL) { |
1 | 1161 |
const char* msg = "loader constraint violation in interface " |
1162 |
"itable initialization: when resolving method \"%s\" the class" |
|
1163 |
" loader (instance of %s) of the current class, %s, " |
|
1164 |
"and the class loader (instance of %s) for interface " |
|
1165 |
"%s have different Class objects for the type %s " |
|
1166 |
"used in the signature"; |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1167 |
char* sig = target()->name_and_sig_as_C_string(); |
1 | 1168 |
const char* loader1 = SystemDictionary::loader_name(method_holder_loader()); |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1169 |
char* current = _klass->name()->as_C_string(); |
1 | 1170 |
const char* loader2 = SystemDictionary::loader_name(interface_loader()); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1171 |
char* iface = InstanceKlass::cast(interf_h())->name()->as_C_string(); |
16591
73047b0eb568
8009731: Confusing error message for loader constraint violation
acorn
parents:
15591
diff
changeset
|
1172 |
char* failed_type_name = failed_type_symbol->as_C_string(); |
1 | 1173 |
size_t buflen = strlen(msg) + strlen(sig) + strlen(loader1) + |
1174 |
strlen(current) + strlen(loader2) + strlen(iface) + |
|
1175 |
strlen(failed_type_name); |
|
1176 |
char* buf = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, buflen); |
|
1177 |
jio_snprintf(buf, buflen, msg, sig, loader1, current, loader2, |
|
1178 |
iface, failed_type_name); |
|
1179 |
THROW_MSG(vmSymbols::java_lang_LinkageError(), buf); |
|
1180 |
} |
|
1181 |
} |
|
1182 |
} |
|
1183 |
||
1184 |
// ime may have moved during GC so recalculate address |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1185 |
int ime_num = m->itable_index(); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1186 |
assert(ime_num < ime_count, "oob"); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1187 |
itableOffsetEntry::method_entry(_klass(), method_table_offset)[ime_num].initialize(target()); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1188 |
if (TraceItables && Verbose) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1189 |
ResourceMark rm(THREAD); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1190 |
if (target() != NULL) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1191 |
char* sig = target()->name_and_sig_as_C_string(); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1192 |
tty->print("interface: %s, ime_num: %d, target: %s, method_holder: %s ", |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1193 |
interf_h()->internal_name(), ime_num, sig, |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1194 |
target()->method_holder()->internal_name()); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1195 |
tty->print("target_method flags: "); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1196 |
target()->access_flags().print_on(tty); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1197 |
if (target()->is_default_method()) { |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1198 |
tty->print("default "); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1199 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1200 |
tty->cr(); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1201 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1202 |
} |
1 | 1203 |
} |
1204 |
} |
|
1205 |
} |
|
1206 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1207 |
// Update entry for specific Method* |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1208 |
void klassItable::initialize_with_method(Method* m) { |
1 | 1209 |
itableMethodEntry* ime = method_entry(0); |
1210 |
for(int i = 0; i < _size_method_table; i++) { |
|
1211 |
if (ime->method() == m) { |
|
1212 |
ime->initialize(m); |
|
1213 |
} |
|
1214 |
ime++; |
|
1215 |
} |
|
1216 |
} |
|
1217 |
||
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1218 |
#if INCLUDE_JVMTI |
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1219 |
// search the itable for uses of either obsolete or EMCP methods |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1220 |
void klassItable::adjust_method_entries(InstanceKlass* holder, bool * trace_name_printed) { |
1 | 1221 |
|
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1222 |
itableMethodEntry* ime = method_entry(0); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1223 |
for (int i = 0; i < _size_method_table; i++, ime++) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1224 |
Method* old_method = ime->method(); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1225 |
if (old_method == NULL || old_method->method_holder() != holder || !old_method->is_old()) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1226 |
continue; // skip uninteresting entries |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1227 |
} |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1228 |
assert(!old_method->is_deleted(), "itable methods may not be deleted"); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1229 |
|
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1230 |
Method* new_method = holder->method_with_idnum(old_method->orig_method_idnum()); |
1 | 1231 |
|
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1232 |
assert(new_method != NULL, "method_with_idnum() should not be NULL"); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1233 |
assert(old_method != new_method, "sanity check"); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1234 |
|
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1235 |
ime->initialize(new_method); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1236 |
|
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1237 |
if (RC_TRACE_IN_RANGE(0x00100000, 0x00400000)) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1238 |
if (!(*trace_name_printed)) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1239 |
// RC_TRACE_MESG macro has an embedded ResourceMark |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1240 |
RC_TRACE_MESG(("adjust: name=%s", |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1241 |
old_method->method_holder()->external_name())); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1242 |
*trace_name_printed = true; |
1 | 1243 |
} |
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1244 |
// RC_TRACE macro has an embedded ResourceMark |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1245 |
RC_TRACE(0x00200000, ("itable method update: %s(%s)", |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1246 |
new_method->name()->as_C_string(), |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1247 |
new_method->signature()->as_C_string())); |
1 | 1248 |
} |
1249 |
} |
|
1250 |
} |
|
1251 |
||
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1252 |
// an itable should never contain old or obsolete methods |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1253 |
bool klassItable::check_no_old_or_obsolete_entries() { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1254 |
itableMethodEntry* ime = method_entry(0); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1255 |
for (int i = 0; i < _size_method_table; i++) { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1256 |
Method* m = ime->method(); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1257 |
if (m != NULL && |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1258 |
(NOT_PRODUCT(!m->is_valid() ||) m->is_old() || m->is_obsolete())) { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1259 |
return false; |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1260 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1261 |
ime++; |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1262 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1263 |
return true; |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1264 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1265 |
|
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1266 |
void klassItable::dump_itable() { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1267 |
itableMethodEntry* ime = method_entry(0); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1268 |
tty->print_cr("itable dump --"); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1269 |
for (int i = 0; i < _size_method_table; i++) { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1270 |
Method* m = ime->method(); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1271 |
if (m != NULL) { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1272 |
tty->print(" (%5d) ", i); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1273 |
m->access_flags().print_on(tty); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1274 |
if (m->is_default_method()) { |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1275 |
tty->print("default "); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1276 |
} |
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1277 |
tty->print(" -- "); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1278 |
m->print_name(tty); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1279 |
tty->cr(); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1280 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1281 |
ime++; |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1282 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1283 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1284 |
#endif // INCLUDE_JVMTI |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1285 |
|
1 | 1286 |
|
1287 |
// Setup |
|
1288 |
class InterfaceVisiterClosure : public StackObj { |
|
1289 |
public: |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1290 |
virtual void doit(Klass* intf, int method_count) = 0; |
1 | 1291 |
}; |
1292 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1293 |
// Visit all interfaces with at least one itable method |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1294 |
void visit_all_interfaces(Array<Klass*>* transitive_intf, InterfaceVisiterClosure *blk) { |
1 | 1295 |
// Handle array argument |
1296 |
for(int i = 0; i < transitive_intf->length(); i++) { |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1297 |
Klass* intf = transitive_intf->at(i); |
14488 | 1298 |
assert(intf->is_interface(), "sanity check"); |
1 | 1299 |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1300 |
// Find no. of itable methods |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1301 |
int method_count = 0; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1302 |
// method_count = klassItable::method_count_for_interface(intf); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1303 |
Array<Method*>* methods = InstanceKlass::cast(intf)->methods(); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1304 |
if (methods->length() > 0) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1305 |
for (int i = methods->length(); --i >= 0; ) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1306 |
if (interface_method_needs_itable_index(methods->at(i))) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1307 |
method_count++; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1308 |
} |
1 | 1309 |
} |
1310 |
} |
|
1311 |
||
1312 |
// Only count interfaces with at least one method |
|
1313 |
if (method_count > 0) { |
|
1314 |
blk->doit(intf, method_count); |
|
1315 |
} |
|
1316 |
} |
|
1317 |
} |
|
1318 |
||
1319 |
class CountInterfacesClosure : public InterfaceVisiterClosure { |
|
1320 |
private: |
|
1321 |
int _nof_methods; |
|
1322 |
int _nof_interfaces; |
|
1323 |
public: |
|
1324 |
CountInterfacesClosure() { _nof_methods = 0; _nof_interfaces = 0; } |
|
1325 |
||
1326 |
int nof_methods() const { return _nof_methods; } |
|
1327 |
int nof_interfaces() const { return _nof_interfaces; } |
|
1328 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1329 |
void doit(Klass* intf, int method_count) { _nof_methods += method_count; _nof_interfaces++; } |
1 | 1330 |
}; |
1331 |
||
1332 |
class SetupItableClosure : public InterfaceVisiterClosure { |
|
1333 |
private: |
|
1334 |
itableOffsetEntry* _offset_entry; |
|
1335 |
itableMethodEntry* _method_entry; |
|
1336 |
address _klass_begin; |
|
1337 |
public: |
|
1338 |
SetupItableClosure(address klass_begin, itableOffsetEntry* offset_entry, itableMethodEntry* method_entry) { |
|
1339 |
_klass_begin = klass_begin; |
|
1340 |
_offset_entry = offset_entry; |
|
1341 |
_method_entry = method_entry; |
|
1342 |
} |
|
1343 |
||
1344 |
itableMethodEntry* method_entry() const { return _method_entry; } |
|
1345 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1346 |
void doit(Klass* intf, int method_count) { |
1 | 1347 |
int offset = ((address)_method_entry) - _klass_begin; |
1348 |
_offset_entry->initialize(intf, offset); |
|
1349 |
_offset_entry++; |
|
1350 |
_method_entry += method_count; |
|
1351 |
} |
|
1352 |
}; |
|
1353 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1354 |
int klassItable::compute_itable_size(Array<Klass*>* transitive_interfaces) { |
1 | 1355 |
// Count no of interfaces and total number of interface methods |
1356 |
CountInterfacesClosure cic; |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1357 |
visit_all_interfaces(transitive_interfaces, &cic); |
1 | 1358 |
|
189
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1359 |
// There's alway an extra itable entry so we can null-terminate it. |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1360 |
int itable_size = calc_itable_size(cic.nof_interfaces() + 1, cic.nof_methods()); |
1 | 1361 |
|
1362 |
// Statistics |
|
1363 |
update_stats(itable_size * HeapWordSize); |
|
1364 |
||
1365 |
return itable_size; |
|
1366 |
} |
|
1367 |
||
1368 |
||
1369 |
// Fill out offset table and interface klasses into the itable space |
|
1370 |
void klassItable::setup_itable_offset_table(instanceKlassHandle klass) { |
|
1371 |
if (klass->itable_length() == 0) return; |
|
1372 |
assert(!klass->is_interface(), "Should have zero length itable"); |
|
1373 |
||
1374 |
// Count no of interfaces and total number of interface methods |
|
1375 |
CountInterfacesClosure cic; |
|
1376 |
visit_all_interfaces(klass->transitive_interfaces(), &cic); |
|
1377 |
int nof_methods = cic.nof_methods(); |
|
1378 |
int nof_interfaces = cic.nof_interfaces(); |
|
1379 |
||
189
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1380 |
// Add one extra entry so we can null-terminate the table |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1381 |
nof_interfaces++; |
1 | 1382 |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1383 |
assert(compute_itable_size(klass->transitive_interfaces()) == |
1 | 1384 |
calc_itable_size(nof_interfaces, nof_methods), |
1385 |
"mismatch calculation of itable size"); |
|
1386 |
||
1387 |
// Fill-out offset table |
|
1388 |
itableOffsetEntry* ioe = (itableOffsetEntry*)klass->start_of_itable(); |
|
1389 |
itableMethodEntry* ime = (itableMethodEntry*)(ioe + nof_interfaces); |
|
1390 |
intptr_t* end = klass->end_of_itable(); |
|
8725
8c1e3dd5fe1b
7017732: move static fields into Class to prepare for perm gen removal
never
parents:
8653
diff
changeset
|
1391 |
assert((oop*)(ime + nof_methods) <= (oop*)klass->start_of_nonstatic_oop_maps(), "wrong offset calculation (1)"); |
360
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
189
diff
changeset
|
1392 |
assert((oop*)(end) == (oop*)(ime + nof_methods), "wrong offset calculation (2)"); |
1 | 1393 |
|
1394 |
// Visit all interfaces and initialize itable offset table |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1395 |
SetupItableClosure sic((address)klass(), ioe, ime); |
1 | 1396 |
visit_all_interfaces(klass->transitive_interfaces(), &sic); |
1397 |
||
1398 |
#ifdef ASSERT |
|
1399 |
ime = sic.method_entry(); |
|
1400 |
oop* v = (oop*) klass->end_of_itable(); |
|
1401 |
assert( (oop*)(ime) == v, "wrong offset calculation (2)"); |
|
1402 |
#endif |
|
1403 |
} |
|
1404 |
||
1405 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1406 |
// inverse to itable_index |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1407 |
Method* klassItable::method_for_itable_index(Klass* intf, int itable_index) { |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1408 |
assert(InstanceKlass::cast(intf)->is_interface(), "sanity check"); |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1409 |
assert(intf->verify_itable_index(itable_index), ""); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1410 |
Array<Method*>* methods = InstanceKlass::cast(intf)->methods(); |
2332
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2136
diff
changeset
|
1411 |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1412 |
if (itable_index < 0 || itable_index >= method_count_for_interface(intf)) |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1413 |
return NULL; // help caller defend against bad indices |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1414 |
|
2332
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2136
diff
changeset
|
1415 |
int index = itable_index; |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1416 |
Method* m = methods->at(index); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1417 |
int index2 = -1; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1418 |
while (!m->has_itable_index() || |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1419 |
(index2 = m->itable_index()) != itable_index) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1420 |
assert(index2 < itable_index, "monotonic"); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1421 |
if (++index == methods->length()) |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1422 |
return NULL; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1423 |
m = methods->at(index); |
2332
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2136
diff
changeset
|
1424 |
} |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1425 |
assert(m->itable_index() == itable_index, "correct inverse"); |
2332
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2136
diff
changeset
|
1426 |
|
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2136
diff
changeset
|
1427 |
return m; |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2136
diff
changeset
|
1428 |
} |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2136
diff
changeset
|
1429 |
|
1 | 1430 |
void klassVtable::verify(outputStream* st, bool forced) { |
1431 |
// make sure table is initialized |
|
1432 |
if (!Universe::is_fully_initialized()) return; |
|
1433 |
#ifndef PRODUCT |
|
1434 |
// avoid redundant verifies |
|
1435 |
if (!forced && _verify_count == Universe::verify_count()) return; |
|
1436 |
_verify_count = Universe::verify_count(); |
|
1437 |
#endif |
|
1438 |
oop* end_of_obj = (oop*)_klass() + _klass()->size(); |
|
1439 |
oop* end_of_vtable = (oop *)&table()[_length]; |
|
1440 |
if (end_of_vtable > end_of_obj) { |
|
5403
6b0dd9c75dde
6888954: argument formatting for assert() and friends
jcoomes
parents:
5402
diff
changeset
|
1441 |
fatal(err_msg("klass %s: klass object too short (vtable extends beyond " |
6b0dd9c75dde
6888954: argument formatting for assert() and friends
jcoomes
parents:
5402
diff
changeset
|
1442 |
"end)", _klass->internal_name())); |
1 | 1443 |
} |
1444 |
||
1445 |
for (int i = 0; i < _length; i++) table()[i].verify(this, st); |
|
1446 |
// verify consistency with superKlass vtable |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1447 |
Klass* super = _klass->super(); |
1 | 1448 |
if (super != NULL) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1449 |
InstanceKlass* sk = InstanceKlass::cast(super); |
1 | 1450 |
klassVtable* vt = sk->vtable(); |
1451 |
for (int i = 0; i < vt->length(); i++) { |
|
1452 |
verify_against(st, vt, i); |
|
1453 |
} |
|
1454 |
} |
|
1455 |
} |
|
1456 |
||
1457 |
void klassVtable::verify_against(outputStream* st, klassVtable* vt, int index) { |
|
1458 |
vtableEntry* vte = &vt->table()[index]; |
|
1459 |
if (vte->method()->name() != table()[index].method()->name() || |
|
1460 |
vte->method()->signature() != table()[index].method()->signature()) { |
|
1461 |
fatal("mismatched name/signature of vtable entries"); |
|
1462 |
} |
|
1463 |
} |
|
1464 |
||
1465 |
#ifndef PRODUCT |
|
1466 |
void klassVtable::print() { |
|
1467 |
ResourceMark rm; |
|
1468 |
tty->print("klassVtable for klass %s (length %d):\n", _klass->internal_name(), length()); |
|
1469 |
for (int i = 0; i < length(); i++) { |
|
1470 |
table()[i].print(); |
|
1471 |
tty->cr(); |
|
1472 |
} |
|
1473 |
} |
|
1474 |
#endif |
|
1475 |
||
1476 |
void vtableEntry::verify(klassVtable* vt, outputStream* st) { |
|
1477 |
NOT_PRODUCT(FlagSetting fs(IgnoreLockingAssertions, true)); |
|
1478 |
assert(method() != NULL, "must have set method"); |
|
1479 |
method()->verify(); |
|
1480 |
// we sub_type, because it could be a miranda method |
|
1481 |
if (!vt->klass()->is_subtype_of(method()->method_holder())) { |
|
1482 |
#ifndef PRODUCT |
|
1483 |
print(); |
|
1484 |
#endif |
|
5403
6b0dd9c75dde
6888954: argument formatting for assert() and friends
jcoomes
parents:
5402
diff
changeset
|
1485 |
fatal(err_msg("vtableEntry " PTR_FORMAT ": method is from subclass", this)); |
1 | 1486 |
} |
1487 |
} |
|
1488 |
||
1489 |
#ifndef PRODUCT |
|
1490 |
||
1491 |
void vtableEntry::print() { |
|
1492 |
ResourceMark rm; |
|
1493 |
tty->print("vtableEntry %s: ", method()->name()->as_C_string()); |
|
1494 |
if (Verbose) { |
|
1495 |
tty->print("m %#lx ", (address)method()); |
|
1496 |
} |
|
1497 |
} |
|
1498 |
||
1499 |
class VtableStats : AllStatic { |
|
1500 |
public: |
|
1501 |
static int no_klasses; // # classes with vtables |
|
1502 |
static int no_array_klasses; // # array classes |
|
1503 |
static int no_instance_klasses; // # instanceKlasses |
|
1504 |
static int sum_of_vtable_len; // total # of vtable entries |
|
1505 |
static int sum_of_array_vtable_len; // total # of vtable entries in array klasses only |
|
1506 |
static int fixed; // total fixed overhead in bytes |
|
1507 |
static int filler; // overhead caused by filler bytes |
|
1508 |
static int entries; // total bytes consumed by vtable entries |
|
1509 |
static int array_entries; // total bytes consumed by array vtable entries |
|
1510 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1511 |
static void do_class(Klass* k) { |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1512 |
Klass* kl = k; |
1 | 1513 |
klassVtable* vt = kl->vtable(); |
1514 |
if (vt == NULL) return; |
|
1515 |
no_klasses++; |
|
1516 |
if (kl->oop_is_instance()) { |
|
1517 |
no_instance_klasses++; |
|
1518 |
kl->array_klasses_do(do_class); |
|
1519 |
} |
|
1520 |
if (kl->oop_is_array()) { |
|
1521 |
no_array_klasses++; |
|
1522 |
sum_of_array_vtable_len += vt->length(); |
|
1523 |
} |
|
1524 |
sum_of_vtable_len += vt->length(); |
|
1525 |
} |
|
1526 |
||
1527 |
static void compute() { |
|
1528 |
SystemDictionary::classes_do(do_class); |
|
1529 |
fixed = no_klasses * oopSize; // vtable length |
|
1530 |
// filler size is a conservative approximation |
|
13952
e3cf184080bc
8000213: NPG: Should have renamed arrayKlass and typeArrayKlass
coleenp
parents:
13728
diff
changeset
|
1531 |
filler = oopSize * (no_klasses - no_instance_klasses) * (sizeof(InstanceKlass) - sizeof(ArrayKlass) - 1); |
1 | 1532 |
entries = sizeof(vtableEntry) * sum_of_vtable_len; |
1533 |
array_entries = sizeof(vtableEntry) * sum_of_array_vtable_len; |
|
1534 |
} |
|
1535 |
}; |
|
1536 |
||
1537 |
int VtableStats::no_klasses = 0; |
|
1538 |
int VtableStats::no_array_klasses = 0; |
|
1539 |
int VtableStats::no_instance_klasses = 0; |
|
1540 |
int VtableStats::sum_of_vtable_len = 0; |
|
1541 |
int VtableStats::sum_of_array_vtable_len = 0; |
|
1542 |
int VtableStats::fixed = 0; |
|
1543 |
int VtableStats::filler = 0; |
|
1544 |
int VtableStats::entries = 0; |
|
1545 |
int VtableStats::array_entries = 0; |
|
1546 |
||
1547 |
void klassVtable::print_statistics() { |
|
1548 |
ResourceMark rm; |
|
1549 |
HandleMark hm; |
|
1550 |
VtableStats::compute(); |
|
1551 |
tty->print_cr("vtable statistics:"); |
|
1552 |
tty->print_cr("%6d classes (%d instance, %d array)", VtableStats::no_klasses, VtableStats::no_instance_klasses, VtableStats::no_array_klasses); |
|
1553 |
int total = VtableStats::fixed + VtableStats::filler + VtableStats::entries; |
|
1554 |
tty->print_cr("%6d bytes fixed overhead (refs + vtable object header)", VtableStats::fixed); |
|
1555 |
tty->print_cr("%6d bytes filler overhead", VtableStats::filler); |
|
1556 |
tty->print_cr("%6d bytes for vtable entries (%d for arrays)", VtableStats::entries, VtableStats::array_entries); |
|
1557 |
tty->print_cr("%6d bytes total", total); |
|
1558 |
} |
|
1559 |
||
1560 |
int klassItable::_total_classes; // Total no. of classes with itables |
|
1561 |
long klassItable::_total_size; // Total no. of bytes used for itables |
|
1562 |
||
1563 |
void klassItable::print_statistics() { |
|
1564 |
tty->print_cr("itable statistics:"); |
|
1565 |
tty->print_cr("%6d classes with itables", _total_classes); |
|
1566 |
tty->print_cr("%6d K uses for itables (average by class: %d bytes)", _total_size / K, _total_size / _total_classes); |
|
1567 |
} |
|
1568 |
||
1569 |
#endif // PRODUCT |