author | egahlin |
Tue, 15 May 2018 20:24:34 +0200 | |
changeset 50113 | caf115bb98ad |
parent 50057 | f945444fabc3 |
child 50233 | 48d4abe945f1 |
permissions | -rw-r--r-- |
24426 | 1 |
/* |
49041
44122f767467
8198286: Direct memory accessors in typeArrayOop.hpp should use Access API
eosterlund
parents:
48618
diff
changeset
|
2 |
* Copyright (c) 1997, 2018, Oracle and/or its affiliates. All rights reserved. |
24426 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
20 |
* or visit www.oracle.com if you need additional information or have any |
|
21 |
* questions. |
|
22 |
* |
|
23 |
*/ |
|
24 |
||
25 |
#include "precompiled.hpp" |
|
26 |
#include "classfile/altHashing.hpp" |
|
34659
3a7071043457
8143615: compactHashtable.hpp includes .inline.hpp file
iklam
parents:
33628
diff
changeset
|
27 |
#include "classfile/compactHashtable.inline.hpp" |
35498
392b50de06c6
8146401: Clean up oop.hpp: add inline directives and fix header files
goetz
parents:
34659
diff
changeset
|
28 |
#include "classfile/javaClasses.inline.hpp" |
24426 | 29 |
#include "classfile/stringTable.hpp" |
30 |
#include "classfile/systemDictionary.hpp" |
|
50057
f945444fabc3
8202647: Add deduplicate_string function to CollectedHeap
stefank
parents:
49982
diff
changeset
|
31 |
#include "gc/shared/collectedHeap.hpp" |
46522
86b13b03a053
8176132: -XX:+PrintSharedSpaces should be converted to use Unified Logging.
rprotacio
parents:
46488
diff
changeset
|
32 |
#include "logging/log.hpp" |
24426 | 33 |
#include "memory/allocation.inline.hpp" |
34 |
#include "memory/filemap.hpp" |
|
46746
ea379ebb9447
8072061: Automatically determine optimal sizes for the CDS regions
iklam
parents:
46742
diff
changeset
|
35 |
#include "memory/metaspaceShared.hpp" |
37248 | 36 |
#include "memory/resourceArea.hpp" |
50057
f945444fabc3
8202647: Add deduplicate_string function to CollectedHeap
stefank
parents:
49982
diff
changeset
|
37 |
#include "memory/universe.hpp" |
48618
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
38 |
#include "oops/access.inline.hpp" |
24426 | 39 |
#include "oops/oop.inline.hpp" |
49041
44122f767467
8198286: Direct memory accessors in typeArrayOop.hpp should use Access API
eosterlund
parents:
48618
diff
changeset
|
40 |
#include "oops/typeArrayOop.inline.hpp" |
40655
9f644073d3a0
8157907: Incorrect inclusion of atomic.hpp instead of atomic.inline.hpp
dholmes
parents:
38647
diff
changeset
|
41 |
#include "runtime/atomic.hpp" |
49393 | 42 |
#include "runtime/handles.inline.hpp" |
24426 | 43 |
#include "runtime/mutexLocker.hpp" |
49594
898ef81cbc0e
8200106: Move NoSafepointVerifier out from gcLocker.hpp
stefank
parents:
49393
diff
changeset
|
44 |
#include "runtime/safepointVerifiers.hpp" |
46742 | 45 |
#include "services/diagnosticCommand.hpp" |
24426 | 46 |
#include "utilities/hashtable.inline.hpp" |
27684
e0391b2bf625
8064581: Move INCLUDE_ALL_GCS include section to the end of the include list
stefank
parents:
26421
diff
changeset
|
47 |
#include "utilities/macros.hpp" |
24426 | 48 |
|
49 |
// the number of buckets a thread claims |
|
50 |
const int ClaimChunkSize = 32; |
|
51 |
||
52 |
#ifdef ASSERT |
|
53 |
class StableMemoryChecker : public StackObj { |
|
54 |
enum { _bufsize = wordSize*4 }; |
|
55 |
||
56 |
address _region; |
|
57 |
jint _size; |
|
58 |
u1 _save_buf[_bufsize]; |
|
59 |
||
60 |
int sample(u1* save_buf) { |
|
61 |
if (_size <= _bufsize) { |
|
62 |
memcpy(save_buf, _region, _size); |
|
63 |
return _size; |
|
64 |
} else { |
|
65 |
// copy head and tail |
|
66 |
memcpy(&save_buf[0], _region, _bufsize/2); |
|
67 |
memcpy(&save_buf[_bufsize/2], _region + _size - _bufsize/2, _bufsize/2); |
|
68 |
return (_bufsize/2)*2; |
|
69 |
} |
|
70 |
} |
|
71 |
||
72 |
public: |
|
73 |
StableMemoryChecker(const void* region, jint size) { |
|
74 |
_region = (address) region; |
|
75 |
_size = size; |
|
76 |
sample(_save_buf); |
|
77 |
} |
|
78 |
||
79 |
bool verify() { |
|
80 |
u1 check_buf[sizeof(_save_buf)]; |
|
81 |
int check_size = sample(check_buf); |
|
82 |
return (0 == memcmp(_save_buf, check_buf, check_size)); |
|
83 |
} |
|
84 |
||
85 |
void set_region(const void* region) { _region = (address) region; } |
|
86 |
}; |
|
87 |
#endif |
|
88 |
||
89 |
||
90 |
// -------------------------------------------------------------------------- |
|
91 |
StringTable* StringTable::_the_table = NULL; |
|
46810
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
92 |
bool StringTable::_shared_string_mapped = false; |
24426 | 93 |
bool StringTable::_needs_rehashing = false; |
94 |
||
95 |
volatile int StringTable::_parallel_claimed_idx = 0; |
|
96 |
||
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
97 |
CompactHashtable<oop, char> StringTable::_shared_table; |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
98 |
|
24426 | 99 |
// Pick hashing algorithm |
37172
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
100 |
unsigned int StringTable::hash_string(const jchar* s, int len) { |
44323
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
101 |
return use_alternate_hashcode() ? alt_hash_string(s, len) : |
24426 | 102 |
java_lang_String::hash_code(s, len); |
103 |
} |
|
104 |
||
44323
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
105 |
unsigned int StringTable::alt_hash_string(const jchar* s, int len) { |
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
106 |
return AltHashing::murmur3_32(seed(), s, len); |
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
107 |
} |
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
108 |
|
37172
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
109 |
unsigned int StringTable::hash_string(oop string) { |
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
110 |
EXCEPTION_MARK; |
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
111 |
if (string == NULL) { |
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
112 |
return hash_string((jchar*)NULL, 0); |
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
113 |
} |
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
114 |
ResourceMark rm(THREAD); |
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
115 |
// All String oops are hashed as unicode |
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
116 |
int length; |
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
117 |
jchar* chars = java_lang_String::as_unicode_string(string, length, THREAD); |
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
118 |
if (chars != NULL) { |
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
119 |
return hash_string(chars, length); |
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
120 |
} else { |
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
121 |
vm_exit_out_of_memory(length, OOM_MALLOC_ERROR, "unable to create Unicode string for verification"); |
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
122 |
return 0; |
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
123 |
} |
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
124 |
} |
33628 | 125 |
|
48618
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
126 |
oop StringTable::string_object(HashtableEntry<oop, mtSymbol>* entry) { |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
127 |
return RootAccess<ON_PHANTOM_OOP_REF>::oop_load(entry->literal_addr()); |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
128 |
} |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
129 |
|
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
130 |
oop StringTable::string_object_no_keepalive(HashtableEntry<oop, mtSymbol>* entry) { |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
131 |
// The AS_NO_KEEPALIVE peeks at the oop without keeping it alive. |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
132 |
// This is *very dangerous* in general but is okay in this specific |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
133 |
// case. The subsequent oop_load keeps the oop alive if it it matched |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
134 |
// the jchar* string. |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
135 |
return RootAccess<ON_PHANTOM_OOP_REF | AS_NO_KEEPALIVE>::oop_load(entry->literal_addr()); |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
136 |
} |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
137 |
|
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
138 |
void StringTable::set_string_object(HashtableEntry<oop, mtSymbol>* entry, oop string) { |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
139 |
RootAccess<ON_PHANTOM_OOP_REF>::oop_store(entry->literal_addr(), string); |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
140 |
} |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
141 |
|
44323
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
142 |
oop StringTable::lookup_shared(jchar* name, int len, unsigned int hash) { |
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
143 |
assert(hash == java_lang_String::hash_code(name, len), |
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
144 |
"hash must be computed using java_lang_String::hash_code"); |
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
145 |
return _shared_table.lookup((const char*)name, hash, len); |
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
146 |
} |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
147 |
|
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
148 |
oop StringTable::lookup_in_main_table(int index, jchar* name, |
48618
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
149 |
int len, unsigned int hash) { |
24426 | 150 |
int count = 0; |
151 |
for (HashtableEntry<oop, mtSymbol>* l = bucket(index); l != NULL; l = l->next()) { |
|
152 |
count++; |
|
153 |
if (l->hash() == hash) { |
|
48618
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
154 |
if (java_lang_String::equals(string_object_no_keepalive(l), name, len)) { |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
155 |
// We must perform a new load with string_object() that keeps the string |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
156 |
// alive as we must expose the oop as strongly reachable when exiting |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
157 |
// this context, in case the oop gets published. |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
158 |
return string_object(l); |
24426 | 159 |
} |
160 |
} |
|
161 |
} |
|
162 |
// If the bucket size is too deep check if this hash code is insufficient. |
|
26421
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
25492
diff
changeset
|
163 |
if (count >= rehash_count && !needs_rehashing()) { |
24426 | 164 |
_needs_rehashing = check_rehash_table(count); |
165 |
} |
|
166 |
return NULL; |
|
167 |
} |
|
168 |
||
169 |
||
170 |
oop StringTable::basic_add(int index_arg, Handle string, jchar* name, |
|
171 |
int len, unsigned int hashValue_arg, TRAPS) { |
|
172 |
||
173 |
assert(java_lang_String::equals(string(), name, len), |
|
174 |
"string must be properly initialized"); |
|
175 |
// Cannot hit a safepoint in this function because the "this" pointer can move. |
|
35492
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
34659
diff
changeset
|
176 |
NoSafepointVerifier nsv; |
24426 | 177 |
|
178 |
// Check if the symbol table has been rehashed, if so, need to recalculate |
|
179 |
// the hash value and index before second lookup. |
|
180 |
unsigned int hashValue; |
|
181 |
int index; |
|
182 |
if (use_alternate_hashcode()) { |
|
44323
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
183 |
hashValue = alt_hash_string(name, len); |
24426 | 184 |
index = hash_to_index(hashValue); |
185 |
} else { |
|
186 |
hashValue = hashValue_arg; |
|
187 |
index = index_arg; |
|
188 |
} |
|
189 |
||
190 |
// Since look-up was done lock-free, we need to check if another |
|
191 |
// thread beat us in the race to insert the symbol. |
|
192 |
||
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
193 |
// No need to lookup the shared table from here since the caller (intern()) already did |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
194 |
oop test = lookup_in_main_table(index, name, len, hashValue); // calls lookup(u1*, int) |
24426 | 195 |
if (test != NULL) { |
196 |
// Entry already added |
|
197 |
return test; |
|
198 |
} |
|
199 |
||
200 |
HashtableEntry<oop, mtSymbol>* entry = new_entry(hashValue, string()); |
|
201 |
add_entry(index, entry); |
|
202 |
return string(); |
|
203 |
} |
|
204 |
||
205 |
||
206 |
oop StringTable::lookup(Symbol* symbol) { |
|
207 |
ResourceMark rm; |
|
208 |
int length; |
|
209 |
jchar* chars = symbol->as_unicode(length); |
|
210 |
return lookup(chars, length); |
|
211 |
} |
|
212 |
||
213 |
oop StringTable::lookup(jchar* name, int len) { |
|
44323
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
214 |
// shared table always uses java_lang_String::hash_code |
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
215 |
unsigned int hash = java_lang_String::hash_code(name, len); |
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
216 |
oop string = lookup_shared(name, len, hash); |
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
217 |
if (string != NULL) { |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
218 |
return string; |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
219 |
} |
44323
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
220 |
if (use_alternate_hashcode()) { |
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
221 |
hash = alt_hash_string(name, len); |
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
222 |
} |
24426 | 223 |
int index = the_table()->hash_to_index(hash); |
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
224 |
string = the_table()->lookup_in_main_table(index, name, len, hash); |
25492
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
225 |
|
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
226 |
return string; |
24426 | 227 |
} |
228 |
||
229 |
oop StringTable::intern(Handle string_or_null, jchar* name, |
|
230 |
int len, TRAPS) { |
|
44323
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
231 |
// shared table always uses java_lang_String::hash_code |
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
232 |
unsigned int hashValue = java_lang_String::hash_code(name, len); |
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
233 |
oop found_string = lookup_shared(name, len, hashValue); |
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
234 |
if (found_string != NULL) { |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
235 |
return found_string; |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
236 |
} |
44323
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
237 |
if (use_alternate_hashcode()) { |
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
238 |
hashValue = alt_hash_string(name, len); |
1566bea4793a
8176593: Throwable::getStackTrace performance regression
redestad
parents:
42057
diff
changeset
|
239 |
} |
24426 | 240 |
int index = the_table()->hash_to_index(hashValue); |
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
241 |
found_string = the_table()->lookup_in_main_table(index, name, len, hashValue); |
24426 | 242 |
|
243 |
// Found |
|
25492
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
244 |
if (found_string != NULL) { |
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
245 |
return found_string; |
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
246 |
} |
24426 | 247 |
|
248 |
debug_only(StableMemoryChecker smc(name, len * sizeof(name[0]))); |
|
249 |
assert(!Universe::heap()->is_in_reserved(name), |
|
250 |
"proposed name of symbol must be stable"); |
|
251 |
||
46271
979ebd346ecf
8169881: Remove implicit Handle conversions oop->Handle
coleenp
parents:
42057
diff
changeset
|
252 |
HandleMark hm(THREAD); // cleanup strings created |
24426 | 253 |
Handle string; |
254 |
// try to reuse the string if possible |
|
255 |
if (!string_or_null.is_null()) { |
|
256 |
string = string_or_null; |
|
257 |
} else { |
|
258 |
string = java_lang_String::create_from_unicode(name, len, CHECK_NULL); |
|
259 |
} |
|
260 |
||
50057
f945444fabc3
8202647: Add deduplicate_string function to CollectedHeap
stefank
parents:
49982
diff
changeset
|
261 |
// Deduplicate the string before it is interned. Note that we should never |
f945444fabc3
8202647: Add deduplicate_string function to CollectedHeap
stefank
parents:
49982
diff
changeset
|
262 |
// deduplicate a string after it has been interned. Doing so will counteract |
f945444fabc3
8202647: Add deduplicate_string function to CollectedHeap
stefank
parents:
49982
diff
changeset
|
263 |
// compiler optimizations done on e.g. interned string literals. |
f945444fabc3
8202647: Add deduplicate_string function to CollectedHeap
stefank
parents:
49982
diff
changeset
|
264 |
Universe::heap()->deduplicate_string(string()); |
24426 | 265 |
|
266 |
// Grab the StringTable_lock before getting the_table() because it could |
|
267 |
// change at safepoint. |
|
25492
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
268 |
oop added_or_found; |
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
269 |
{ |
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
270 |
MutexLocker ml(StringTable_lock, THREAD); |
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
271 |
// Otherwise, add to symbol to table |
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
272 |
added_or_found = the_table()->basic_add(index, string, name, len, |
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
273 |
hashValue, CHECK_NULL); |
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
274 |
} |
24426 | 275 |
|
25492
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
276 |
return added_or_found; |
24426 | 277 |
} |
278 |
||
279 |
oop StringTable::intern(Symbol* symbol, TRAPS) { |
|
280 |
if (symbol == NULL) return NULL; |
|
281 |
ResourceMark rm(THREAD); |
|
282 |
int length; |
|
283 |
jchar* chars = symbol->as_unicode(length); |
|
284 |
Handle string; |
|
285 |
oop result = intern(string, chars, length, CHECK_NULL); |
|
286 |
return result; |
|
287 |
} |
|
288 |
||
289 |
||
290 |
oop StringTable::intern(oop string, TRAPS) |
|
291 |
{ |
|
292 |
if (string == NULL) return NULL; |
|
293 |
ResourceMark rm(THREAD); |
|
294 |
int length; |
|
295 |
Handle h_string (THREAD, string); |
|
296 |
jchar* chars = java_lang_String::as_unicode_string(string, length, CHECK_NULL); |
|
297 |
oop result = intern(h_string, chars, length, CHECK_NULL); |
|
298 |
return result; |
|
299 |
} |
|
300 |
||
301 |
||
302 |
oop StringTable::intern(const char* utf8_string, TRAPS) { |
|
303 |
if (utf8_string == NULL) return NULL; |
|
304 |
ResourceMark rm(THREAD); |
|
305 |
int length = UTF8::unicode_length(utf8_string); |
|
306 |
jchar* chars = NEW_RESOURCE_ARRAY(jchar, length); |
|
307 |
UTF8::convert_to_unicode(utf8_string, chars, length); |
|
308 |
Handle string; |
|
309 |
oop result = intern(string, chars, length, CHECK_NULL); |
|
310 |
return result; |
|
311 |
} |
|
312 |
||
313 |
void StringTable::unlink_or_oops_do(BoolObjectClosure* is_alive, OopClosure* f, int* processed, int* removed) { |
|
45114
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
44323
diff
changeset
|
314 |
BucketUnlinkContext context; |
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
44323
diff
changeset
|
315 |
buckets_unlink_or_oops_do(is_alive, f, 0, the_table()->table_size(), &context); |
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
44323
diff
changeset
|
316 |
_the_table->bulk_free_entries(&context); |
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
44323
diff
changeset
|
317 |
*processed = context._num_processed; |
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
44323
diff
changeset
|
318 |
*removed = context._num_removed; |
24426 | 319 |
} |
320 |
||
321 |
void StringTable::possibly_parallel_unlink_or_oops_do(BoolObjectClosure* is_alive, OopClosure* f, int* processed, int* removed) { |
|
322 |
// Readers of the table are unlocked, so we should only be removing |
|
323 |
// entries at a safepoint. |
|
324 |
assert(SafepointSynchronize::is_at_safepoint(), "must be at safepoint"); |
|
325 |
const int limit = the_table()->table_size(); |
|
326 |
||
45114
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
44323
diff
changeset
|
327 |
BucketUnlinkContext context; |
24426 | 328 |
for (;;) { |
329 |
// Grab next set of buckets to scan |
|
330 |
int start_idx = Atomic::add(ClaimChunkSize, &_parallel_claimed_idx) - ClaimChunkSize; |
|
331 |
if (start_idx >= limit) { |
|
332 |
// End of table |
|
333 |
break; |
|
334 |
} |
|
335 |
||
336 |
int end_idx = MIN2(limit, start_idx + ClaimChunkSize); |
|
45114
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
44323
diff
changeset
|
337 |
buckets_unlink_or_oops_do(is_alive, f, start_idx, end_idx, &context); |
24426 | 338 |
} |
45114
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
44323
diff
changeset
|
339 |
_the_table->bulk_free_entries(&context); |
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
44323
diff
changeset
|
340 |
*processed = context._num_processed; |
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
44323
diff
changeset
|
341 |
*removed = context._num_removed; |
24426 | 342 |
} |
343 |
||
344 |
void StringTable::buckets_oops_do(OopClosure* f, int start_idx, int end_idx) { |
|
345 |
const int limit = the_table()->table_size(); |
|
346 |
||
347 |
assert(0 <= start_idx && start_idx <= limit, |
|
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
31345
diff
changeset
|
348 |
"start_idx (%d) is out of bounds", start_idx); |
24426 | 349 |
assert(0 <= end_idx && end_idx <= limit, |
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
31345
diff
changeset
|
350 |
"end_idx (%d) is out of bounds", end_idx); |
24426 | 351 |
assert(start_idx <= end_idx, |
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
31345
diff
changeset
|
352 |
"Index ordering: start_idx=%d, end_idx=%d", |
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
31345
diff
changeset
|
353 |
start_idx, end_idx); |
24426 | 354 |
|
355 |
for (int i = start_idx; i < end_idx; i += 1) { |
|
356 |
HashtableEntry<oop, mtSymbol>* entry = the_table()->bucket(i); |
|
357 |
while (entry != NULL) { |
|
358 |
assert(!entry->is_shared(), "CDS not used for the StringTable"); |
|
359 |
||
360 |
f->do_oop((oop*)entry->literal_addr()); |
|
361 |
||
362 |
entry = entry->next(); |
|
363 |
} |
|
364 |
} |
|
365 |
} |
|
366 |
||
45114
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
44323
diff
changeset
|
367 |
void StringTable::buckets_unlink_or_oops_do(BoolObjectClosure* is_alive, OopClosure* f, int start_idx, int end_idx, BucketUnlinkContext* context) { |
24426 | 368 |
const int limit = the_table()->table_size(); |
369 |
||
370 |
assert(0 <= start_idx && start_idx <= limit, |
|
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
31345
diff
changeset
|
371 |
"start_idx (%d) is out of bounds", start_idx); |
24426 | 372 |
assert(0 <= end_idx && end_idx <= limit, |
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
31345
diff
changeset
|
373 |
"end_idx (%d) is out of bounds", end_idx); |
24426 | 374 |
assert(start_idx <= end_idx, |
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
31345
diff
changeset
|
375 |
"Index ordering: start_idx=%d, end_idx=%d", |
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
31345
diff
changeset
|
376 |
start_idx, end_idx); |
24426 | 377 |
|
378 |
for (int i = start_idx; i < end_idx; ++i) { |
|
379 |
HashtableEntry<oop, mtSymbol>** p = the_table()->bucket_addr(i); |
|
380 |
HashtableEntry<oop, mtSymbol>* entry = the_table()->bucket(i); |
|
381 |
while (entry != NULL) { |
|
382 |
assert(!entry->is_shared(), "CDS not used for the StringTable"); |
|
383 |
||
48618
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
384 |
if (is_alive->do_object_b(string_object_no_keepalive(entry))) { |
24426 | 385 |
if (f != NULL) { |
48618
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
386 |
f->do_oop(entry->literal_addr()); |
24426 | 387 |
} |
388 |
p = entry->next_addr(); |
|
389 |
} else { |
|
390 |
*p = entry->next(); |
|
45114
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
44323
diff
changeset
|
391 |
context->free_entry(entry); |
24426 | 392 |
} |
45114
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
44323
diff
changeset
|
393 |
context->_num_processed++; |
24426 | 394 |
entry = *p; |
395 |
} |
|
396 |
} |
|
397 |
} |
|
398 |
||
399 |
void StringTable::oops_do(OopClosure* f) { |
|
400 |
buckets_oops_do(f, 0, the_table()->table_size()); |
|
401 |
} |
|
402 |
||
403 |
void StringTable::possibly_parallel_oops_do(OopClosure* f) { |
|
404 |
const int limit = the_table()->table_size(); |
|
405 |
||
406 |
for (;;) { |
|
407 |
// Grab next set of buckets to scan |
|
408 |
int start_idx = Atomic::add(ClaimChunkSize, &_parallel_claimed_idx) - ClaimChunkSize; |
|
409 |
if (start_idx >= limit) { |
|
410 |
// End of table |
|
411 |
break; |
|
412 |
} |
|
413 |
||
414 |
int end_idx = MIN2(limit, start_idx + ClaimChunkSize); |
|
415 |
buckets_oops_do(f, start_idx, end_idx); |
|
416 |
} |
|
417 |
} |
|
418 |
||
419 |
// This verification is part of Universe::verify() and needs to be quick. |
|
420 |
// See StringTable::verify_and_compare() below for exhaustive verification. |
|
421 |
void StringTable::verify() { |
|
422 |
for (int i = 0; i < the_table()->table_size(); ++i) { |
|
423 |
HashtableEntry<oop, mtSymbol>* p = the_table()->bucket(i); |
|
424 |
for ( ; p != NULL; p = p->next()) { |
|
48618
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
425 |
oop s = string_object_no_keepalive(p); |
24426 | 426 |
guarantee(s != NULL, "interned string is NULL"); |
37172
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
427 |
unsigned int h = hash_string(s); |
24426 | 428 |
guarantee(p->hash() == h, "broken hash in string table entry"); |
429 |
guarantee(the_table()->hash_to_index(h) == i, |
|
430 |
"wrong index in string table"); |
|
431 |
} |
|
432 |
} |
|
433 |
} |
|
434 |
||
28363
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
435 |
void StringTable::dump(outputStream* st, bool verbose) { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
436 |
if (!verbose) { |
46742 | 437 |
the_table()->print_table_statistics(st, "StringTable"); |
28363
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
438 |
} else { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
439 |
Thread* THREAD = Thread::current(); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
440 |
st->print_cr("VERSION: 1.1"); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
441 |
for (int i = 0; i < the_table()->table_size(); ++i) { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
442 |
HashtableEntry<oop, mtSymbol>* p = the_table()->bucket(i); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
443 |
for ( ; p != NULL; p = p->next()) { |
48618
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
444 |
oop s = string_object_no_keepalive(p); |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
445 |
typeArrayOop value = java_lang_String::value_no_keepalive(s); |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
446 |
int length = java_lang_String::length(s); |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
447 |
bool is_latin1 = java_lang_String::is_latin1(s); |
28363
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
448 |
|
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
449 |
if (length <= 0) { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
450 |
st->print("%d: ", length); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
451 |
} else { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
452 |
ResourceMark rm(THREAD); |
42057
6a5b8ebcd3f2
8164612: NoSuchMethodException when method name contains NULL or Latin-1 supplement character
thartmann
parents:
40655
diff
changeset
|
453 |
int utf8_length = length; |
33628 | 454 |
char* utf8_string; |
455 |
||
456 |
if (!is_latin1) { |
|
457 |
jchar* chars = value->char_at_addr(0); |
|
42057
6a5b8ebcd3f2
8164612: NoSuchMethodException when method name contains NULL or Latin-1 supplement character
thartmann
parents:
40655
diff
changeset
|
458 |
utf8_string = UNICODE::as_utf8(chars, utf8_length); |
33628 | 459 |
} else { |
460 |
jbyte* bytes = value->byte_at_addr(0); |
|
42057
6a5b8ebcd3f2
8164612: NoSuchMethodException when method name contains NULL or Latin-1 supplement character
thartmann
parents:
40655
diff
changeset
|
461 |
utf8_string = UNICODE::as_utf8(bytes, utf8_length); |
33628 | 462 |
} |
28363
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
463 |
|
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
464 |
st->print("%d: ", utf8_length); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
465 |
HashtableTextDump::put_utf8(st, utf8_string, utf8_length); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
466 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
467 |
st->cr(); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
468 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
469 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
470 |
} |
24426 | 471 |
} |
472 |
||
473 |
StringTable::VerifyRetTypes StringTable::compare_entries( |
|
474 |
int bkt1, int e_cnt1, |
|
475 |
HashtableEntry<oop, mtSymbol>* e_ptr1, |
|
476 |
int bkt2, int e_cnt2, |
|
477 |
HashtableEntry<oop, mtSymbol>* e_ptr2) { |
|
478 |
// These entries are sanity checked by verify_and_compare_entries() |
|
479 |
// before this function is called. |
|
48618
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
480 |
oop str1 = string_object_no_keepalive(e_ptr1); |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
481 |
oop str2 = string_object_no_keepalive(e_ptr2); |
24426 | 482 |
|
483 |
if (str1 == str2) { |
|
484 |
tty->print_cr("ERROR: identical oop values (0x" PTR_FORMAT ") " |
|
485 |
"in entry @ bucket[%d][%d] and entry @ bucket[%d][%d]", |
|
33148
68fa8b6c4340
8042893: compiler: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files
david
parents:
33105
diff
changeset
|
486 |
p2i(str1), bkt1, e_cnt1, bkt2, e_cnt2); |
24426 | 487 |
return _verify_fail_continue; |
488 |
} |
|
489 |
||
490 |
if (java_lang_String::equals(str1, str2)) { |
|
491 |
tty->print_cr("ERROR: identical String values in entry @ " |
|
492 |
"bucket[%d][%d] and entry @ bucket[%d][%d]", |
|
493 |
bkt1, e_cnt1, bkt2, e_cnt2); |
|
494 |
return _verify_fail_continue; |
|
495 |
} |
|
496 |
||
497 |
return _verify_pass; |
|
498 |
} |
|
499 |
||
500 |
StringTable::VerifyRetTypes StringTable::verify_entry(int bkt, int e_cnt, |
|
48618
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
501 |
HashtableEntry<oop, mtSymbol>* e_ptr, |
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
502 |
StringTable::VerifyMesgModes mesg_mode) { |
24426 | 503 |
|
504 |
VerifyRetTypes ret = _verify_pass; // be optimistic |
|
505 |
||
48618
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
506 |
oop str = string_object_no_keepalive(e_ptr); |
24426 | 507 |
if (str == NULL) { |
508 |
if (mesg_mode == _verify_with_mesgs) { |
|
509 |
tty->print_cr("ERROR: NULL oop value in entry @ bucket[%d][%d]", bkt, |
|
510 |
e_cnt); |
|
511 |
} |
|
512 |
// NULL oop means no more verifications are possible |
|
513 |
return _verify_fail_done; |
|
514 |
} |
|
515 |
||
516 |
if (str->klass() != SystemDictionary::String_klass()) { |
|
517 |
if (mesg_mode == _verify_with_mesgs) { |
|
518 |
tty->print_cr("ERROR: oop is not a String in entry @ bucket[%d][%d]", |
|
519 |
bkt, e_cnt); |
|
520 |
} |
|
521 |
// not a String means no more verifications are possible |
|
522 |
return _verify_fail_done; |
|
523 |
} |
|
524 |
||
37172
ff4d69314a4c
8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java
coleenp
parents:
36187
diff
changeset
|
525 |
unsigned int h = hash_string(str); |
24426 | 526 |
if (e_ptr->hash() != h) { |
527 |
if (mesg_mode == _verify_with_mesgs) { |
|
528 |
tty->print_cr("ERROR: broken hash value in entry @ bucket[%d][%d], " |
|
529 |
"bkt_hash=%d, str_hash=%d", bkt, e_cnt, e_ptr->hash(), h); |
|
530 |
} |
|
531 |
ret = _verify_fail_continue; |
|
532 |
} |
|
533 |
||
534 |
if (the_table()->hash_to_index(h) != bkt) { |
|
535 |
if (mesg_mode == _verify_with_mesgs) { |
|
536 |
tty->print_cr("ERROR: wrong index value for entry @ bucket[%d][%d], " |
|
537 |
"str_hash=%d, hash_to_index=%d", bkt, e_cnt, h, |
|
538 |
the_table()->hash_to_index(h)); |
|
539 |
} |
|
540 |
ret = _verify_fail_continue; |
|
541 |
} |
|
542 |
||
543 |
return ret; |
|
544 |
} |
|
545 |
||
546 |
// See StringTable::verify() above for the quick verification that is |
|
547 |
// part of Universe::verify(). This verification is exhaustive and |
|
548 |
// reports on every issue that is found. StringTable::verify() only |
|
549 |
// reports on the first issue that is found. |
|
550 |
// |
|
551 |
// StringTable::verify_entry() checks: |
|
552 |
// - oop value != NULL (same as verify()) |
|
553 |
// - oop value is a String |
|
554 |
// - hash(String) == hash in entry (same as verify()) |
|
555 |
// - index for hash == index of entry (same as verify()) |
|
556 |
// |
|
557 |
// StringTable::compare_entries() checks: |
|
558 |
// - oops are unique across all entries |
|
559 |
// - String values are unique across all entries |
|
560 |
// |
|
561 |
int StringTable::verify_and_compare_entries() { |
|
562 |
assert(StringTable_lock->is_locked(), "sanity check"); |
|
563 |
||
564 |
int fail_cnt = 0; |
|
565 |
||
566 |
// first, verify all the entries individually: |
|
567 |
for (int bkt = 0; bkt < the_table()->table_size(); bkt++) { |
|
568 |
HashtableEntry<oop, mtSymbol>* e_ptr = the_table()->bucket(bkt); |
|
569 |
for (int e_cnt = 0; e_ptr != NULL; e_ptr = e_ptr->next(), e_cnt++) { |
|
570 |
VerifyRetTypes ret = verify_entry(bkt, e_cnt, e_ptr, _verify_with_mesgs); |
|
571 |
if (ret != _verify_pass) { |
|
572 |
fail_cnt++; |
|
573 |
} |
|
574 |
} |
|
575 |
} |
|
576 |
||
577 |
// Optimization: if the above check did not find any failures, then |
|
578 |
// the comparison loop below does not need to call verify_entry() |
|
579 |
// before calling compare_entries(). If there were failures, then we |
|
580 |
// have to call verify_entry() to see if the entry can be passed to |
|
581 |
// compare_entries() safely. When we call verify_entry() in the loop |
|
582 |
// below, we do so quietly to void duplicate messages and we don't |
|
583 |
// increment fail_cnt because the failures have already been counted. |
|
584 |
bool need_entry_verify = (fail_cnt != 0); |
|
585 |
||
586 |
// second, verify all entries relative to each other: |
|
587 |
for (int bkt1 = 0; bkt1 < the_table()->table_size(); bkt1++) { |
|
588 |
HashtableEntry<oop, mtSymbol>* e_ptr1 = the_table()->bucket(bkt1); |
|
589 |
for (int e_cnt1 = 0; e_ptr1 != NULL; e_ptr1 = e_ptr1->next(), e_cnt1++) { |
|
590 |
if (need_entry_verify) { |
|
591 |
VerifyRetTypes ret = verify_entry(bkt1, e_cnt1, e_ptr1, |
|
592 |
_verify_quietly); |
|
593 |
if (ret == _verify_fail_done) { |
|
594 |
// cannot use the current entry to compare against other entries |
|
595 |
continue; |
|
596 |
} |
|
597 |
} |
|
598 |
||
599 |
for (int bkt2 = bkt1; bkt2 < the_table()->table_size(); bkt2++) { |
|
600 |
HashtableEntry<oop, mtSymbol>* e_ptr2 = the_table()->bucket(bkt2); |
|
601 |
int e_cnt2; |
|
602 |
for (e_cnt2 = 0; e_ptr2 != NULL; e_ptr2 = e_ptr2->next(), e_cnt2++) { |
|
603 |
if (bkt1 == bkt2 && e_cnt2 <= e_cnt1) { |
|
604 |
// skip the entries up to and including the one that |
|
605 |
// we're comparing against |
|
606 |
continue; |
|
607 |
} |
|
608 |
||
609 |
if (need_entry_verify) { |
|
610 |
VerifyRetTypes ret = verify_entry(bkt2, e_cnt2, e_ptr2, |
|
611 |
_verify_quietly); |
|
612 |
if (ret == _verify_fail_done) { |
|
613 |
// cannot compare against this entry |
|
614 |
continue; |
|
615 |
} |
|
616 |
} |
|
617 |
||
618 |
// compare two entries, report and count any failures: |
|
619 |
if (compare_entries(bkt1, e_cnt1, e_ptr1, bkt2, e_cnt2, e_ptr2) |
|
620 |
!= _verify_pass) { |
|
621 |
fail_cnt++; |
|
622 |
} |
|
623 |
} |
|
624 |
} |
|
625 |
} |
|
626 |
} |
|
627 |
return fail_cnt; |
|
628 |
} |
|
629 |
||
630 |
// Create a new table and using alternate hash code, populate the new table |
|
631 |
// with the existing strings. Set flag to use the alternate hash code afterwards. |
|
632 |
void StringTable::rehash_table() { |
|
633 |
assert(SafepointSynchronize::is_at_safepoint(), "must be at safepoint"); |
|
634 |
// This should never happen with -Xshare:dump but it might in testing mode. |
|
635 |
if (DumpSharedSpaces) return; |
|
636 |
StringTable* new_table = new StringTable(); |
|
637 |
||
638 |
// Rehash the table |
|
639 |
the_table()->move_to(new_table); |
|
640 |
||
641 |
// Delete the table and buckets (entries are reused in new table). |
|
642 |
delete _the_table; |
|
643 |
// Don't check if we need rehashing until the table gets unbalanced again. |
|
644 |
// Then rehash with a new global seed. |
|
645 |
_needs_rehashing = false; |
|
646 |
_the_table = new_table; |
|
647 |
} |
|
28363
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
648 |
|
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
649 |
// Utility for dumping strings |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
650 |
StringtableDCmd::StringtableDCmd(outputStream* output, bool heap) : |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
651 |
DCmdWithParser(output, heap), |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
652 |
_verbose("-verbose", "Dump the content of each string in the table", |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
653 |
"BOOLEAN", false, "false") { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
654 |
_dcmdparser.add_dcmd_option(&_verbose); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
655 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
656 |
|
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
657 |
void StringtableDCmd::execute(DCmdSource source, TRAPS) { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
658 |
VM_DumpHashtable dumper(output(), VM_DumpHashtable::DumpStrings, |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
659 |
_verbose.value()); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
660 |
VMThread::execute(&dumper); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
661 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
662 |
|
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
663 |
int StringtableDCmd::num_arguments() { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
664 |
ResourceMark rm; |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
665 |
StringtableDCmd* dcmd = new StringtableDCmd(NULL, false); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
666 |
if (dcmd != NULL) { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
667 |
DCmdMark mark(dcmd); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
668 |
return dcmd->_dcmdparser.num_arguments(); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
669 |
} else { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
670 |
return 0; |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
671 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27684
diff
changeset
|
672 |
} |
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
673 |
|
46810
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
674 |
#if INCLUDE_CDS_JAVA_HEAP |
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
675 |
// Sharing |
46810
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
676 |
oop StringTable::create_archived_string(oop s, Thread* THREAD) { |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
677 |
assert(DumpSharedSpaces, "this function is only used with -Xshare:dump"); |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
678 |
|
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
679 |
oop new_s = NULL; |
48618
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
680 |
typeArrayOop v = java_lang_String::value_no_keepalive(s); |
46810
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
681 |
typeArrayOop new_v = (typeArrayOop)MetaspaceShared::archive_heap_object(v, THREAD); |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
682 |
if (new_v == NULL) { |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
683 |
return NULL; |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
684 |
} |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
685 |
new_s = MetaspaceShared::archive_heap_object(s, THREAD); |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
686 |
if (new_s == NULL) { |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
687 |
return NULL; |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
688 |
} |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
689 |
|
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
690 |
// adjust the pointer to the 'value' field in the new String oop |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
691 |
java_lang_String::set_value_raw(new_s, new_v); |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
692 |
return new_s; |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
693 |
} |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
694 |
|
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
695 |
bool StringTable::copy_shared_string(GrowableArray<MemRegion> *string_space, |
37995 | 696 |
CompactStringTableWriter* writer) { |
46810
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
697 |
assert(MetaspaceShared::is_heap_object_archiving_allowed(), "must be"); |
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
698 |
|
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
699 |
Thread* THREAD = Thread::current(); |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
700 |
for (int i = 0; i < the_table()->table_size(); ++i) { |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
701 |
HashtableEntry<oop, mtSymbol>* bucket = the_table()->bucket(i); |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
702 |
for ( ; bucket != NULL; bucket = bucket->next()) { |
48618
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
703 |
oop s = string_object_no_keepalive(bucket); |
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
704 |
unsigned int hash = java_lang_String::hash_code(s); |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
705 |
if (hash == 0) { |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
706 |
continue; |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
707 |
} |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
708 |
|
46810
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
709 |
java_lang_String::set_hash(s, hash); |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
710 |
oop new_s = create_archived_string(s, THREAD); |
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
711 |
if (new_s == NULL) { |
46810
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
712 |
continue; |
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
713 |
} |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
714 |
|
46810
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
715 |
// set the archived string in bucket |
48618
688e5cbd0b91
8192003: Refactor weak references in StringTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
716 |
set_string_object(bucket, new_s); |
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
717 |
|
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
718 |
// add to the compact table |
37995 | 719 |
writer->add(hash, new_s); |
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
720 |
} |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
721 |
} |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
722 |
|
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
723 |
return true; |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
724 |
} |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
725 |
|
46746
ea379ebb9447
8072061: Automatically determine optimal sizes for the CDS regions
iklam
parents:
46742
diff
changeset
|
726 |
void StringTable::write_to_archive(GrowableArray<MemRegion> *string_space) { |
46810
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
727 |
assert(MetaspaceShared::is_heap_object_archiving_allowed(), "must be"); |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
728 |
|
37995 | 729 |
_shared_table.reset(); |
46810
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
730 |
int num_buckets = the_table()->number_of_entries() / |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
731 |
SharedSymbolTableBucketSize; |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
732 |
// calculation of num_buckets can result in zero buckets, we need at least one |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
733 |
CompactStringTableWriter writer(num_buckets > 1 ? num_buckets : 1, |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
734 |
&MetaspaceShared::stats()->string); |
37995 | 735 |
|
46810
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
736 |
// Copy the interned strings into the "string space" within the java heap |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
737 |
if (copy_shared_string(string_space, &writer)) { |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
738 |
writer.dump(&_shared_table); |
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
739 |
} |
46746
ea379ebb9447
8072061: Automatically determine optimal sizes for the CDS regions
iklam
parents:
46742
diff
changeset
|
740 |
} |
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
741 |
|
46746
ea379ebb9447
8072061: Automatically determine optimal sizes for the CDS regions
iklam
parents:
46742
diff
changeset
|
742 |
void StringTable::serialize(SerializeClosure* soc) { |
37995 | 743 |
_shared_table.set_type(CompactHashtable<oop, char>::_string_table); |
744 |
_shared_table.serialize(soc); |
|
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
745 |
|
37995 | 746 |
if (soc->writing()) { |
747 |
_shared_table.reset(); // Sanity. Make sure we don't use the shared table at dump time |
|
46810
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
748 |
} else if (!_shared_string_mapped) { |
37995 | 749 |
_shared_table.reset(); |
31345
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
750 |
} |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
751 |
} |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
752 |
|
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
753 |
void StringTable::shared_oops_do(OopClosure* f) { |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
754 |
_shared_table.oops_do(f); |
1bba15125d8d
8015086: add interned strings to the shared archive.
jiangli
parents:
30764
diff
changeset
|
755 |
} |
46810
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
756 |
#endif //INCLUDE_CDS_JAVA_HEAP |