author | jwilhelm |
Thu, 03 Oct 2013 21:36:29 +0200 | |
changeset 20398 | b206c580c45f |
parent 19549 | 60e5c7cafdca |
child 25350 | 6423a57e5451 |
permissions | -rw-r--r-- |
1374 | 1 |
/* |
18025 | 2 |
* Copyright (c) 2001, 2013, Oracle and/or its affiliates. All rights reserved. |
1374 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
5547
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
4458
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
4458
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
4458
diff
changeset
|
21 |
* questions. |
1374 | 22 |
* |
23 |
*/ |
|
24 |
||
7397 | 25 |
#include "precompiled.hpp" |
10769
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
26 |
#include "gc_implementation/g1/concurrentMarkThread.inline.hpp" |
7397 | 27 |
#include "gc_implementation/g1/g1CollectedHeap.inline.hpp" |
28 |
#include "gc_implementation/g1/g1CollectorPolicy.hpp" |
|
12378
ed44b9ecfa2f
7160728: Introduce an extra logging level for G1 logging
brutisso
parents:
12227
diff
changeset
|
29 |
#include "gc_implementation/g1/g1Log.hpp" |
7397 | 30 |
#include "gc_implementation/g1/vm_operations_g1.hpp" |
18025 | 31 |
#include "gc_implementation/shared/gcTimer.hpp" |
32 |
#include "gc_implementation/shared/gcTraceTime.hpp" |
|
7397 | 33 |
#include "gc_implementation/shared/isGCActiveMark.hpp" |
7398 | 34 |
#include "gc_implementation/g1/vm_operations_g1.hpp" |
7397 | 35 |
#include "runtime/interfaceSupport.hpp" |
1374 | 36 |
|
7398 | 37 |
VM_G1CollectForAllocation::VM_G1CollectForAllocation( |
38 |
unsigned int gc_count_before, |
|
39 |
size_t word_size) |
|
12227
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
40 |
: VM_G1OperationWithAllocRequest(gc_count_before, word_size, |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
41 |
GCCause::_allocation_failure) { |
7398 | 42 |
guarantee(word_size > 0, "an allocation should always be requested"); |
43 |
} |
|
44 |
||
1374 | 45 |
void VM_G1CollectForAllocation::doit() { |
46 |
G1CollectedHeap* g1h = G1CollectedHeap::heap(); |
|
12628
bd8e0e8f8e5c
7168294: G1: Some Full GCs incorrectly report GC cause as "No GC"
johnc
parents:
12378
diff
changeset
|
47 |
GCCauseSetter x(g1h, _gc_cause); |
7398 | 48 |
_result = g1h->satisfy_failed_allocation(_word_size, &_pause_succeeded); |
49 |
assert(_result == NULL || _pause_succeeded, |
|
50 |
"if we get back a result, the pause should have succeeded"); |
|
1374 | 51 |
} |
52 |
||
53 |
void VM_G1CollectFull::doit() { |
|
54 |
G1CollectedHeap* g1h = G1CollectedHeap::heap(); |
|
55 |
GCCauseSetter x(g1h, _gc_cause); |
|
56 |
g1h->do_full_collection(false /* clear_all_soft_refs */); |
|
57 |
} |
|
58 |
||
7398 | 59 |
VM_G1IncCollectionPause::VM_G1IncCollectionPause( |
60 |
unsigned int gc_count_before, |
|
61 |
size_t word_size, |
|
62 |
bool should_initiate_conc_mark, |
|
63 |
double target_pause_time_ms, |
|
64 |
GCCause::Cause gc_cause) |
|
12227
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
65 |
: VM_G1OperationWithAllocRequest(gc_count_before, word_size, gc_cause), |
7398 | 66 |
_should_initiate_conc_mark(should_initiate_conc_mark), |
67 |
_target_pause_time_ms(target_pause_time_ms), |
|
12227
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
68 |
_should_retry_gc(false), |
12934
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
69 |
_old_marking_cycles_completed_before(0) { |
7398 | 70 |
guarantee(target_pause_time_ms > 0.0, |
71 |
err_msg("target_pause_time_ms = %1.6lf should be positive", |
|
72 |
target_pause_time_ms)); |
|
73 |
_gc_cause = gc_cause; |
|
74 |
} |
|
75 |
||
12227
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
76 |
bool VM_G1IncCollectionPause::doit_prologue() { |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
77 |
bool res = VM_GC_Operation::doit_prologue(); |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
78 |
if (!res) { |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
79 |
if (_should_initiate_conc_mark) { |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
80 |
// The prologue can fail for a couple of reasons. The first is that another GC |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
81 |
// got scheduled and prevented the scheduling of the initial mark GC. The |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
82 |
// second is that the GC locker may be active and the heap can't be expanded. |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
83 |
// In both cases we want to retry the GC so that the initial mark pause is |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
84 |
// actually scheduled. In the second case, however, we should stall until |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
85 |
// until the GC locker is no longer active and then retry the initial mark GC. |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
86 |
_should_retry_gc = true; |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
87 |
} |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
88 |
} |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
89 |
return res; |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
90 |
} |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
91 |
|
1374 | 92 |
void VM_G1IncCollectionPause::doit() { |
93 |
G1CollectedHeap* g1h = G1CollectedHeap::heap(); |
|
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
94 |
assert(!_should_initiate_conc_mark || |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
95 |
((_gc_cause == GCCause::_gc_locker && GCLockerInvokesConcurrent) || |
11576
e0bef5ca4602
6976060: G1: humongous object allocations should initiate marking cycles when necessary
brutisso
parents:
10769
diff
changeset
|
96 |
(_gc_cause == GCCause::_java_lang_system_gc && ExplicitGCInvokesConcurrent) || |
e0bef5ca4602
6976060: G1: humongous object allocations should initiate marking cycles when necessary
brutisso
parents:
10769
diff
changeset
|
97 |
_gc_cause == GCCause::_g1_humongous_allocation), |
e0bef5ca4602
6976060: G1: humongous object allocations should initiate marking cycles when necessary
brutisso
parents:
10769
diff
changeset
|
98 |
"only a GC locker, a System.gc() or a hum allocation induced GC should start a cycle"); |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
99 |
|
7398 | 100 |
if (_word_size > 0) { |
101 |
// An allocation has been requested. So, try to do that first. |
|
102 |
_result = g1h->attempt_allocation_at_safepoint(_word_size, |
|
103 |
false /* expect_null_cur_alloc_region */); |
|
104 |
if (_result != NULL) { |
|
105 |
// If we can successfully allocate before we actually do the |
|
106 |
// pause then we will consider this pause successful. |
|
107 |
_pause_succeeded = true; |
|
108 |
return; |
|
109 |
} |
|
110 |
} |
|
111 |
||
4458
075a9ef4e467
6902303: G1: ScavengeALot should cause an incremental, rather than a full, collection
ysr
parents:
3261
diff
changeset
|
112 |
GCCauseSetter x(g1h, _gc_cause); |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
113 |
if (_should_initiate_conc_mark) { |
12934
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
114 |
// It's safer to read old_marking_cycles_completed() here, given |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
115 |
// that noone else will be updating it concurrently. Since we'll |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
116 |
// only need it if we're initiating a marking cycle, no point in |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
117 |
// setting it earlier. |
12934
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
118 |
_old_marking_cycles_completed_before = g1h->old_marking_cycles_completed(); |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
119 |
|
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
120 |
// At this point we are supposed to start a concurrent cycle. We |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
121 |
// will do so if one is not already in progress. |
10523
cdb54c167ab0
7050392: G1: Introduce flag to generate a log of the G1 ergonomic decisions
tonyp
parents:
9996
diff
changeset
|
122 |
bool res = g1h->g1_policy()->force_initial_mark_if_outside_cycle(_gc_cause); |
9996
3851e45f93e7
7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents:
8921
diff
changeset
|
123 |
|
3851e45f93e7
7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents:
8921
diff
changeset
|
124 |
// The above routine returns true if we were able to force the |
3851e45f93e7
7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents:
8921
diff
changeset
|
125 |
// next GC pause to be an initial mark; it returns false if a |
3851e45f93e7
7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents:
8921
diff
changeset
|
126 |
// marking cycle is already in progress. |
3851e45f93e7
7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents:
8921
diff
changeset
|
127 |
// |
12227
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
128 |
// If a marking cycle is already in progress just return and skip the |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
129 |
// pause below - if the reason for requesting this initial mark pause |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
130 |
// was due to a System.gc() then the requesting thread should block in |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
131 |
// doit_epilogue() until the marking cycle is complete. |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
132 |
// |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
133 |
// If this initial mark pause was requested as part of a humongous |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
134 |
// allocation then we know that the marking cycle must just have |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
135 |
// been started by another thread (possibly also allocating a humongous |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
136 |
// object) as there was no active marking cycle when the requesting |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
137 |
// thread checked before calling collect() in |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
138 |
// attempt_allocation_humongous(). Retrying the GC, in this case, |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
139 |
// will cause the requesting thread to spin inside collect() until the |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
140 |
// just started marking cycle is complete - which may be a while. So |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
141 |
// we do NOT retry the GC. |
9996
3851e45f93e7
7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents:
8921
diff
changeset
|
142 |
if (!res) { |
12227
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
143 |
assert(_word_size == 0, "Concurrent Full GC/Humongous Object IM shouldn't be allocating"); |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
144 |
if (_gc_cause != GCCause::_g1_humongous_allocation) { |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
145 |
_should_retry_gc = true; |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
146 |
} |
9996
3851e45f93e7
7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents:
8921
diff
changeset
|
147 |
return; |
3851e45f93e7
7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents:
8921
diff
changeset
|
148 |
} |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
149 |
} |
7398 | 150 |
|
151 |
_pause_succeeded = |
|
152 |
g1h->do_collection_pause_at_safepoint(_target_pause_time_ms); |
|
153 |
if (_pause_succeeded && _word_size > 0) { |
|
154 |
// An allocation had been requested. |
|
155 |
_result = g1h->attempt_allocation_at_safepoint(_word_size, |
|
156 |
true /* expect_null_cur_alloc_region */); |
|
157 |
} else { |
|
158 |
assert(_result == NULL, "invariant"); |
|
12227
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
159 |
if (!_pause_succeeded) { |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
160 |
// Another possible reason reason for the pause to not be successful |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
161 |
// is that, again, the GC locker is active (and has become active |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
162 |
// since the prologue was executed). In this case we should retry |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
163 |
// the pause after waiting for the GC locker to become inactive. |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
164 |
_should_retry_gc = true; |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
165 |
} |
7398 | 166 |
} |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
167 |
} |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
168 |
|
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
169 |
void VM_G1IncCollectionPause::doit_epilogue() { |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
170 |
VM_GC_Operation::doit_epilogue(); |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
171 |
|
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
172 |
// If the pause was initiated by a System.gc() and |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
173 |
// +ExplicitGCInvokesConcurrent, we have to wait here for the cycle |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
174 |
// that just started (or maybe one that was already in progress) to |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
175 |
// finish. |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
176 |
if (_gc_cause == GCCause::_java_lang_system_gc && |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
177 |
_should_initiate_conc_mark) { |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
178 |
assert(ExplicitGCInvokesConcurrent, |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
179 |
"the only way to be here is if ExplicitGCInvokesConcurrent is set"); |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
180 |
|
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
181 |
G1CollectedHeap* g1h = G1CollectedHeap::heap(); |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
182 |
|
12934
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
183 |
// In the doit() method we saved g1h->old_marking_cycles_completed() |
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
184 |
// in the _old_marking_cycles_completed_before field. We have to |
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
185 |
// wait until we observe that g1h->old_marking_cycles_completed() |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
186 |
// has increased by at least one. This can happen if a) we started |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
187 |
// a cycle and it completes, b) a cycle already in progress |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
188 |
// completes, or c) a Full GC happens. |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
189 |
|
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
190 |
// If the condition has already been reached, there's no point in |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
191 |
// actually taking the lock and doing the wait. |
12934
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
192 |
if (g1h->old_marking_cycles_completed() <= |
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
193 |
_old_marking_cycles_completed_before) { |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
194 |
// The following is largely copied from CMS |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
195 |
|
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
196 |
Thread* thr = Thread::current(); |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
197 |
assert(thr->is_Java_thread(), "invariant"); |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
198 |
JavaThread* jt = (JavaThread*)thr; |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
199 |
ThreadToNativeFromVM native(jt); |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
200 |
|
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
201 |
MutexLockerEx x(FullGCCount_lock, Mutex::_no_safepoint_check_flag); |
12934
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
202 |
while (g1h->old_marking_cycles_completed() <= |
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
203 |
_old_marking_cycles_completed_before) { |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
204 |
FullGCCount_lock->wait(Mutex::_no_safepoint_check_flag); |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
205 |
} |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
206 |
} |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
207 |
} |
1374 | 208 |
} |
209 |
||
10769
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
210 |
void VM_CGC_Operation::acquire_pending_list_lock() { |
12227
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
211 |
assert(_needs_pll, "don't call this otherwise"); |
10769
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
212 |
// The caller may block while communicating |
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
213 |
// with the SLT thread in order to acquire/release the PLL. |
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
214 |
ConcurrentMarkThread::slt()-> |
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
215 |
manipulatePLL(SurrogateLockerThread::acquirePLL); |
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
216 |
} |
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
217 |
|
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
218 |
void VM_CGC_Operation::release_and_notify_pending_list_lock() { |
12227
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
219 |
assert(_needs_pll, "don't call this otherwise"); |
10769
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
220 |
// The caller may block while communicating |
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
221 |
// with the SLT thread in order to acquire/release the PLL. |
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
222 |
ConcurrentMarkThread::slt()-> |
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
223 |
manipulatePLL(SurrogateLockerThread::releaseAndNotifyPLL); |
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
224 |
} |
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
225 |
|
1374 | 226 |
void VM_CGC_Operation::doit() { |
12378
ed44b9ecfa2f
7160728: Introduce an extra logging level for G1 logging
brutisso
parents:
12227
diff
changeset
|
227 |
gclog_or_tty->date_stamp(G1Log::fine() && PrintGCDateStamps); |
ed44b9ecfa2f
7160728: Introduce an extra logging level for G1 logging
brutisso
parents:
12227
diff
changeset
|
228 |
TraceCPUTime tcpu(G1Log::finer(), true, gclog_or_tty); |
18025 | 229 |
GCTraceTime t(_printGCMessage, G1Log::fine(), true, G1CollectedHeap::heap()->gc_timer_cm()); |
1374 | 230 |
SharedHeap* sh = SharedHeap::heap(); |
231 |
// This could go away if CollectedHeap gave access to _gc_is_active... |
|
232 |
if (sh != NULL) { |
|
233 |
IsGCActiveMark x; |
|
234 |
_cl->do_void(); |
|
235 |
} else { |
|
236 |
_cl->do_void(); |
|
237 |
} |
|
238 |
} |
|
239 |
||
240 |
bool VM_CGC_Operation::doit_prologue() { |
|
10769
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
241 |
// Note the relative order of the locks must match that in |
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
242 |
// VM_GC_Operation::doit_prologue() or deadlocks can occur |
12227
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
243 |
if (_needs_pll) { |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
244 |
acquire_pending_list_lock(); |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
245 |
} |
10769
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
246 |
|
1374 | 247 |
Heap_lock->lock(); |
248 |
SharedHeap::heap()->_thread_holds_heap_lock_for_gc = true; |
|
249 |
return true; |
|
250 |
} |
|
251 |
||
252 |
void VM_CGC_Operation::doit_epilogue() { |
|
10769
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
253 |
// Note the relative order of the unlocks must match that in |
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10523
diff
changeset
|
254 |
// VM_GC_Operation::doit_epilogue() |
1374 | 255 |
SharedHeap::heap()->_thread_holds_heap_lock_for_gc = false; |
256 |
Heap_lock->unlock(); |
|
12227
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
257 |
if (_needs_pll) { |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
258 |
release_and_notify_pending_list_lock(); |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
259 |
} |
1374 | 260 |
} |