author | goetz |
Tue, 19 Mar 2019 16:16:39 +0100 | |
branch | JEP-8220715-NPE_messages |
changeset 57273 | acdec92db672 |
permissions | -rw-r--r-- |
57273
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
1 |
/* |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
2 |
* Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved. |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
3 |
* Copyright (c) 2019 SAP SE. All rights reserved. |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
4 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
5 |
* |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
6 |
* This code is free software; you can redistribute it and/or modify it |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
7 |
* under the terms of the GNU General Public License version 2 only, as |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
8 |
* published by the Free Software Foundation. |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
9 |
* |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
10 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
11 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
12 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
13 |
* version 2 for more details (a copy is included in the LICENSE file that |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
14 |
* accompanied this code). |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
15 |
* |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
16 |
* You should have received a copy of the GNU General Public License version |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
17 |
* 2 along with this work; if not, write to the Free Software Foundation, |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
18 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
19 |
* |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
20 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
21 |
* or visit www.oracle.com if you need additional information or have any |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
22 |
* questions. |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
23 |
*/ |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
24 |
|
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
25 |
/** |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
26 |
* @test |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
27 |
* @summary Test NullPointerException messages thrown in frames that |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
28 |
* are hidden in the backtrace/stackTrace. |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
29 |
* @library /test/lib |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
30 |
* @compile -g NPEInHiddenTopFrameTest.java |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
31 |
* @run main/othervm -XX:-ShowHiddenFrames NPEInHiddenTopFrameTest hidden |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
32 |
* @run main/othervm -XX:+ShowHiddenFrames NPEInHiddenTopFrameTest visible |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
33 |
*/ |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
34 |
|
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
35 |
import java.io.ByteArrayInputStream; |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
36 |
import java.io.ByteArrayOutputStream; |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
37 |
import java.io.ObjectInputStream; |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
38 |
import java.io.ObjectOutputStream; |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
39 |
import java.util.ArrayList; |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
40 |
|
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
41 |
import jdk.test.lib.Asserts; |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
42 |
|
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
43 |
/** |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
44 |
* Tests NullPointerExceptions |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
45 |
*/ |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
46 |
public class NPEInHiddenTopFrameTest { |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
47 |
|
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
48 |
@FunctionalInterface |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
49 |
private static interface SomeFunctionalInterface { |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
50 |
String someMethod(String a, String b); |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
51 |
} |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
52 |
|
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
53 |
public static void checkMessage(String expression, |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
54 |
String obtainedMsg, String expectedMsg) { |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
55 |
System.out.println(); |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
56 |
System.out.println(" source code: " + expression); |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
57 |
System.out.println(" thrown msg: " + obtainedMsg); |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
58 |
System.out.println("expected msg: " + expectedMsg); |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
59 |
if (obtainedMsg == null && expectedMsg == null) return; |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
60 |
Asserts.assertEquals(obtainedMsg, expectedMsg); |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
61 |
} |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
62 |
|
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
63 |
public static void main(String[] args) throws Exception { |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
64 |
boolean framesAreHidden = false; |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
65 |
if (args.length > 0) { |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
66 |
String arg = (String)args[0]; |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
67 |
if (arg.equals("hidden")) framesAreHidden = true; |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
68 |
} |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
69 |
|
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
70 |
try { |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
71 |
final SomeFunctionalInterface concatter = String::concat; |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
72 |
final String nullString = null; |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
73 |
if (concatter != null) { |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
74 |
concatter.someMethod(nullString, "validString"); |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
75 |
} |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
76 |
} catch (NullPointerException e) { |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
77 |
checkMessage("concatter.someMethod(nullString, \"validString\");", e.getMessage(), |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
78 |
framesAreHidden ? |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
79 |
// This is the message printed if the wrong method/bci are used. |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
80 |
//"'concatter' is null. " + |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
81 |
//"Can not invoke method 'NPEInHiddenTopFrameTest$SomeFunctionalInterface.someMethod(Ljava/lang/String;Ljava/lang/String;)Ljava/lang/String;'." : |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
82 |
// With this fix no message is printed. |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
83 |
null : |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
84 |
// This is the corerct message, but it describes code generated on-the-fly. |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
85 |
// There is no debug information in this code. |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
86 |
"'<parameter1>' is null. " + |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
87 |
"Can not invoke method 'java.lang.String.concat(Ljava/lang/String;)Ljava/lang/String;'." ); |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
88 |
} |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
89 |
} |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
90 |
} |
acdec92db672
8221077: No NullPointerException message if top frame is hidden.
goetz
parents:
diff
changeset
|
91 |