src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifySystemPropertyUsage.java
author chegar
Thu, 17 Oct 2019 20:54:25 +0100
branchdatagramsocketimpl-branch
changeset 58679 9c3209ff7550
parent 58678 9cf78a70fa4f
parent 58533 46b0b7fe255c
permissions -rw-r--r--
datagramsocketimpl-branch: merge with default
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
54328
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     1
/*
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     2
 * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     4
 *
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     7
 * published by the Free Software Foundation.
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     8
 *
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    13
 * accompanied this code).
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    14
 *
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    18
 *
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    21
 * questions.
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    22
 */
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    23
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    24
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    25
package org.graalvm.compiler.core.test;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    26
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    27
import java.util.regex.Matcher;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    28
import java.util.regex.Pattern;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    29
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    30
import org.graalvm.compiler.nodes.StructuredGraph;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    31
import org.graalvm.compiler.nodes.java.MethodCallTargetNode;
55509
d58442b8abc1 8225497: Update Graal
jwilhelm
parents: 54328
diff changeset
    32
import org.graalvm.compiler.nodes.spi.CoreProviders;
54328
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    33
import org.graalvm.compiler.phases.VerifyPhase;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    34
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    35
import jdk.vm.ci.meta.MetaAccessProvider;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    36
import jdk.vm.ci.meta.ResolvedJavaMethod;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    37
import jdk.vm.ci.meta.ResolvedJavaType;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    38
import jdk.vm.ci.services.Services;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    39
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    40
/**
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    41
 * Checks against calls to {@link System#getProperty(String)},
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    42
 * {@link System#getProperty(String, String)} and {@link System#getProperties()}. System properties
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    43
 * can be modified by application code so {@link Services#getSavedProperties()} should be used
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    44
 * instead.
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    45
 */
55509
d58442b8abc1 8225497: Update Graal
jwilhelm
parents: 54328
diff changeset
    46
public class VerifySystemPropertyUsage extends VerifyPhase<CoreProviders> {
54328
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    47
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    48
    static final Class<?>[] BOXES = {Integer.class, Long.class, Boolean.class, Float.class, Double.class};
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    49
    static final int JVMCI_VERSION_MAJOR;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    50
    static final int JVMCI_VERSION_MINOR;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    51
    static {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    52
        int major = -1;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    53
        int minor = -1;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    54
        String vmVersion = System.getProperty("java.vm.version");
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    55
        if (System.getProperty("java.specification.version").compareTo("1.9") < 0) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    56
            Pattern re = Pattern.compile(".*-jvmci-(\\d+)\\.(\\d+).*");
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    57
            Matcher matcher = re.matcher(vmVersion);
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    58
            if (matcher.matches()) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    59
                major = Integer.parseInt(matcher.group(1));
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    60
                minor = Integer.parseInt(matcher.group(2));
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    61
            }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    62
        }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    63
        JVMCI_VERSION_MAJOR = major;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    64
        JVMCI_VERSION_MINOR = minor;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    65
    }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    66
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    67
    @Override
55509
d58442b8abc1 8225497: Update Graal
jwilhelm
parents: 54328
diff changeset
    68
    protected void verify(StructuredGraph graph, CoreProviders context) {
54328
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    69
        MetaAccessProvider metaAccess = context.getMetaAccess();
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    70
        final ResolvedJavaType systemType = metaAccess.lookupJavaType(System.class);
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    71
        final ResolvedJavaType[] boxTypes = new ResolvedJavaType[BOXES.length];
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    72
        for (int i = 0; i < boxTypes.length; i++) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    73
            boxTypes[i] = metaAccess.lookupJavaType(BOXES[i]);
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    74
        }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    75
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    76
        ResolvedJavaMethod caller = graph.method();
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    77
        String holderQualified = caller.format("%H");
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    78
        String holderUnqualified = caller.format("%h");
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    79
        String packageName = holderQualified.equals(holderUnqualified) ? "" : holderQualified.substring(0, holderQualified.length() - holderUnqualified.length() - 1);
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    80
        if (packageName.startsWith("jdk.vm.ci")) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    81
            if (JVMCI_VERSION_MAJOR >= 0 && JVMCI_VERSION_MINOR > 56) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    82
                // This JVMCI version should not use non-saved system properties
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    83
            } else {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    84
                // This JVMCI version still has some calls that need to be removed
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    85
                return;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    86
            }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    87
        } else if (holderQualified.equals("org.graalvm.compiler.hotspot.JVMCIVersionCheck") && caller.getName().equals("main")) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    88
            // The main method in JVMCIVersionCheck is only called from the shell
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    89
            return;
58533
46b0b7fe255c 8231973: Update Graal
dlong
parents: 58299
diff changeset
    90
        } else if (packageName.startsWith("com.oracle.truffle") || packageName.startsWith("org.graalvm.polyglot") || packageName.startsWith("org.graalvm.home")) {
46b0b7fe255c 8231973: Update Graal
dlong
parents: 58299
diff changeset
    91
            // Truffle and SDK do not depend on JVMCI so they cannot use
54328
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    92
            // Services.getSavedProperties()
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    93
            return;
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    94
        } else if (packageName.startsWith("com.oracle.svm")) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    95
            // SVM must read system properties in:
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    96
            // * its JDK substitutions to mimic required JDK semantics
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    97
            // * native-image for config info
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
    98
            return;
58299
6df94ce3ab2f 8229201: Update Graal
dlong
parents: 55509
diff changeset
    99
        } else if (packageName.startsWith("jdk.tools.jaotc")) {
6df94ce3ab2f 8229201: Update Graal
dlong
parents: 55509
diff changeset
   100
            // Workaround since jdk.internal.vm.ci/jdk.vm.ci.services is not exported to jdk.aot.
6df94ce3ab2f 8229201: Update Graal
dlong
parents: 55509
diff changeset
   101
            // The jaotc launcher dynamically adds these exports.
6df94ce3ab2f 8229201: Update Graal
dlong
parents: 55509
diff changeset
   102
            return;
54328
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   103
        }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   104
        for (MethodCallTargetNode t : graph.getNodes(MethodCallTargetNode.TYPE)) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   105
            ResolvedJavaMethod callee = t.targetMethod();
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   106
            if (callee.getDeclaringClass().equals(systemType)) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   107
                if (callee.getName().equals("getProperty") || callee.getName().equals("getProperties")) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   108
                    throw new VerificationError("Call to %s at callsite %s is prohibited. Call Services.getSavedProperties().get(String) instead.",
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   109
                                    callee.format("%H.%n(%p)"),
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   110
                                    caller.format("%H.%n(%p)"));
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   111
                }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   112
            } else {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   113
                for (int i = 0; i < boxTypes.length; i++) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   114
                    ResolvedJavaType boxType = boxTypes[i];
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   115
                    if (callee.getDeclaringClass().equals(boxType)) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   116
                        String simpleName = boxType.toJavaName(false);
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   117
                        if (callee.getName().equals("get" + simpleName)) {
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   118
                            throw new VerificationError("Call to %s at callsite %s is prohibited. Call %s.parse%s(Services.getSavedProperties().get(String)) instead.",
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   119
                                            callee.format("%H.%n(%p)"),
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   120
                                            caller.format("%H.%n(%p)"),
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   121
                                            simpleName, simpleName);
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   122
                        }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   123
                    }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   124
                }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   125
            }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   126
        }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   127
    }
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   128
37648a9c4a6a 8221341: Update Graal
jwilhelm
parents:
diff changeset
   129
}