author | coleenp |
Tue, 03 Oct 2017 16:42:04 -0400 | |
changeset 47580 | 96392e113a0a |
parent 47216 | 71c04702a3d5 |
child 49164 | 7e958a8ebcd3 |
permissions | -rw-r--r-- |
1 | 1 |
/* |
46321
640277633c23
8164038: Missing volatile keyword at CardTableRS::write_ref_field_gc_par()
sangheki
parents:
40655
diff
changeset
|
2 |
* Copyright (c) 2001, 2017, Oracle and/or its affiliates. All rights reserved. |
1 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
5547
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
3261
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
3261
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
3261
diff
changeset
|
21 |
* questions. |
1 | 22 |
* |
23 |
*/ |
|
24 |
||
7397 | 25 |
#include "precompiled.hpp" |
30764 | 26 |
#include "gc/shared/cardTableRS.hpp" |
27 |
#include "gc/shared/genCollectedHeap.hpp" |
|
28 |
#include "gc/shared/generation.hpp" |
|
29 |
#include "gc/shared/space.inline.hpp" |
|
7397 | 30 |
#include "memory/allocation.inline.hpp" |
31 |
#include "oops/oop.inline.hpp" |
|
40655
9f644073d3a0
8157907: Incorrect inclusion of atomic.hpp instead of atomic.inline.hpp
dholmes
parents:
37073
diff
changeset
|
32 |
#include "runtime/atomic.hpp" |
7397 | 33 |
#include "runtime/java.hpp" |
34 |
#include "runtime/os.hpp" |
|
15482
470d0b0c09f1
8005915: Unify SERIALGC and INCLUDE_ALTERNATE_GCS
jprovino
parents:
13728
diff
changeset
|
35 |
#include "utilities/macros.hpp" |
1 | 36 |
|
47580 | 37 |
class HasAccumulatedModifiedOopsClosure : public CLDClosure { |
33212 | 38 |
bool _found; |
39 |
public: |
|
40 |
HasAccumulatedModifiedOopsClosure() : _found(false) {} |
|
47580 | 41 |
void do_cld(ClassLoaderData* cld) { |
33212 | 42 |
if (_found) { |
43 |
return; |
|
44 |
} |
|
45 |
||
47580 | 46 |
if (cld->has_accumulated_modified_oops()) { |
33212 | 47 |
_found = true; |
48 |
} |
|
49 |
} |
|
50 |
bool found() { |
|
51 |
return _found; |
|
52 |
} |
|
53 |
}; |
|
54 |
||
47580 | 55 |
bool CLDRemSet::mod_union_is_clear() { |
33212 | 56 |
HasAccumulatedModifiedOopsClosure closure; |
47580 | 57 |
ClassLoaderDataGraph::cld_do(&closure); |
33212 | 58 |
|
59 |
return !closure.found(); |
|
60 |
} |
|
61 |
||
62 |
||
47580 | 63 |
class ClearCLDModUnionClosure : public CLDClosure { |
33212 | 64 |
public: |
47580 | 65 |
void do_cld(ClassLoaderData* cld) { |
66 |
if (cld->has_accumulated_modified_oops()) { |
|
67 |
cld->clear_accumulated_modified_oops(); |
|
33212 | 68 |
} |
69 |
} |
|
70 |
}; |
|
71 |
||
47580 | 72 |
void CLDRemSet::clear_mod_union() { |
73 |
ClearCLDModUnionClosure closure; |
|
74 |
ClassLoaderDataGraph::cld_do(&closure); |
|
33212 | 75 |
} |
76 |
||
47580 | 77 |
|
27687
3a6367d7110b
8064721: The card tables only ever need two covering regions
ehelin
parents:
26160
diff
changeset
|
78 |
CardTableRS::CardTableRS(MemRegion whole_heap) : |
33212 | 79 |
_bs(NULL), |
27687
3a6367d7110b
8064721: The card tables only ever need two covering regions
ehelin
parents:
26160
diff
changeset
|
80 |
_cur_youngergen_card_val(youngergenP1_card) |
1 | 81 |
{ |
27687
3a6367d7110b
8064721: The card tables only ever need two covering regions
ehelin
parents:
26160
diff
changeset
|
82 |
_ct_bs = new CardTableModRefBSForCTRS(whole_heap); |
26160 | 83 |
_ct_bs->initialize(); |
1374
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
84 |
set_bs(_ct_bs); |
30155 | 85 |
// max_gens is really GenCollectedHeap::heap()->gen_policy()->number_of_generations() |
86 |
// (which is always 2, young & old), but GenCollectedHeap has not been initialized yet. |
|
87 |
uint max_gens = 2; |
|
88 |
_last_cur_val_in_gen = NEW_C_HEAP_ARRAY3(jbyte, max_gens + 1, |
|
25946 | 89 |
mtGC, CURRENT_PC, AllocFailStrategy::RETURN_NULL); |
1 | 90 |
if (_last_cur_val_in_gen == NULL) { |
17376
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17031
diff
changeset
|
91 |
vm_exit_during_initialization("Could not create last_cur_val_in_gen array."); |
1 | 92 |
} |
30155 | 93 |
for (uint i = 0; i < max_gens + 1; i++) { |
1 | 94 |
_last_cur_val_in_gen[i] = clean_card_val(); |
95 |
} |
|
1374
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
96 |
_ct_bs->set_CTRS(this); |
1 | 97 |
} |
98 |
||
17376
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17031
diff
changeset
|
99 |
CardTableRS::~CardTableRS() { |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17031
diff
changeset
|
100 |
if (_ct_bs) { |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17031
diff
changeset
|
101 |
delete _ct_bs; |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17031
diff
changeset
|
102 |
_ct_bs = NULL; |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17031
diff
changeset
|
103 |
} |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17031
diff
changeset
|
104 |
if (_last_cur_val_in_gen) { |
27880
afb974a04396
8060074: os::free() takes MemoryTrackingLevel but doesn't need it
coleenp
parents:
26160
diff
changeset
|
105 |
FREE_C_HEAP_ARRAY(jbyte, _last_cur_val_in_gen); |
17376
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17031
diff
changeset
|
106 |
} |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17031
diff
changeset
|
107 |
} |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17031
diff
changeset
|
108 |
|
1 | 109 |
void CardTableRS::resize_covered_region(MemRegion new_region) { |
1374
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
110 |
_ct_bs->resize_covered_region(new_region); |
1 | 111 |
} |
112 |
||
113 |
jbyte CardTableRS::find_unused_youngergenP_card_value() { |
|
114 |
for (jbyte v = youngergenP1_card; |
|
115 |
v < cur_youngergen_and_prev_nonclean_card; |
|
116 |
v++) { |
|
117 |
bool seen = false; |
|
1374
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
118 |
for (int g = 0; g < _regions_to_iterate; g++) { |
1 | 119 |
if (_last_cur_val_in_gen[g] == v) { |
120 |
seen = true; |
|
121 |
break; |
|
122 |
} |
|
123 |
} |
|
32623
390a27af5657
8134626: Misc cleanups after generation array removal
jwilhelm
parents:
31964
diff
changeset
|
124 |
if (!seen) { |
390a27af5657
8134626: Misc cleanups after generation array removal
jwilhelm
parents:
31964
diff
changeset
|
125 |
return v; |
390a27af5657
8134626: Misc cleanups after generation array removal
jwilhelm
parents:
31964
diff
changeset
|
126 |
} |
1 | 127 |
} |
128 |
ShouldNotReachHere(); |
|
129 |
return 0; |
|
130 |
} |
|
131 |
||
132 |
void CardTableRS::prepare_for_younger_refs_iterate(bool parallel) { |
|
133 |
// Parallel or sequential, we must always set the prev to equal the |
|
134 |
// last one written. |
|
135 |
if (parallel) { |
|
136 |
// Find a parallel value to be used next. |
|
137 |
jbyte next_val = find_unused_youngergenP_card_value(); |
|
138 |
set_cur_youngergen_card_val(next_val); |
|
139 |
||
140 |
} else { |
|
141 |
// In an sequential traversal we will always write youngergen, so that |
|
142 |
// the inline barrier is correct. |
|
143 |
set_cur_youngergen_card_val(youngergen_card); |
|
144 |
} |
|
145 |
} |
|
146 |
||
147 |
void CardTableRS::younger_refs_iterate(Generation* g, |
|
30870
3050fdcdc60b
8080112: Replace and remove the last usages of CollectedHeap::n_par_threads()
stefank
parents:
30764
diff
changeset
|
148 |
OopsInGenClosure* blk, |
3050fdcdc60b
8080112: Replace and remove the last usages of CollectedHeap::n_par_threads()
stefank
parents:
30764
diff
changeset
|
149 |
uint n_threads) { |
31358
693058672cc6
8077842: Remove the level parameter passed around in GenCollectedHeap
jwilhelm
parents:
30870
diff
changeset
|
150 |
// The indexing in this array is slightly odd. We want to access |
693058672cc6
8077842: Remove the level parameter passed around in GenCollectedHeap
jwilhelm
parents:
30870
diff
changeset
|
151 |
// the old generation record here, which is at index 2. |
693058672cc6
8077842: Remove the level parameter passed around in GenCollectedHeap
jwilhelm
parents:
30870
diff
changeset
|
152 |
_last_cur_val_in_gen[2] = cur_youngergen_card_val(); |
30870
3050fdcdc60b
8080112: Replace and remove the last usages of CollectedHeap::n_par_threads()
stefank
parents:
30764
diff
changeset
|
153 |
g->younger_refs_iterate(blk, n_threads); |
1 | 154 |
} |
155 |
||
9336
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
156 |
inline bool ClearNoncleanCardWrapper::clear_card(jbyte* entry) { |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
157 |
if (_is_par) { |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
158 |
return clear_card_parallel(entry); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
159 |
} else { |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
160 |
return clear_card_serial(entry); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
161 |
} |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
162 |
} |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
163 |
|
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
164 |
inline bool ClearNoncleanCardWrapper::clear_card_parallel(jbyte* entry) { |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
165 |
while (true) { |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
166 |
// In the parallel case, we may have to do this several times. |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
167 |
jbyte entry_val = *entry; |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
168 |
assert(entry_val != CardTableRS::clean_card_val(), |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
169 |
"We shouldn't be looking at clean cards, and this should " |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
170 |
"be the only place they get cleaned."); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
171 |
if (CardTableRS::card_is_dirty_wrt_gen_iter(entry_val) |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
172 |
|| _ct->is_prev_youngergen_card_val(entry_val)) { |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
173 |
jbyte res = |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
174 |
Atomic::cmpxchg(CardTableRS::clean_card_val(), entry, entry_val); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
175 |
if (res == entry_val) { |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
176 |
break; |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
177 |
} else { |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
178 |
assert(res == CardTableRS::cur_youngergen_and_prev_nonclean_card, |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
179 |
"The CAS above should only fail if another thread did " |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
180 |
"a GC write barrier."); |
1 | 181 |
} |
9336
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
182 |
} else if (entry_val == |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
183 |
CardTableRS::cur_youngergen_and_prev_nonclean_card) { |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
184 |
// Parallelism shouldn't matter in this case. Only the thread |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
185 |
// assigned to scan the card should change this value. |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
186 |
*entry = _ct->cur_youngergen_card_val(); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
187 |
break; |
1 | 188 |
} else { |
9336
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
189 |
assert(entry_val == _ct->cur_youngergen_card_val(), |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
190 |
"Should be the only possibility."); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
191 |
// In this case, the card was clean before, and become |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
192 |
// cur_youngergen only because of processing of a promoted object. |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
193 |
// We don't have to look at the card. |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
194 |
return false; |
1 | 195 |
} |
196 |
} |
|
9336
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
197 |
return true; |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
198 |
} |
1 | 199 |
|
9336
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
200 |
|
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
201 |
inline bool ClearNoncleanCardWrapper::clear_card_serial(jbyte* entry) { |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
202 |
jbyte entry_val = *entry; |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
203 |
assert(entry_val != CardTableRS::clean_card_val(), |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
204 |
"We shouldn't be looking at clean cards, and this should " |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
205 |
"be the only place they get cleaned."); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
206 |
assert(entry_val != CardTableRS::cur_youngergen_and_prev_nonclean_card, |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
207 |
"This should be possible in the sequential case."); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
208 |
*entry = CardTableRS::clean_card_val(); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
209 |
return true; |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
210 |
} |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
211 |
|
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
212 |
ClearNoncleanCardWrapper::ClearNoncleanCardWrapper( |
30870
3050fdcdc60b
8080112: Replace and remove the last usages of CollectedHeap::n_par_threads()
stefank
parents:
30764
diff
changeset
|
213 |
DirtyCardToOopClosure* dirty_card_closure, CardTableRS* ct, bool is_par) : |
3050fdcdc60b
8080112: Replace and remove the last usages of CollectedHeap::n_par_threads()
stefank
parents:
30764
diff
changeset
|
214 |
_dirty_card_closure(dirty_card_closure), _ct(ct), _is_par(is_par) { |
9336
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
215 |
} |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
216 |
|
12118
36458db4ccf5
7068625: Testing 8 bytes of card table entries at a time speeds up card-scanning
brutisso
parents:
11174
diff
changeset
|
217 |
bool ClearNoncleanCardWrapper::is_word_aligned(jbyte* entry) { |
36458db4ccf5
7068625: Testing 8 bytes of card table entries at a time speeds up card-scanning
brutisso
parents:
11174
diff
changeset
|
218 |
return (((intptr_t)entry) & (BytesPerWord-1)) == 0; |
36458db4ccf5
7068625: Testing 8 bytes of card table entries at a time speeds up card-scanning
brutisso
parents:
11174
diff
changeset
|
219 |
} |
36458db4ccf5
7068625: Testing 8 bytes of card table entries at a time speeds up card-scanning
brutisso
parents:
11174
diff
changeset
|
220 |
|
30165
c4ff729cb74a
8076614: Add comment to ClearNoncleanCardWrapper::do_MemRegion()
brutisso
parents:
30155
diff
changeset
|
221 |
// The regions are visited in *decreasing* address order. |
c4ff729cb74a
8076614: Add comment to ClearNoncleanCardWrapper::do_MemRegion()
brutisso
parents:
30155
diff
changeset
|
222 |
// This order aids with imprecise card marking, where a dirty |
c4ff729cb74a
8076614: Add comment to ClearNoncleanCardWrapper::do_MemRegion()
brutisso
parents:
30155
diff
changeset
|
223 |
// card may cause scanning, and summarization marking, of objects |
c4ff729cb74a
8076614: Add comment to ClearNoncleanCardWrapper::do_MemRegion()
brutisso
parents:
30155
diff
changeset
|
224 |
// that extend onto subsequent cards. |
9336
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
225 |
void ClearNoncleanCardWrapper::do_MemRegion(MemRegion mr) { |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
226 |
assert(mr.word_size() > 0, "Error"); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
227 |
assert(_ct->is_aligned(mr.start()), "mr.start() should be card aligned"); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
228 |
// mr.end() may not necessarily be card aligned. |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
229 |
jbyte* cur_entry = _ct->byte_for(mr.last()); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
230 |
const jbyte* limit = _ct->byte_for(mr.start()); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
231 |
HeapWord* end_of_non_clean = mr.end(); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
232 |
HeapWord* start_of_non_clean = end_of_non_clean; |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
233 |
while (cur_entry >= limit) { |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
234 |
HeapWord* cur_hw = _ct->addr_for(cur_entry); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
235 |
if ((*cur_entry != CardTableRS::clean_card_val()) && clear_card(cur_entry)) { |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
236 |
// Continue the dirty range by opening the |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
237 |
// dirty window one card to the left. |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
238 |
start_of_non_clean = cur_hw; |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
239 |
} else { |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
240 |
// We hit a "clean" card; process any non-empty |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
241 |
// "dirty" range accumulated so far. |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
242 |
if (start_of_non_clean < end_of_non_clean) { |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
243 |
const MemRegion mrd(start_of_non_clean, end_of_non_clean); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
244 |
_dirty_card_closure->do_MemRegion(mrd); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
245 |
} |
12118
36458db4ccf5
7068625: Testing 8 bytes of card table entries at a time speeds up card-scanning
brutisso
parents:
11174
diff
changeset
|
246 |
|
36458db4ccf5
7068625: Testing 8 bytes of card table entries at a time speeds up card-scanning
brutisso
parents:
11174
diff
changeset
|
247 |
// fast forward through potential continuous whole-word range of clean cards beginning at a word-boundary |
36458db4ccf5
7068625: Testing 8 bytes of card table entries at a time speeds up card-scanning
brutisso
parents:
11174
diff
changeset
|
248 |
if (is_word_aligned(cur_entry)) { |
36458db4ccf5
7068625: Testing 8 bytes of card table entries at a time speeds up card-scanning
brutisso
parents:
11174
diff
changeset
|
249 |
jbyte* cur_row = cur_entry - BytesPerWord; |
36458db4ccf5
7068625: Testing 8 bytes of card table entries at a time speeds up card-scanning
brutisso
parents:
11174
diff
changeset
|
250 |
while (cur_row >= limit && *((intptr_t*)cur_row) == CardTableRS::clean_card_row()) { |
36458db4ccf5
7068625: Testing 8 bytes of card table entries at a time speeds up card-scanning
brutisso
parents:
11174
diff
changeset
|
251 |
cur_row -= BytesPerWord; |
36458db4ccf5
7068625: Testing 8 bytes of card table entries at a time speeds up card-scanning
brutisso
parents:
11174
diff
changeset
|
252 |
} |
36458db4ccf5
7068625: Testing 8 bytes of card table entries at a time speeds up card-scanning
brutisso
parents:
11174
diff
changeset
|
253 |
cur_entry = cur_row + BytesPerWord; |
36458db4ccf5
7068625: Testing 8 bytes of card table entries at a time speeds up card-scanning
brutisso
parents:
11174
diff
changeset
|
254 |
cur_hw = _ct->addr_for(cur_entry); |
36458db4ccf5
7068625: Testing 8 bytes of card table entries at a time speeds up card-scanning
brutisso
parents:
11174
diff
changeset
|
255 |
} |
36458db4ccf5
7068625: Testing 8 bytes of card table entries at a time speeds up card-scanning
brutisso
parents:
11174
diff
changeset
|
256 |
|
9336
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
257 |
// Reset the dirty window, while continuing to look |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
258 |
// for the next dirty card that will start a |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
259 |
// new dirty window. |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
260 |
end_of_non_clean = cur_hw; |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
261 |
start_of_non_clean = cur_hw; |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
262 |
} |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
263 |
// Note that "cur_entry" leads "start_of_non_clean" in |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
264 |
// its leftward excursion after this point |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
265 |
// in the loop and, when we hit the left end of "mr", |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
266 |
// will point off of the left end of the card-table |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
267 |
// for "mr". |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
268 |
cur_entry--; |
1 | 269 |
} |
9336
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
270 |
// If the first card of "mr" was dirty, we will have |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
271 |
// been left with a dirty window, co-initial with "mr", |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
272 |
// which we now process. |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
273 |
if (start_of_non_clean < end_of_non_clean) { |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
274 |
const MemRegion mrd(start_of_non_clean, end_of_non_clean); |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
275 |
_dirty_card_closure->do_MemRegion(mrd); |
1 | 276 |
} |
9336
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
277 |
} |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
278 |
|
1 | 279 |
// clean (by dirty->clean before) ==> cur_younger_gen |
280 |
// dirty ==> cur_youngergen_and_prev_nonclean_card |
|
281 |
// precleaned ==> cur_youngergen_and_prev_nonclean_card |
|
282 |
// prev-younger-gen ==> cur_youngergen_and_prev_nonclean_card |
|
283 |
// cur-younger-gen ==> cur_younger_gen |
|
284 |
// cur_youngergen_and_prev_nonclean_card ==> no change. |
|
360
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
179
diff
changeset
|
285 |
void CardTableRS::write_ref_field_gc_par(void* field, oop new_val) { |
46321
640277633c23
8164038: Missing volatile keyword at CardTableRS::write_ref_field_gc_par()
sangheki
parents:
40655
diff
changeset
|
286 |
volatile jbyte* entry = _ct_bs->byte_for(field); |
1 | 287 |
do { |
288 |
jbyte entry_val = *entry; |
|
289 |
// We put this first because it's probably the most common case. |
|
290 |
if (entry_val == clean_card_val()) { |
|
291 |
// No threat of contention with cleaning threads. |
|
292 |
*entry = cur_youngergen_card_val(); |
|
293 |
return; |
|
294 |
} else if (card_is_dirty_wrt_gen_iter(entry_val) |
|
295 |
|| is_prev_youngergen_card_val(entry_val)) { |
|
296 |
// Mark it as both cur and prev youngergen; card cleaning thread will |
|
297 |
// eventually remove the previous stuff. |
|
298 |
jbyte new_val = cur_youngergen_and_prev_nonclean_card; |
|
299 |
jbyte res = Atomic::cmpxchg(new_val, entry, entry_val); |
|
300 |
// Did the CAS succeed? |
|
301 |
if (res == entry_val) return; |
|
302 |
// Otherwise, retry, to see the new value. |
|
303 |
continue; |
|
304 |
} else { |
|
305 |
assert(entry_val == cur_youngergen_and_prev_nonclean_card |
|
306 |
|| entry_val == cur_youngergen_card_val(), |
|
307 |
"should be only possibilities."); |
|
308 |
return; |
|
309 |
} |
|
310 |
} while (true); |
|
311 |
} |
|
312 |
||
313 |
void CardTableRS::younger_refs_in_space_iterate(Space* sp, |
|
30870
3050fdcdc60b
8080112: Replace and remove the last usages of CollectedHeap::n_par_threads()
stefank
parents:
30764
diff
changeset
|
314 |
OopsInGenClosure* cl, |
3050fdcdc60b
8080112: Replace and remove the last usages of CollectedHeap::n_par_threads()
stefank
parents:
30764
diff
changeset
|
315 |
uint n_threads) { |
9342
456b8d0486b5
7039089: G1: changeset for 7037276 broke heap verification, and related cleanups
ysr
parents:
9336
diff
changeset
|
316 |
const MemRegion urasm = sp->used_region_at_save_marks(); |
456b8d0486b5
7039089: G1: changeset for 7037276 broke heap verification, and related cleanups
ysr
parents:
9336
diff
changeset
|
317 |
#ifdef ASSERT |
456b8d0486b5
7039089: G1: changeset for 7037276 broke heap verification, and related cleanups
ysr
parents:
9336
diff
changeset
|
318 |
// Convert the assertion check to a warning if we are running |
456b8d0486b5
7039089: G1: changeset for 7037276 broke heap verification, and related cleanups
ysr
parents:
9336
diff
changeset
|
319 |
// CMS+ParNew until related bug is fixed. |
456b8d0486b5
7039089: G1: changeset for 7037276 broke heap verification, and related cleanups
ysr
parents:
9336
diff
changeset
|
320 |
MemRegion ur = sp->used_region(); |
27898
813ad96387b3
8065972: Remove support for ParNew+SerialOld and DefNew+CMS
brutisso
parents:
27687
diff
changeset
|
321 |
assert(ur.contains(urasm) || (UseConcMarkSweepGC), |
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
32623
diff
changeset
|
322 |
"Did you forget to call save_marks()? " |
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
32623
diff
changeset
|
323 |
"[" PTR_FORMAT ", " PTR_FORMAT ") is not contained in " |
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
32623
diff
changeset
|
324 |
"[" PTR_FORMAT ", " PTR_FORMAT ")", |
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
32623
diff
changeset
|
325 |
p2i(urasm.start()), p2i(urasm.end()), p2i(ur.start()), p2i(ur.end())); |
9342
456b8d0486b5
7039089: G1: changeset for 7037276 broke heap verification, and related cleanups
ysr
parents:
9336
diff
changeset
|
326 |
// In the case of CMS+ParNew, issue a warning |
456b8d0486b5
7039089: G1: changeset for 7037276 broke heap verification, and related cleanups
ysr
parents:
9336
diff
changeset
|
327 |
if (!ur.contains(urasm)) { |
27898
813ad96387b3
8065972: Remove support for ParNew+SerialOld and DefNew+CMS
brutisso
parents:
27687
diff
changeset
|
328 |
assert(UseConcMarkSweepGC, "Tautology: see assert above"); |
37073
c39d0903390b
8151605: Change warning() to log_warning(gc) in the GC code
brutisso
parents:
33230
diff
changeset
|
329 |
log_warning(gc)("CMS+ParNew: Did you forget to call save_marks()? " |
c39d0903390b
8151605: Change warning() to log_warning(gc) in the GC code
brutisso
parents:
33230
diff
changeset
|
330 |
"[" PTR_FORMAT ", " PTR_FORMAT ") is not contained in " |
c39d0903390b
8151605: Change warning() to log_warning(gc) in the GC code
brutisso
parents:
33230
diff
changeset
|
331 |
"[" PTR_FORMAT ", " PTR_FORMAT ")", |
c39d0903390b
8151605: Change warning() to log_warning(gc) in the GC code
brutisso
parents:
33230
diff
changeset
|
332 |
p2i(urasm.start()), p2i(urasm.end()), p2i(ur.start()), p2i(ur.end())); |
9342
456b8d0486b5
7039089: G1: changeset for 7037276 broke heap verification, and related cleanups
ysr
parents:
9336
diff
changeset
|
333 |
MemRegion ur2 = sp->used_region(); |
456b8d0486b5
7039089: G1: changeset for 7037276 broke heap verification, and related cleanups
ysr
parents:
9336
diff
changeset
|
334 |
MemRegion urasm2 = sp->used_region_at_save_marks(); |
456b8d0486b5
7039089: G1: changeset for 7037276 broke heap verification, and related cleanups
ysr
parents:
9336
diff
changeset
|
335 |
if (!ur.equals(ur2)) { |
37073
c39d0903390b
8151605: Change warning() to log_warning(gc) in the GC code
brutisso
parents:
33230
diff
changeset
|
336 |
log_warning(gc)("CMS+ParNew: Flickering used_region()!!"); |
9342
456b8d0486b5
7039089: G1: changeset for 7037276 broke heap verification, and related cleanups
ysr
parents:
9336
diff
changeset
|
337 |
} |
456b8d0486b5
7039089: G1: changeset for 7037276 broke heap verification, and related cleanups
ysr
parents:
9336
diff
changeset
|
338 |
if (!urasm.equals(urasm2)) { |
37073
c39d0903390b
8151605: Change warning() to log_warning(gc) in the GC code
brutisso
parents:
33230
diff
changeset
|
339 |
log_warning(gc)("CMS+ParNew: Flickering used_region_at_save_marks()!!"); |
9342
456b8d0486b5
7039089: G1: changeset for 7037276 broke heap verification, and related cleanups
ysr
parents:
9336
diff
changeset
|
340 |
} |
9624
c3657c3324ee
6883834: ParNew: assert(!_g->to()->is_in_reserved(obj),"Scanning field twice?") with LargeObjects tests
ysr
parents:
9342
diff
changeset
|
341 |
ShouldNotReachHere(); |
9342
456b8d0486b5
7039089: G1: changeset for 7037276 broke heap verification, and related cleanups
ysr
parents:
9336
diff
changeset
|
342 |
} |
456b8d0486b5
7039089: G1: changeset for 7037276 broke heap verification, and related cleanups
ysr
parents:
9336
diff
changeset
|
343 |
#endif |
30870
3050fdcdc60b
8080112: Replace and remove the last usages of CollectedHeap::n_par_threads()
stefank
parents:
30764
diff
changeset
|
344 |
_ct_bs->non_clean_card_iterate_possibly_parallel(sp, urasm, cl, this, n_threads); |
1 | 345 |
} |
346 |
||
19289
213031f03f61
8023021: Unnecessary clearing of the card table introduced by the fix for JDK-8023013
brutisso
parents:
19286
diff
changeset
|
347 |
void CardTableRS::clear_into_younger(Generation* old_gen) { |
31358
693058672cc6
8077842: Remove the level parameter passed around in GenCollectedHeap
jwilhelm
parents:
30870
diff
changeset
|
348 |
assert(GenCollectedHeap::heap()->is_old_gen(old_gen), |
693058672cc6
8077842: Remove the level parameter passed around in GenCollectedHeap
jwilhelm
parents:
30870
diff
changeset
|
349 |
"Should only be called for the old generation"); |
19289
213031f03f61
8023021: Unnecessary clearing of the card table introduced by the fix for JDK-8023013
brutisso
parents:
19286
diff
changeset
|
350 |
// The card tables for the youngest gen need never be cleared. |
1 | 351 |
// There's a bit of subtlety in the clear() and invalidate() |
352 |
// methods that we exploit here and in invalidate_or_clear() |
|
353 |
// below to avoid missing cards at the fringes. If clear() or |
|
354 |
// invalidate() are changed in the future, this code should |
|
355 |
// be revisited. 20040107.ysr |
|
19286
48394008c803
8022800: Use specific generations rather than generation iteration
brutisso
parents:
17376
diff
changeset
|
356 |
clear(old_gen->prev_used_region()); |
1 | 357 |
} |
358 |
||
19289
213031f03f61
8023021: Unnecessary clearing of the card table introduced by the fix for JDK-8023013
brutisso
parents:
19286
diff
changeset
|
359 |
void CardTableRS::invalidate_or_clear(Generation* old_gen) { |
31358
693058672cc6
8077842: Remove the level parameter passed around in GenCollectedHeap
jwilhelm
parents:
30870
diff
changeset
|
360 |
assert(GenCollectedHeap::heap()->is_old_gen(old_gen), |
693058672cc6
8077842: Remove the level parameter passed around in GenCollectedHeap
jwilhelm
parents:
30870
diff
changeset
|
361 |
"Should only be called for the old generation"); |
19289
213031f03f61
8023021: Unnecessary clearing of the card table introduced by the fix for JDK-8023013
brutisso
parents:
19286
diff
changeset
|
362 |
// Invalidate the cards for the currently occupied part of |
213031f03f61
8023021: Unnecessary clearing of the card table introduced by the fix for JDK-8023013
brutisso
parents:
19286
diff
changeset
|
363 |
// the old generation and clear the cards for the |
1 | 364 |
// unoccupied part of the generation (if any, making use |
365 |
// of that generation's prev_used_region to determine that |
|
366 |
// region). No need to do anything for the youngest |
|
367 |
// generation. Also see note#20040107.ysr above. |
|
19289
213031f03f61
8023021: Unnecessary clearing of the card table introduced by the fix for JDK-8023013
brutisso
parents:
19286
diff
changeset
|
368 |
MemRegion used_mr = old_gen->used_region(); |
213031f03f61
8023021: Unnecessary clearing of the card table introduced by the fix for JDK-8023013
brutisso
parents:
19286
diff
changeset
|
369 |
MemRegion to_be_cleared_mr = old_gen->prev_used_region().minus(used_mr); |
19286
48394008c803
8022800: Use specific generations rather than generation iteration
brutisso
parents:
17376
diff
changeset
|
370 |
if (!to_be_cleared_mr.is_empty()) { |
48394008c803
8022800: Use specific generations rather than generation iteration
brutisso
parents:
17376
diff
changeset
|
371 |
clear(to_be_cleared_mr); |
1 | 372 |
} |
19286
48394008c803
8022800: Use specific generations rather than generation iteration
brutisso
parents:
17376
diff
changeset
|
373 |
invalidate(used_mr); |
1 | 374 |
} |
375 |
||
376 |
||
377 |
class VerifyCleanCardClosure: public OopClosure { |
|
360
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
179
diff
changeset
|
378 |
private: |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
179
diff
changeset
|
379 |
HeapWord* _boundary; |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
179
diff
changeset
|
380 |
HeapWord* _begin; |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
179
diff
changeset
|
381 |
HeapWord* _end; |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
179
diff
changeset
|
382 |
protected: |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
179
diff
changeset
|
383 |
template <class T> void do_oop_work(T* p) { |
1 | 384 |
HeapWord* jp = (HeapWord*)p; |
8923
67b8a1ea66e2
7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC
ysr
parents:
7397
diff
changeset
|
385 |
assert(jp >= _begin && jp < _end, |
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
32623
diff
changeset
|
386 |
"Error: jp " PTR_FORMAT " should be within " |
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
32623
diff
changeset
|
387 |
"[_begin, _end) = [" PTR_FORMAT "," PTR_FORMAT ")", |
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
32623
diff
changeset
|
388 |
p2i(jp), p2i(_begin), p2i(_end)); |
8923
67b8a1ea66e2
7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC
ysr
parents:
7397
diff
changeset
|
389 |
oop obj = oopDesc::load_decode_heap_oop(p); |
67b8a1ea66e2
7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC
ysr
parents:
7397
diff
changeset
|
390 |
guarantee(obj == NULL || (HeapWord*)obj >= _boundary, |
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
32623
diff
changeset
|
391 |
"pointer " PTR_FORMAT " at " PTR_FORMAT " on " |
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
32623
diff
changeset
|
392 |
"clean card crosses boundary" PTR_FORMAT, |
33198 | 393 |
p2i(obj), p2i(jp), p2i(_boundary)); |
1 | 394 |
} |
8923
67b8a1ea66e2
7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC
ysr
parents:
7397
diff
changeset
|
395 |
|
360
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
179
diff
changeset
|
396 |
public: |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
179
diff
changeset
|
397 |
VerifyCleanCardClosure(HeapWord* b, HeapWord* begin, HeapWord* end) : |
8923
67b8a1ea66e2
7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC
ysr
parents:
7397
diff
changeset
|
398 |
_boundary(b), _begin(begin), _end(end) { |
67b8a1ea66e2
7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC
ysr
parents:
7397
diff
changeset
|
399 |
assert(b <= begin, |
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
32623
diff
changeset
|
400 |
"Error: boundary " PTR_FORMAT " should be at or below begin " PTR_FORMAT, |
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
32623
diff
changeset
|
401 |
p2i(b), p2i(begin)); |
8923
67b8a1ea66e2
7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC
ysr
parents:
7397
diff
changeset
|
402 |
assert(begin <= end, |
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
32623
diff
changeset
|
403 |
"Error: begin " PTR_FORMAT " should be strictly below end " PTR_FORMAT, |
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
32623
diff
changeset
|
404 |
p2i(begin), p2i(end)); |
8923
67b8a1ea66e2
7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC
ysr
parents:
7397
diff
changeset
|
405 |
} |
67b8a1ea66e2
7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC
ysr
parents:
7397
diff
changeset
|
406 |
|
360
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
179
diff
changeset
|
407 |
virtual void do_oop(oop* p) { VerifyCleanCardClosure::do_oop_work(p); } |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
179
diff
changeset
|
408 |
virtual void do_oop(narrowOop* p) { VerifyCleanCardClosure::do_oop_work(p); } |
1 | 409 |
}; |
410 |
||
411 |
class VerifyCTSpaceClosure: public SpaceClosure { |
|
360
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
179
diff
changeset
|
412 |
private: |
1 | 413 |
CardTableRS* _ct; |
414 |
HeapWord* _boundary; |
|
415 |
public: |
|
416 |
VerifyCTSpaceClosure(CardTableRS* ct, HeapWord* boundary) : |
|
417 |
_ct(ct), _boundary(boundary) {} |
|
360
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
179
diff
changeset
|
418 |
virtual void do_space(Space* s) { _ct->verify_space(s, _boundary); } |
1 | 419 |
}; |
420 |
||
421 |
class VerifyCTGenClosure: public GenCollectedHeap::GenClosure { |
|
422 |
CardTableRS* _ct; |
|
423 |
public: |
|
424 |
VerifyCTGenClosure(CardTableRS* ct) : _ct(ct) {} |
|
425 |
void do_generation(Generation* gen) { |
|
426 |
// Skip the youngest generation. |
|
31358
693058672cc6
8077842: Remove the level parameter passed around in GenCollectedHeap
jwilhelm
parents:
30870
diff
changeset
|
427 |
if (GenCollectedHeap::heap()->is_young_gen(gen)) { |
693058672cc6
8077842: Remove the level parameter passed around in GenCollectedHeap
jwilhelm
parents:
30870
diff
changeset
|
428 |
return; |
693058672cc6
8077842: Remove the level parameter passed around in GenCollectedHeap
jwilhelm
parents:
30870
diff
changeset
|
429 |
} |
1 | 430 |
// Normally, we're interested in pointers to younger generations. |
431 |
VerifyCTSpaceClosure blk(_ct, gen->reserved().start()); |
|
432 |
gen->space_iterate(&blk, true); |
|
433 |
} |
|
434 |
}; |
|
435 |
||
436 |
void CardTableRS::verify_space(Space* s, HeapWord* gen_boundary) { |
|
437 |
// We don't need to do young-gen spaces. |
|
438 |
if (s->end() <= gen_boundary) return; |
|
439 |
MemRegion used = s->used_region(); |
|
440 |
||
441 |
jbyte* cur_entry = byte_for(used.start()); |
|
442 |
jbyte* limit = byte_after(used.last()); |
|
443 |
while (cur_entry < limit) { |
|
31964 | 444 |
if (*cur_entry == clean_card_val()) { |
1 | 445 |
jbyte* first_dirty = cur_entry+1; |
446 |
while (first_dirty < limit && |
|
31964 | 447 |
*first_dirty == clean_card_val()) { |
1 | 448 |
first_dirty++; |
449 |
} |
|
450 |
// If the first object is a regular object, and it has a |
|
451 |
// young-to-old field, that would mark the previous card. |
|
452 |
HeapWord* boundary = addr_for(cur_entry); |
|
453 |
HeapWord* end = (first_dirty >= limit) ? used.end() : addr_for(first_dirty); |
|
454 |
HeapWord* boundary_block = s->block_start(boundary); |
|
455 |
HeapWord* begin = boundary; // Until proven otherwise. |
|
456 |
HeapWord* start_block = boundary_block; // Until proven otherwise. |
|
457 |
if (boundary_block < boundary) { |
|
458 |
if (s->block_is_obj(boundary_block) && s->obj_is_alive(boundary_block)) { |
|
459 |
oop boundary_obj = oop(boundary_block); |
|
460 |
if (!boundary_obj->is_objArray() && |
|
461 |
!boundary_obj->is_typeArray()) { |
|
462 |
guarantee(cur_entry > byte_for(used.start()), |
|
463 |
"else boundary would be boundary_block"); |
|
31964 | 464 |
if (*byte_for(boundary_block) != clean_card_val()) { |
1 | 465 |
begin = boundary_block + s->block_size(boundary_block); |
466 |
start_block = begin; |
|
467 |
} |
|
468 |
} |
|
469 |
} |
|
470 |
} |
|
471 |
// Now traverse objects until end. |
|
8923
67b8a1ea66e2
7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC
ysr
parents:
7397
diff
changeset
|
472 |
if (begin < end) { |
67b8a1ea66e2
7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC
ysr
parents:
7397
diff
changeset
|
473 |
MemRegion mr(begin, end); |
67b8a1ea66e2
7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC
ysr
parents:
7397
diff
changeset
|
474 |
VerifyCleanCardClosure verify_blk(gen_boundary, begin, end); |
67b8a1ea66e2
7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC
ysr
parents:
7397
diff
changeset
|
475 |
for (HeapWord* cur = start_block; cur < end; cur += s->block_size(cur)) { |
67b8a1ea66e2
7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC
ysr
parents:
7397
diff
changeset
|
476 |
if (s->block_is_obj(cur) && s->obj_is_alive(cur)) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
12118
diff
changeset
|
477 |
oop(cur)->oop_iterate_no_header(&verify_blk, mr); |
8923
67b8a1ea66e2
7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC
ysr
parents:
7397
diff
changeset
|
478 |
} |
1 | 479 |
} |
480 |
} |
|
481 |
cur_entry = first_dirty; |
|
482 |
} else { |
|
483 |
// We'd normally expect that cur_youngergen_and_prev_nonclean_card |
|
484 |
// is a transient value, that cannot be in the card table |
|
485 |
// except during GC, and thus assert that: |
|
486 |
// guarantee(*cur_entry != cur_youngergen_and_prev_nonclean_card, |
|
487 |
// "Illegal CT value"); |
|
488 |
// That however, need not hold, as will become clear in the |
|
489 |
// following... |
|
490 |
||
491 |
// We'd normally expect that if we are in the parallel case, |
|
492 |
// we can't have left a prev value (which would be different |
|
493 |
// from the current value) in the card table, and so we'd like to |
|
494 |
// assert that: |
|
495 |
// guarantee(cur_youngergen_card_val() == youngergen_card |
|
496 |
// || !is_prev_youngergen_card_val(*cur_entry), |
|
497 |
// "Illegal CT value"); |
|
498 |
// That, however, may not hold occasionally, because of |
|
499 |
// CMS or MSC in the old gen. To wit, consider the |
|
500 |
// following two simple illustrative scenarios: |
|
501 |
// (a) CMS: Consider the case where a large object L |
|
502 |
// spanning several cards is allocated in the old |
|
503 |
// gen, and has a young gen reference stored in it, dirtying |
|
504 |
// some interior cards. A young collection scans the card, |
|
505 |
// finds a young ref and installs a youngergenP_n value. |
|
506 |
// L then goes dead. Now a CMS collection starts, |
|
507 |
// finds L dead and sweeps it up. Assume that L is |
|
508 |
// abutting _unallocated_blk, so _unallocated_blk is |
|
509 |
// adjusted down to (below) L. Assume further that |
|
510 |
// no young collection intervenes during this CMS cycle. |
|
511 |
// The next young gen cycle will not get to look at this |
|
512 |
// youngergenP_n card since it lies in the unoccupied |
|
513 |
// part of the space. |
|
514 |
// Some young collections later the blocks on this |
|
515 |
// card can be re-allocated either due to direct allocation |
|
516 |
// or due to absorbing promotions. At this time, the |
|
517 |
// before-gc verification will fail the above assert. |
|
518 |
// (b) MSC: In this case, an object L with a young reference |
|
519 |
// is on a card that (therefore) holds a youngergen_n value. |
|
520 |
// Suppose also that L lies towards the end of the used |
|
521 |
// the used space before GC. An MSC collection |
|
522 |
// occurs that compacts to such an extent that this |
|
523 |
// card is no longer in the occupied part of the space. |
|
524 |
// Since current code in MSC does not always clear cards |
|
525 |
// in the unused part of old gen, this stale youngergen_n |
|
526 |
// value is left behind and can later be covered by |
|
527 |
// an object when promotion or direct allocation |
|
528 |
// re-allocates that part of the heap. |
|
529 |
// |
|
530 |
// Fortunately, the presence of such stale card values is |
|
531 |
// "only" a minor annoyance in that subsequent young collections |
|
532 |
// might needlessly scan such cards, but would still never corrupt |
|
533 |
// the heap as a result. However, it's likely not to be a significant |
|
534 |
// performance inhibitor in practice. For instance, |
|
535 |
// some recent measurements with unoccupied cards eagerly cleared |
|
536 |
// out to maintain this invariant, showed next to no |
|
537 |
// change in young collection times; of course one can construct |
|
538 |
// degenerate examples where the cost can be significant.) |
|
539 |
// Note, in particular, that if the "stale" card is modified |
|
540 |
// after re-allocation, it would be dirty, not "stale". Thus, |
|
541 |
// we can never have a younger ref in such a card and it is |
|
542 |
// safe not to scan that card in any collection. [As we see |
|
543 |
// below, we do some unnecessary scanning |
|
544 |
// in some cases in the current parallel scanning algorithm.] |
|
545 |
// |
|
546 |
// The main point below is that the parallel card scanning code |
|
547 |
// deals correctly with these stale card values. There are two main |
|
32623
390a27af5657
8134626: Misc cleanups after generation array removal
jwilhelm
parents:
31964
diff
changeset
|
548 |
// cases to consider where we have a stale "young gen" value and a |
1 | 549 |
// "derivative" case to consider, where we have a stale |
550 |
// "cur_younger_gen_and_prev_non_clean" value, as will become |
|
551 |
// apparent in the case analysis below. |
|
552 |
// o Case 1. If the stale value corresponds to a younger_gen_n |
|
553 |
// value other than the cur_younger_gen value then the code |
|
554 |
// treats this as being tantamount to a prev_younger_gen |
|
555 |
// card. This means that the card may be unnecessarily scanned. |
|
556 |
// There are two sub-cases to consider: |
|
557 |
// o Case 1a. Let us say that the card is in the occupied part |
|
558 |
// of the generation at the time the collection begins. In |
|
559 |
// that case the card will be either cleared when it is scanned |
|
560 |
// for young pointers, or will be set to cur_younger_gen as a |
|
561 |
// result of promotion. (We have elided the normal case where |
|
562 |
// the scanning thread and the promoting thread interleave |
|
563 |
// possibly resulting in a transient |
|
564 |
// cur_younger_gen_and_prev_non_clean value before settling |
|
565 |
// to cur_younger_gen. [End Case 1a.] |
|
566 |
// o Case 1b. Consider now the case when the card is in the unoccupied |
|
567 |
// part of the space which becomes occupied because of promotions |
|
568 |
// into it during the current young GC. In this case the card |
|
569 |
// will never be scanned for young references. The current |
|
570 |
// code will set the card value to either |
|
571 |
// cur_younger_gen_and_prev_non_clean or leave |
|
572 |
// it with its stale value -- because the promotions didn't |
|
573 |
// result in any younger refs on that card. Of these two |
|
574 |
// cases, the latter will be covered in Case 1a during |
|
575 |
// a subsequent scan. To deal with the former case, we need |
|
576 |
// to further consider how we deal with a stale value of |
|
577 |
// cur_younger_gen_and_prev_non_clean in our case analysis |
|
578 |
// below. This we do in Case 3 below. [End Case 1b] |
|
579 |
// [End Case 1] |
|
580 |
// o Case 2. If the stale value corresponds to cur_younger_gen being |
|
581 |
// a value not necessarily written by a current promotion, the |
|
582 |
// card will not be scanned by the younger refs scanning code. |
|
583 |
// (This is OK since as we argued above such cards cannot contain |
|
584 |
// any younger refs.) The result is that this value will be |
|
585 |
// treated as a prev_younger_gen value in a subsequent collection, |
|
586 |
// which is addressed in Case 1 above. [End Case 2] |
|
587 |
// o Case 3. We here consider the "derivative" case from Case 1b. above |
|
588 |
// because of which we may find a stale |
|
589 |
// cur_younger_gen_and_prev_non_clean card value in the table. |
|
590 |
// Once again, as in Case 1, we consider two subcases, depending |
|
591 |
// on whether the card lies in the occupied or unoccupied part |
|
592 |
// of the space at the start of the young collection. |
|
593 |
// o Case 3a. Let us say the card is in the occupied part of |
|
594 |
// the old gen at the start of the young collection. In that |
|
595 |
// case, the card will be scanned by the younger refs scanning |
|
596 |
// code which will set it to cur_younger_gen. In a subsequent |
|
597 |
// scan, the card will be considered again and get its final |
|
598 |
// correct value. [End Case 3a] |
|
599 |
// o Case 3b. Now consider the case where the card is in the |
|
600 |
// unoccupied part of the old gen, and is occupied as a result |
|
601 |
// of promotions during thus young gc. In that case, |
|
602 |
// the card will not be scanned for younger refs. The presence |
|
603 |
// of newly promoted objects on the card will then result in |
|
604 |
// its keeping the value cur_younger_gen_and_prev_non_clean |
|
605 |
// value, which we have dealt with in Case 3 here. [End Case 3b] |
|
606 |
// [End Case 3] |
|
607 |
// |
|
608 |
// (Please refer to the code in the helper class |
|
609 |
// ClearNonCleanCardWrapper and in CardTableModRefBS for details.) |
|
610 |
// |
|
611 |
// The informal arguments above can be tightened into a formal |
|
612 |
// correctness proof and it behooves us to write up such a proof, |
|
613 |
// or to use model checking to prove that there are no lingering |
|
614 |
// concerns. |
|
615 |
// |
|
616 |
// Clearly because of Case 3b one cannot bound the time for |
|
617 |
// which a card will retain what we have called a "stale" value. |
|
618 |
// However, one can obtain a Loose upper bound on the redundant |
|
619 |
// work as a result of such stale values. Note first that any |
|
620 |
// time a stale card lies in the occupied part of the space at |
|
621 |
// the start of the collection, it is scanned by younger refs |
|
622 |
// code and we can define a rank function on card values that |
|
623 |
// declines when this is so. Note also that when a card does not |
|
624 |
// lie in the occupied part of the space at the beginning of a |
|
625 |
// young collection, its rank can either decline or stay unchanged. |
|
626 |
// In this case, no extra work is done in terms of redundant |
|
627 |
// younger refs scanning of that card. |
|
628 |
// Then, the case analysis above reveals that, in the worst case, |
|
629 |
// any such stale card will be scanned unnecessarily at most twice. |
|
630 |
// |
|
22551 | 631 |
// It is nonetheless advisable to try and get rid of some of this |
1 | 632 |
// redundant work in a subsequent (low priority) re-design of |
633 |
// the card-scanning code, if only to simplify the underlying |
|
634 |
// state machine analysis/proof. ysr 1/28/2002. XXX |
|
635 |
cur_entry++; |
|
636 |
} |
|
637 |
} |
|
638 |
} |
|
639 |
||
640 |
void CardTableRS::verify() { |
|
641 |
// At present, we only know how to verify the card table RS for |
|
642 |
// generational heaps. |
|
643 |
VerifyCTGenClosure blk(this); |
|
30173
13cf7580b000
8077413: Avoid use of Universe::heap() inside collectors
pliden
parents:
30165
diff
changeset
|
644 |
GenCollectedHeap::heap()->generation_iterate(&blk, false); |
13cf7580b000
8077413: Avoid use of Universe::heap() inside collectors
pliden
parents:
30165
diff
changeset
|
645 |
_ct_bs->verify(); |
13cf7580b000
8077413: Avoid use of Universe::heap() inside collectors
pliden
parents:
30165
diff
changeset
|
646 |
} |