author | sspitsyn |
Wed, 10 Apr 2019 17:29:03 -0700 | |
changeset 54497 | 96230a5ef2ec |
parent 54431 | ad9fa99fa48e |
child 54511 | fbfcebad8e66 |
permissions | -rw-r--r-- |
46505 | 1 |
/* |
53904
9c3fe09f69bc
8078725: method adjustments can be done just once for all classes involved into redefinition
coleenp
parents:
51567
diff
changeset
|
2 |
* Copyright (c) 2017, 2019, Oracle and/or its affiliates. All rights reserved. |
46505 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
20 |
* or visit www.oracle.com if you need additional information or have any |
|
21 |
* questions. |
|
22 |
* |
|
23 |
*/ |
|
24 |
||
25 |
#include "precompiled.hpp" |
|
49593
4dd58ecc9912
8200105: Remove cyclic dependency between oop.inline.hpp and collectedHeap.inline.hpp
stefank
parents:
48615
diff
changeset
|
26 |
#include "classfile/javaClasses.hpp" |
49982 | 27 |
#include "logging/log.hpp" |
46505 | 28 |
#include "memory/allocation.hpp" |
49593
4dd58ecc9912
8200105: Remove cyclic dependency between oop.inline.hpp and collectedHeap.inline.hpp
stefank
parents:
48615
diff
changeset
|
29 |
#include "memory/resourceArea.hpp" |
48615
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
30 |
#include "oops/access.inline.hpp" |
46505 | 31 |
#include "oops/oop.inline.hpp" |
32 |
#include "oops/method.hpp" |
|
33 |
#include "oops/symbol.hpp" |
|
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
34 |
#include "oops/weakHandle.inline.hpp" |
46505 | 35 |
#include "prims/resolvedMethodTable.hpp" |
36 |
#include "runtime/handles.inline.hpp" |
|
37 |
#include "runtime/mutexLocker.hpp" |
|
49594
898ef81cbc0e
8200106: Move NoSafepointVerifier out from gcLocker.hpp
stefank
parents:
49593
diff
changeset
|
38 |
#include "runtime/safepointVerifiers.hpp" |
46505 | 39 |
#include "utilities/hashtable.inline.hpp" |
40 |
#include "utilities/macros.hpp" |
|
48615
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
41 |
|
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
42 |
|
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
43 |
oop ResolvedMethodEntry::object() { |
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
44 |
return literal().resolve(); |
48615
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
45 |
} |
46505 | 46 |
|
48615
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
47 |
oop ResolvedMethodEntry::object_no_keepalive() { |
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
48 |
// The AS_NO_KEEPALIVE peeks at the oop without keeping it alive. |
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
49 |
// This is dangerous in general but is okay if the loaded oop does |
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
50 |
// not leak out past a thread transition where a safepoint can happen. |
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
51 |
// A subsequent oop_load without AS_NO_KEEPALIVE (the object() accessor) |
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
52 |
// keeps the oop alive before doing so. |
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
53 |
return literal().peek(); |
48615
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
54 |
} |
46505 | 55 |
|
56 |
ResolvedMethodTable::ResolvedMethodTable() |
|
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
57 |
: Hashtable<ClassLoaderWeakHandle, mtClass>(_table_size, sizeof(ResolvedMethodEntry)) { } |
46505 | 58 |
|
59 |
oop ResolvedMethodTable::lookup(int index, unsigned int hash, Method* method) { |
|
51472
eb97d1a319f9
8206423: Use locking for cleaning ResolvedMethodTable
pchilanomate
parents:
49982
diff
changeset
|
60 |
assert_locked_or_safepoint(ResolvedMethodTable_lock); |
46505 | 61 |
for (ResolvedMethodEntry* p = bucket(index); p != NULL; p = p->next()) { |
62 |
if (p->hash() == hash) { |
|
48615
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
63 |
|
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
64 |
// Peek the object to check if it is the right target. |
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
65 |
oop target = p->object_no_keepalive(); |
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
66 |
|
46505 | 67 |
// The method is in the table as a target already |
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
68 |
if (target != NULL && java_lang_invoke_ResolvedMethodName::vmtarget(target) == method) { |
46505 | 69 |
ResourceMark rm; |
70 |
log_debug(membername, table) ("ResolvedMethod entry found for %s index %d", |
|
71 |
method->name_and_sig_as_C_string(), index); |
|
48615
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
72 |
// The object() accessor makes sure the target object is kept alive before |
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
73 |
// leaking out. |
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
74 |
return p->object(); |
46505 | 75 |
} |
76 |
} |
|
77 |
} |
|
78 |
return NULL; |
|
79 |
} |
|
80 |
||
81 |
unsigned int ResolvedMethodTable::compute_hash(Method* method) { |
|
82 |
unsigned int name_hash = method->name()->identity_hash(); |
|
83 |
unsigned int signature_hash = method->signature()->identity_hash(); |
|
84 |
return name_hash ^ signature_hash; |
|
85 |
} |
|
86 |
||
87 |
||
88 |
oop ResolvedMethodTable::lookup(Method* method) { |
|
89 |
unsigned int hash = compute_hash(method); |
|
90 |
int index = hash_to_index(hash); |
|
91 |
return lookup(index, hash, method); |
|
92 |
} |
|
93 |
||
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
94 |
oop ResolvedMethodTable::basic_add(Method* method, Handle rmethod_name) { |
46505 | 95 |
assert_locked_or_safepoint(ResolvedMethodTable_lock); |
96 |
||
97 |
unsigned int hash = compute_hash(method); |
|
98 |
int index = hash_to_index(hash); |
|
99 |
||
100 |
// One was added while aquiring the lock |
|
101 |
oop entry = lookup(index, hash, method); |
|
102 |
if (entry != NULL) { |
|
103 |
return entry; |
|
104 |
} |
|
105 |
||
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
106 |
ClassLoaderWeakHandle w = ClassLoaderWeakHandle::create(rmethod_name); |
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
107 |
ResolvedMethodEntry* p = (ResolvedMethodEntry*) Hashtable<ClassLoaderWeakHandle, mtClass>::new_entry(hash, w); |
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
108 |
Hashtable<ClassLoaderWeakHandle, mtClass>::add_entry(index, p); |
46505 | 109 |
ResourceMark rm; |
110 |
log_debug(membername, table) ("ResolvedMethod entry added for %s index %d", |
|
111 |
method->name_and_sig_as_C_string(), index); |
|
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
112 |
return rmethod_name(); |
46505 | 113 |
} |
114 |
||
115 |
ResolvedMethodTable* ResolvedMethodTable::_the_table = NULL; |
|
116 |
||
117 |
oop ResolvedMethodTable::find_method(Method* method) { |
|
51472
eb97d1a319f9
8206423: Use locking for cleaning ResolvedMethodTable
pchilanomate
parents:
49982
diff
changeset
|
118 |
MutexLocker ml(ResolvedMethodTable_lock); |
46505 | 119 |
oop entry = _the_table->lookup(method); |
120 |
return entry; |
|
121 |
} |
|
122 |
||
53924
09cba396916f
8181171: Deleting method for RedefineClasses breaks ResolvedMethodName
coleenp
parents:
53904
diff
changeset
|
123 |
oop ResolvedMethodTable::add_method(const methodHandle& m, Handle resolved_method_name) { |
46505 | 124 |
MutexLocker ml(ResolvedMethodTable_lock); |
125 |
DEBUG_ONLY(NoSafepointVerifier nsv); |
|
126 |
||
53924
09cba396916f
8181171: Deleting method for RedefineClasses breaks ResolvedMethodName
coleenp
parents:
53904
diff
changeset
|
127 |
Method* method = m(); |
46505 | 128 |
// Check if method has been redefined while taking out ResolvedMethodTable_lock, if so |
54431
ad9fa99fa48e
8221992: Fix old method replacement in ResolvedMethodTable
coleenp
parents:
53924
diff
changeset
|
129 |
// use new method in the ResolvedMethodName. The old method won't be deallocated |
ad9fa99fa48e
8221992: Fix old method replacement in ResolvedMethodTable
coleenp
parents:
53924
diff
changeset
|
130 |
// yet because it's passed in as a Handle. |
46505 | 131 |
if (method->is_old()) { |
54431
ad9fa99fa48e
8221992: Fix old method replacement in ResolvedMethodTable
coleenp
parents:
53924
diff
changeset
|
132 |
method = (method->is_deleted()) ? Universe::throw_no_such_method_error() : |
ad9fa99fa48e
8221992: Fix old method replacement in ResolvedMethodTable
coleenp
parents:
53924
diff
changeset
|
133 |
method->get_new_method(); |
46505 | 134 |
java_lang_invoke_ResolvedMethodName::set_vmtarget(resolved_method_name(), method); |
135 |
} |
|
54431
ad9fa99fa48e
8221992: Fix old method replacement in ResolvedMethodTable
coleenp
parents:
53924
diff
changeset
|
136 |
|
46505 | 137 |
// Set flag in class to indicate this InstanceKlass has entries in the table |
138 |
// to avoid walking table during redefinition if none of the redefined classes |
|
139 |
// have any membernames in the table. |
|
140 |
method->method_holder()->set_has_resolved_methods(); |
|
141 |
||
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
142 |
return _the_table->basic_add(method, resolved_method_name); |
46505 | 143 |
} |
144 |
||
145 |
// Removing entries |
|
51567
0c4f2b26849e
8209844: MemberNameLeak.java fails when ResolvedMethod entry is not removed
pchilanomate
parents:
51472
diff
changeset
|
146 |
int ResolvedMethodTable::_total_oops_removed = 0; |
46505 | 147 |
|
51472
eb97d1a319f9
8206423: Use locking for cleaning ResolvedMethodTable
pchilanomate
parents:
49982
diff
changeset
|
148 |
// There are no dead entries at start |
eb97d1a319f9
8206423: Use locking for cleaning ResolvedMethodTable
pchilanomate
parents:
49982
diff
changeset
|
149 |
bool ResolvedMethodTable::_dead_entries = false; |
eb97d1a319f9
8206423: Use locking for cleaning ResolvedMethodTable
pchilanomate
parents:
49982
diff
changeset
|
150 |
|
eb97d1a319f9
8206423: Use locking for cleaning ResolvedMethodTable
pchilanomate
parents:
49982
diff
changeset
|
151 |
void ResolvedMethodTable::trigger_cleanup() { |
eb97d1a319f9
8206423: Use locking for cleaning ResolvedMethodTable
pchilanomate
parents:
49982
diff
changeset
|
152 |
MutexLockerEx ml(Service_lock, Mutex::_no_safepoint_check_flag); |
eb97d1a319f9
8206423: Use locking for cleaning ResolvedMethodTable
pchilanomate
parents:
49982
diff
changeset
|
153 |
_dead_entries = true; |
eb97d1a319f9
8206423: Use locking for cleaning ResolvedMethodTable
pchilanomate
parents:
49982
diff
changeset
|
154 |
Service_lock->notify_all(); |
eb97d1a319f9
8206423: Use locking for cleaning ResolvedMethodTable
pchilanomate
parents:
49982
diff
changeset
|
155 |
} |
eb97d1a319f9
8206423: Use locking for cleaning ResolvedMethodTable
pchilanomate
parents:
49982
diff
changeset
|
156 |
|
46505 | 157 |
// Serially invoke removed unused oops from the table. |
51472
eb97d1a319f9
8206423: Use locking for cleaning ResolvedMethodTable
pchilanomate
parents:
49982
diff
changeset
|
158 |
// This is done by the ServiceThread after being notified on class unloading |
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
159 |
void ResolvedMethodTable::unlink() { |
51472
eb97d1a319f9
8206423: Use locking for cleaning ResolvedMethodTable
pchilanomate
parents:
49982
diff
changeset
|
160 |
MutexLocker ml(ResolvedMethodTable_lock); |
51567
0c4f2b26849e
8209844: MemberNameLeak.java fails when ResolvedMethod entry is not removed
pchilanomate
parents:
51472
diff
changeset
|
161 |
int _oops_removed = 0; |
0c4f2b26849e
8209844: MemberNameLeak.java fails when ResolvedMethod entry is not removed
pchilanomate
parents:
51472
diff
changeset
|
162 |
int _oops_counted = 0; |
46505 | 163 |
for (int i = 0; i < _the_table->table_size(); ++i) { |
164 |
ResolvedMethodEntry** p = _the_table->bucket_addr(i); |
|
165 |
ResolvedMethodEntry* entry = _the_table->bucket(i); |
|
166 |
while (entry != NULL) { |
|
167 |
_oops_counted++; |
|
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
168 |
oop l = entry->object_no_keepalive(); |
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
169 |
if (l != NULL) { |
46505 | 170 |
p = entry->next_addr(); |
171 |
} else { |
|
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
172 |
// Entry has been removed. |
46505 | 173 |
_oops_removed++; |
174 |
if (log_is_enabled(Debug, membername, table)) { |
|
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
175 |
log_debug(membername, table) ("ResolvedMethod entry removed for index %d", i); |
46505 | 176 |
} |
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
177 |
entry->literal().release(); |
46505 | 178 |
*p = entry->next(); |
179 |
_the_table->free_entry(entry); |
|
180 |
} |
|
181 |
// get next entry |
|
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
182 |
entry = (ResolvedMethodEntry*)HashtableEntry<ClassLoaderWeakHandle, mtClass>::make_ptr(*p); |
46505 | 183 |
} |
184 |
} |
|
185 |
log_debug(membername, table) ("ResolvedMethod entries counted %d removed %d", |
|
186 |
_oops_counted, _oops_removed); |
|
51567
0c4f2b26849e
8209844: MemberNameLeak.java fails when ResolvedMethod entry is not removed
pchilanomate
parents:
51472
diff
changeset
|
187 |
_total_oops_removed += _oops_removed; |
51472
eb97d1a319f9
8206423: Use locking for cleaning ResolvedMethodTable
pchilanomate
parents:
49982
diff
changeset
|
188 |
_dead_entries = false; |
46505 | 189 |
} |
190 |
||
191 |
#ifndef PRODUCT |
|
192 |
void ResolvedMethodTable::print() { |
|
51472
eb97d1a319f9
8206423: Use locking for cleaning ResolvedMethodTable
pchilanomate
parents:
49982
diff
changeset
|
193 |
MutexLocker ml(ResolvedMethodTable_lock); |
46505 | 194 |
for (int i = 0; i < table_size(); ++i) { |
195 |
ResolvedMethodEntry* entry = bucket(i); |
|
196 |
while (entry != NULL) { |
|
197 |
tty->print("%d : ", i); |
|
48615
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
198 |
oop rmethod_name = entry->object_no_keepalive(); |
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
199 |
if (rmethod_name != NULL) { |
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
200 |
rmethod_name->print(); |
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
201 |
Method* m = (Method*)java_lang_invoke_ResolvedMethodName::vmtarget(rmethod_name); |
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
202 |
m->print(); |
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
203 |
} |
46505 | 204 |
entry = entry->next(); |
205 |
} |
|
206 |
} |
|
207 |
} |
|
208 |
#endif // PRODUCT |
|
209 |
||
210 |
#if INCLUDE_JVMTI |
|
211 |
// It is called at safepoint only for RedefineClasses |
|
212 |
void ResolvedMethodTable::adjust_method_entries(bool * trace_name_printed) { |
|
213 |
assert(SafepointSynchronize::is_at_safepoint(), "only called at safepoint"); |
|
214 |
// For each entry in RMT, change to new method |
|
215 |
for (int i = 0; i < _the_table->table_size(); ++i) { |
|
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
216 |
for (ResolvedMethodEntry* entry = _the_table->bucket(i); |
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
217 |
entry != NULL; |
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
218 |
entry = entry->next()) { |
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
219 |
|
48615
31cd0c16f4d2
8191904: Refactor weak oops in ResolvedMethodTable to use the Access API
eosterlund
parents:
47216
diff
changeset
|
220 |
oop mem_name = entry->object_no_keepalive(); |
49818
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
221 |
// except ones removed |
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
222 |
if (mem_name == NULL) { |
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
223 |
continue; |
e57e6addb978
8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable
coleenp
parents:
49594
diff
changeset
|
224 |
} |
46505 | 225 |
Method* old_method = (Method*)java_lang_invoke_ResolvedMethodName::vmtarget(mem_name); |
226 |
||
227 |
if (old_method->is_old()) { |
|
228 |
||
53924
09cba396916f
8181171: Deleting method for RedefineClasses breaks ResolvedMethodName
coleenp
parents:
53904
diff
changeset
|
229 |
Method* new_method = (old_method->is_deleted()) ? |
09cba396916f
8181171: Deleting method for RedefineClasses breaks ResolvedMethodName
coleenp
parents:
53904
diff
changeset
|
230 |
Universe::throw_no_such_method_error() : |
09cba396916f
8181171: Deleting method for RedefineClasses breaks ResolvedMethodName
coleenp
parents:
53904
diff
changeset
|
231 |
old_method->get_new_method(); |
46505 | 232 |
java_lang_invoke_ResolvedMethodName::set_vmtarget(mem_name, new_method); |
233 |
||
234 |
ResourceMark rm; |
|
235 |
if (!(*trace_name_printed)) { |
|
236 |
log_info(redefine, class, update)("adjust: name=%s", old_method->method_holder()->external_name()); |
|
237 |
*trace_name_printed = true; |
|
238 |
} |
|
239 |
log_debug(redefine, class, update, constantpool) |
|
240 |
("ResolvedMethod method update: %s(%s)", |
|
241 |
new_method->name()->as_C_string(), new_method->signature()->as_C_string()); |
|
242 |
} |
|
243 |
} |
|
244 |
} |
|
245 |
} |
|
246 |
#endif // INCLUDE_JVMTI |