hotspot/src/share/vm/opto/mathexactnode.cpp
author roland
Thu, 03 Oct 2013 10:55:07 +0200
changeset 20696 946797ddfade
parent 20289 35d78de0c547
child 20715 be1135dc1406
permissions -rw-r--r--
8024067: Missing replace_in_map() calls following null checks Summary: add replace_in_map() calls following some null checks in type checks Reviewed-by: kvn
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
20289
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
     1
/*
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
     2
 * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved.
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
     4
 *
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
     7
 * published by the Free Software Foundation.
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
     8
 *
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    13
 * accompanied this code).
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    14
 *
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    18
 *
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    21
 * questions.
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    22
 *
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    23
 */
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    24
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    25
#include "precompiled.hpp"
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    26
#include "memory/allocation.inline.hpp"
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    27
#include "opto/addnode.hpp"
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    28
#include "opto/machnode.hpp"
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    29
#include "opto/mathexactnode.hpp"
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    30
#include "opto/matcher.hpp"
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    31
#include "opto/subnode.hpp"
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    32
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    33
MathExactNode::MathExactNode(Node* ctrl, Node* n1, Node* n2) : MultiNode(3) {
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    34
  init_req(0, ctrl);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    35
  init_req(1, n1);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    36
  init_req(2, n2);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    37
}
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    38
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    39
Node* AddExactINode::match(const ProjNode* proj, const Matcher* m) {
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    40
  uint ideal_reg = proj->ideal_reg();
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    41
  RegMask rm;
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    42
  if (proj->_con == result_proj_node) {
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    43
    rm = m->mathExactI_result_proj_mask();
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    44
  } else {
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    45
    assert(proj->_con == flags_proj_node, "must be result or flags");
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    46
    assert(ideal_reg == Op_RegFlags, "sanity");
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    47
    rm = m->mathExactI_flags_proj_mask();
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    48
  }
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    49
  return new (m->C) MachProjNode(this, proj->_con, rm, ideal_reg);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    50
}
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    51
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    52
// If the MathExactNode won't overflow we have to replace the
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    53
// FlagsProjNode and ProjNode that is generated by the MathExactNode
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    54
Node* MathExactNode::no_overflow(PhaseGVN *phase, Node* new_result) {
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    55
  PhaseIterGVN *igvn = phase->is_IterGVN();
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    56
  if (igvn) {
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    57
    ProjNode* result = result_node();
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    58
    ProjNode* flags = flags_node();
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    59
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    60
    if (result != NULL) {
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    61
      igvn->replace_node(result, new_result);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    62
    }
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    63
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    64
    if (flags != NULL) {
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    65
      BoolNode* bolnode = (BoolNode *) flags->unique_out();
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    66
      switch (bolnode->_test._test) {
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    67
        case BoolTest::overflow:
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    68
          // if the check is for overflow - never taken
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    69
          igvn->replace_node(bolnode, phase->intcon(0));
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    70
          break;
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    71
        case BoolTest::no_overflow:
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    72
          // if the check is for no overflow - always taken
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    73
          igvn->replace_node(bolnode, phase->intcon(1));
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    74
          break;
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    75
        default:
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    76
          fatal("Unexpected value of BoolTest");
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    77
          break;
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    78
      }
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    79
      flags->del_req(0);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    80
    }
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    81
  }
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    82
  return new_result;
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    83
}
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    84
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    85
Node *AddExactINode::Ideal(PhaseGVN *phase, bool can_reshape) {
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    86
  Node *arg1 = in(1);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    87
  Node *arg2 = in(2);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    88
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    89
  const Type* type1 = phase->type(arg1);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    90
  const Type* type2 = phase->type(arg2);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    91
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    92
  if (type1 != Type::TOP && type1->singleton() &&
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    93
      type2 != Type::TOP && type2->singleton()) {
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    94
    jint val1 = arg1->get_int();
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    95
    jint val2 = arg2->get_int();
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    96
    jint result = val1 + val2;
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    97
    // Hacker's Delight 2-12 Overflow if both arguments have the opposite sign of the result
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    98
    if ( (((val1 ^ result) & (val2 ^ result)) >= 0)) {
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
    99
      Node* con_result = ConINode::make(phase->C, result);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   100
      return no_overflow(phase, con_result);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   101
    }
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   102
    return NULL;
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   103
  }
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   104
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   105
  if (type1 == TypeInt::ZERO) { // (Add 0 x) == x
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   106
    Node* add_result = new (phase->C) AddINode(arg1, arg2);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   107
    return no_overflow(phase, add_result);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   108
  }
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   109
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   110
  if (type2 == TypeInt::ZERO) { // (Add x 0) == x
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   111
    Node* add_result = new (phase->C) AddINode(arg1, arg2);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   112
    return no_overflow(phase, add_result);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   113
  }
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   114
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   115
  if (type2->singleton()) {
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   116
    return NULL; // no change - keep constant on the right
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   117
  }
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   118
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   119
  if (type1->singleton()) {
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   120
    // Make it x + Constant - move constant to the right
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   121
    swap_edges(1, 2);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   122
    return this;
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   123
  }
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   124
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   125
  if (arg2->is_Load()) {
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   126
    return NULL; // no change - keep load on the right
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   127
  }
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   128
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   129
  if (arg1->is_Load()) {
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   130
    // Make it x + Load - move load to the right
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   131
    swap_edges(1, 2);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   132
    return this;
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   133
  }
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   134
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   135
  if (arg1->_idx > arg2->_idx) {
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   136
    // Sort the edges
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   137
    swap_edges(1, 2);
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   138
    return this;
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   139
  }
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   140
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   141
  return NULL;
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   142
}
35d78de0c547 8024924: Intrinsify java.lang.Math.addExact
rbackman
parents:
diff changeset
   143